Re: [PATCH] selftests/futex: Order calls in futex_requeue

2024-06-20 Thread Muhammad Usama Anjum
On 6/19/24 5:22 AM, Edward Liaw wrote: > Like fbf4dec70277 ("selftests/futex: Order calls to futex_lock_pi"), > which fixed a flake in futex_lock_pi due to racing between the parent > and child threads. > > The same issue can occur in the futex_requeue test, because it expects > waiterfn to make

Re: [PATCH v4 3/4] selftest/mm: test enable_soft_offline behaviors

2024-06-20 Thread Muhammad Usama Anjum
On 6/20/24 11:48 PM, Jiaqi Yan wrote: > Add regression and new tests when hugepage has correctable memory > errors, and how userspace wants to deal with it: > * if enable_soft_offline=1, mapped hugepage is soft offlined > * if enable_soft_offline=0, mapped hugepage is intact > > Free hugepages

Re: [PATCH net-next] selftests: net: change shebang to bash in amt.sh

2024-06-20 Thread Muhammad Usama Anjum
On 6/21/24 9:16 AM, Taehee Yoo wrote: > amt.sh is written in bash, not sh. > So, shebang should be bash. > > Signed-off-by: Taehee Yoo Acked-by: Muhammad Usama Anjum > --- > tools/testing/selftests/net/amt.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH net-next] selftests: net: change shebang to bash in amt.sh

2024-06-20 Thread Taehee Yoo
amt.sh is written in bash, not sh. So, shebang should be bash. Signed-off-by: Taehee Yoo --- tools/testing/selftests/net/amt.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/amt.sh b/tools/testing/selftests/net/amt.sh index

Re: [PATCH bpf-next v6 0/6] use network helpers, part 7

2024-06-20 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (master) by Alexei Starovoitov : On Fri, 21 Jun 2024 10:15:57 +0800 you wrote: > From: Geliang Tang > > v6: > - update ASSERT strings in patch 4 as Eduard suggested. (thanks) > > v5: > - update patch 1, add getsockopt(SO_PROTOCOL) in

Re: [RFC PATCH v5 00/29] TDX KVM selftests

2024-06-20 Thread Edgecombe, Rick P
+Yan On Wed, 2024-06-05 at 14:44 -0700, Rick Edgecombe wrote: > > I will take a look at rebasing the selftests on top of the Intel > > development branch and I can post it on our github branch. We can talk > > about co-development offline. We already have some code that was > > suggested by Isaku

Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout

2024-06-20 Thread Huang, Ying
David Hildenbrand writes: > On 20.06.24 11:04, Ryan Roberts wrote: >> On 20/06/2024 01:26, Barry Song wrote: >>> From: Barry Song >>> >>> Both Ryan and Chris have been utilizing the small test program to aid >>> in debugging and identifying issues with swap entry allocation. While >>> a real or

[PATCH bpf-next v6 6/6] selftests/bpf: Use start_server_str in test_tcp_check_syncookie_user

2024-06-20 Thread Geliang Tang
From: Geliang Tang Since start_server_str() is added now, it can be used in script test_tcp_check_syncookie_user.c instead of start_server_addr() to simplify the code. Acked-by: Eduard Zingerman Signed-off-by: Geliang Tang --- .../bpf/test_tcp_check_syncookie_user.c | 29

[PATCH bpf-next v6 5/6] selftests/bpf: Use start_server_str in mptcp

2024-06-20 Thread Geliang Tang
From: Geliang Tang Since start_server_str() is added now, it can be used in mptcp.c in start_mptcp_server() instead of using helpers make_sockaddr() and start_server_addr() to simplify the code. Acked-by: Eduard Zingerman Signed-off-by: Geliang Tang ---

[PATCH bpf-next v6 4/6] selftests/bpf: Drop noconnect from network_helper_opts

2024-06-20 Thread Geliang Tang
From: Geliang Tang In test_bpf_ip_check_defrag_ok(), the new helper client_socket() can be used to replace connect_to_fd_opts() with "noconnect" opts, and the strcut member "noconnect" of network_helper_opts can be dropped now, always connect to server in connect_to_fd_opts(). Acked-by: Eduard

[PATCH bpf-next v6 3/6] selftests/bpf: Add client_socket helper

2024-06-20 Thread Geliang Tang
From: Geliang Tang This patch extracts a new helper client_socket() from connect_to_fd_opts() to create the client socket, but don't connect to the server. Then connect_to_fd_opts() can be implemented using client_socket() and connect_fd_to_addr(). This helper can be used in connect_to_addr()

[PATCH bpf-next v6 2/6] selftests/bpf: Use connect_to_addr in connect_to_fd_opt

2024-06-20 Thread Geliang Tang
From: Geliang Tang This patch moves "post_socket_cb" and "noconnect" into connect_to_addr(), then connect_to_fd_opts() can be implemented by getsockname() and connect_to_addr(). This change makes connect_to_* interfaces more unified. Acked-by: Eduard Zingerman Signed-off-by: Geliang Tang ---

[PATCH bpf-next v6 0/6] use network helpers, part 7

2024-06-20 Thread Geliang Tang
From: Geliang Tang v6: - update ASSERT strings in patch 4 as Eduard suggested. (thanks) v5: - update patch 1, add getsockopt(SO_PROTOCOL) in connect_to_fd() to fix errors reported by CI. v4: - fix errors reported by CI. v3: - rename start_client to client_socket - Use connect_to_addr in

[PATCH bpf-next v6 1/6] selftests/bpf: Drop type from network_helper_opts

2024-06-20 Thread Geliang Tang
From: Geliang Tang The opts.{type, noconnect} is at least a bit non intuitive or unnecessary. The only use case now is in test_bpf_ip_check_defrag_ok which ends up bypassing most (or at least some) of the connect_to_fd_opts() logic. It's much better that test should have its own

Re: [PATCH V4] rcutorture: Add CFcommon.arch for the various arch's need

2024-06-20 Thread Zhouyi Zhou
On Fri, Jun 21, 2024 at 1:57 AM Paul E. McKenney wrote: > > On Wed, Jun 19, 2024 at 11:06:58PM +, Zhouyi Zhou wrote: > > Add CFcommon.arch for the various arch's need for rcutorture. > > > > In accordance with [1], [2] and [3], move x86 specific kernel option > > CONFIG_HYPERVISOR_GUEST to

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Sean Christopherson
On Thu, Jun 20, 2024, Jason Gunthorpe wrote: > On Thu, Jun 20, 2024 at 01:30:29PM -0700, Sean Christopherson wrote: > > I.e. except for blatant bugs, e.g. use-after-free, we need to be able to > > guarantee > > with 100% accuracy that there are no outstanding mappings when converting a > > page

Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout

2024-06-20 Thread Chris Li
Hi Barry, Thanks for the wonderful test program. I have also used other swap test programs as well. A lot of those tests are harder to setup up and run. This test is very quick and simple to run. It can test some hard to hit corner cases for me. I am able to reproduce the warning and the

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Jason Gunthorpe
On Thu, Jun 20, 2024 at 03:47:23PM -0700, Elliot Berman wrote: > On Thu, Jun 20, 2024 at 11:29:56AM -0300, Jason Gunthorpe wrote: > > On Thu, Jun 20, 2024 at 04:01:08PM +0200, David Hildenbrand wrote: > > > Regarding huge pages: assume the huge page (e.g., 1 GiB hugetlb) is > > > shared, > > >

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Jason Gunthorpe
On Thu, Jun 20, 2024 at 01:30:29PM -0700, Sean Christopherson wrote: > I.e. except for blatant bugs, e.g. use-after-free, we need to be able to > guarantee > with 100% accuracy that there are no outstanding mappings when converting a > page > from shared=>private. Crossing our fingers and

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Jason Gunthorpe
On Thu, Jun 20, 2024 at 08:53:07PM +0200, David Hildenbrand wrote: > On 20.06.24 18:36, Jason Gunthorpe wrote: > > On Thu, Jun 20, 2024 at 04:45:08PM +0200, David Hildenbrand wrote: > > > > > If we could disallow pinning any shared pages, that would make life a lot > > > easier, but I think there

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Jason Gunthorpe
> This is the step that concerns me. "Relatively short time" is, well, > relative. > Hmm, though I suppose if userspace managed to map a shared page into something > that pins the page, and can't force an unpin, e.g. by stopping I/O?, then > either > there's a host userspace bug or a guest

Re: [PATCH v4 0/4] Userspace controls soft-offline pages

2024-06-20 Thread Andi Kleen
Jiaqi Yan writes: > Correctable memory errors are very common on servers with large > amount of memory, and are corrected by ECC, but with two > pain points to users: > 1. Correction usually happens on the fly and adds latency overhead > 2. Not-fully-proved theory states excessive correctable

Re: [PATCH 3/5] riscv: hwprobe: export Zaamo and Zalrsc extensions

2024-06-20 Thread Charlie Jenkins
On Wed, Jun 19, 2024 at 05:39:10PM +0200, Clément Léger wrote: > Export the Zaamo and Zalrsc extensions to userspace using hwprobe. > > Signed-off-by: Clément Léger > --- > Documentation/arch/riscv/hwprobe.rst | 8 > arch/riscv/include/uapi/asm/hwprobe.h | 2 ++ >

Re: [PATCH bpf-next v5 4/6] selftests/bpf: Drop noconnect from network_helper_opts

2024-06-20 Thread Eduard Zingerman
On Wed, 2024-06-19 at 10:51 +0800, Geliang Tang wrote: Oops, sorry, missed two places that should be changed. Please keep my ack if you respin. [...] > diff --git a/tools/testing/selftests/bpf/prog_tests/ip_check_defrag.c > b/tools/testing/selftests/bpf/prog_tests/ip_check_defrag.c > index

Re: [PATCH bpf-next v5 1/6] selftests/bpf: Drop type from network_helper_opts

2024-06-20 Thread Eduard Zingerman
On Wed, 2024-06-19 at 10:51 +0800, Geliang Tang wrote: > From: Geliang Tang > > The opts.{type, noconnect} is at least a bit non intuitive or unnecessary. > The only use case now is in test_bpf_ip_check_defrag_ok which ends up > bypassing most (or at least some) of the connect_to_fd_opts()

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Elliot Berman
On Thu, Jun 20, 2024 at 11:29:56AM -0300, Jason Gunthorpe wrote: > On Thu, Jun 20, 2024 at 04:01:08PM +0200, David Hildenbrand wrote: > > Regarding huge pages: assume the huge page (e.g., 1 GiB hugetlb) is shared, > > now the VM requests to make one subpage private. > > I think the general CC

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Sean Christopherson
On Thu, Jun 20, 2024, David Hildenbrand wrote: > On 20.06.24 22:30, Sean Christopherson wrote: > > On Thu, Jun 20, 2024, David Hildenbrand wrote: > > > On 20.06.24 18:36, Jason Gunthorpe wrote: > > > > On Thu, Jun 20, 2024 at 04:45:08PM +0200, David Hildenbrand wrote: > > > > > > > > > If we

Re: [PATCH v10 1/3] KVM: selftests: aarch64: Add helper function for the vpmu vcpu creation

2024-06-20 Thread Raghavendra Rao Ananta
Hi Shaoqin On Wed, Jun 19, 2024 at 1:32 AM Shaoqin Huang wrote: > > Create a vcpu with vpmu would be a common requirement for the vpmu test, > so add the helper function for the vpmu vcpu creation. And use those > helper function in the vpmu_counter_access.c test. > > Use this chance to delete

Re: [PATCH bpf-next v5 2/6] selftests/bpf: Use connect_to_addr in connect_to_fd_opt

2024-06-20 Thread Eduard Zingerman
On Wed, 2024-06-19 at 10:51 +0800, Geliang Tang wrote: > From: Geliang Tang > > This patch moves "post_socket_cb" and "noconnect" into connect_to_addr(), > then connect_to_fd_opts() can be implemented by getsockname() and > connect_to_addr(). This change makes connect_to_* interfaces more

Re: [PATCH v10 2/3] KVM: selftests: aarch64: Introduce pmu_event_filter_test

2024-06-20 Thread Raghavendra Rao Ananta
Hi Shaoqin, On Wed, Jun 19, 2024 at 1:33 AM Shaoqin Huang wrote: > > Introduce pmu_event_filter_test for arm64 platforms. The test configures > PMUv3 for a vCPU, and sets different pmu event filters for the vCPU, and > check if the guest can see those events which user allow and can't use >

Re: [PATCH bpf-next v5 3/6] selftests/bpf: Add client_socket helper

2024-06-20 Thread Eduard Zingerman
On Wed, 2024-06-19 at 10:51 +0800, Geliang Tang wrote: > From: Geliang Tang > > This patch extracts a new helper client_socket() from connect_to_fd_opts() > to create the client socket, but don't connect to the server. Then > connect_to_fd_opts() can be implemented using client_socket() and >

Re: [PATCH bpf-next v5 4/6] selftests/bpf: Drop noconnect from network_helper_opts

2024-06-20 Thread Eduard Zingerman
On Wed, 2024-06-19 at 10:51 +0800, Geliang Tang wrote: > From: Geliang Tang > > In test_bpf_ip_check_defrag_ok(), the new helper client_socket() can be > used to replace connect_to_fd_opts() with "noconnect" opts, and the strcut > member "noconnect" of network_helper_opts can be dropped now,

[RFC net-next 9/9] bpf: selftests: test disabling GRO by XDP

2024-06-20 Thread Yan Zhai
Test the case when XDP disables GRO for a packet, the effect is actually reflected on the receiving side. Signed-off-by: Yan Zhai --- tools/testing/selftests/bpf/config| 1 + .../selftests/bpf/prog_tests/xdp_offloading.c | 122 ++

Re: [PATCH v2] kunit/usercopy: Disable testing on !CONFIG_MMU

2024-06-20 Thread Rae Moar
On Wed, Jun 19, 2024 at 4:25 PM Kees Cook wrote: > > Since arch_pick_mmap_layout() is an inline for non-MMU systems, disable > this test there. > > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202406160505.ubge6tmy-...@intel.com/ > Signed-off-by: Kees Cook

Re: [PATCH] kunit/usercopy: Add missing MODULE_DESCRIPTION()

2024-06-20 Thread Rae Moar
On Wed, Jun 19, 2024 at 4:27 PM Kees Cook wrote: > > From: Jeff Johnson > > Fix warning seen with: > > $ make allmodconfig && make W=1 C=1 lib/usercopy_kunit.ko > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/usercopy_kunit.o > > Signed-off-by: Jeff Johnson > Signed-off-by: Kees Cook

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread David Hildenbrand
On 20.06.24 22:30, Sean Christopherson wrote: On Thu, Jun 20, 2024, David Hildenbrand wrote: On 20.06.24 18:36, Jason Gunthorpe wrote: On Thu, Jun 20, 2024 at 04:45:08PM +0200, David Hildenbrand wrote: If we could disallow pinning any shared pages, that would make life a lot easier, but I

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Sean Christopherson
On Thu, Jun 20, 2024, David Hildenbrand wrote: > On 20.06.24 18:36, Jason Gunthorpe wrote: > > On Thu, Jun 20, 2024 at 04:45:08PM +0200, David Hildenbrand wrote: > > > > > If we could disallow pinning any shared pages, that would make life a lot > > > easier, but I think there were reasons for

Re: [PATCH 2/2] selftest: rtc: Check if could access /dev/rtc0 before testing

2024-06-20 Thread Alexandre Belloni
On 23/05/2024 18:38:07-0700, Joseph Jang wrote: > The rtctest requires the read permission on /dev/rtc0. The rtctest will > be skipped if the /dev/rtc0 is not readable. > > Reviewed-by: Koba Ko > Reviewed-by: Matthew R. Ochs > Signed-off-by: Joseph Jang Acked-by: Alexandre Belloni > --- >

Re: [PATCH 1/2] selftest: rtc: Add to check rtc alarm status for alarm related test

2024-06-20 Thread Alexandre Belloni
On 23/05/2024 18:38:06-0700, Joseph Jang wrote: > In alarm_wkalm_set and alarm_wkalm_set_minute test, they use different > ioctl (RTC_ALM_SET/RTC_WKALM_SET) for alarm feature detection. They will > skip testing if RTC_ALM_SET/RTC_WKALM_SET ioctl returns an EINVAL error > code. This design may miss

Re: [PATCH v3 4/4] selftests/resctrl: Enable MBA/MBA tests on AMD

2024-06-20 Thread Moger, Babu
Hi Reinette, On 6/14/24 13:39, Reinette Chatre wrote: > Hi Babu, > > On 6/5/24 3:45 PM, Babu Moger wrote: >> Enable MBA/MBM tests if UMC (Unified Memory Controller) support is >> available on the system. Tests will be skipped otherwise. > > Could you please point out where the test is skipped

[PATCH v4 1/4] mm/memory-failure: refactor log format in soft offline code

2024-06-20 Thread Jiaqi Yan
Logs from soft_offline_page and soft_offline_in_use_page have different formats than majority of the memory failure code: "Memory failure: 0x${pfn}: ${lower_case_message}" Convert them to the following format: "Soft offline: 0x${pfn}: ${lower_case_message}" No functional change in this

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread David Hildenbrand
On 20.06.24 18:04, Sean Christopherson wrote: On Thu, Jun 20, 2024, David Hildenbrand wrote: On 20.06.24 16:29, Jason Gunthorpe wrote: On Thu, Jun 20, 2024 at 04:01:08PM +0200, David Hildenbrand wrote: On 20.06.24 15:55, Jason Gunthorpe wrote: On Thu, Jun 20, 2024 at 09:32:11AM +0100, Fuad

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread David Hildenbrand
On 20.06.24 18:36, Jason Gunthorpe wrote: On Thu, Jun 20, 2024 at 04:45:08PM +0200, David Hildenbrand wrote: If we could disallow pinning any shared pages, that would make life a lot easier, but I think there were reasons for why we might require it. To convert shared->private, simply unmap

[PATCH v4 3/4] selftest/mm: test enable_soft_offline behaviors

2024-06-20 Thread Jiaqi Yan
Add regression and new tests when hugepage has correctable memory errors, and how userspace wants to deal with it: * if enable_soft_offline=1, mapped hugepage is soft offlined * if enable_soft_offline=0, mapped hugepage is intact Free hugepages case is not explicitly covered by the tests.

[PATCH v4 4/4] docs: mm: add enable_soft_offline sysctl

2024-06-20 Thread Jiaqi Yan
Add the documentation for soft offline behaviors / costs, and what the new enable_soft_offline sysctl is for. Acked-by: Oscar Salvador Signed-off-by: Jiaqi Yan --- Documentation/admin-guide/sysctl/vm.rst | 32 + 1 file changed, 32 insertions(+) diff --git

[PATCH v4 2/4] mm/memory-failure: userspace controls soft-offlining pages

2024-06-20 Thread Jiaqi Yan
Correctable memory errors are very common on servers with large amount of memory, and are corrected by ECC. Soft offline is kernel's additional recovery handling for memory pages having (excessive) corrected memory errors. Impacted page is migrated to a healthy page if inuse; the original page is

[PATCH v4 0/4] Userspace controls soft-offline pages

2024-06-20 Thread Jiaqi Yan
Correctable memory errors are very common on servers with large amount of memory, and are corrected by ECC, but with two pain points to users: 1. Correction usually happens on the fly and adds latency overhead 2. Not-fully-proved theory states excessive correctable memory errors can develop

Re: [PATCH V4] rcutorture: Add CFcommon.arch for the various arch's need

2024-06-20 Thread Paul E. McKenney
On Wed, Jun 19, 2024 at 11:06:58PM +, Zhouyi Zhou wrote: > Add CFcommon.arch for the various arch's need for rcutorture. > > In accordance with [1], [2] and [3], move x86 specific kernel option > CONFIG_HYPERVISOR_GUEST to CFcommon.arch, also move kernel option > CONFIG_KVM_GUEST which

Re: [PATCH v3 3/3] docs: mm: add enable_soft_offline sysctl

2024-06-20 Thread Jiaqi Yan
On Tue, Jun 18, 2024 at 10:20 PM Oscar Salvador wrote: > > On Mon, Jun 17, 2024 at 05:05:45PM +, Jiaqi Yan wrote: > > Add the documentation for soft offline behaviors / costs, and what > > the new enable_soft_offline sysctl is for. > > > > Signed-off-by: Jiaqi Yan > > --- > >

Re: [PATCH v4 00/14] security: digest_cache LSM

2024-06-20 Thread Paul Moore
On Thu, Jun 20, 2024 at 1:06 PM Roberto Sassu wrote: > On Thu, 2024-06-20 at 12:51 -0400, Paul Moore wrote: > > On Thu, Jun 20, 2024 at 12:31 PM Roberto Sassu > > wrote: > > > On Thu, 2024-06-20 at 12:08 -0400, Paul Moore wrote: > > > > On Thu, Jun 20, 2024 at 11:14 AM Roberto Sassu > > > >

Re: [PATCH v4 00/14] security: digest_cache LSM

2024-06-20 Thread Roberto Sassu
On Thu, 2024-06-20 at 12:51 -0400, Paul Moore wrote: > On Thu, Jun 20, 2024 at 12:31 PM Roberto Sassu > wrote: > > On Thu, 2024-06-20 at 12:08 -0400, Paul Moore wrote: > > > On Thu, Jun 20, 2024 at 11:14 AM Roberto Sassu > > > wrote: > > > > On Thu, 2024-06-20 at 10:48 -0400, Paul Moore wrote: >

Re: [PATCH v4 00/14] security: digest_cache LSM

2024-06-20 Thread Roberto Sassu
On Thu, 2024-06-20 at 11:32 -0500, Dr. Greg wrote: > On Wed, Jun 19, 2024 at 06:37:49PM +0200, Roberto Sassu wrote: > > Good morning Roberto, I hope your week is going well, greetings to > everyone copied else as well. > > > On Wed, 2024-06-19 at 12:34 -0400, Paul Moore wrote: > > > On Wed, Jun

Re: [PATCH v4 00/14] security: digest_cache LSM

2024-06-20 Thread Paul Moore
On Thu, Jun 20, 2024 at 12:31 PM Roberto Sassu wrote: > On Thu, 2024-06-20 at 12:08 -0400, Paul Moore wrote: > > On Thu, Jun 20, 2024 at 11:14 AM Roberto Sassu > > wrote: > > > On Thu, 2024-06-20 at 10:48 -0400, Paul Moore wrote: > > > > On Thu, Jun 20, 2024 at 5:12 AM Roberto Sassu > > > >

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Jason Gunthorpe
On Thu, Jun 20, 2024 at 04:45:08PM +0200, David Hildenbrand wrote: > If we could disallow pinning any shared pages, that would make life a lot > easier, but I think there were reasons for why we might require it. To > convert shared->private, simply unmap that folio (only the shared parts > could

Re: [PATCH v4 00/14] security: digest_cache LSM

2024-06-20 Thread Dr. Greg
On Wed, Jun 19, 2024 at 06:37:49PM +0200, Roberto Sassu wrote: Good morning Roberto, I hope your week is going well, greetings to everyone copied else as well. > On Wed, 2024-06-19 at 12:34 -0400, Paul Moore wrote: > > On Wed, Jun 19, 2024 at 11:55???AM Roberto Sassu > > wrote: > > > On Wed,

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Mostafa Saleh
Hi David, On Thu, Jun 20, 2024 at 04:14:23PM +0200, David Hildenbrand wrote: > On 20.06.24 15:08, Mostafa Saleh wrote: > > Hi David, > > > > On Wed, Jun 19, 2024 at 09:37:58AM +0200, David Hildenbrand wrote: > > > Hi, > > > > > > On 19.06.24 04:44, John Hubbard wrote: > > > > On 6/18/24 5:05

Re: [PATCH v4 00/14] security: digest_cache LSM

2024-06-20 Thread Roberto Sassu
On Thu, 2024-06-20 at 12:08 -0400, Paul Moore wrote: > On Thu, Jun 20, 2024 at 11:14 AM Roberto Sassu > wrote: > > On Thu, 2024-06-20 at 10:48 -0400, Paul Moore wrote: > > > On Thu, Jun 20, 2024 at 5:12 AM Roberto Sassu > > > wrote: > > > > On Wed, 2024-06-19 at 14:43 -0400, Paul Moore wrote: >

Re: [PATCH v3 3/4] selftests/resctrl: Add support for MBM and MBA tests on AMD

2024-06-20 Thread Moger, Babu
Hi Reinette, On 6/14/24 13:39, Reinette Chatre wrote: > Hi Babu, > > On 6/5/24 3:45 PM, Babu Moger wrote: >> Add support to read UMC (Unified Memory Controller) perf events to compare >> the numbers with QoS monitor for AMD. >> >> Signed-off-by: Babu Moger >> --- >> v3: Made read_from_mc_dir

Re: [PATCH v4 00/14] security: digest_cache LSM

2024-06-20 Thread Paul Moore
On Thu, Jun 20, 2024 at 11:14 AM Roberto Sassu wrote: > On Thu, 2024-06-20 at 10:48 -0400, Paul Moore wrote: > > On Thu, Jun 20, 2024 at 5:12 AM Roberto Sassu > > wrote: > > > On Wed, 2024-06-19 at 14:43 -0400, Paul Moore wrote: > > > > On Wed, Jun 19, 2024 at 12:38 PM Roberto Sassu > > > >

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Sean Christopherson
On Thu, Jun 20, 2024, David Hildenbrand wrote: > On 20.06.24 16:29, Jason Gunthorpe wrote: > > On Thu, Jun 20, 2024 at 04:01:08PM +0200, David Hildenbrand wrote: > > > On 20.06.24 15:55, Jason Gunthorpe wrote: > > > > On Thu, Jun 20, 2024 at 09:32:11AM +0100, Fuad Tabba wrote: > > > Regarding huge

Re: [PATCH v3 2/4] selftests/resctrl: Pass sysfs controller name of the vendor

2024-06-20 Thread Moger, Babu
Hi Reinette, On 6/14/24 13:38, Reinette Chatre wrote: > Hi Babu, > > Subject and changelog mentions how controller name is "passed" but the > patch does not seem to "pass" anything new. Sure. Will change the subject to this. Also will update the commit message. selftests/resctrl: Dynamically

Re: [PATCH v3 1/4] selftests/resctrl: Rename variables and functions to generic names

2024-06-20 Thread Moger, Babu
Hi Reinette, On 6/14/24 13:37, Reinette Chatre wrote: > Hi Babu, > > On 6/5/24 3:45 PM, Babu Moger wrote: >> In an effort to support MBM and MBA tests for AMD, renaming for variable >> and functions to generic names. For Intel, the memory controller is called > > Changelog usually starts with

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Sean Christopherson
On Wed, Jun 19, 2024, Fuad Tabba wrote: > Hi Jason, > > On Wed, Jun 19, 2024 at 12:51 PM Jason Gunthorpe wrote: > > > > On Wed, Jun 19, 2024 at 10:11:35AM +0100, Fuad Tabba wrote: > > > > > To be honest, personally (speaking only for myself, not necessarily > > > for Elliot and not for anyone

Re: [PATCH v4 00/14] security: digest_cache LSM

2024-06-20 Thread Roberto Sassu
On Thu, 2024-06-20 at 10:48 -0400, Paul Moore wrote: > On Thu, Jun 20, 2024 at 5:12 AM Roberto Sassu > wrote: > > On Wed, 2024-06-19 at 14:43 -0400, Paul Moore wrote: > > > On Wed, Jun 19, 2024 at 12:38 PM Roberto Sassu > > > wrote: > > > > > > > > Making it a kernel subsystem would likely mean

Re: [PATCH v4 00/14] security: digest_cache LSM

2024-06-20 Thread Paul Moore
On Thu, Jun 20, 2024 at 5:12 AM Roberto Sassu wrote: > On Wed, 2024-06-19 at 14:43 -0400, Paul Moore wrote: > > On Wed, Jun 19, 2024 at 12:38 PM Roberto Sassu > > wrote: > > > > > > Making it a kernel subsystem would likely mean replicating what the LSM > > > infrastructure is doing, inode

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread David Hildenbrand
On 20.06.24 16:29, Jason Gunthorpe wrote: On Thu, Jun 20, 2024 at 04:01:08PM +0200, David Hildenbrand wrote: On 20.06.24 15:55, Jason Gunthorpe wrote: On Thu, Jun 20, 2024 at 09:32:11AM +0100, Fuad Tabba wrote: Hi, On Thu, Jun 20, 2024 at 5:11 AM Christoph Hellwig wrote: On Wed, Jun 19,

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Jason Gunthorpe
On Thu, Jun 20, 2024 at 04:14:23PM +0200, David Hildenbrand wrote: > 1) How would the device be able to grab/access "private memory", if not >via the user page tables? The approaches I'm aware of require the secure world to own the IOMMU and generate the IOMMU page tables. So we will not use

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Jason Gunthorpe
On Thu, Jun 20, 2024 at 04:01:08PM +0200, David Hildenbrand wrote: > On 20.06.24 15:55, Jason Gunthorpe wrote: > > On Thu, Jun 20, 2024 at 09:32:11AM +0100, Fuad Tabba wrote: > > > Hi, > > > > > > On Thu, Jun 20, 2024 at 5:11 AM Christoph Hellwig > > > wrote: > > > > > > > > On Wed, Jun 19,

Re: [PATCH net] selftests: virtio_net: add forgotten config options

2024-06-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 19 Jun 2024 08:17:48 +0200 you wrote: > From: Jiri Pirko > > One may use tools/testing/selftests/drivers/net/virtio_net/config > for example for vng build command like this one: > $ vng -v -b -f

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread David Hildenbrand
On 20.06.24 15:08, Mostafa Saleh wrote: Hi David, On Wed, Jun 19, 2024 at 09:37:58AM +0200, David Hildenbrand wrote: Hi, On 19.06.24 04:44, John Hubbard wrote: On 6/18/24 5:05 PM, Elliot Berman wrote: In arm64 pKVM and QuIC's Gunyah protected VM model, we want to support grabbing shmem user

Re: [PATCH net] selftests: virtio_net: add forgotten config options

2024-06-20 Thread Jakub Kicinski
On Wed, 19 Jun 2024 08:17:48 +0200 Jiri Pirko wrote: > CONFIG_VIRTIO_NET=y > CONFIG_VIRTIO_DEBUG=y > +CONFIG_NET_L3_MASTER_DEV=y > +CONFIG_IPV6_MULTIPLE_TABLES=y > +CONFIG_NET_VRF=m > +CONFIG_BPF_SYSCALL=y > +CONFIG_CGROUP_BPF=y > +CONFIG_IPV6=y I sorted them alphabetically when applying, hope

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Jason Gunthorpe
On Thu, Jun 20, 2024 at 11:00:45AM +0200, David Hildenbrand wrote: > > Not sure if IOMMU + private makes that much sense really, but I think > > I might not really understand what you mean by this. > > A device might be able to access private memory. In the TDX world, this > would mean that a

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread David Hildenbrand
On 20.06.24 15:55, Jason Gunthorpe wrote: On Thu, Jun 20, 2024 at 09:32:11AM +0100, Fuad Tabba wrote: Hi, On Thu, Jun 20, 2024 at 5:11 AM Christoph Hellwig wrote: On Wed, Jun 19, 2024 at 08:51:35AM -0300, Jason Gunthorpe wrote: If you can't agree with the guest_memfd people on how to get

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Jason Gunthorpe
On Thu, Jun 20, 2024 at 09:32:11AM +0100, Fuad Tabba wrote: > Hi, > > On Thu, Jun 20, 2024 at 5:11 AM Christoph Hellwig wrote: > > > > On Wed, Jun 19, 2024 at 08:51:35AM -0300, Jason Gunthorpe wrote: > > > If you can't agree with the guest_memfd people on how to get there > > > then maybe you

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Mostafa Saleh
Hi David, On Wed, Jun 19, 2024 at 09:37:58AM +0200, David Hildenbrand wrote: > Hi, > > On 19.06.24 04:44, John Hubbard wrote: > > On 6/18/24 5:05 PM, Elliot Berman wrote: > > > In arm64 pKVM and QuIC's Gunyah protected VM model, we want to support > > > grabbing shmem user pages instead of using

[PATCH v2 net-next 7/7] selftests: net: add config for openvswitch

2024-06-20 Thread Aaron Conole
The pmtu testing will require that the OVS module is installed, so do that. Reviewed-by: Simon Horman Tested-by: Simon Horman Signed-off-by: Aaron Conole --- tools/testing/selftests/net/config | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/net/config

[PATCH v2 net-next 6/7] selftests: net: Use the provided dpctl rather than the vswitchd for tests.

2024-06-20 Thread Aaron Conole
The current pmtu test infrastucture requires an installed copy of the ovs-vswitchd userspace. This means that any automated or constrained environments may not have the requisite tools to run the tests. However, the pmtu tests don't require any special classifier processing. Indeed they are

[PATCH v2 net-next 4/7] selftests: openvswitch: Add support for tunnel() key.

2024-06-20 Thread Aaron Conole
This will be used when setting details about the tunnel to use as transport. There is a difference between the ODP format between tunnel(): the 'key' flag is not actually a flag field, so we don't support it in the same way that the vswitchd userspace supports displaying it. Signed-off-by: Aaron

[PATCH v2 net-next 5/7] selftests: openvswitch: Support implicit ipv6 arguments.

2024-06-20 Thread Aaron Conole
The current iteration of IPv6 support requires explicit fields to be set in addition to not properly support the actual IPv6 addresses properly. With this change, make it so that the ipv6() bare option is usable to create wildcarded flows to match broad swaths of ipv6 traffic. Reviewed-by: Simon

[PATCH v2 net-next 3/7] selftests: openvswitch: Add set() and set_masked() support.

2024-06-20 Thread Aaron Conole
These will be used in upcoming commits to set specific attributes for interacting with tunnels. Since set() will use the key parsing routine, we also make sure to prepend it with an open paren, for the action parsing to properly understand it. Reviewed-by: Simon Horman Tested-by: Simon Horman

[PATCH v2 net-next 2/7] selftests: openvswitch: Refactor actions parsing.

2024-06-20 Thread Aaron Conole
Until recently, the ovs-dpctl utility was used with a limited actions set and didn't need to have support for multiple similar actions. However, when adding support for tunnels, it will be important to support multiple set() actions in a single flow. When printing these actions, the existing

[PATCH v2 net-next 1/7] selftests: openvswitch: Support explicit tunnel port creation.

2024-06-20 Thread Aaron Conole
The OVS module can operate in conjunction with various types of tunnel ports. These are created as either explicit tunnel vport types, OR by creating a tunnel interface which acts as an anchor for the lightweight tunnel support. This patch adds the ability to add tunnel ports to an OVS datapath

[PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-20 Thread Aaron Conole
Currently, if a user wants to run pmtu.sh and cover all the provided test cases, they need to install the Open vSwitch userspace utilities. This dependency is difficult for users as well as CI environments, because the userspace build and setup may require lots of support and devel packages to be

Re: (subset) [PATCH 0/6] defconfig: drop RT_GROUP_SCHED=y

2024-06-20 Thread Michael Ellerman
On Thu, 30 May 2024 19:19:48 +0800, Celeste Liu wrote: > For cgroup v1, if turned on, and there's any cgroup in the "cpu" hierarchy it > needs an RT budget assigned, otherwise the processes in it will not be able to > get RT at all. The problem with RT group scheduling is that it requires the >

Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout

2024-06-20 Thread David Hildenbrand
On 20.06.24 11:04, Ryan Roberts wrote: On 20/06/2024 01:26, Barry Song wrote: From: Barry Song Both Ryan and Chris have been utilizing the small test program to aid in debugging and identifying issues with swap entry allocation. While a real or intricate workload might be more suitable for

Re: [PATCH 1/2] tools: kernel-chktaint: Fix bashism, simplify code

2024-06-20 Thread Thorsten Leemhuis
On 18.06.24 11:06, Petr Vorel wrote: > '==' is bashism, '=' needs to be used for comparison. > With this fix script can work on systems where the default shell is > dash, busybox ash or any other strictly POSIX compatible shell. > > While at it, also improve: > * remove "x" in the comparison (not

Re: [PATCH v3 03/13] riscv: dts: allwinner: Add xtheadvector to the D1/D1s devicetree

2024-06-20 Thread Chen-Yu Tsai
On Thu, Jun 20, 2024 at 7:57 AM Charlie Jenkins wrote: > > The D1/D1s SoCs support xtheadvector so it can be included in the > devicetree. Also include vlenb for the cpu. > > Signed-off-by: Charlie Jenkins > Reviewed-by: Conor Dooley Acked-by: Chen-Yu Tsai If the RISC-V maintainers want to

Re: [PATCH v4 00/14] security: digest_cache LSM

2024-06-20 Thread Roberto Sassu
On Thu, 2024-06-20 at 11:12 +0200, Roberto Sassu wrote: > On Wed, 2024-06-19 at 14:43 -0400, Paul Moore wrote: > > On Wed, Jun 19, 2024 at 12:38 PM Roberto Sassu > > wrote: > > > > > > Making it a kernel subsystem would likely mean replicating what the LSM > > > infrastructure is doing, inode

Re: [PATCH v4 00/14] security: digest_cache LSM

2024-06-20 Thread Roberto Sassu
On Wed, 2024-06-19 at 14:43 -0400, Paul Moore wrote: > On Wed, Jun 19, 2024 at 12:38 PM Roberto Sassu > wrote: > > > > Making it a kernel subsystem would likely mean replicating what the LSM > > infrastructure is doing, inode (security) blob and being notified about > > file/directory changes. >

Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout

2024-06-20 Thread Barry Song
On Thu, Jun 20, 2024 at 8:28 PM Huang, Ying wrote: > > Barry Song <21cn...@gmail.com> writes: > > > On Thu, Jun 20, 2024 at 8:01 PM Huang, Ying wrote: > >> > >> Barry Song <21cn...@gmail.com> writes: > >> > >> > On Thu, Jun 20, 2024 at 6:36 PM Huang, Ying wrote: > >> >> > >> >> Barry Song

Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout

2024-06-20 Thread Ryan Roberts
On 20/06/2024 01:26, Barry Song wrote: > From: Barry Song > > Both Ryan and Chris have been utilizing the small test program to aid > in debugging and identifying issues with swap entry allocation. While > a real or intricate workload might be more suitable for assessing the > correctness and

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread David Hildenbrand
Yes, and I think we might have to revive that discussion, unfortunately. I started thinking about this, but did not reach a conclusion. Sharing my thoughts. The minimum we might need to make use of guest_memfd (v1 or v2 ;) ) not just for private memory should be: (1) Have private + shared parts

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Fuad Tabba
Hi David, On Wed, Jun 19, 2024 at 1:16 PM David Hildenbrand wrote: > > On 19.06.24 11:11, Fuad Tabba wrote: > > Hi John and David, > > > > Thank you for your comments. > > > > On Wed, Jun 19, 2024 at 8:38 AM David Hildenbrand wrote: > >> > >> Hi, > >> > >> On 19.06.24 04:44, John Hubbard wrote:

Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning

2024-06-20 Thread Fuad Tabba
Hi, On Thu, Jun 20, 2024 at 5:11 AM Christoph Hellwig wrote: > > On Wed, Jun 19, 2024 at 08:51:35AM -0300, Jason Gunthorpe wrote: > > If you can't agree with the guest_memfd people on how to get there > > then maybe you need a guest_memfd2 for this slightly different special > > stuff instead of

Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout

2024-06-20 Thread Huang, Ying
Barry Song <21cn...@gmail.com> writes: > On Thu, Jun 20, 2024 at 8:01 PM Huang, Ying wrote: >> >> Barry Song <21cn...@gmail.com> writes: >> >> > On Thu, Jun 20, 2024 at 6:36 PM Huang, Ying wrote: >> >> >> >> Barry Song <21cn...@gmail.com> writes: >> >> >> >> > On Thu, Jun 20, 2024 at 5:22 PM

Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout

2024-06-20 Thread Barry Song
On Thu, Jun 20, 2024 at 8:01 PM Huang, Ying wrote: > > Barry Song <21cn...@gmail.com> writes: > > > On Thu, Jun 20, 2024 at 6:36 PM Huang, Ying wrote: > >> > >> Barry Song <21cn...@gmail.com> writes: > >> > >> > On Thu, Jun 20, 2024 at 5:22 PM Huang, Ying wrote: > >> >> > >> >> Barry Song

Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout

2024-06-20 Thread Huang, Ying
Barry Song <21cn...@gmail.com> writes: > On Thu, Jun 20, 2024 at 6:36 PM Huang, Ying wrote: >> >> Barry Song <21cn...@gmail.com> writes: >> >> > On Thu, Jun 20, 2024 at 5:22 PM Huang, Ying wrote: >> >> >> >> Barry Song <21cn...@gmail.com> writes: >> >> >> >> > On Thu, Jun 20, 2024 at 1:55 PM

Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout

2024-06-20 Thread Huang, Ying
David Hildenbrand writes: > On 20.06.24 03:53, Huang, Ying wrote: >> Barry Song <21cn...@gmail.com> writes: >> >>> From: Barry Song >>> >>> Both Ryan and Chris have been utilizing the small test program to aid >>> in debugging and identifying issues with swap entry allocation. While >>> a real

Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout

2024-06-20 Thread Barry Song
On Thu, Jun 20, 2024 at 6:36 PM Huang, Ying wrote: > > Barry Song <21cn...@gmail.com> writes: > > > On Thu, Jun 20, 2024 at 5:22 PM Huang, Ying wrote: > >> > >> Barry Song <21cn...@gmail.com> writes: > >> > >> > On Thu, Jun 20, 2024 at 1:55 PM Huang, Ying wrote: > >> >> > >> >> Barry Song

Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout

2024-06-20 Thread David Hildenbrand
On 20.06.24 03:53, Huang, Ying wrote: Barry Song <21cn...@gmail.com> writes: From: Barry Song Both Ryan and Chris have been utilizing the small test program to aid in debugging and identifying issues with swap entry allocation. While a real or intricate workload might be more suitable for

  1   2   >