Re: [PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton of either endianness

2024-08-31 Thread Tony Ambardar
On Fri, Aug 30, 2024 at 06:24:47PM -0700, Alexei Starovoitov wrote: > On Fri, Aug 30, 2024 at 2:31 PM Andrii Nakryiko > wrote: > > > > > > > > for the rest, Alexei, can you please review and give your ack? > > It looks fine. > All of the additional pr_debug()s look a bit excessive. > Will take an

Re: [PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton of either endianness

2024-08-31 Thread Tony Ambardar
On Fri, Aug 30, 2024 at 02:30:46PM -0700, Andrii Nakryiko wrote: > On Fri, Aug 30, 2024 at 12:30 AM Tony Ambardar > wrote: > > > > Track target endianness in 'struct bpf_gen' and process in-memory data in > > native byte-order, but on finalization convert the embedded loader BPF > > insns to targ

Re: [PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton of either endianness

2024-08-30 Thread Alexei Starovoitov
On Fri, Aug 30, 2024 at 2:31 PM Andrii Nakryiko wrote: > > > > for the rest, Alexei, can you please review and give your ack? It looks fine. All of the additional pr_debug()s look a bit excessive. Will take another look at respin.

Re: [PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton of either endianness

2024-08-30 Thread Andrii Nakryiko
On Fri, Aug 30, 2024 at 12:30 AM Tony Ambardar wrote: > > Track target endianness in 'struct bpf_gen' and process in-memory data in > native byte-order, but on finalization convert the embedded loader BPF > insns to target endianness. > > The light skeleton also includes a target-accessed data blo

[PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton of either endianness

2024-08-30 Thread Tony Ambardar
Track target endianness in 'struct bpf_gen' and process in-memory data in native byte-order, but on finalization convert the embedded loader BPF insns to target endianness. The light skeleton also includes a target-accessed data blob which is heterogeneous and thus difficult to convert to target b