Re: tm6000 calculating urb buffer

2010-05-04 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 04.05.2010 21:50, schrieb Mauro Carvalho Chehab: >> Stefan Ringel wrote: >> > datagram from urb to videobuf > > urb copy to temp copy to 1. videobuf >

[patch -next 1/2] media/s2255drv: return if vdev not found

2010-05-04 Thread Dan Carpenter
The original code didn't handle the case where vdev was not found so I added a check for that. Signed-off-by: Dan Carpenter diff --git a/drivers/media/video/s2255drv.c b/drivers/media/video/s2255drv.c index ac9c40c..1f9a49e 100644 --- a/drivers/media/video/s2255drv.c +++ b/drivers/media/video/s2

[patch -next 2/2] media/s2255drv: remove dead code

2010-05-04 Thread Dan Carpenter
My concern initially was we dereference "dev" in the parameter list to s2255_dev_err() but it turns out that code path is never used. The s2255_stop_readpipe() is only called from one place and "dev" is never null. So this patch just removes the whole condition here. Signed-off-by: Dan Carpent

[patch] media/ov511: cleanup: remove unneeded null check

2010-05-04 Thread Dan Carpenter
We dereference "ov" unconditionally throughout the function so there is no way it can be NULL here. This code has been around for ages so if it were possible for "ov" to be NULL someone would have complained. Signed-off-by: Dan Carpenter diff --git a/drivers/media/video/ov511.c b/drivers/media

[patch -next] media/mem2mem: dereferencing free memory

2010-05-04 Thread Dan Carpenter
We dereferenced "ctx" on the error path. Signed-off-by: Dan Carpenter diff --git a/drivers/media/video/mem2mem_testdev.c b/drivers/media/video/mem2mem_testdev.c index baf211b..b161d26 100644 --- a/drivers/media/video/mem2mem_testdev.c +++ b/drivers/media/video/mem2mem_testdev.c @@ -871,8 +871,1

[patch -next] dvb/stv6110x: cleanup error handling

2010-05-04 Thread Dan Carpenter
The "stv6110x" is NULL so we can just return directly without calling kfree(). Also I changed the printk() to make checkpatch.pl happy. Signed-off-by: Dan Carpenter diff --git a/drivers/media/dvb/frontends/stv6110x.c b/drivers/media/dvb/frontends/stv6110x.c index 2f9cd24..42591ce 100644 --- a/

[patch -next] input: unlock on error paths

2010-05-04 Thread Dan Carpenter
We can't return here directly, we need to unlock the event_lock first. This was introduced in: edeada2cde "V4L/DVB: input: Add support for EVIO[CS]GKEYCODEBIG" Signed-off-by: Dan Carpenter diff --git a/drivers/input/input.c b/drivers/input/input.c index e623edf..7c3fc5e 100644 --- a/drivers/inpu

Re: tm6000

2010-05-04 Thread Bee Hock Goh
Did you comment off the code in the get_next_buff that clear the previous frame data? On Wed, May 5, 2010 at 12:50 PM, Dmitri Belimov wrote: > Hi > > At this moment I can start mplayer and see green field with some junk without > crash. > Info from mplayer - received 497 frames, drop 69 incorrec

Re: Hauppauge HVR-4400

2010-05-04 Thread Jed
On 5/4/10 10:45 AM, Jed wrote: Oh wow I didn't know Hauppauge had released some new models above the 2200. http://www.hauppauge.co.uk/site/products/prods_hvr_internal.html Is this 4400 exactly the same as the HVR-2200, aside from the demodulator used for it's DVB-S/S2? I hope so, that way work be

tm6000

2010-05-04 Thread Dmitri Belimov
Hi At this moment I can start mplayer and see green field with some junk without crash. Info from mplayer - received 497 frames, drop 69 incorrect frames. Compile without support DVB-T for our cards. Now try understand init process working drivers and diff with linux. P.S. Linux kernel is 2.6

RE: [Resubmit: PATCH-V2] AM3517: Add VPFE Capture driver support

2010-05-04 Thread Hiremath, Vaibhav
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Wednesday, May 05, 2010 4:48 AM > To: Hiremath, Vaibhav > Cc: linux-o...@vger.kernel.org; linux-media@vger.kernel.org > Subject: Re: [Resubmit: PATCH-V2] AM3517: Add VPFE Capture driver support > > * hvaib...@ti.

Re: [PATCH] tm6000, moving cards name defines

2010-05-04 Thread Dmitri Belimov
On Sun, 02 May 2010 13:32:00 -0300 Mauro Carvalho Chehab wrote: > Dmitri Belimov wrote: > > Hi > > > > Move TV cards name defines to better place header file. > > I prefer if we can keep having all board-specific stuff inside > tm6000-cards. We need know type of tuner and type of TV card insid

Re: [PATCH] Rework for support xc5000

2010-05-04 Thread Bee Hock Goh
There does not seem to be any radio support in the tm6000 codes. tun_setup.mode_mask |= (T_ANALOG_TV | T_RADIO); Is the T_RADIO mode still required since this is a cleanup? On Wed, May 5, 2010 at 6:53 AM, Dmitri Belimov wrote: > Hi > > Set correct GPIO number for BEHOLD_WANDER/VOYAGER > Add xc5

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

2010-05-04 Thread Rafael J. Wysocki
On Wednesday 05 May 2010, Stefan Lippers-Hollmann wrote: > Hi > > On Wednesday 05 May 2010, Rafael J. Wysocki wrote: > > This message has been generated automatically as a part of a summary report > > of recent regressions. > > > > The following bug entry is on the current list of known regressio

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

2010-05-04 Thread Stefan Lippers-Hollmann
Hi On Wednesday 05 May 2010, Rafael J. Wysocki wrote: > This message has been generated automatically as a part of a summary report > of recent regressions. > > The following bug entry is on the current list of known regressions > from 2.6.33. Please verify if it still should be listed and let t

Re: [Resubmit: PATCH-V2] AM3517: Add VPFE Capture driver support

2010-05-04 Thread Tony Lindgren
* hvaib...@ti.com [100319 02:34]: > From: Vaibhav Hiremath > > AM3517 and DM644x uses same CCDC IP, so reusing the driver > for AM3517. > > Signed-off-by: Vaibhav Hiremath > --- > arch/arm/mach-omap2/board-am3517evm.c | 160 > + > 1 files changed, 160 inserti

[PATCH] Rework for support xc5000

2010-05-04 Thread Dmitri Belimov
Hi Set correct GPIO number for BEHOLD_WANDER/VOYAGER Add xc5000 callback function Small rework tm6000_cards_setup function Small rework tm6000_config_tuner, build mode_mask by config information Rework for support xc5000 silicon tuner Add some information messages for more better understand an err

MSI DigiVox A/D II (analog sound) problem reloaded

2010-05-04 Thread Oravecz Csaba
Hi, quite some time ago there was some discussion on this issue but i suspect it has not been resolved ever since. On Thu, 15 Jan 2009 09:32:14 Bastian Beekes wrote: > So I tried modprobe em28xx card=50, which is my MSI DigiVox A/D II - the > video was alright, but when I ran arecord -D hw:1,0 -

Re: tm6000 calculating urb buffer

2010-05-04 Thread Stefan Ringel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 04.05.2010 21:50, schrieb Mauro Carvalho Chehab: > Stefan Ringel wrote: > datagram from urb to videobuf urb copy to temp copy to 1. videobuf buffer2.

Re: tm6000 calculating urb buffer

2010-05-04 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: >>> datagram from urb to videobuf >>> >>> urb copy to temp copy to 1. videobuf >>> buffer2. audiobuf >>>3. vbi >>> 184 Packets ---> 18

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: WARNINGS

2010-05-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Tue May 4 19:00:22 CEST 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 14619:ee9826bc7106 git master:

[PATCH v2] IR/imon: remove dead IMON_KEY_RELEASE_OFFSET

2010-05-04 Thread Jarod Wilson
On Tue, May 04, 2010 at 06:06:41PM +0200, Dan Carpenter wrote: > On Tue, May 04, 2010 at 10:03:18AM -0400, Jarod Wilson wrote: > > @@ -1205,7 +1204,7 @@ static u32 imon_panel_key_lookup(u64 hw_code) > > if (imon_panel_key_table[i].hw_code == (code | 0xffee)) > > brea

Re: tm6000 calculating urb buffer

2010-05-04 Thread Stefan Ringel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 04.05.2010 20:25, schrieb Mauro Carvalho Chehab: > Hi Stefan, > > Stefan Ringel wrote: >> Am 30.04.2010 21:31, schrieb Stefan Ringel: >>> Am 30.04.2010 18:34, schrieb Stefan Ringel: >>> Hi Mauro, Today I'm writing directly to you,

Re: linux-next: Tree for May 4 (media & IR)

2010-05-04 Thread Randy Dunlap
On Tue, 4 May 2010 16:23:05 +1000 Stephen Rothwell wrote: > Hi all, > > Changes since 20100503: drivers/media/video/vivi.c:1144: error: implicit declaration of function 'kfree' drivers/media/video/vivi.c:1156: error: implicit declaration of function 'kzalloc' drivers/media/video/vivi.c:1156: w

Re: tm6000 calculating urb buffer

2010-05-04 Thread Mauro Carvalho Chehab
Hi Stefan, Stefan Ringel wrote: > Am 30.04.2010 21:31, schrieb Stefan Ringel: >> Am 30.04.2010 18:34, schrieb Stefan Ringel: >> >>> Hi Mauro, >>> >>> Today I'm writing directly to you, because it doesn't work the mailing >>> list. I thought over the calculating urb buffer and I have follow idea

Re: [PATCH] IR/imon: remove dead IMON_KEY_RELEASE_OFFSET

2010-05-04 Thread Dan Carpenter
On Tue, May 04, 2010 at 10:03:18AM -0400, Jarod Wilson wrote: > @@ -1205,7 +1204,7 @@ static u32 imon_panel_key_lookup(u64 hw_code) > if (imon_panel_key_table[i].hw_code == (code | 0xffee)) > break; > > - keycode = imon_panel_key_table[i % IMON_KEY_RELEASE_

Re: Hauppauge HVR-4400

2010-05-04 Thread Steven Toth
On 5/4/10 10:45 AM, Jed wrote: Oh wow I didn't know Hauppauge had released some new models above the 2200. http://www.hauppauge.co.uk/site/products/prods_hvr_internal.html Is this 4400 exactly the same as the HVR-2200, aside from the demodulator used for it's DVB-S/S2? I hope so, that way work be

Re: tm6000 calculating urb buffer

2010-05-04 Thread Stefan Ringel
Am 30.04.2010 21:31, schrieb Stefan Ringel: > Am 30.04.2010 18:34, schrieb Stefan Ringel: > >> Hi Mauro, >> >> Today I'm writing directly to you, because it doesn't work the mailing >> list. I thought over the calculating urb buffer and I have follow idea: >> >> buffer = endpoint fifo size (3072

[linux-dvb] pci_abort errors with Hauppauge WinTV Nova-HD-S2

2010-05-04 Thread Thierry LELEGARD
Hello, I recently added a Hauppauge WinTV Nova-HD-S2 into a Linux system. I experience frequent packet loss and pci_abort errors. Each time my application detects packet loss (continuity errors actually), I get the following messages in dmesg: cx88[0]: irq mpeg [0x8] pci_abort* cx88[0]/2-mp

Re: Hauppauge HVR-4400

2010-05-04 Thread Jed
Oh wow I didn't know Hauppauge had released some new models above the 2200. http://www.hauppauge.co.uk/site/products/prods_hvr_internal.html Is this 4400 exactly the same as the HVR-2200, aside from the demodulator used for it's DVB-S/S2? I hope so, that way work being done on the 2200 can flow o

Re: Hauppauge HVR-4400

2010-05-04 Thread Jed
Oh wow I didn't know Haupauge had released some new models above the 2200. http://www.hauppauge.co.uk/site/products/prods_hvr_internal.html Is this 4400 exactly the same as the HVR-2200, aside from the demodulator used for it's DVB-S/S2? I hope so, that way work being done on the 2200 can flow on

Re: [patch -next 1/2] media/az6027: doing dma on the stack

2010-05-04 Thread walter harms
Dan Carpenter schrieb: > I changed the dma buffers to use allocated memory instead of stack > memory. > > The reason for this is documented in Documentation/DMA-API-HOWTO.txt > under the section: "What memory is DMA'able?" That document was only > added a couple weeks ago and there are still l

[PATCH] IR/imon: remove dead IMON_KEY_RELEASE_OFFSET

2010-05-04 Thread Jarod Wilson
This hack was used when the imon driver was using internal key lookup routines, but became dead weight when the driver was converted to use ir-core's key lookup routines. These bits simply didn't get removed, drop 'em now. Pointed out by Dan Carpenter. Signed-off-by: Jarod Wilson --- drivers/me

Re: [patch -next 3/3] media/IR/imon: potential double unlock on error

2010-05-04 Thread Jarod Wilson
On Tue, May 4, 2010 at 7:36 AM, Dan Carpenter wrote: > If there is an error here we should unlock in the caller (which is > imon_init_intf1()).  We can remove this stray unlock. > > Signed-off-by: Dan Carpenter Good catch, missed that when doing some heavy refactoring a while back (haven't got a

Re: [patch -next 2/3] media/IR/imon: testing the wrong variable

2010-05-04 Thread Jarod Wilson
On Tue, May 4, 2010 at 7:38 AM, Dan Carpenter wrote: > There is a typo here.  We meant to test "ir" instead of "props".  The > "props" variable was tested earlier. > > Signed-off-by: Dan Carpenter Acked-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send

Re: [patch -next 1/3] media/IR/imon: precendence issue: ! vs ==

2010-05-04 Thread Jarod Wilson
On Tue, May 4, 2010 at 7:37 AM, Dan Carpenter wrote: > The original condition is always false because ! has higher precedence > than == and neither 0 nor 1 is equal to IMON_DISPLAY_TYPE_VGA. > > Signed-off-by: Dan Carpenter Acked-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsub

Re: Hauppauge HVR-4400

2010-05-04 Thread Devin Heitmueller
On Tue, May 4, 2010 at 8:00 AM, Jan Möbius wrote: > Hi, > > im trying to get a Hauppauge HVR-4400 working on a Debian squeeze. It seems to > be unsopported yet. Is there any driver which i don't know about? There is no support currently for that card, and since it uses a demodulator for which the

[patch -next 1/2] media/az6027: handle -EIO failure

2010-05-04 Thread Dan Carpenter
If the az6027_usb_in_op() returns a negative errno ret is -EIO and in that case the value of b[0] may be undefined. The original code assigned 0 to ret, but since it's already 0 now we can skip that. Signed-off-by: Dan Carpenter diff --git a/drivers/media/dvb/dvb-usb/az6027.c b/drivers/media/d

Hauppauge HVR-4400

2010-05-04 Thread Jan Möbius
Hi, im trying to get a Hauppauge HVR-4400 working on a Debian squeeze. It seems to be unsopported yet. Is there any driver which i don't know about? If not i would really like to help getting it supported (information, testing,...) Some information i get from the card: Hauppauge HVR-4400 ( sh

[-next] [bug report] media/IR/imon: array overflow

2010-05-04 Thread Dan Carpenter
This is a Smatch thing. I'm not sure what's intended. drivers/media/IR/imon.c +1211 imon_panel_key_lookup(10) error: buffer overflow 'imon_panel_key_table' 21 <= 21 1207 for (i = 0; i < ARRAY_SIZE(imon_panel_key_table); i++) 1208 if (imon_panel_key_table[i].hw_code

[patch -next 1/2] media/az6027: doing dma on the stack

2010-05-04 Thread Dan Carpenter
I changed the dma buffers to use allocated memory instead of stack memory. The reason for this is documented in Documentation/DMA-API-HOWTO.txt under the section: "What memory is DMA'able?" That document was only added a couple weeks ago and there are still lots of modules which haven't been cor

[patch -next 2/3] media/IR/imon: testing the wrong variable

2010-05-04 Thread Dan Carpenter
There is a typo here. We meant to test "ir" instead of "props". The "props" variable was tested earlier. Signed-off-by: Dan Carpenter diff --git a/drivers/media/IR/imon.c b/drivers/media/IR/imon.c index b65c31a..f2066d0 100644 --- a/drivers/media/IR/imon.c +++ b/drivers/media/IR/imon.c @@ -167

[patch -next 1/3] media/IR/imon: precendence issue: ! vs ==

2010-05-04 Thread Dan Carpenter
The original condition is always false because ! has higher precedence than == and neither 0 nor 1 is equal to IMON_DISPLAY_TYPE_VGA. Signed-off-by: Dan Carpenter diff --git a/drivers/media/IR/imon.c b/drivers/media/IR/imon.c index b65c31a..93b5796 100644 --- a/drivers/media/IR/imon.c +++ b/driv

[patch -next 3/3] media/IR/imon: potential double unlock on error

2010-05-04 Thread Dan Carpenter
If there is an error here we should unlock in the caller (which is imon_init_intf1()). We can remove this stray unlock. Signed-off-by: Dan Carpenter diff --git a/drivers/media/IR/imon.c b/drivers/media/IR/imon.c index b65c31a..d48ad6d 100644 --- a/drivers/media/IR/imon.c +++ b/drivers/media/IR

Re: [patch 10/11] ir-keytable: avoid double lock

2010-05-04 Thread Dan Carpenter
On Mon, May 03, 2010 at 08:07:29PM -0300, Mauro Carvalho Chehab wrote: > a...@linux-foundation.org wrote: > > From: Dan Carpenter > > > > It's possible that we wanted to resize to a smaller size but we didn't > > have enough memory to create the new table. We need to test for that here > > so we

gnutv: change channels quickly with cam suport

2010-05-04 Thread Simon Vogl
Dear all, I extended gnutv a little in order to make it switch channels quickly: I'v added a command line option (-remote) to make it read channel names from stdin and change from one channel to another in a few hundred ms. Hope you find this useful, Simon -- DI Dr. Simon Vogl