Re: [PATCH RFC 01/12] s5p-csis: Add device tree support

2012-12-11 Thread Grant Likely
On Mon, 10 Dec 2012 20:45:55 +0100, Sylwester Nawrocki s.nawro...@samsung.com wrote: s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC (camera host interface DMA engine and image processor). This patch adds support for instantiating the MIPI-CSIS devices from DT and parsing

Re: [PATCH RFC 01/13] i2c: add dummy inline functions for when CONFIG_OF_I2C(_MODULE) isn't defined

2012-12-11 Thread Grant Likely
On Mon, 10 Dec 2012 20:41:27 +0100, Sylwester Nawrocki s.nawro...@samsung.com wrote: From: Guennadi Liakhovetski g.liakhovet...@gmx.de If CONFIG_OF_I2C and CONFIG_OF_I2C_MODULE are undefined no declaration of of_find_i2c_device_by_node and of_find_i2c_adapter_by_node will be available. Add

Re: [PATCH RFC 02/13] of: add a dummy inline function for when CONFIG_OF is not defined

2012-12-11 Thread Grant Likely
On Mon, 10 Dec 2012 20:41:28 +0100, Sylwester Nawrocki s.nawro...@samsung.com wrote: From: Guennadi Liakhovetski g.liakhovet...@gmx.de If CONFIG_OF isn't defined, no declaration of of_get_parent will be found and compilation can fail. This patch adds a dummy inline function definition to

Re: [PATCH RFC 03/13] OF: define of_*_cmp() macros also if CONFIG_OF isn't set

2012-12-11 Thread Grant Likely
On Mon, 10 Dec 2012 20:41:29 +0100, Sylwester Nawrocki s.nawro...@samsung.com wrote: From: Guennadi Liakhovetski g.liakhovet...@gmx.de of_*_cmp() macros do not depend on any OF functions and can be defined also if CONFIG_OF isn't set. Also include linux/string.h, required by those macros.

Re: [PATCH RFC 04/13] OF: make a function pointer argument const

2012-12-11 Thread Grant Likely
On Mon, 10 Dec 2012 20:41:30 +0100, Sylwester Nawrocki s.nawro...@samsung.com wrote: From: Guennadi Liakhovetski g.liakhovet...@gmx.de The struct device_node * argument of of_parse_phandle_*() can be const. This is a good time to talk about commit text. Again, the patch looks fine, but it

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-11 Thread Hans Verkuil
On Thu 6 December 2012 10:54:32 Sakari Ailus wrote: Hi Prabhakar and Hans, On Thu, Dec 06, 2012 at 10:24:18AM +0530, Prabhakar Lad wrote: Hi Hans, On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil hverk...@xs4all.nl wrote: (resend without HTML formatting) On Wed 5 December 2012

Re: [PATCH RFC 05/13] of: Add empty for_each_available_child_of_node() macro definition

2012-12-11 Thread Grant Likely
On Mon, 10 Dec 2012 20:41:31 +0100, Sylwester Nawrocki s.nawro...@samsung.com wrote: Add this empty macro definition so users can be compiled without excluding this macro call with preprocessor directives when CONFIG_OF is disabled. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com

Re: [PATCH RFC 06/13] of: Add empty of_find_device_by_node() function definition

2012-12-11 Thread Grant Likely
On Mon, 10 Dec 2012 20:41:32 +0100, Sylwester Nawrocki s.nawro...@samsung.com wrote: This allows users to be compiled without excluding this function call with preprocessor directives when CONFIG_OF_DEVICE is disabled. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by:

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-11 Thread Hans Verkuil
On Tue 11 December 2012 09:56:42 Hans Verkuil wrote: On Thu 6 December 2012 10:54:32 Sakari Ailus wrote: Hi Prabhakar and Hans, On Thu, Dec 06, 2012 at 10:24:18AM +0530, Prabhakar Lad wrote: Hi Hans, On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil hverk...@xs4all.nl wrote:

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-11 Thread Prabhakar Lad
Hi Hans, On Tue, Dec 11, 2012 at 2:26 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Thu 6 December 2012 10:54:32 Sakari Ailus wrote: Hi Prabhakar and Hans, On Thu, Dec 06, 2012 at 10:24:18AM +0530, Prabhakar Lad wrote: Hi Hans, On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil

Re: RFC: First draft of guidelines for submitting patches to linux-media

2012-12-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Dec 2012 00:52:39 +0100 Laurent Pinchart laurent.pinch...@ideasonboard.com escreveu: Hi, On Monday 10 December 2012 16:33:13 Mauro Carvalho Chehab wrote: Em Mon, 10 Dec 2012 14:07:09 +0100 Hans Verkuil escreveu: Hi all, As discussed in Barcelona I would write a text

Re: [PATCH RFC 01/12] s5p-csis: Add device tree support

2012-12-11 Thread Sylwester Nawrocki
Hello Grant, On 12/11/2012 09:36 AM, Grant Likely wrote: On Mon, 10 Dec 2012 20:45:55 +0100, Sylwester Nawrocki s.nawro...@samsung.com wrote: s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC (camera host interface DMA engine and image processor). This patch adds support

Re: RFC: First draft of guidelines for submitting patches to linux-media

2012-12-11 Thread Laurent Pinchart
Hi Mauro, On Tuesday 11 December 2012 08:29:30 Mauro Carvalho Chehab wrote: Em Tue, 11 Dec 2012 00:52:39 +0100 Laurent Pinchart escreveu: On Monday 10 December 2012 16:33:13 Mauro Carvalho Chehab wrote: Em Mon, 10 Dec 2012 14:07:09 +0100 Hans Verkuil escreveu: [snip] Submitting New

Re: RFC: First draft of guidelines for submitting patches to linux-media

2012-12-11 Thread Hans Verkuil
I've added a few quick remarks below. I'll collect all the very useful feedback on Friday and post a new version. After that I'm on vacation for three weeks. On Tue 11 December 2012 11:29:30 Mauro Carvalho Chehab wrote: Em Tue, 11 Dec 2012 00:52:39 +0100 Laurent Pinchart

Re: Kworld PCI Analog TV Card Lite PVR-7134SE

2012-12-11 Thread Saad Bin Javed
On 12/11/2012 02:22 AM, Alfredo Jesús Delaiti wrote: Hi Read: http://www.linuxtv.org/wiki/index.php/Kworld_PCI_Analog_TV_Card_Lite Alfredo El 10/12/12 15:06, Saad Bin Javed escribió: Can anybody help setting up this card? I posted details in an earlier message but got no response. This list

Re: RFC: First draft of guidelines for submitting patches to linux-media

2012-12-11 Thread Laurent Pinchart
Hi Hans, On Tuesday 11 December 2012 12:50:21 Hans Verkuil wrote: I've added a few quick remarks below. I'll collect all the very useful feedback on Friday and post a new version. After that I'm on vacation for three weeks. On Tue 11 December 2012 11:29:30 Mauro Carvalho Chehab wrote: Em

[PATCH] omap3isp: csiphy: Fix an uninitialized variable compiler warning

2012-12-11 Thread Laurent Pinchart
drivers/media/platform/omap3isp/ispcsiphy.c: In function ‘csiphy_routing_cfg’: drivers/media/platform/omap3isp/ispcsiphy.c:71:57: warning: ‘shift’ may be used uninitialized in this function [-Wuninitialized] drivers/media/platform/omap3isp/ispcsiphy.c:40:6: note: ‘shift’ was declared here The

Re: RFC: First draft of guidelines for submitting patches to linux-media

2012-12-11 Thread Hans Verkuil
On Mon 10 December 2012 14:07:09 Hans Verkuil wrote: Hi all, As discussed in Barcelona I would write a text describing requirements for new drivers and what to expect when submitting patches to linux-media. This is a first rough draft and nothing is fixed yet. I have a few open

Re: RFC: First draft of guidelines for submitting patches to linux-media

2012-12-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Dec 2012 12:39:06 +0100 Laurent Pinchart laurent.pinch...@ideasonboard.com escreveu: Hi Mauro, On Tuesday 11 December 2012 08:29:30 Mauro Carvalho Chehab wrote: Em Tue, 11 Dec 2012 00:52:39 +0100 Laurent Pinchart escreveu: On Monday 10 December 2012 16:33:13 Mauro Carvalho

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-12-11 Thread Federico Vaga
Sorry for the late answer to this. This allocator is needed because some device (like STA2X11 VIP) cannot work with DMA sg or DMA coherent. Some other device (like the one used by Jonathan when he proposes vb2-dma-nc allocator) can obtain much better performance with DMA streaming than

Re: [RFC PATCH] vb2: force output buffers to fault into memory

2012-12-11 Thread Laurent Pinchart
Hi Marek, On Friday 07 December 2012 15:29:30 Marek Szyprowski wrote: On 12/6/2012 2:23 AM, Laurent Pinchart wrote: On Tuesday 04 December 2012 16:48:40 Hans Verkuil wrote: (repost after accidentally using HTML formatting) This needs a good review. The change is minor, but as I am

Re: RFC: First draft of guidelines for submitting patches to linux-media

2012-12-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Dec 2012 12:50:21 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: - typedefs should't be used; CodingStyle, chapter 5. Surprisingly this chapter doesn't mention typedefs for function pointers. Those are very hard to manage without a typedef. It seems you detected

How to configure resizer in ISP pipeline?

2012-12-11 Thread Andreas Nagel
Hello, using Media Controller API, I can successfully configure a simple ISP pipeline on an OMAP3530 and capture video data. Now I want to include the resizer. So the pipeline would look like this (where MEM would be the devnode corresponding to resizer output): Sensor -- CCDC -- Resizer --

Re: RFC: First draft of guidelines for submitting patches to linux-media

2012-12-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Dec 2012 13:20:32 +0100 Laurent Pinchart laurent.pinch...@ideasonboard.com escreveu: [snip] - not sure if this is possible: if a v2 patch series is posted, then automatically remove v1. This would require sanity checks: same subject, same author. There's a security issue here

Re: RFC: First draft of guidelines for submitting patches to linux-media

2012-12-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Dec 2012 14:15:31 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: On Mon 10 December 2012 14:07:09 Hans Verkuil wrote: Hi all, As discussed in Barcelona I would write a text describing requirements for new drivers and what to expect when submitting patches to linux-media.

Re: [PATCH] omap3isp: csiphy: Fix an uninitialized variable compiler warning

2012-12-11 Thread Sakari Ailus
On Tue, Dec 11, 2012 at 02:11:52PM +0100, Laurent Pinchart wrote: drivers/media/platform/omap3isp/ispcsiphy.c: In function ‘csiphy_routing_cfg’: drivers/media/platform/omap3isp/ispcsiphy.c:71:57: warning: ‘shift’ may be used uninitialized in this function [-Wuninitialized]

Re: [PATCH RFC 05/13] of: Add empty for_each_available_child_of_node() macro definition

2012-12-11 Thread Sylwester Nawrocki
On 12/11/2012 09:57 AM, Grant Likely wrote: On Mon, 10 Dec 2012 20:41:31 +0100, Sylwester Nawrocki s.nawro...@samsung.com wrote: Add this empty macro definition so users can be compiled without excluding this macro call with preprocessor directives when CONFIG_OF is disabled.

How to manage weighted sections for scene brightness calculation

2012-12-11 Thread davide . bonfanti
Hi, I'm writing a driver for a CMOS sensor having the following feature: the frame average brightness value is given by the weighted average of 16 sections. In other words, the scene is divided into 16 square areas: each area can be weighted differently (from 1 to 4) to achieve the whole

Re: [PATCH RFC 01/12] s5p-csis: Add device tree support

2012-12-11 Thread Grant Likely
On Tue, 11 Dec 2012 12:24:23 +0100, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hello Grant, On 12/11/2012 09:36 AM, Grant Likely wrote: On Mon, 10 Dec 2012 20:45:55 +0100, Sylwester Nawrocki s.nawro...@samsung.com wrote: s5p-csis is platform device driver for MIPI-CSI frontend to

Re: RFC: First draft of guidelines for submitting patches to linux-media

2012-12-11 Thread Frank Schäfer
Am 10.12.2012 20:40, schrieb Mauro Carvalho Chehab: [snip] And people beeing subsystem maintainers AND driver maintainers have to find a balance between processing pull requests and reviewing patches. I'm not sure if I have understood yet how this balance should look like... Can you

Re: EM2800 and audio via USB ?

2012-12-11 Thread Frank Schäfer
Am 10.12.2012 21:08, schrieb Devin Heitmueller: On Mon, Dec 10, 2012 at 2:32 PM, Frank Schäfer fschaefer@googlemail.com wrote: a Terratec Cinergy 200 USB Most of those really old devices don't actually make the PCM audio available over the USB. That's why they provide an audio out

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2012-12-11 Thread Frank Schäfer
Am 10.12.2012 21:48, schrieb Antti Palosaari: On 12/10/2012 09:24 PM, Frank Schäfer wrote: Am 10.12.2012 18:57, schrieb Antti Palosaari: On 12/10/2012 06:13 PM, Devin Heitmueller wrote: On Mon, Dec 10, 2012 at 11:01 AM, Frank Schäfer Adding a new property to the RC profile certainly seems to

cron job: media_tree daily build: WARNINGS

2012-12-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Tue Dec 11 19:00:20 CET 2012 git hash:16427faf28674451a7a0485ab0a929402f355ffd gcc version: i686-linux-gcc

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2012-12-11 Thread Antti Palosaari
On 12/11/2012 10:51 PM, Frank Schäfer wrote: Am 10.12.2012 21:48, schrieb Antti Palosaari: On 12/10/2012 09:24 PM, Frank Schäfer wrote: Am 10.12.2012 18:57, schrieb Antti Palosaari: On 12/10/2012 06:13 PM, Devin Heitmueller wrote: On Mon, Dec 10, 2012 at 11:01 AM, Frank Schäfer Adding a new

Re: [PATCH RFC 1/2] V4L: Add auto focus selection targets

2012-12-11 Thread Sakari Ailus
Hi Andrzej, Many thanks for the patch! On Mon, Dec 10, 2012 at 02:43:38PM +0100, Andrzej Hajda wrote: From: Sylwester Nawrocki s.nawro...@samsung.com The camera automatic focus algorithms may require setting up a spot or rectangle coordinates. The automatic focus selection targets are

Re: [PATCH RFC 2/2] V4L: Add V4L2_CID_AUTO_FOCUS_AREA control

2012-12-11 Thread Sakari Ailus
Hi Andrzej and Sylwester, Thanks for the patch! On Mon, Dec 10, 2012 at 02:43:39PM +0100, Andrzej Hajda wrote: From: Sylwester Nawrocki s.nawro...@samsung.com Add control for automatic focus area selection. This control determines the area of the frame that the camera uses for automatic

[PATCH 08/19] MAINTAINERS: fix drivers/media/usb/dvb-usb/cxusb*

2012-12-11 Thread Cesar Eduardo Barros
This driver was never at dvb-usb-v2, as far as I could see. Cc: Michael Krufky mkru...@linuxtv.org Cc: linux-media@vger.kernel.org Signed-off-by: Cesar Eduardo Barros ces...@cesarb.net --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH 06/19] MAINTAINERS: fix drivers/media/platform/atmel-isi.c

2012-12-11 Thread Cesar Eduardo Barros
This file was moved to drivers/media/platform/soc_camera/atmel-isi.c by commit b47ff4a ([media] move soc_camera to its own directory). Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: Josh Wu josh...@atmel.com Cc: linux-media@vger.kernel.org Signed-off-by: Cesar Eduardo Barros ces...@cesarb.net

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-11 Thread Sakari Ailus
Hi Hans, On Tue, Dec 11, 2012 at 09:56:42AM +0100, Hans Verkuil wrote: ... If I set both V4L2_CID_GAIN_RED and V4L2_CID_RED_OFFSET, how are they supposed to interact? Or are they mutually exclusive? And if I set both V4L2_CID_GAIN_OFFSET and V4L2_CID_RED_OFFSET, how are

Re: EM2800 and audio via USB ?

2012-12-11 Thread Benny Amorsen
Frank Schäfer fschaefer@googlemail.com writes: Yes, I remeber these days ;) I just wonder why it has a line-in input. It seems it is completely useless... Just a guess: The line-in is patched through to line-out when the TV tuner is not in use. That way you do not have to move cables all

[PATCH 2/5] media: davinci: fix return value check in vpbe_display_reqbufs().

2012-12-11 Thread Cyril Roelandt
vb2_dma_contig_init_ctx() returns ERR_PTR and never returns NULL, so IS_ERR should be used instead of a NULL check. Signed-off-by: Cyril Roelandt tipec...@gmail.com --- drivers/media/platform/davinci/vpbe_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 2/5] media: davinci: fix return value check in vpbe_display_reqbufs().

2012-12-11 Thread Prabhakar Lad
Hi Cyril, On Wed, Dec 12, 2012 at 5:54 AM, Cyril Roelandt tipec...@gmail.com wrote: vb2_dma_contig_init_ctx() returns ERR_PTR and never returns NULL, so IS_ERR should be used instead of a NULL check. patch fixing this issue has been already posted with a better fix

Re: Kworld PCI Analog TV Card Lite PVR-7134SE

2012-12-11 Thread Saad Bin Javed
Dear Alfredo, Thank you for helping me. Is the same card: Board indentification : 713XTV VRE: J Yes, I have the same board. 713XTV VRE:J Please try: modprobe saa7134 card=63 tuner=43 or modprobe saa7134 card=59 tuner=56 please tell me which program you use to watch TV. Use