[PATCH 4/4] [media] s3c-camif: Use dev_info instead of printk

2013-04-29 Thread Sachin Kamat
dev_info is preferred to printk. Silences the related checkpatch warning. WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: Sachin Kamat --- drivers/media/platform/s3c-camif/camif-regs.c |2 +- 1 file changed, 1 insertion(

[PATCH 3/4] [media] s3c-camif: Staticize local symbols

2013-04-29 Thread Sachin Kamat
These symbols are local to the file and should be static. Signed-off-by: Sachin Kamat --- drivers/media/platform/s3c-camif/camif-regs.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s3c-camif/camif-regs.c b/drivers/media/platform/s3c-camif/cam

[PATCH 2/4] [media] s3c-camif: Fix incorrect variable type

2013-04-29 Thread Sachin Kamat
'rotation' was an 8 bit variable and hence could not have values greater than 255. Since we need higher values, chnage it to 16 bit type. Signed-off-by: Sachin Kamat --- drivers/media/platform/s3c-camif/camif-core.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/m

[PATCH 1/4] [media] s3c-camif: Remove redundant NULL check

2013-04-29 Thread Sachin Kamat
clk_unprepare checks for NULL pointer. Hence convert IS_ERR_OR_NULL to IS_ERR only. Signed-off-by: Sachin Kamat --- drivers/media/platform/s3c-camif/camif-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

2013-04-29 Thread Sascha Hauer
Hi, One more point for your devicetree conversions, On Mon, Apr 29, 2013 at 01:30:01PM +0530, Prabhakar Lad wrote: > From: Lad, Prabhakar > > add OF support for the mt9p031 sensor driver. > > +static struct mt9p031_platform_data > + *mt9p031_get_pdata(struct i2c_client *client) > + > +{ >

[PATCH 1/1] [media] exynos4-is: Remove redundant NULL check in fimc-lite.c

2013-04-29 Thread Sachin Kamat
clk_unprepare checks for NULL pointer. Hence convert IS_ERR_OR_NULL to IS_ERR only. Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos4-is/fimc-lite.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-lite.c b/drivers/media/

[PATCH] [media] s5c73m3: Fix off-by-one valid range checking for fie->index

2013-04-29 Thread Axel Lin
Current code uses fie->index as array subscript, thus the valid value range is 0 ... ARRAY_SIZE(s5c73m3_intervals) - 1. Signed-off-by: Axel Lin --- drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.

V4L2: Get device/input status

2013-04-29 Thread Vadim Golopupov
I have plugged in usb digital camera (it has one input pin - 0). I check input status every 5 seconds via structure: v4l2_input (here is the example: http://pastebin.com/X9Z23DbZ), to process situation if one of the flags is set (V4L2_IN_ST_NO_POWER or V4L2_IN_ST_NO_SIGNAL or V4L2_IN_ST_NO_H_LOCK)

Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-04-29 Thread Laurent Pinchart
Hi Scott, Sorry for the (very) late reply. On Sunday 07 April 2013 18:35:54 Scott Jiang wrote: > Hi Laurent, > > >> >> >> +struct mt9m114_reg { > >> >> >> + u16 reg; > >> >> >> + u32 val; > >> >> >> + int width; > >> >> >> +}; > >> >> >> + > >> >> >> +enum { > >> >> >> + MT9M114_

Re: [RFC] Motion Detection API

2013-04-29 Thread Laurent Pinchart
Hi Hans, Sorry for the late reply. On Friday 12 April 2013 17:36:16 Hans Verkuil wrote: > This RFC looks at adding support for motion detection to V4L2. This is the > main missing piece that prevents the go7007 and solo6x10 drivers from being > moved into mainline from the staging directory. > >

[PATCH V2 1/3] saa7115: move the autodetection code out of the probe function

2013-04-29 Thread Jon Arne Jørgensen
As we're now seeing other variants from chinese clones, like gm1113c, we'll need to add more bits at the detection code. So, move it into a separate function. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Jon Arne Jørgensen --- drivers/media/i2c/saa7115.c | 133 ++

[PATCH V2 3/3] saa7115: Add register setup and config for gm7113c

2013-04-29 Thread Jon Arne Jørgensen
Signed-off-by: Jon Arne Jørgensen --- drivers/media/i2c/saa7115.c | 48 - 1 file changed, 39 insertions(+), 9 deletions(-) diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c index eb2c19d..77c13dc 100644 --- a/drivers/media/i2c/saa

[PATCH 0/3] saa7115: add detection code for gm7113c

2013-04-29 Thread Jon Arne Jørgensen
This is the second version of a patch-set previously posted by Mauro, the first verseon was posted on 26 April, and can be found here: http://www.spinics.net/lists/linux-media/msg63079.html The purpose of this patch is to add support for the gm7113c chip in the saa7115 driver. The gm7113c chip is

[PATCH V2 2/3] saa7115: add detection code for gm7113c

2013-04-29 Thread Jon Arne Jørgensen
Adds a code that (auto)detects gm7113c clones. The auto-detection here is not perfect, as, on contrary to what it would be expected by looking into its datasheets some devices would return, instead: saa7115 0-0025: chip 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 @ 0x4a is unknown (f

Re: [PATCH] [media] uvcvideo: Retry usb_submit_urb on -EPERM return

2013-04-29 Thread Laurent Pinchart
Hi Shawn, Thank you for the patch. On Tuesday 23 April 2013 17:42:32 Shawn Nematbakhsh wrote: > While usb_kill_urb is in progress, calls to usb_submit_urb will fail > with -EPERM (documented in Documentation/usb/URB.txt). The UVC driver > does not correctly handle this case -- there is no synchro

cron job: media_tree daily build: WARNINGS

2013-04-29 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Apr 29 19:00:18 CEST 2013 git branch: test git hash: 4494f0fdd825958d596d05a4bd577df94b149038 gcc versi

Re: [PATCH] media: i2c: adv7343: add OF support

2013-04-29 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Mon, Apr 29, 2013 at 7:32 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Friday 26 April 2013 18:48:06 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> add OF support for the adv7343 driver. >> >> Signed-off-by: Lad, Prabh

Re: [PATCH] media: i2c: tvp7002: enable TVP7002 decoder for media controller based usage

2013-04-29 Thread Prabhakar Lad
Hi Laurent, On Mon, Apr 29, 2013 at 11:06 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Monday 29 April 2013 23:00:26 Prabhakar Lad wrote: >> On Mon, Apr 29, 2013 at 7:57 PM, Laurent Pinchart wrote: >> > On Friday 26 April 2013 13:35:35 Prabhakar Lad wrote: >> >> From: Lad, Prabhakar >> >>

Re: [PATCH] media: i2c: tvp7002: enable TVP7002 decoder for media controller based usage

2013-04-29 Thread Laurent Pinchart
Hi Prabhakar, On Monday 29 April 2013 23:00:26 Prabhakar Lad wrote: > On Mon, Apr 29, 2013 at 7:57 PM, Laurent Pinchart wrote: > > On Friday 26 April 2013 13:35:35 Prabhakar Lad wrote: > >> From: Lad, Prabhakar > >> > >> This patch enables tvp7002 decoder driver for media controller > >> based u

Re: [PATCH] media: i2c: tvp7002: enable TVP7002 decoder for media controller based usage

2013-04-29 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Mon, Apr 29, 2013 at 7:57 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Friday 26 April 2013 13:35:35 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> This patch enables tvp7002 decoder driver for media controller >> base

Re: [PATCH] media: i2c: tvp514x: add OF support

2013-04-29 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Mon, Apr 29, 2013 at 7:27 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. Please see below for a couple of comments. Most of > them apply to your adv7343 patch as well. > alright I'll fix for that patch as well. > On Friday 26 April

Re: [PATCH RFC v2] [media] blackfin: add video display device driver

2013-04-29 Thread Sylwester Nawrocki
Hi Scott, On 04/28/2013 11:20 PM, Scott Jiang wrote: > This is a V4L2 driver for Blackfin video display (E)PPI interface. > This module is common for BF537/BF561/BF548/BF609. > > Signed-off-by: Scott Jiang >From a quick review this patch looks good to me. Feel free to add Reviewed-by: Sylweste

Re: [PATCH] media: i2c: adv7343: add OF support

2013-04-29 Thread Sylwester Nawrocki
Hi, On 04/26/2013 03:18 PM, Prabhakar Lad wrote: > From: Lad, Prabhakar > > add OF support for the adv7343 driver. > +++ b/Documentation/devicetree/bindings/media/i2c/adv7343.txt > @@ -0,0 +1,69 @@ > +* Analog Devices adv7343 video encoder > + > +The ADV7343 are high speed, digital-to-analog vi

Re: [RFC v2 6/6] media: exynos5-is: Adding media device driver for exynos5

2013-04-29 Thread Sylwester Nawrocki
On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote: > This patch adds support for media device for EXYNOS5 SoCs. > The current media device supports the following ips to connect > through the media controller framework. > Signed-off-by: Shaik Ameer Basha > --- > .../devicetree/bindings/media/exynos

Re: [RFC v2 5/6] media: s5p-csis: Adding Exynos5250 compatibility

2013-04-29 Thread Sylwester Nawrocki
On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote: > FIMC-IS firmware needs all the MIPI-CSIS interrupts to be enabled. > This patch enables all those MIPI interrupts and adds the Exynos5 > compatible string. > > Signed-off-by: Shaik Ameer Basha > --- > drivers/media/platform/exynos4-is/mipi-csis.

Re: [RFC v2 3/6] media: fimc-lite: Adding support for Exynos5

2013-04-29 Thread Sylwester Nawrocki
On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote: > FIMC-LITE supports multiple DMA shadow registers from Exynos5 onwards. > This patch adds the functionality of using shadow registers by > checking the driver data. > > Signed-off-by: Shaik Ameer Basha > --- > drivers/media/platform/exynos4-is/fi

Re: em28xx: Kernel panic after installing latest linuxtv.org modules

2013-04-29 Thread Mauro Carvalho Chehab
Em Sun, 28 Apr 2013 20:29:19 +0200 Marcel Kulicke escreveu: > Hi Mauro, > > thanks a lot for taking the time to respond to my issue! > > Did it used to work with a previous version? If so, could you please > > bisect to see what patch broke it? > No, it also didn't work with the previous versio

Re: [PATCH] media: i2c: tvp7002: enable TVP7002 decoder for media controller based usage

2013-04-29 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Friday 26 April 2013 13:35:35 Prabhakar Lad wrote: > From: Lad, Prabhakar > > This patch enables tvp7002 decoder driver for media controller > based usage by adding v4l2_subdev_pad_ops operations support > for enum_mbus_code, set_pad_format, get_pad_fo

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

2013-04-29 Thread Laurent Pinchart
On Monday 29 April 2013 17:18:02 Prabhakar Lad wrote: > On Mon, Apr 29, 2013 at 5:05 PM, Laurent Pinchart wrote: > > Hi Prabhakar, > > > > Thank you for the patch. Please see below for a couple of comments in > > addition to the ones I've just sent (in reply to Sascha's e-mail). > > Yep fixed the

Re: [PATCH] media: i2c: adv7343: add OF support

2013-04-29 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Friday 26 April 2013 18:48:06 Prabhakar Lad wrote: > From: Lad, Prabhakar > > add OF support for the adv7343 driver. > > Signed-off-by: Lad, Prabhakar > Cc: Hans Verkuil > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Guennadi Liakhovetski

Re: [PATCH] media: i2c: tvp514x: add OF support

2013-04-29 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. Please see below for a couple of comments. Most of them apply to your adv7343 patch as well. On Friday 26 April 2013 16:53:50 Prabhakar Lad wrote: > From: Lad, Prabhakar > > add OF support for the tvp514x driver. > > Signed-off-by: Lad, Prabhakar > Cc:

Re: [PATCH v2 00/31] Add r820t support at rtl28xxu

2013-04-29 Thread Mauro Carvalho Chehab
Em Sun, 28 Apr 2013 19:42:12 +0200 Lars Buerding escreveu: > On 17.04.2013 02:42, Mauro Carvalho Chehab wrote: > > Add a tuner driver for Rafael Micro R820T silicon tuner. > > > > This tuner seems to be popular those days. Add support for it > > at rtl28xxu. > > > > This tuner was written from sc

Re: Terratec Grabby hwrev 2

2013-04-29 Thread Timo Teras
On Fri, 05 Apr 2013 17:33:07 +0200 Frank Schäfer wrote: > Am 03.04.2013 10:27, schrieb Timo Teras: > > I did not test VBI, so I'm unsure if it works or not. > > The em2860 supports VBI, so VBI mode is used. > You can force the normal mode with module parameter disable_vbi=1 Right. Tested that n

Re: [RFC v2 2/6] fimc-lite: Adding Exynos5 compatibility to fimc-lite driver

2013-04-29 Thread Sylwester Nawrocki
On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote: > This patch adds, > 1] Exynos5 soc compatibility to the fimc-lite driver > 2] Multiple dma output buffer support as from Exynos5 onwards, >fimc-lite h/w ip supports multiple dma buffers. > > Signed-off-by: Shaik Ameer Basha > --- > drivers/me

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

2013-04-29 Thread Prabhakar Lad
Hi Laurent, On Mon, Apr 29, 2013 at 5:05 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. Please see below for a couple of comments in addition > to the ones I've just sent (in reply to Sascha's e-mail). > Yep fixed them all. [snip] > >> --- >> .../devicetree/bindings/m

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

2013-04-29 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. Please see below for a couple of comments in addition to the ones I've just sent (in reply to Sascha's e-mail). On Monday 29 April 2013 13:30:01 Prabhakar Lad wrote: > From: Lad, Prabhakar > > add OF support for the mt9p031 sensor driver. > > Signed-off-

Re: [RFC v2 1/6] media: exynos4-is: modify existing mdev to use common pipeline

2013-04-29 Thread Sylwester Nawrocki
Hi Shaik, Thanks for the updated patch series. On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote: > Current fimc_pipeline is tightly coupled with exynos4-is media > device driver. And this will not allow to use the same pipeline > across different exynos series media device drivers. > > This patch

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

2013-04-29 Thread Laurent Pinchart
Hi Prabhakar, On Monday 29 April 2013 16:41:07 Prabhakar Lad wrote: > On Mon, Apr 29, 2013 at 1:51 PM, Sascha Hauer wrote: > > > >> +Required Properties : > >> +- compatible : value should be either one among the following > >> + (a) "aptina,mt9p031-sensor" for mt9p031 sensor > >> + (b)

Re: [PATCH v2 1/4] V4L2: soc_camera: Renesas R-Car VIN driver

2013-04-29 Thread Sergei Shtylyov
Hello. On 29-04-2013 11:23, Guennadi Liakhovetski wrote: send these patches patchwork.linuxtv.org Thanks, I totally forgot about this one. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

2013-04-29 Thread Prabhakar Lad
Hi Sascha, Thanks for the quick review. On Mon, Apr 29, 2013 at 1:51 PM, Sascha Hauer wrote: >> +Required Properties : >> +- compatible : value should be either one among the following >> + (a) "aptina,mt9p031-sensor" for mt9p031 sensor >> + (b) "aptina,mt9p031m-sensor" for mt9p031m se

Re: [PATCH v9 02/20] V4L2: support asynchronous subdevice registration

2013-04-29 Thread Sascha Hauer
On Fri, Apr 26, 2013 at 11:07:24PM +0200, Guennadi Liakhovetski wrote: > Hi Sascha > > On Fri, 26 Apr 2013, Sascha Hauer wrote: > > > Hi Guennadi, > > > > On Fri, Apr 12, 2013 at 05:40:22PM +0200, Guennadi Liakhovetski wrote: > > > + > > > +static bool match_i2c(struct device *dev, struct v4l2_a

Re: [PATCH 23/24] V4L2: mt9p031: add struct v4l2_subdev_platform_data to platform data

2013-04-29 Thread Laurent Pinchart
Hi Sascha, On Friday 26 April 2013 11:15:56 Sascha Hauer wrote: > On Fri, Apr 26, 2013 at 10:43:28AM +0200, Guennadi Liakhovetski wrote: > > On Fri, 26 Apr 2013, Sascha Hauer wrote: > > > > > That information should be conveyed by platform/DT data for the > > > > > host, and be used to convert the

[PATCH 2/3] [media] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL in mixer_drv.c

2013-04-29 Thread Sachin Kamat
NULL check on clocks obtained using common clock APIs should not be done. Use IS_ERR only. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/mixer_drv.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/s5p-tv/mixer_drv.c b/drive

[PATCH 3/3] [media] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL in mixer_video.c

2013-04-29 Thread Sachin Kamat
vb2_dma_contig_init_ctx does not return NULL. Use IS_ERR() instead. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/mixer_video.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-tv/mixer_video.c b/drivers/media/platform/s5p-tv/mixe

[PATCH 1/3] [media] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL in hdmi_drv.c

2013-04-29 Thread Sachin Kamat
NULL check on clocks obtained using common clock APIs should not be done. Use IS_ERR only. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/hdmi_drv.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

2013-04-29 Thread Sascha Hauer
On Mon, Apr 29, 2013 at 01:30:01PM +0530, Prabhakar Lad wrote: > From: Lad, Prabhakar > > add OF support for the mt9p031 sensor driver. > > Signed-off-by: Lad, Prabhakar > Cc: Hans Verkuil > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Guennadi Liakhovetski > Cc: Sylwester Nawrock

[PATCH RFC] media: i2c: mt9p031: add OF support

2013-04-29 Thread Prabhakar Lad
From: Lad, Prabhakar add OF support for the mt9p031 sensor driver. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc: device

Re: [PATCH v2 1/4] V4L2: soc_camera: Renesas R-Car VIN driver

2013-04-29 Thread Guennadi Liakhovetski
On Sun, 28 Apr 2013, Sergei Shtylyov wrote: > send these patches patchwork.linuxtv.org -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html