Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Now that we want to split the video handling to a separate
module, move all video-specific functions to em28xx-video.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
In order to make easier for the next patches, do some
cosmetic changes.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 2 +-
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
There are several init code inside em28xx-cards that are actually
part of analog initialization. Move the code to em28x-video, in
order to remove part of the mess.
In thesis, no functional changes so far.
Signed-off-by: Mauro Carvalho
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Now that all analog-specific code are at em28xx-video, convert
it into an em28xx extension and load it as a separate module.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/Kconfig | 6 ++-
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
In order to initialize the analog tuner, v4l2 should be registere
first, or otherwise we get an oops:
[ 51.783537] BUG: unable to handle kernel NULL pointer dereference at
)
[ 51.784479] IP: [81319fbb]
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
changeset 45f04e82d035 added a logic to check if em28xx got
a timeout on an I2C transfer.
That patch started to produce a series of errors that is present
with HVR-950, like:
[ 4032.218656] xc2028 19-0061: Error on line 1299: -19
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Add a message with consistent prints before and after each
extension initialization, and provide a better text for module
load.
While here, add a missing sanity check for extension finish
code at em28xx-v4l extension.
Signed-off-by: Mauro
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
The I2C wait completion/timeout logic currently assumes that
msleep(5) will wait exaclty 5 ms. This is not true at all,
as it depends on CONFIG_HZ.
Convert it to use jiffies, in order to not wait for more time
than needed.
Signed-off-by:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Instead of using two I2C operations between write and read,
use just one i2c_transfer. That allows I2C mutexes to not
let any other I2C transfer between the two.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
This macro is not used. remove it.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/tuners/tuner-xc2028.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/media/tuners/tuner-xc2028.c
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Better to split chipset detection from the audio setup. So, move the
detection code to em28xx_init_dev().
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 11 +++
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Instead of assuming that msleep() is precise, use a jiffies
based code to wait for AC97 to be available.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-core.c | 7 +--
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Better to first write the GPIOs of the input mux, before initializing
the audio.
Why are you making this change ?
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-video.c | 40
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Use the same module version on all em28xx sub-modules, and use
the same naming convention to describe the driver.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-audio.c | 3 ++-
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
When em28xx extensions are loaded/removed, there are two locks:
a single static em28xx_devlist_mutex that registers each extension
and the struct em28xx dev-lock.
When extensions are registered, em28xx_devlist_mutex is taken first,
and
More small fixes:
On 12/29/2013 05:04 AM, Antti Palosaari wrote:
Update documention to reflect 1 Hz frequency step flag.
documention - documentation
Cc: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Antti Palosaari cr...@iki.fi
---
.../DocBook/media/v4l/vidioc-enum-freq-bands.xml
More small fixes:
On 12/29/2013 05:04 AM, Antti Palosaari wrote:
Document V4L2 SDR interface.
Cc: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Antti Palosaari cr...@iki.fi
---
Documentation/DocBook/media/v4l/compat.xml | 10 ++
Documentation/DocBook/media/v4l/dev-sdr.xml
On 12/29/2013 05:03 AM, Antti Palosaari wrote:
VIDIOC_QUERYCAP IOCTL is used to query device capabilities. Add new
capability flag to inform given device supports SDR capture.
Cc: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Antti Palosaari cr...@iki.fi
Acked-by: Hans Verkuil
On 12/29/2013 05:51 AM, Antti Palosaari wrote:
Add unsigned 8-bit sample format. Format is got directly from
hardware, but it is converted from signed to unsigned. It is worst
known sampling resolution hardware offer.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
On 12/29/2013 05:04 AM, Antti Palosaari wrote:
Add SDR device type to v4l2-framework.txt document.
Cc: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Antti Palosaari cr...@iki.fi
---
Documentation/video4linux/v4l2-framework.txt | 1 +
1 file changed, 1 insertion(+)
diff --git
Em Sun, 05 Jan 2014 11:47:00 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Now that all analog-specific code are at em28xx-video, convert
it into an em28xx extension and load it as a separate module.
Signed-off-by: Mauro
Em Sun, 05 Jan 2014 11:51:44 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
changeset 45f04e82d035 added a logic to check if em28xx got
a timeout on an I2C transfer.
That patch started to produce a series of errors that is
Em Sun, 05 Jan 2014 11:55:34 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Add a message with consistent prints before and after each
extension initialization, and provide a better text for module
load.
While here, add a
Em Sun, 05 Jan 2014 12:03:51 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
The I2C wait completion/timeout logic currently assumes that
msleep(5) will wait exaclty 5 ms. This is not true at all,
as it depends on CONFIG_HZ.
Em Sun, 05 Jan 2014 12:29:11 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Better to first write the GPIOs of the input mux, before initializing
the audio.
Why are you making this change ?
Signed-off-by: Mauro Carvalho
Em Sun, 05 Jan 2014 12:19:41 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Instead of assuming that msleep() is precise, use a jiffies
based code to wait for AC97 to be available.
Signed-off-by: Mauro Carvalho Chehab
Em Sun, 05 Jan 2014 12:12:34 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Better to split chipset detection from the audio setup. So, move the
detection code to em28xx_init_dev().
Signed-off-by: Mauro Carvalho Chehab
Em Sun, 05 Jan 2014 11:51:44 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
changeset 45f04e82d035 added a logic to check if em28xx got
a timeout on an I2C transfer.
That patch started to produce a series of errors that is
Em Sun, 05 Jan 2014 11:11:20 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Now that we want to split the video handling to a separate
module, move all video-specific functions to em28xx-video.
No functional changes.
Em Sun, 05 Jan 2014 11:26:14 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
There are several init code inside em28xx-cards that are actually
part of analog initialization. Move the code to em28x-video, in
order to remove part
Fix the error handling logic, making it to unregister i2c bus 0, in
case of a failure to register the second bus.
Reported-by: Frank Schäfer fschaefer@googlemail.com
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 3 +++
1 file
Em Sun, 05 Jan 2014 10:56:33 -0200
Mauro Carvalho Chehab m.che...@samsung.com escreveu:
Em Sun, 05 Jan 2014 11:47:00 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Now that all analog-specific code are at em28xx-video,
Em Sun, 05 Jan 2014 11:08:22 -0200
Mauro Carvalho Chehab m.che...@samsung.com escreveu:
Em Sun, 05 Jan 2014 11:55:34 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Add a message with consistent prints before and after each
Em Sun, 05 Jan 2014 11:20:02 -0200
Mauro Carvalho Chehab m.che...@samsung.com escreveu:
Em Sun, 05 Jan 2014 12:19:41 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Instead of assuming that msleep() is precise, use a jiffies
This macro is used by all em28xx devices, and not just em2800.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-i2c.c | 6 +++---
drivers/media/usb/em28xx/em28xx.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
In the lack of a better spec, let's assume the timeout
values compatible with SMBus spec:
http://smbus.org/specs/smbus110.pdf
at chapter 8 - Electrical Characteristics of SMBus devices
Ok, SMBus is a subset of I2C, and not all
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
The proper error code for I2C errors are EREMOTEIO. The em28xx driver
is using EIO instead.
Replace all occurrences of EIO at em28xx-i2c, in order to fix it.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
-ENODEV reports a permanent condition where a device is not found,
and used only during device probing or device removal, as stated
at the V4L2 spec:
http://linuxtv.org/downloads/v4l-dvb-apis/gen_errors.html
Except during device
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
The I2C output messages is too polluted. Clean it a little
bit, by:
- use the proper core support for memory dumps;
- hide most stuff under the i2c_debug umbrella;
- add the missing KERN_CONT where needed;
- use 2
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Instead of allocating transfer buffers with kmalloc() use
usb_alloc_coherent().
That makes it work also with arm CPUs.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-audio.c | 31
Em Sun, 05 Jan 2014 21:38:31 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
In the lack of a better spec, let's assume the timeout
values compatible with SMBus spec:
http://smbus.org/specs/smbus110.pdf
at chapter 8 -
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
From: Mauro Carvalho Chehab mche...@redhat.com
Is this line still correct ? ;)
Instead of allocating/deallocating URBs and transfer buffers
every time stream is started/stopped, just do it once.
That reduces the memory allocation pressure
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
I2C read operations can also take some time to happen.
Try again, if it fails with return code different than 0x10
until timeout.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-i2c.c | 62
Am 05.01.2014 13:05, schrieb Mauro Carvalho Chehab:
Fix the error handling logic, making it to unregister i2c bus 0, in
case of a failure to register the second bus.
Reported-by: Frank Schäfer fschaefer@googlemail.com
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
Am 05.01.2014 13:46, schrieb Mauro Carvalho Chehab:
This macro is used by all em28xx devices, and not just em2800.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-i2c.c | 6 +++---
drivers/media/usb/em28xx/em28xx.h | 2 +-
2 files changed,
Am 04.01.2014 18:58, schrieb Markus Rechberger:
Did you trace the i2c messages on the bus? This seems like papering
the actual bug.
The USB traces are clear:
i2c status 0x10 is treated as _final_ i2c transfer status and the driver
does _not_ retry.
Yes, it's papering over the actual bug.
We
Em Sun, 05 Jan 2014 22:02:40 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
From: Mauro Carvalho Chehab mche...@redhat.com
Is this line still correct ? ;)
Instead of allocating/deallocating URBs and transfer buffers
every
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Mon Jan 6 04:00:26 CET 2014
git branch: test
git hash: f7d40eea8e3e531f1517ab7eded552e8837ef5da
gcc
48 matches
Mail list logo
