Another round of sparse fixes. After this there are two drivers that still
have a lot of warnings: cx88 (caused by a sparse bug, I've reported this on
the sparse mailinglist) and saa7164.
Regards,
Hans
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body
From: Hans Verkuil hans.verk...@cisco.com
bttv-cards.c:3874:55: warning: incorrect type in initializer (different base
types)
Also clean up the code a little by adding spaces.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/bt8xx/bttv-cards.c | 6 +++---
1 file
From: Hans Verkuil hans.verk...@cisco.com
sp2.c:272:5: warning: symbol 'sp2_init' was not declared. Should it be static?
sp2.c:354:5: warning: symbol 'sp2_exit' was not declared. Should it be static?
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/dvb-frontends/sp2.c | 4
From: Hans Verkuil hans.verk...@cisco.com
videobuf-core.c:834:23: warning: Using plain integer as NULL pointer
videobuf-core.c:851:28: warning: Using plain integer as NULL pointer
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/videobuf-core.c | 6 --
1 file
From: Hans Verkuil hans.verk...@cisco.com
stk1160-v4l.c:478:49: warning: incorrect type in argument 3 (different base
types)
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/stk1160/stk1160-v4l.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
s5p_mfc_enc.c:1178:25: error: incompatible types in conditional expression
(different base types)
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Cc: Kamil Debski k.deb...@samsung.com
---
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 2 +-
1 file
From: Hans Verkuil hans.verk...@cisco.com
cxusb.c:1443:32: warning: restricted __le16 degrades to integer
cxusb.c:1487:32: warning: restricted __le16 degrades to integer
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/dvb-usb/cxusb.c | 4 ++--
1 file changed, 2
From: Hans Verkuil hans.verk...@cisco.com
smipcie.c:950:31: warning: Using plain integer as NULL pointer
smipcie.c:973:31: warning: Using plain integer as NULL pointer
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/smipcie/smipcie.c | 4 ++--
1 file changed, 2
From: Hans Verkuil hans.verk...@cisco.com
sc.c:303:26: warning: incorrect type in return expression (different address
spaces)
csc.c:188:27: warning: incorrect type in return expression (different address
spaces)
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
On Wed, Nov 05, 2014 at 12:57:38PM +0530, Sudip Mukherjee wrote:
On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote:
On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote:
On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote:
This patch replaces dev_err by
Em Wed, 5 Nov 2014 09:17:48 +0100
Hans Verkuil hverk...@xs4all.nl escreveu:
From: Hans Verkuil hans.verk...@cisco.com
sp2.c:272:5: warning: symbol 'sp2_init' was not declared. Should it be static?
sp2.c:354:5: warning: symbol 'sp2_exit' was not declared. Should it be static?
This one was
Hi Andreas,
(c/c the others that are listed as the authors of the TBS driver)
Em Wed, 26 Mar 2014 21:32:46 +0100
Andreas Steinmetz a...@domdv.de escreveu:
[Please CC me on replies, I'm not subscribed]
The patch adds a driver for TBS USB DVB-S/S2 devices for which complete
GPLv2 code
Hi,
2014-11-04 23:32 GMT+00:00 Sakari Ailus sakari.ai...@iki.fi:
Sakari Ailus wrote:
yavta does, for example, print both the monotonic timestamp from the buffer
and the time when the buffer has been dequeued:
URL:http://git.ideasonboard.org/yavta.git
$ yavta -c /dev/video0
should
Em Tue, 4 Nov 2014 02:13:19 +0200
Aya Mahfouz mahfouz.saif.elya...@gmail.com escreveu:
This patch replaces dev_err by pr_err since the value
of ir is NULL when the message is displayed.
This one doesn't apply at the media tree:
diff --git a/drivers/staging/media/lirc/lirc_zilog.c
Em Tue, 4 Nov 2014 23:43:07 +0200
Aya Mahfouz mahfouz.saif.elya...@gmail.com escreveu:
This patches replaces one pr_debug call by dev_dbg and
changes the device used by one of the dev_err calls.
Also doesn't apply. Probably made to apply on Greg's tree.
Regards,
Mauro
Signed-off-by: Aya
The following changes since commit a8f29e89f2b54fbf2c52be341f149bc195b63a8b:
[media] media/rc: Send sync space information on the lirc device
(2014-11-04 20:41:42 -0200)
are available in the git repository at:
git://linuxtv.org/kdebski/media_tree_2.git for-3.19-2
for you to fetch changes
The following changes since commit 4895cc47a072dcb32d3300d0a46a251a8c6db5f1:
[media] s5p-mfc: fix sparse error (2014-11-05 08:29:27 -0200)
are available in the git repository at:
git://linuxtv.org/hverkuil/media_tree.git sparse
for you to fetch changes up to
As sparse complains:
drivers/media/dvb-frontends/stv090x.c:3471:30: warning: mixing
different enum types
drivers/media/dvb-frontends/stv090x.c:3471:30: int enum
fe_delivery_system versus
drivers/media/dvb-frontends/stv090x.c:3471:30: int enum
stv090x_delsys
On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote:
This patches replaces one pr_debug call by dev_dbg and
changes the device used by one of the dev_err calls.
i think you should mention in the commit message why you are changing the
device.
and also for revised patch its better if
move the return to happen before the logic. This way, we can
avoid one extra identation.
This also fixes an identation issue on this function.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/dvb-frontends/cx24110.c
b/drivers/media/dvb-frontends/cx24110.c
As new FEC types were added, we need a check to avoid overflows:
drivers/media/dvb-frontends/cx22700.c:172 cx22700_set_tps() error:
buffer overflow 'fec_tab' 6 = 6
drivers/media/dvb-frontends/cx22700.c:173 cx22700_set_tps() error:
buffer overflow 'fec_tab' 6 = 6
Signed-off-by:
This is actually a false positive:
drivers/media/dvb-frontends/cx24110.c:210 cx24110_set_fec() error:
buffer overflow 'rate' 7 = 8
But fixing it is easy: just ensure that the table size will be
limited to FEC_AUTO.
While here, fix spacing on the affected lines.
Signed-off-by: Mauro
When a parameter is invalid, the right return code is
-EINVAL.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/dvb-frontends/cx24110.c
b/drivers/media/dvb-frontends/cx24110.c
index 4f5c992afe67..5a31b3f59306 100644
---
It is hard to read what's there, because it doesn't follow the
CodingStyle.
Add missing whitespaces to split function arguments.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/dvb-frontends/cx24110.c
spatch or smatch? I assume smatch :-)
BTW, I've just added smatch support to the daily build.
Regards,
Hans
On 11/05/14 13:03, Mauro Carvalho Chehab wrote:
This is actually a false positive:
drivers/media/dvb-frontends/cx24110.c:210 cx24110_set_fec() error:
buffer overflow
As reported by smatch:
drivers/media/rc/rc-main.c:1426 rc_register_device() warn: should '1
rc_map-rc_type' be a 64 bit type?
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index
Em Wed, 05 Nov 2014 04:44:22 +0200
Antti Palosaari cr...@iki.fi escreveu:
Acked-by: Antti Palosaari cr...@iki.fi
Reviewed-by: Antti Palosaari cr...@iki.fi
anyhow, I think these branches could never taken in real life.
Yes, probably this never happens with current code.
But as a
killing
Em Wed, 05 Nov 2014 13:21:31 +0100
Hans Verkuil hverk...@xs4all.nl escreveu:
spatch or smatch? I assume smatch :-)
Yeah, typo... both are tools used for static code analizers... very easy to
type it wrong ;)
BTW, I've just added smatch support to the daily build.
Good!
I'll fix some more
On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote:
Em Tue, 4 Nov 2014 23:43:07 +0200
Aya Mahfouz mahfouz.saif.elya...@gmail.com escreveu:
This patches replaces one pr_debug call by dev_dbg and
changes the device used by one of the dev_err calls.
Also doesn't apply.
On Wed, Nov 05, 2014 at 04:59:15PM +0530, Sudip Mukherjee wrote:
On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote:
This patches replaces one pr_debug call by dev_dbg and
changes the device used by one of the dev_err calls.
i think you should mention in the commit message why you
On Sun, Nov 02, 2014 at 04:53:26PM +0200, Laurent Pinchart wrote:
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
include/media/media-entity.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/media/media-entity.h b/include/media/media-entity.h
Hi Boris,
On Tue, Nov 04, 2014 at 10:54:57AM +0100, Boris Brezillon wrote:
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Update
1 When m88ds3103 works in serial ts mode, its serial ts clock is equal to ts
master clock and the clock divider is bypassed.
2 The serial ts clock is configed by the bridge driver just like parallel ts
clock.
Signed-off-by: Nibble Max nibble@gmail.com
---
DVBSky S950 dvb-s/s2 PCIe card:
1dvb frontend: M88TS2022(tuner),M88DS3103(demod)
2PCIe bridge: cx23885
3rc: cx23885 integrated.
Signed-off-by: Nibble Max nibble@gmail.com
---
drivers/media/pci/cx23885/cx23885-cards.c | 20
drivers/media/pci/cx23885/cx23885-dvb.c | 9
DVBSky S952 dvb-s/s2 dual PCIe card:
1dvb frontend: M88TS2022(tuner),M88DS3103(demod)
2PCIe bridge: CX23885(port b: parallel mode, port c: serial mode)
3rc: cx23885 integrated.
Signed-off-by: Nibble Max nibble@gmail.com
---
drivers/media/pci/cx23885/cx23885-cards.c | 22 +++
Hi Sakari,
On Wed, 5 Nov 2014 16:57:27 +0200
Sakari Ailus sakari.ai...@iki.fi wrote:
Hi Boris,
On Tue, Nov 04, 2014 at 10:54:57AM +0100, Boris Brezillon wrote:
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to
Hi,
On Tue, Nov 04, 2014 at 12:09:59PM +0100, Hans Verkuil wrote:
Well, I gave two alternatives :-)
Both are fine as far as I am concerned, but it would be nice to hear
what others think.
In fact I think both are good options. :-)
I'd perhaps lean towards the latter, for it has the benefit
Hi Boris,
On Tue, Nov 04, 2014 at 10:55:06AM +0100, Boris Brezillon wrote:
The v4l2_mbus_pixelcode enum (or its values) should be replaced by the
media_bus_format enum.
Keep this enum in v4l2-mediabus.h and create a new header containing
the v4l2_mbus_framefmt struct definition (which is not
On Wed, 5 Nov 2014 17:08:15 +0200
Sakari Ailus sakari.ai...@iki.fi wrote:
Hi Boris,
On Tue, Nov 04, 2014 at 10:55:06AM +0100, Boris Brezillon wrote:
The v4l2_mbus_pixelcode enum (or its values) should be replaced by the
media_bus_format enum.
Keep this enum in v4l2-mediabus.h and create
On Tue, Nov 04, 2014 at 10:54:58AM +0100, Boris Brezillon wrote:
Replace references to the v4l2_mbus_pixelcode enum with the new
media_bus_format enum in all common headers.
Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com
Acked-by: Sakari Ailus sakari.ai...@linux.intel.com
On 11/05/14 16:15, Boris Brezillon wrote:
On Wed, 5 Nov 2014 17:08:15 +0200
Sakari Ailus sakari.ai...@iki.fi wrote:
Hi Boris,
On Tue, Nov 04, 2014 at 10:55:06AM +0100, Boris Brezillon wrote:
The v4l2_mbus_pixelcode enum (or its values) should be replaced by the
media_bus_format enum.
Hi Boris,
On Wed, Nov 05, 2014 at 04:15:38PM +0100, Boris Brezillon wrote:
On Wed, 5 Nov 2014 17:08:15 +0200
Sakari Ailus sakari.ai...@iki.fi wrote:
I would keep the original file name, even if the compatibility definitions
are there. I don't see any harm in having them around as well.
On Wed, 05 Nov 2014 16:19:56 +0100
Hans Verkuil hansv...@cisco.com wrote:
On 11/05/14 16:15, Boris Brezillon wrote:
On Wed, 5 Nov 2014 17:08:15 +0200
Sakari Ailus sakari.ai...@iki.fi wrote:
Hi Boris,
On Tue, Nov 04, 2014 at 10:55:06AM +0100, Boris Brezillon wrote:
The
On Wed, 5 Nov 2014 17:00:25 +0200
Sakari Ailus sakari.ai...@iki.fi wrote:
Hi,
On Tue, Nov 04, 2014 at 12:09:59PM +0100, Hans Verkuil wrote:
Well, I gave two alternatives :-)
Both are fine as far as I am concerned, but it would be nice to hear
what others think.
In fact I think
On 11/05/14 16:30, Boris Brezillon wrote:
On Wed, 05 Nov 2014 16:19:56 +0100
Hans Verkuil hansv...@cisco.com wrote:
On 11/05/14 16:15, Boris Brezillon wrote:
On Wed, 5 Nov 2014 17:08:15 +0200
Sakari Ailus sakari.ai...@iki.fi wrote:
Hi Boris,
On Tue, Nov 04, 2014 at 10:55:06AM +0100,
Hi Paolo,
On Wed, Nov 05, 2014 at 10:13:45AM +, Paulo Assis wrote:
Hi,
2014-11-04 23:32 GMT+00:00 Sakari Ailus sakari.ai...@iki.fi:
Sakari Ailus wrote:
yavta does, for example, print both the monotonic timestamp from the buffer
and the time when the buffer has been dequeued:
The UVC devices do produce hardware timestamps according to the spec, but
not all cameras implement it or implement it correctly. Add a quirk flag for
such devices, and use monotonic timestamp from the end of the frame instead.
Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com
---
Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com
---
drivers/media/usb/uvc/uvc_driver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/uvc/uvc_driver.c
b/drivers/media/usb/uvc/uvc_driver.c
index 7c8322d..3908e2f 100644
---
On Wed, Nov 05, 2014 at 03:43:44PM +0200, Aya Mahfouz wrote:
On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote:
Em Tue, 4 Nov 2014 23:43:07 +0200
Aya Mahfouz mahfouz.saif.elya...@gmail.com escreveu:
This patches replaces one pr_debug call by dev_dbg and
changes
Hi Hans,
On Monday 03 November 2014 10:47:03 Hans Verkuil wrote:
On 11/01/2014 02:24 PM, Laurent Pinchart wrote:
Hi Hans,
Thank you for the review. I've fixed most of the issues you've pointed
out, please find my replies to the remaining ones below.
On Tuesday 30 September 2014
Hi Hans,
On Monday 03 November 2014 11:12:15 Hans Verkuil wrote:
Hi Laurent,
Some small nitpicks...
On 11/02/2014 03:53 PM, Laurent Pinchart wrote:
Xilinx platforms have no hardwired video capture or video processing
interface. Users create capture and memory to memory processing
Hi Paulo,
On Wednesday 05 November 2014 10:13:45 Paulo Assis wrote:
2014-11-04 23:32 GMT+00:00 Sakari Ailus sakari.ai...@iki.fi:
Sakari Ailus wrote:
yavta does, for example, print both the monotonic timestamp from the
buffer and the time when the buffer has been dequeued:
Hi Rémi,
On Tuesday 04 November 2014 22:41:44 Rémi Denis-Courmont wrote:
Le mardi 04 novembre 2014, 15:42:37 Rémi Denis-Courmont a écrit :
Le 2014-11-04 14:58, Sakari Ailus a écrit :
Have you tried with a different application to see if the problem
persists?
Tried mplayer and
Xilinx platforms have no hardwired video capture or video processing
interface. Users create capture and memory to memory processing
pipelines in the FPGA fabric to suit their particular needs, by
instantiating video IP cores from a large library.
The Xilinx Video IP core is a framework that
Dear Recipient,
You have been awarded the sum of 8,000,000.00 (Eight Million Pounds sterling)
with reference number 77100146 by office of the ministry of finance UK.Send us
your personal details to deliver your funds.
Gloria Peter
--
To unsubscribe from this list: send the line unsubscribe
Dear all,
please somebody could have a look at
https://bugzilla.kernel.org/show_bug.cgi?id=87711
https://bugzilla.kernel.org/show_bug.cgi?id=62911
?
Thanks for interests to everyone,
Michal
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to
More on the same topic.
I believe there's another bug on displaying of payload.
Let's say we have the same [45][45] array, and this is what is posted to it:
uint16_t buf[45 * 45] = {0, };
buf[0] = 1;
buf[1] = 2;
buf[45] = 3;
buf[45 * 45 - 1] = 0xff;
What is shown
Dropping code (introduced in 316d9e84a72069e04e483de0d5934c1d75f6a44c)
which intends to make raising of motion events more smooth(?).
It made motion event never appear in my installation.
That code is complicated, so I couldn't figure out quickly how to fix
it, so dropping it seems better to me.
Laurent,
see below yavta output and matching syslog
./yavta -c -s 800x600 -t 1/30 -f mjpeg /dev/video0
Device /dev/video0 opened.
Device `Logitech Webcam C930e' on `usb-:00:1a.7-1' is a video
output (without mplanes) device.
Video format set: MJPEG (47504a4d) 800x600 (stride 0) field none
Reviewed-by: Antti Palosaari cr...@iki.fi
...but I really expect Olli did the better job. I simply don't know that
driver internals well enough. Patch looks 100% fine for my eyes.
regards
Antti
On 11/05/2014 04:58 PM, Nibble Max wrote:
DVBSky S950 dvb-s/s2 PCIe card:
1dvb frontend:
Reviewed-by: Antti Palosaari cr...@iki.fi
Patch looks correct for my eyes, but I am not professional here, so lets
Olli make final decision.
regards
Antti
On 11/05/2014 04:58 PM, Nibble Max wrote:
DVBSky S952 dvb-s/s2 dual PCIe card:
1dvb frontend: M88TS2022(tuner),M88DS3103(demod)
2PCIe
Reviewed-by: Antti Palosaari cr...@iki.fi
Antti
On 11/05/2014 04:59 PM, Nibble Max wrote:
1 When m88ds3103 works in serial ts mode, its serial ts clock is equal to ts
master clock and the clock divider is bypassed.
2 The serial ts clock is configed by the bridge driver just like parallel ts
Laurent,
-Original Message-
From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com]
Sent: Wednesday, November 05, 2014 10:36 AM
To: linux-media@vger.kernel.org
Cc: Michal Simek; Chris Kohn; Hyun Kwon; devicet...@vger.kernel.org
Subject: [PATCH v3 11/13] v4l: xilinx: Add
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Thu Nov 6 04:00:16 CET 2014
git branch: test
git hash: 4895cc47a072dcb32d3300d0a46a251a8c6db5f1
gcc
Hi,
analog TV on Hauppauge HVR 900 [2040:6500] - audio works correctly but
video stops after few samples, audio continues after video stop,
tested:
mplayer tv:// -tv
norm=PAL-BG:freq=687.5:input=0:device=/dev/video0:alsa:amode=1:adevice=hw.2,0:audiorate=48000:forceaudio:immediatemode=0
65 matches
Mail list logo
