[PATCH v4 2/3] media: atmel-isi: move configure_geometry() to start_streaming()

As in set_fmt() function we only need to know which format is been set, we don't need to access the ISI hardware in this moment. So move the configure_geometry(), which access the ISI hardware, to start_streaming() will make code more consistent and simpler. Signed-off-by: Josh Wu

[PATCH v4 1/3] media: atmel-isi: setup the ISI_CFG2 register directly

In the function configure_geometry(), we will setup the ISI CFG2 according to the sensor output format. It make no sense to just read back the CFG2 register and just set part of it. So just set up this register directly makes things simpler. Currently only support YUV format from camera sensor.

[PATCH v4 3/3] media: atmel-isi: add sanity check for supported formats in try/set_fmt()

After adding the format check in try_fmt()/set_fmt(), we don't need any format check in configure_geometry(). So make configure_geometry() as void type. Signed-off-by: Josh Wu --- Hi, Laurent For the similiarity between set_fmt() and try_frm() function, it need more work

Re: [RFC RESEND 05/11] v4l2-core: Don't sync cache for a buffer if so requested

On 09/11/2015 01:50 PM, Sakari Ailus wrote: > From: Samu Onkalo > > The user may request to the driver (vb2) to skip the cache maintenance > operations in case the buffer does not need cache synchronisation, e.g. in > cases where the buffer is passed between hardware

Re: [RFC RESEND 04/11] v4l: Unify cache management hint buffer flags

On 09/11/2015 01:50 PM, Sakari Ailus wrote: > The V4L2_BUF_FLAG_NO_CACHE_INVALIDATE and V4L2_BUF_FLAG_NO_CACHE_CLEAN > buffer flags are currently not used by the kernel. Replace the definitions > by a single V4L2_BUF_FLAG_NO_CACHE_SYNC flag to be used by further > patches. > > Different cache

Re: [RFC RESEND 06/11] vb2: Improve struct vb2_mem_ops documentation; alloc and put are for MMAP

On 09/11/2015 01:50 PM, Sakari Ailus wrote: > The alloc() and put() ops are for MMAP buffers only. Document it. > > Signed-off-by: Sakari Ailus ' Acked-by: Hans Verkuil > --- > include/media/videobuf2-core.h | 20 ++-- > 1

Re: [RFC RESEND 07/11] vb2: dma-contig: Remove redundant sgt_base field

On 09/11/2015 01:50 PM, Sakari Ailus wrote: > The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and > dma_sgt. The former is used by DMA-BUF buffers whereas the latter is used > by USERPTR. > > Unify the two, leaving dma_sgt. > > MMAP buffers do not need cache flushing since

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

Hello Sakari, On 09/11/2015 07:51 AM, Sakari Ailus wrote: > Hi Javier, > > Javier Martinez Canillas wrote: >> Hello Sakari, >> >> On 09/10/2015 07:14 PM, Sakari Ailus wrote: >>> Hi Javier, >>> >>> Thanks for the set! A few comments below. >>> >> >> Thanks to you for your feedback. >> >>> Javier

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

Em Fri, 11 Sep 2015 09:31:36 +0200 Javier Martinez Canillas escreveu: > Hello Sakari, > > On 09/11/2015 07:51 AM, Sakari Ailus wrote: > > Hi Javier, > > > > Javier Martinez Canillas wrote: > >> Hello Sakari, > >> > >> On 09/10/2015 07:14 PM, Sakari Ailus wrote: > >>> Hi

[RFC 5/9] media: Use entity enums in graph walk

Signed-off-by: Sakari Ailus --- drivers/media/media-entity.c | 10 +- include/media/media-entity.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c index 5526e8c..a4d6e1b

[RFC 3/9] media: Add an API to manage entity enumerations

This is useful in e.g. knowing whether certain operations have already been performed for an entity. The users include the framework itself (for graph walking) and a number of drivers. Signed-off-by: Sakari Ailus --- include/media/media-entity.h | 45

[RFC 0/9] Unrestricted media entity ID range support

Hi all, This patchset adds an API for managing entity enumerations, i.e. storing a bit of information per entity. The entity ID is no longer limited to small integers (e.g. 31 or 63), but MEDIA_ENTITY_MAX_LOW_ID. The drivers are also converted to use that instead of a fixed number. If the number

[RFC 1/9] media: Rename MEDIA_ENTITY_ENUM_MAX_ID as MEDIA_ENTITY_MAX_LOW_ID

Rename the macro as it no longer is a maximum ID that an entity can have, but a low ID which is used for internal purposes of enumeration. This is the maximum number of concurrent entities that may exist in a media device. Signed-off-by: Sakari Ailus ---

[RFC 2/9] media: Introduce low_id for media entities

A low ID is a unique number specific to a media entity. The number is guaranteed to be under MEDIA_ENTITY_MAX_LOW_ID. Signed-off-by: Sakari Ailus --- drivers/media/media-device.c | 14 ++ include/media/media-device.h | 2 ++

[RFC 9/9] staging: omap4iss: Use media entity enum API

Signed-off-by: Sakari Ailus --- drivers/staging/media/omap4iss/iss.c | 7 --- drivers/staging/media/omap4iss/iss.h | 4 ++-- drivers/staging/media/omap4iss/iss_video.c | 4 ++-- drivers/staging/media/omap4iss/iss_video.h | 4 ++-- 4 files changed, 10

[RFC 7/9] omap3isp: Use media entity enumeration API

Signed-off-by: Sakari Ailus --- drivers/media/platform/omap3isp/isp.c | 15 +++ drivers/media/platform/omap3isp/isp.h | 5 +++-- drivers/media/platform/omap3isp/ispccdc.c | 2 +- drivers/media/platform/omap3isp/ispvideo.c | 11 +--

Re: [PATCH 08/18] [media] s5c73m3: Export OF module alias information

On 09/11/2015 03:19 AM, Javier Martinez Canillas wrote: > Hello, > > On 08/20/2015 09:07 AM, Javier Martinez Canillas wrote: >> The SPI core always reports the MODALIAS uevent as "spi:" >> regardless of the mechanism that was used to register the device >> (i.e: OF or board code) and the table

[RFC 6/9] media: entity: Remove useless WARN_ON()'s

The checks for entity ID not reaching too high value the framework could not handle are now present in the entity registration. It's quite far-fetched this condition could happen inside the framework, so remove the WARN_ON()'s. Signed-off-by: Sakari Ailus ---

[RFC 4/9] media: Use media entity enum API for managing low IDs

Signed-off-by: Sakari Ailus --- drivers/media/media-device.c | 15 +++ include/media/media-device.h | 2 +- include/media/media-entity.h | 12 3 files changed, 20 insertions(+), 9 deletions(-) diff --git a/drivers/media/media-device.c

[RFC 8/9] vsp1: Use media entity enumeration API

Signed-off-by: Sakari Ailus --- drivers/media/platform/vsp1/vsp1_video.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c index f741582..026d6462 100644

Re: [RFC PATCH v4 7/8] [media] videobuf2: Move v4l2-specific stuff to videobuf2-v4l2

On 09/09/2015 01:19 PM, Junghak Sung wrote: > Move v4l2-specific stuff from videobu2-core to videobuf2-v4l2 > without doing any functional changes. > > Signed-off-by: Junghak Sung > Signed-off-by: Geunyoung Kim > Acked-by: Seung-Woo Kim

Re: [RFC PATCH v4 2/8] [media] videobuf2: Restructure vb2_buffer (1/3)

On 09/09/2015 01:19 PM, Junghak Sung wrote: > Remove v4l2 stuff - v4l2_buf, v4l2_plane - from struct vb2_buffer. > > Add new member variables - bytesused, length, offset, userptr, fd, > data_offset - to struct vb2_plane in order to cover all information > of v4l2_plane. > struct vb2_plane { >

Re: [PATCH 08/18] [media] s5c73m3: Export OF module alias information

On 09/11/2015 03:19 AM, Javier Martinez Canillas wrote: > Hello, > > On 08/20/2015 09:07 AM, Javier Martinez Canillas wrote: >> The SPI core always reports the MODALIAS uevent as "spi:" >> regardless of the mechanism that was used to register the device >> (i.e: OF or board code) and the table

Re: [RFC PATCH v4 5/8] [media] videobuf2: Change queue_setup argument

On 09/09/2015 01:19 PM, Junghak Sung wrote: > Replace struct v4l2_format * with void * to make queue_setup() > for common use. > And then, modify all device drivers related with this change. > > Signed-off-by: Junghak Sung > Signed-off-by: Geunyoung Kim

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

Hi Mauro, Mauro Carvalho Chehab wrote: > Em Fri, 11 Sep 2015 09:31:36 +0200 > Javier Martinez Canillas escreveu: > >> Hello Sakari, >> >> On 09/11/2015 07:51 AM, Sakari Ailus wrote: >>> Hi Javier, >>> >>> Javier Martinez Canillas wrote: Hello Sakari, On

Re: [RFC PATCH v4 1/8] [media] videobuf2: Replace videobuf2-core with videobuf2-v4l2

On 09/09/2015 01:19 PM, Junghak Sung wrote: > Make videobuf2-v4l2 as a wrapper of videobuf2-core for v4l2-use. > And replace videobuf2-core.h with videobuf2-v4l2.h. > This renaming change should be accompanied by the modifications > of all device drivers that include videobuf2-core.h. > It can be

Re: [GIT PULL for v4.3-rc1] media updates

Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v4.3-1 For the media subsystem patches for Kernel 4.3. This series contain: Hello Mauro! Is there a chance that you could also push up https://patchwork.linuxtv.org/patch/30695/ ? It

Re: [RFC PATCH v4 6/8] [media] videobuf2: Replace v4l2-specific data with vb2 data.

Hi Junghak, A few comments: On 09/09/2015 01:19 PM, Junghak Sung wrote: > enum v4l2_memory -> enum vb2_memory > VIDEO_MAX_FRAME -> VB2_MAX_FRAME > VIDEO_MAX_PLANES -> VB2_MAX_PLANES and owner is now a void pointer! With respect to the two defines above: I think it is a good idea to add a check

Re: DVBSky T980C CI issues (kernel 4.0.x)

On 2015-08-23 19:50, Jurgen Kramer wrote: On Sun, 2015-07-12 at 12:38 +0200, Jurgen Kramer wrote: I have been running a couple of DVBSky T980C's with CIs with success using an older kernel (3.17.8) with media-build and some added patches from the mailing list. I thought lets try a current 4.0

Re: [RFC PATCH v4 5/8] [media] videobuf2: Change queue_setup argument

Hello Hans, First of all, thank you for your review. On 09/11/2015 05:52 PM, Hans Verkuil wrote: On 09/09/2015 01:19 PM, Junghak Sung wrote: Replace struct v4l2_format * with void * to make queue_setup() for common use. And then, modify all device drivers related with this change.

Re: [PATCH v8 42/55] [media] dvb: modify core to implement interfaces/entities at MC new gen

On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > The Media Controller New Generation redefines the types for both > interfaces and entities to be used on DVB. Make the needed > changes at the DVB core for all interfaces, entities and > data and interface links to appear in the graph. > >

Re: [PATCH v8 48/55] [media] media_device: add a topology version field

On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > Every time a graph object is added or removed, the version > of the topology changes. That's a requirement for the new > MEDIA_IOC_G_TOPOLOGY, in order to allow userspace to know > that the topology has changed after a previous call to it. >

[PATCH][resend] rc: gpio-ir-recv: allow flush space on idle

Many decoders require a trailing space (period without IR illumination) to be delivered before completing a decode. Since the gpio-ir-recv driver only delivers events on gpio transitions, a single IR symbol (caused by a quick touch on an IR remote) will not be properly decoded without the use of

Re: [PATCH v8 46/55] [media] media: move mdev list init to gobj

On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > Let's control the topology changes inside the graph_object. So, move the > addition and removal of interfaces/entities from the mdev lists to > media_gobj_init() and media_gobj_remove(). > > The main reason is that mdev should have lists for

Re: [PATCH v8 43/55] [media] media: report if a pad is sink or source at debug msg

On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > Sometimes, it is important to see if the created pad is > sink or source. Add info to track that. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git

Re: [PATCH v8 44/55] [media] uapi/media.h: Add MEDIA_IOC_G_TOPOLOGY ioctl

On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > Add a new ioctl that will report the entire topology on > one go. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil I do have one suggestion: media_v2_interface, media_v2_pad

Re: [PATCH v8 49/55] [media] media-device: add support for MEDIA_IOC_G_TOPOLOGY ioctl

On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > Add support for the new MEDIA_IOC_G_TOPOLOGY ioctl, according > with the RFC for the MC next generation. > > Signed-off-by: Mauro Carvalho Chehab Two comments: > > diff --git a/drivers/media/media-device.c

Re: [RFC RESEND 04/11] v4l: Unify cache management hint buffer flags

On 09/11/2015 06:26 PM, Hans Verkuil wrote: > On 09/11/2015 01:50 PM, Sakari Ailus wrote: >> The V4L2_BUF_FLAG_NO_CACHE_INVALIDATE and V4L2_BUF_FLAG_NO_CACHE_CLEAN >> buffer flags are currently not used by the kernel. Replace the definitions >> by a single V4L2_BUF_FLAG_NO_CACHE_SYNC flag to be

Re: DVBSky T980C CI issues (kernel 4.0.x)

Op 11-09-15 om 22:01 schreef Torbjorn Jansson: did you get it to work? i got a dvbsky T980C too for dvb-t2 reception and so far the only drivers that have worked at all is the ones from dvbsky directly. i was very happy when i noticed that recent kernels have support for it built in but

Re: [PATCH 08/18] [media] s5c73m3: Export OF module alias information

Hello Andrzej, On 09/11/2015 12:10 PM, Andrzej Hajda wrote: > On 09/11/2015 03:19 AM, Javier Martinez Canillas wrote: >> Hello, >> >> On 08/20/2015 09:07 AM, Javier Martinez Canillas wrote: >>> The SPI core always reports the MODALIAS uevent as "spi:" >>> regardless of the mechanism that was used

[RFC RESEND 10/11] vb2: dma-contig: Let drivers decide DMA attrs of MMAP and USERPTR bufs

The desirable DMA attributes are not generic for all devices using Videobuf2 contiguous DMA ops. Let the drivers decide. This change also results in MMAP buffers always having an sg_table (dma_sgt field). Also arrange the header files alphabetically. As a result, also the DMA-BUF exporter must

[RFC RESEND 03/11] vb2: Move cache synchronisation from buffer done to dqbuf handler

The cache synchronisation may be a time consuming operation and thus not best performed in an interrupt which is a typical context for vb2_buffer_done() calls. This may consume up to tens of ms on some machines, depending on the buffer size. Signed-off-by: Sakari Ailus

[RFC RESEND 00/11] vb2: Handle user cache hints, allow drivers to choose cache coherency

Hi folks, This RFC patchset achieves two main objectives: 1. Respects cache flags passed from the user space. As no driver nor videobuf2 has (ever?) implemented them, the two flags are replaced by a single one (V4L2_BUF_FLAG_NO_CACHE_SYNC) and the two old flags are deprecated. This is done since

[RFC RESEND 05/11] v4l2-core: Don't sync cache for a buffer if so requested

From: Samu Onkalo The user may request to the driver (vb2) to skip the cache maintenance operations in case the buffer does not need cache synchronisation, e.g. in cases where the buffer is passed between hardware blocks without it being touched by the CPU. Also document

[RFC RESEND 07/11] vb2: dma-contig: Remove redundant sgt_base field

The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and dma_sgt. The former is used by DMA-BUF buffers whereas the latter is used by USERPTR. Unify the two, leaving dma_sgt. MMAP buffers do not need cache flushing since they have been allocated using dma_alloc_coherent().

[RFC RESEND 09/11] vb2: dma-contig: Don't warn on failure in obtaining scatterlist

vb2_dc_get_base_sgt() which obtains the scatterlist already prints information on why the scatterlist could not be obtained. Also, remove the useless warning of a failed kmalloc(). Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 6

[RFC RESEND 08/11] vb2: dma-contig: Move vb2_dc_get_base_sgt() up

Just move the function up. It'll be soon needed earlier than previously. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 44 +- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git

[RFC RESEND 01/11] vb2: Rename confusingly named internal buffer preparation functions

Rename __qbuf_*() functions which are specific to a buffer type as __prepare_*() which matches with what they do. The naming was there for historical reasons; the purpose of the functions was changed without renaming them. Signed-off-by: Sakari Ailus ---

[RFC RESEND 11/11] vb2: dma-contig: Add WARN_ON_ONCE() to check for potential bugs

The scatterlist should always be present when the cache would need to be flushed. Each buffer type has its own means to provide that. Add WARN_ON_ONCE() to check the scatterist exists. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/videobuf2-dma-contig.c |

[RFC RESEND 04/11] v4l: Unify cache management hint buffer flags

The V4L2_BUF_FLAG_NO_CACHE_INVALIDATE and V4L2_BUF_FLAG_NO_CACHE_CLEAN buffer flags are currently not used by the kernel. Replace the definitions by a single V4L2_BUF_FLAG_NO_CACHE_SYNC flag to be used by further patches. Different cache architectures should not be visible to the user space which

[RFC RESEND 02/11] vb2: Move buffer cache synchronisation to prepare from queue

The buffer cache should be synchronised in buffer preparation, not when the buffer is queued to the device. Fix this. Mmap buffers do not need cache synchronisation since they are always coherent. Signed-off-by: Sakari Ailus ---

Re: [RFC PATCH v4 6/8] [media] videobuf2: Replace v4l2-specific data with vb2 data.

On 09/11/2015 05:14 PM, Hans Verkuil wrote: Hi Junghak, A few comments: On 09/09/2015 01:19 PM, Junghak Sung wrote: enum v4l2_memory -> enum vb2_memory VIDEO_MAX_FRAME -> VB2_MAX_FRAME VIDEO_MAX_PLANES -> VB2_MAX_PLANES and owner is now a void pointer! With respect to the two defines

Re: [RFC PATCH v4 5/8] [media] videobuf2: Change queue_setup argument

On 09/11/2015 01:07 PM, Junghak Sung wrote: > > Hello Hans, > > First of all, thank you for your review. > > > On 09/11/2015 05:52 PM, Hans Verkuil wrote: >> On 09/09/2015 01:19 PM, Junghak Sung wrote: >>> Replace struct v4l2_format * with void * to make queue_setup() >>> for common use. >>>

[RFC RESEND 06/11] vb2: Improve struct vb2_mem_ops documentation; alloc and put are for MMAP

The alloc() and put() ops are for MMAP buffers only. Document it. Signed-off-by: Sakari Ailus --- include/media/videobuf2-core.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/include/media/videobuf2-core.h

[PATCH v2] [media] s5c73m3: Export OF module alias information

The SPI core always reports the MODALIAS uevent as "spi:" regardless of the mechanism that was used to register the device (i.e: OF or board code) and the table that is used later to match the driver with the device (i.e: SPI id table or OF match table). So drivers needs to export the SPI id

cron job: media_tree daily build: OK

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Sep 12 04:00:19 CEST 2015 git branch: test git hash: 50ef28a6ac216fd8b796257a3768fef8f57b917d gcc

Re: [RFC PATCH v4 8/8] [media] videobuf2: Remove v4l2-dependencies from videobuf2-core

Hi Junghak, Patch 7/8 helped a lot in reducing the size of this one. But it is still difficult to review so I would like to request one final (honest!) split for this patch: Move all the code that does not depend on the new buf_ops into a separate patch. So the new q->is_output and

Re: [PATCH v8 41/55] [media] DocBook: update descriptions for the media controller entities

On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > Cleanup the media controller entities description: > - remove MEDIA_ENT_T_DEVNODE and MEDIA_ENT_T_V4L2_SUBDEV entity > types, as they don't mean anything; > - add MEDIA_ENT_T_UNKNOWN with a proper description; > - remove ALSA and FB entity

Re: [PATCH v2] [media] vimc: Virtual Media Controller core, capture and sensor

Hi On Thu, Aug 6, 2015 at 1:10 AM, Helen Fornazier wrote: > First version of the Virtual Media Controller. > Add a simple version of the core of the driver, the capture and > sensor nodes in the topology, generating a grey image in a hardcoded > format. > >

Re: [PATCH v2] [media] vimc: Virtual Media Controller core, capture and sensor

On Fri, Sep 11, 2015 at 9:53 AM, Hans Verkuil wrote: > On 09/11/2015 02:43 PM, Helen Fornazier wrote: >> Hi >> >> On Thu, Aug 6, 2015 at 1:10 AM, Helen Fornazier > > > >> >> >> I am sending this email as a reminder to review this patch. Thanks >> > > As you've no doubt seen

Re: [PATCH v8 14/55] [media] media: add functions to allow creating interfaces

On 09/06/2015 02:02 PM, Mauro Carvalho Chehab wrote: > Interfaces are different than entities: they represent a > Kernel<->userspace interaction, while entities represent a > piece of hardware/firmware/software that executes a function. > > Let's distinguish them by creating a separate structure

Re: [PATCH v8 39/55] [media] media controller: get rid of entity subtype on Kernel

On 09/06/2015 02:02 PM, Mauro Carvalho Chehab wrote: > Don't use anymore the type/subtype entity data/macros > inside the Kernel. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git a/include/media/media-entity.h

Re: [PATCH v2] [media] vimc: Virtual Media Controller core, capture and sensor

On 09/11/2015 02:43 PM, Helen Fornazier wrote: > Hi > > On Thu, Aug 6, 2015 at 1:10 AM, Helen Fornazier > > > I am sending this email as a reminder to review this patch. Thanks > As you've no doubt seen the amount of patches that need to be reviewed is huge. Given the fact that it is 1)

Re: [PATCH v8 28/55] [media] uapi/media.h: Fix entity namespace

On 09/06/2015 02:02 PM, Mauro Carvalho Chehab wrote: > Now that interfaces got created, we need to fix the entity > namespace. > > So, let's create a consistent new namespace and add backward > compatibility macros to keep the old namespace preserved. > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH v8 55/55] [media] media-entity.h: document all the structs

On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > Only a few structs are documented on kernel-doc-nano format > (the ones added by the MC next gen patches). > > Add a documentation for all structs, and ensure that they'll > be producing the documentation at the Kernel's device driver >

Re: [PATCH 02/18] [media] au0828: add support for the connectors

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > Depending on the input, an au0828 may have a different > number of connectors. add entities to represent them. Hmm, this patch uses the new connector defines that are only added in patch 6! So this doesn't compile. Is there a reason why the

Re: [PATCH v8 52/55] [media] media-device: remove interfaces and interface links

On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > Just like what's done with entities, when the media controller is > unregistered, release any interface and interface links that > might still be there. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans

Re: [PATCH 01/18] [media] tuner-core: add an input pad

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > Tuners actually have at least one connector on its > input. > > Add a PAD to connect it. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil And yes, I do think tuner.h is the

Re: [PATCH v8 51/55] [media] remove interface links at media_entity_unregister()

On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > Interface links connected to an entity should be removed > before being able of removing the entity. I'd replace that with: ...before the entity itself can be removed. > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH v8 53/55] [media] v4l2-core: create MC interfaces for devnodes

On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > V4L2 device (and subdevice) nodes should create an interface, if the > Media Controller support is enabled. > > Please notice that radio devices should not create an entity, as radio > input/output is either via wires or via ALSA. > >

Re: [PATCH 04/18] [media] media-device: supress backlinks at G_TOPOLOGY ioctl

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > Due to the graph traversal algorithm currently in usage, we > need a copy of all data links. Those backlinks should not be > send to userspace, as otherwise, all links there will be > duplicated. > > Signed-off-by: Mauro Carvalho Chehab

Terratec H7 Rev. 4 is DVBSky

Hi, I recently got a Terratec H7 in Revision 4 and turned out that it is not just a new revision, but a new product with USB ProductID 0x10a5. Previous revisions have been AZ6007, but this revision does not work with this driver [1]. Output of lsusb (extended output attached): Bus 001 Device

Re: [PATCH 06/18] [media] media.h: create connector entities for hybrid TV devices

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > Add entities to represent the connectors that exists inside a > hybrid TV device. > > Signed-off-by: Mauro Carvalho Chehab > > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index

Re: [PATCH 07/18] [media] dvbdev: returns error if graph object creation fails

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > Right now, if something gets wrong at dvb_create_media_entity() > or at dvb_create_media_graph(), the device will still be > registered. > > Change the logic to properly handle it and free all media graph > objects if something goes wrong at

Re: [PATCH 11/18] [media] au0828:: enforce check for graph creation

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > If the graph creation fails, don't register the device. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git a/drivers/media/usb/au0828/au0828-core.c >

Re: [PATCH 10/18] [media] cx231xx: enforce check for graph creation

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > If the graph creation fails, don't register the device. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c >

Re: [PATCH 12/18] [media] media-entity: must check media_create_pad_link()

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > Drivers should check if media_create_pad_link() actually > worked. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git a/include/media/media-entity.h

Re: [PATCH 13/18] [media] media-entity.h: rename entity.type to entity.function

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > Entities should have one or more functions. Calling it as a > type proofed to not be correct, as an entity could eventually > have more than one type. > > So, rename the field as function. > > Please notice that this patch doesn't extend

Re: [PATCH 14/18] [media] media-device: export the entity function via new ioctl

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > Now that entities have a main function, expose it via > MEDIA_IOC_G_TOPOLOGY ioctl. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git

Re: [PATCH 05/18] [media] media-controller: enable all interface links at init

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > Interface links are normally enabled, meaning that the interfaces are > bound to the entities. So, any ioctl send to the interface are reflected > at the entities managed by the interface. > > However, when a device is usage, other interfaces

Re: [PATCH 08/18] [media] dvb core: must check dvb_create_media_graph()

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > If media controller is enabled and mdev is filled, it should > ensure that the media graph will be properly initialized. > > Enforce that. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil

Re: [PATCH 09/18] [media] media-entity: enforce check of interface and links creation

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > Drivers should check if interfaces and interface links were > created. Add a must_check for them. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git

Re: [PATCH 15/18] [media] uapi/media.h: Rename entities types to functions

On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > Rename the userspace types from MEDIA_ENT_T_ to MEDIA_ENT_F_ > and add the backward compatibility bits. > > The changes at the .c files was generated by the following > coccinelle script: > > @@ > -MEDIA_ENT_T_DVB_DEMUX >

Re: [PATCH 18/18] [media] dvbdev: Don't create indirect links

On 09/06/2015 07:31 PM, Mauro Carvalho Chehab wrote: > Indirect links are those whose the interface indirectly controls s/the// > other functions. > > There are two interfaces that have indirect controls at the DVB > side: > - the network interface, with also controls the demux; s/with/which/

Re: [PATCH 17/18] [media] dvbdev: move indirect links on dvr/demux to a separate function

On 09/06/2015 07:31 PM, Mauro Carvalho Chehab wrote: > Cleanup the code a little bit by moving the routine that creates > links between DVR and demux to the I/O entitis into a separate > function. > > While here, fix the code to use strncmp() instead of strcmp(). > > Signed-off-by: Mauro

Re: [RFC RESEND 01/11] vb2: Rename confusingly named internal buffer preparation functions

On 09/11/2015 01:50 PM, Sakari Ailus wrote: > Rename __qbuf_*() functions which are specific to a buffer type as > __prepare_*() which matches with what they do. The naming was there for > historical reasons; the purpose of the functions was changed without > renaming them. > > Signed-off-by:

Re: [RFC RESEND 02/11] vb2: Move buffer cache synchronisation to prepare from queue

On 09/11/2015 01:50 PM, Sakari Ailus wrote: > The buffer cache should be synchronised in buffer preparation, not when > the buffer is queued to the device. Fix this. > > Mmap buffers do not need cache synchronisation since they are always > coherent. > While I agree with this change, I also

Re: [RFC RESEND 03/11] vb2: Move cache synchronisation from buffer done to dqbuf handler

On 09/11/2015 01:50 PM, Sakari Ailus wrote: > The cache synchronisation may be a time consuming operation and thus not > best performed in an interrupt which is a typical context for > vb2_buffer_done() calls. This may consume up to tens of ms on some > machines, depending on the buffer size. > >