[PATCH 15/15] ARM: dts: exynos: Remove MFC reserved buffers

2017-02-13 Thread Marek Szyprowski
During my research I found that some of the requirements for the memory buffers for MFC v6+ devices were blindly copied from the previous (v5) version and simply turned out to be excessive. The relaxed requirements are applied by the recent patches to the MFC driver and the driver is now fully

[PATCH 08/15] media: s5p-mfc: Move firmware allocation to DMA configure function

2017-02-13 Thread Marek Szyprowski
To complete DMA memory configuration for MFC device, allocation of the firmware buffer is needed, because some parameters are dependant on its base address. Till now, this has been handled in the s5p_mfc_alloc_firmware() function. This patch moves that logic to s5p_mfc_configure_dma_memory() to

[PATCH 05/15] media: s5p-mfc: Simplify alloc/release private buffer functions

2017-02-13 Thread Marek Szyprowski
Change parameters for s5p_mfc_alloc_priv_buf() and s5p_mfc_release_priv_buf() functions. Instead of DMA device pointer and a base, provide common MFC device structure and memory bank context identifier. Signed-off-by: Marek Szyprowski ---

[PATCH 14/15] media: s5p-mfc: Use preallocated block allocator always for MFC v6+

2017-02-13 Thread Marek Szyprowski
It turned out that all versions of MFC v6+ hardware doesn't have a strict requirement for ALL buffers to be allocated on higher addresses than the firmware base like it was documented for MFC v5. This requirement is true only for the device and per-context buffers. All video data buffers can be

[PATCH 07/15] media: s5p-mfc: Put firmware to private buffer structure

2017-02-13 Thread Marek Szyprowski
Use s5p_mfc_priv_buf structure for keeping the firmware image. This will help handling of firmware buffer allocation in the next patches. Signed-off-by: Marek Szyprowski --- drivers/media/platform/s5p-mfc/s5p_mfc_cmd_v5.c | 2 +-

[PATCH 06/15] media: s5p-mfc: Move setting DMA max segmetn size to DMA configure function

2017-02-13 Thread Marek Szyprowski
Setting DMA max segment size to 32 bit mask is a part of DMA memory configuration, so move those calls to s5p_mfc_configure_dma_memory() function. Signed-off-by: Marek Szyprowski --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 21 + 1 file changed,

[PATCH 02/15] media: s5p-mfc: Use generic of_device_get_match_data helper

2017-02-13 Thread Marek Szyprowski
Replace custom code with generic helper to retrieve driver data. Signed-off-by: Marek Szyprowski --- drivers/media/platform/s5p-mfc/s5p_mfc.c| 17 ++--- drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 4 ++-- 2 files changed, 4 insertions(+), 17

[PATCH 12/15] media: s5p-mfc: Add support for probe-time preallocated block based allocator

2017-02-13 Thread Marek Szyprowski
Current MFC driver depends on the fact that when IOMMU is available, the DMA-mapping framework and its IOMMU glue will use first-fit allocator. This was true for ARM architecture, but its not for ARM64 arch. However, in case of MFC v6+ hardware and latest firmware, it turned out that there is no

[PATCH 04/15] media: s5p-mfc: Replace bank1/bank2 entries with an array

2017-02-13 Thread Marek Szyprowski
Internal MFC driver device structure contains two entries for keeping addresses of the DMA memory banks. Replace them with the dma_base[] array and use defines for accessing particular banks. This will help to simplify code in the next patches. Signed-off-by: Marek Szyprowski

[PATCH 09/15] media: s5p-mfc: Allocate firmware with internal private buffer alloc function

2017-02-13 Thread Marek Szyprowski
Once firmware buffer has been converted to use s5p_mfc_priv_buf structure, it is possible to allocate it with existing s5p_mfc_alloc_priv_buf() function. This change will help to reduce code variants in the next patches. Signed-off-by: Marek Szyprowski ---

[PATCH 13/15] media: s5p-mfc: Remove special configuration of IOMMU domain

2017-02-13 Thread Marek Szyprowski
The main reason for using special configuration of IOMMU domain was the problem with MFC firmware, which failed to operate properly when placed at 0 DMA address. Instead of adding custom code for configuring each variant of IOMMU domain and architecture specific glue code, simply use what arch

[PATCH 01/15] media: s5p-mfc: Remove unused structures and dead code

2017-02-13 Thread Marek Szyprowski
Remove unused structures, definitions and functions that are no longer called from the driver code. Signed-off-by: Marek Szyprowski --- drivers/media/platform/s5p-mfc/s5p_mfc.c| 21 - drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 13

[PATCH 11/15] media: s5p-mfc: Split variant DMA memory configuration into separate functions

2017-02-13 Thread Marek Szyprowski
Move code for DMA memory configuration with IOMMU into separate function to make it easier to compare what is being done in each case. Signed-off-by: Marek Szyprowski --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 102 ++- 1 file changed, 61

[PATCH 10/15] media: s5p-mfc: Reduce firmware buffer size for MFC v6+ variants

2017-02-13 Thread Marek Szyprowski
Firmware for MFC v6+ variants is not larger than 400 KiB, so there is no need to allocate a full 1 MiB buffer for it. Reduce it to 512 KiB to keep proper alignment of allocated buffer. Signed-off-by: Marek Szyprowski --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h | 2

[PATCH 03/15] media: s5p-mfc: Replace mem_dev_* entries with an array

2017-02-13 Thread Marek Szyprowski
Internal MFC driver device structure contains two pointers to devices used for DMA memory allocation: mem_dev_l and mem_dev_r. Replace them with the mem_dev[] array and use defines for accessing particular banks. This will help to simplify code in the next patches. Signed-off-by: Marek Szyprowski

[PATCH 00/15] Exynos MFC v6+ - remove the need for the reserved memory

2017-02-13 Thread Marek Szyprowski
Dear All, This patchset is a result of my work on enabling full support for MFC device (multimedia codec) on Exynos 5433 on ARM64 architecture. Initially I thought that to let it working on ARM64 architecture with IOMMU, I would need to solve the issue related to the fact that s5p-mfc driver was

[PATCH v1.1 3/4] smiapp: Get clock rate if it's not available through DT

2017-02-13 Thread Sakari Ailus
Obtain the clock rate from the clock framework if it's not available through DT. The assumption is that the parent device (camera module) defines the rate as clock control is a part of the power on and power off sequences --- which are camera module specific. Also use the clock rate from DT if no

[PATCH] [MEDIA] add device IDs to ngene driver

2017-02-13 Thread Helmut Auer
Author: Helmut Auer Date: Fri Jan 27 09:09:35 2017 +0100 Adding 2 device ID's to ngene driver. Signed-off-by: Helmut Auer --- drivers/media/pci/ngene/ngene-cards.c2016-12-11 20:17:54.0 +0100 +++

[PATCH v1.1 5/8] v4l: Switch from V4L2 OF not V4L2 fwnode API

2017-02-13 Thread Sakari Ailus
Switch users of the v4l2_of_ APIs to the more generic v4l2_fwnode_ APIs. Existing OF matching continues to be supported. omap3isp and smiapp drivers are converted to fwnode matching as well. Signed-off-by: Sakari Ailus --- Resending because of a mis-copied e-mail

Re: [PATCH] [MEDIA] add device ID to ati remote

2017-02-13 Thread Helmut Auer
P.S. Here is the patch again with a correction. > On Tue, Feb 07, 2017 at 09:42:47AM +0100, v...@helmutauer.de wrote: >> >> Author: Helmut Auer >> Date: Fri Jan 27 19:09:35 2017 +0100 >> >> Adding 1 device ID to ati_remote driver. > > If possible, a more descriptive message

[PATCH v1.1 5/8] v4l: Switch from V4L2 OF not V4L2 fwnode API

2017-02-13 Thread Sakari Ailus
Switch users of the v4l2_of_ APIs to the more generic v4l2_fwnode_ APIs. Existing OF matching continues to be supported. omap3isp and smiapp drivers are converted to fwnode matching as well. Signed-off-by: Sakari Ailus --- drivers/media/i2c/Kconfig

Re: [PATCH 5/8] v4l: Switch from V4L2 OF not V4L2 fwnode API

2017-02-13 Thread Sakari Ailus
Hi Benoit, On Mon, Feb 13, 2017 at 10:57:47AM -0600, Benoit Parrot wrote: > Sakari Ailus wrote on Mon [2017-Feb-13 > 15:28:13 +0200]: ... > > @@ -421,6 +423,7 @@ config VIDEO_TI_VPE > > select VIDEO_TI_VPDMA > > select VIDEO_TI_SC > > select

Re: [PATCH 00/11] media: rcar-vin: fix OPS and format/pad index issues

2017-02-13 Thread Niklas Söderlund
Hi Hans, On 2017-02-13 21:57:48 +0100, Hans Verkuil wrote: > On 02/13/2017 06:47 PM, Niklas Söderlund wrote: > > Hi Hans, > > > > Thanks for your feedback. > > > > On 2017-02-13 15:19:13 +0100, Hans Verkuil wrote: > >> Hi Niklas, > >> > >> One general remark: in many commit logs you mistype

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

2017-02-13 Thread Sekhar Nori
On Tuesday 14 February 2017 02:31 AM, Kevin Hilman wrote: > Kevin Hilman writes: > >> Bartosz Golaszewski writes: >> >>> Signed-off-by: Bartosz Golaszewski >> >> I'll fold this one into the original since it's not yet

cron job: media_tree daily build: WARNINGS

2017-02-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Feb 14 05:00:17 CET 2017 media-tree git hash:9eeb0ed0f30938f31a3d9135a88b9502192c18dd media_build

[PATCH v2] v4l: vsp1: Fix RPF/WPF U/V order in 3-planar formats on Gen3

2017-02-13 Thread Laurent Pinchart
The RPF and WPF U/V order bits have no effect for 3-planar formats on Gen3 hardware. Swap the U and V planes addresses manually instead in that case. Fixes: b915bd24a034 ("[media] v4l: vsp1: Add tri-planar memory formats support") Signed-off-by: Laurent Pinchart

Re: [PATCH 1/4] v4l: vsp1: Implement partition algorithm restrictions

2017-02-13 Thread Kuninori Morimoto
Hi Laurent, Kieran Quick response > Testing SRU-UDS scaling 768x576 - 768x576 - 640x480 in RGB24: fail > Testing SRU-UDS scaling 768x576 - 768x576 - 768x576 in RGB24: pass > Testing SRU-UDS scaling 768x576 - 768x576 - 1024x768 in RGB24: pass > Testing SRU-UDS scaling 768x576 - 1536x1152 -

Re: [PATCH v4 3/4] v4l: vsp1: Repair suspend resume operations for video pipelines

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 06 Jan 2017 12:15:30 Kieran Bingham wrote: > When a suspend/resume action is taken, the pipeline is reset and never > reconfigured. > > To correct this, we establish a new flag pipe->configured and utilise > this to establish when we write a full

Re: [PATCH v4 4/4] v4l: vsp1: Remove redundant pipe->dl usage from drm

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 06 Jan 2017 12:15:31 Kieran Bingham wrote: > The pipe->dl is used only inside vsp1_du_atomic_flush(), and can be > obtained and stored locally to simplify the code. > > Signed-off-by: Kieran Bingham

Re: [PATCH v4 2/4] v4l: vsp1: Move vsp1_video_setup_pipeline()

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 06 Jan 2017 12:15:29 Kieran Bingham wrote: > Move the static vsp1_video_setup_pipeline() function in preparation for > the callee updates so that the vsp1_video_pipeline_run() call can > configure pipelines following suspend resume actions. > > This

Re: [PATCH v4 1/4] v4l: vsp1: Prevent multiple streamon race commencing pipeline early

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 06 Jan 2017 12:15:28 Kieran Bingham wrote: > With multiple inputs through the BRU it is feasible for the streams to > race each other at stream-on. > > Multiple VIDIOC_STREAMON calls racing each other could have process > N-1 skipping over the

Re: [PATCH 0/8] v4l: vsp1: Partition phase developments

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patches. On Friday 10 Feb 2017 20:27:28 Kieran Bingham wrote: > This series presents ongoing work with the scaler partition algorithm. > > It is based upon the previous partition algorithm improvements submission > [0] This series has been pushed to a tag [1] for

Re: [PATCH 8/8] v4l: vsp1: Implement left edge partition algorithm overlap

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 10 Feb 2017 20:27:36 Kieran Bingham wrote: > Increase the overlap on the left edge to allow a margin to provide > better image scaling -EIMPOSSIBLE_TO_REVIEW I'm afraid, we need more detailed documentation. > Signed-off-by: Kieran Bingham

Re: [PATCH 7/8] v4l: vsp1: Calculate UDS phase for partitions

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 10 Feb 2017 20:27:35 Kieran Bingham wrote: > To improve image quality when scaling using the UDS we need to correctly > determine the start phase value for each partition window. I think you mean partition, not partition window. > Provide helper

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-13 Thread Steve Longerbeam
(#!##* Thunderbird! resending text only) Hi Philipp, On 02/13/2017 01:20 AM, Philipp Zabel wrote: Hi Steve, On Thu, 2017-02-09 at 15:51 -0800, Steve Longerbeam wrote: On 02/09/2017 03:49 PM, Steve Longerbeam wrote: On 02/08/2017 03:42 PM, Russell King - ARM Linux wrote: On Wed, Feb 08,

Re: [PATCH 6/8] v4l: vsp1: Allow entities to participate in the partition algorithm

2017-02-13 Thread Laurent Pinchart
Hi Kieran, A few more things. On Tuesday 14 Feb 2017 00:51:10 Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday 10 Feb 2017 20:27:34 Kieran Bingham wrote: > > The configuration of the pipeline, and entities directly affects the s/,// > > inputs required to each

Re: [PATCH] [MEDIA] add device ID to ati remote

2017-02-13 Thread Helmut Auer
Hello Thanks for the info, but sorry I'm not willinmg to do anything more to get the patch into the kernel. I have an own distribution and I am applying those patches and thats easier than committing it to the kernel ;) Maybe anyone who needs this finds this patch. Kind regards Helmut Am

Re: [PATCH 6/8] v4l: vsp1: Allow entities to participate in the partition algorithm

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 10 Feb 2017 20:27:34 Kieran Bingham wrote: > The configuration of the pipeline, and entities directly affects the > inputs required to each entity for the partition algorithm. Thus it > makes sense to involve those entities in the decision making

Re: [PATCH 5/8] v4l: vsp1: Operate on partition struct data directly

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 10 Feb 2017 20:27:33 Kieran Bingham wrote: > When generating the partition windows, operate directly on the partition > struct rather than copying and duplicating the processed data > > Signed-off-by: Kieran Bingham

Re: [PATCH 4/8] v4l: vsp1: Move partition rectangles to struct

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 10 Feb 2017 20:27:32 Kieran Bingham wrote: > As we develop the partition algorithm, we need to store more information > per partition to describe the phase and other parameters. > > To keep this data together, further abstract the existing v4l2_rect

Re: [PATCH 3/8] v4l: vsp1: Correct image partition parameters

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 10 Feb 2017 20:27:31 Kieran Bingham wrote: > The image partition algorithm operates on the image dimensions as input > into the WPF entity. > > Correct this in the code, and document what defines the properties for > the algorithm in the section

Re: [PATCH 2/8] v4l: vsp1: Track the SRU entity in the pipeline

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 10 Feb 2017 20:27:30 Kieran Bingham wrote: > The UDS and other entities are already tracked directly through the > pipeline object. To follow the design pattern, and allow us to reference > the SRU convert the usage of 'sru_found' I propose

Re: [PATCH 1/8] v4l: vsp1: Provide UDS register updates

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 10 Feb 2017 20:27:29 Kieran Bingham wrote: > Provide register definitions required for UDS phase and partition > algorithm support I would mention here that those registers and bits are available on Gen3 only. > > Signed-off-by: Kieran Bingham

Re: [PATCH 3/4] v4l: vsp1: Calculate partition sizes at stream start.

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 04 Nov 2016 18:19:29 Kieran Bingham wrote: > Previously the active window and partition sizes for each partition is s/is/were/ > calculated for each partition every frame. This data is constant and > only needs to be calculated once at the start of

Re: [PATCH 4/4] v4l: vsp1: Remove redundant context variables

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 04 Nov 2016 18:19:30 Kieran Bingham wrote: > The vsp1_pipe object context variables for div_size and > current_partition allowed state to be maintained through processing the > partitions during processing. > > Now that the partition tables are

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

2017-02-13 Thread Kevin Hilman
Kevin Hilman writes: > Bartosz Golaszewski writes: > >> Signed-off-by: Bartosz Golaszewski > > I'll fold this one into the original since it's not yet merged. Oops, Sekhar has already merged this one to his v4.11/dt

Re: [PATCH 07/10] ARM: davinci: fix a whitespace error

2017-02-13 Thread Kevin Hilman
Kevin Hilman writes: > Bartosz Golaszewski writes: > >> There's a stray tab in da850_vpif_legacy_init(). Remove it. >> >> Signed-off-by: Bartosz Golaszewski > > Folding into the original, Looks like the version in

Re: [PATCH 00/11] media: rcar-vin: fix OPS and format/pad index issues

2017-02-13 Thread Hans Verkuil
On 02/13/2017 06:47 PM, Niklas Söderlund wrote: > Hi Hans, > > Thanks for your feedback. > > On 2017-02-13 15:19:13 +0100, Hans Verkuil wrote: >> Hi Niklas, >> >> One general remark: in many commit logs you mistype 'subdeivce'. Can you >> fix that for the v2? > > Will fix for v2. > >> >> On

Re: [regression] dvb_usb_cxusb (was Re: ir-keytable: infinite loops, segfaults)

2017-02-13 Thread Vincent McIntyre
ping? My media_build tree is updated as far as: $ git log -1 commit 0721d4bde661c71cd4e41de37afb24b0694c65a3 Author: Hans Verkuil Date: Mon Nov 21 13:17:19 2016 +0100 Only use Makefile.mm if frame_vector.c is present. Signed-off-by: Hans Verkuil

Re: [PATCH v8 2/2] Add support for OV5647 sensor.

2017-02-13 Thread Vladimir Zapolskiy
Hi Ramiro, On 02/13/2017 09:14 PM, Ramiro Oliveira wrote: > Hi Vladimir, > > Thank you for your feedback. > > On 2/13/2017 12:21 PM, Vladimir Zapolskiy wrote: >> Hello Ramiro, >> >> On 02/13/2017 01:25 PM, Ramiro Oliveira wrote: >>> Modes supported: >>> - 640x480 RAW 8 >>> [snip] >>> +static

Re: [PATCH RESEND 1/1] media: platform: Renesas IMR driver

2017-02-13 Thread Konstantin Kozhevnikov
Hello Laurent, regarding your main question, I think the name "image renderer" is misguiding. This IP-block has nothing to do with rendering per se, it is rather an image processing module, designed specifically for image undistortion (lens correction). We use that as a plain memory-to-memory

Re: [PATCH 2/4] v4l: vsp1: Move vsp1_video_pipeline_setup_partitions() function

2017-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday 04 Nov 2016 18:19:28 Kieran Bingham wrote: > Separate the code change from the function move so that code changes can > be clearly identified. This commit has no functional change. > > The partition algorithm functions will be changed, and >

Re: [PATCH 1/4] v4l: vsp1: Implement partition algorithm restrictions

2017-02-13 Thread Laurent Pinchart
Hi Kieran, (CC'ing Morimoto-san) Thank you for the patch. On Friday 04 Nov 2016 18:19:27 Kieran Bingham wrote: > The partition algorithm introduced to support scaling, and rotation on s/,// if I'm not mistaken. > Gen3 hardware has some restrictions on pipeline configuration. Strictly

Re: [PATCH v8 2/2] Add support for OV5647 sensor.

2017-02-13 Thread Ramiro Oliveira
Hi Vladimir, Thank you for your feedback. On 2/13/2017 12:21 PM, Vladimir Zapolskiy wrote: > Hello Ramiro, > > On 02/13/2017 01:25 PM, Ramiro Oliveira wrote: >> Modes supported: >> - 640x480 RAW 8 >> > > It is a pretty short commit message, please consider to write a couple > of words about

[PATCH v4 0/4] Fixes for colorspace logic in exynos-gsc and s5p-mfc drivers

2017-02-13 Thread Thibault Saunier
Hello, This patchset fixes a few issues on the colorspace logic for the exynos-gsc and s5p-mfc drivers. We now handle the colorspace in those drivers, and make sure to respect user setting if possible. We also now set the 'v4l2_pix_format:field' if userspace passed ANY, avoiding GStreamer

[PATCH v4 3/4] [media] s5p-mfc: Set colorspace in VIDIO_{G,TRY}_FMT if DEFAULT provided

2017-02-13 Thread Thibault Saunier
The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV but the driver didn't set the colorimetry when userspace provided V4L2_COLORSPACE_DEFAULT. Use 576p display resolution as a threshold to set this as suggested by

[PATCH v4 2/4] [media] exynos-gsc: Respect userspace colorspace setting in try_fmt

2017-02-13 Thread Thibault Saunier
User userspace provided by the user as we are only doing scaling and color encoding conversion, we won't be able to transform the colorspace itself and the colorspace won't mater in that operation. Also always use output colorspace on the capture side. Signed-off-by: Thibault Saunier

[PATCH v4 1/4] [media] exynos-gsc: Use 576p instead 720p as a threshold for colorspaces

2017-02-13 Thread Thibault Saunier
From: Javier Martinez Canillas The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV. But drivers don't agree on the display resolution that should be used as a threshold. >From EIA CEA 861B

[PATCH v4 4/4] [media] s5p-mfc: Check and set 'v4l2_pix_format:field' field in try_fmt

2017-02-13 Thread Thibault Saunier
It is required by the standard that the field order is set by the driver. Signed-off-by: Thibault Saunier --- Changes in v4: None Changes in v3: - Do not check values in the g_fmt functions as Andrzej explained in previous review Changes in v2: - Fix a silly

[bug report] [media] st-delta: add mjpeg support

2017-02-13 Thread Dan Carpenter
Hello Hugues Fruchet, The patch 433ff5b4a29b: "[media] st-delta: add mjpeg support" from Feb 2, 2017, leads to the following static checker warning: drivers/media/platform/sti/delta/delta-mjpeg-dec.c:415 delta_mjpeg_decode() error: uninitialized symbol 'data_offset'.

Re: [RFC simple allocator v2 0/2] Simple allocator

2017-02-13 Thread Laura Abbott
On 02/13/2017 10:18 AM, Mark Brown wrote: > On Mon, Feb 13, 2017 at 03:45:04PM +0100, Benjamin Gaignard wrote: > >> An other question is: do we have others memory regions that could be >> interested >> by this new framework ? I have in mind that some title memory regions could >> use >> it or

Re: [PATCH 07/10] ARM: davinci: fix a whitespace error

2017-02-13 Thread Kevin Hilman
Bartosz Golaszewski writes: > There's a stray tab in da850_vpif_legacy_init(). Remove it. > > Signed-off-by: Bartosz Golaszewski Folding into the original, Kevin > --- > arch/arm/mach-davinci/pdata-quirks.c | 2 +- > 1 file changed, 1

Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm

2017-02-13 Thread Kevin Hilman
Sekhar Nori writes: > On Tuesday 07 February 2017 11:51 PM, Kevin Hilman wrote: >> Bartosz Golaszewski writes: >> >>> When we enable vpif capture on the da850-evm we hit a BUG_ON() because >>> the i2c adapter can't be found. The board file boot uses

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

2017-02-13 Thread Kevin Hilman
Bartosz Golaszewski writes: > Signed-off-by: Bartosz Golaszewski I'll fold this one into the original since it's not yet merged. Kevin > --- > arch/arm/boot/dts/da850-evm.dts | 10 +- > 1 file changed, 5 insertions(+), 5

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

2017-02-13 Thread Kevin Hilman
Bartosz Golaszewski writes: > Signed-off-by: Bartosz Golaszewski Acked-by: Kevin Hilman > --- > arch/arm/boot/dts/da850-evm.dts | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git

Re: [PATCH 3/4] smiapp: Get clock rate if it's not available through DT

2017-02-13 Thread kbuild test robot
Hi Sakari, [auto build test WARNING on linus/master] [also build test WARNING on v4.10-rc8] [cannot apply to linuxtv-media/master next-20170213] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [RFC simple allocator v2 0/2] Simple allocator

2017-02-13 Thread Mark Brown
On Mon, Feb 13, 2017 at 03:45:04PM +0100, Benjamin Gaignard wrote: > An other question is: do we have others memory regions that could be > interested > by this new framework ? I have in mind that some title memory regions could > use > it or replace ION heaps (system, carveout, etc...). >

Re: [PATCH 00/11] media: rcar-vin: fix OPS and format/pad index issues

2017-02-13 Thread Niklas Söderlund
Hi Hans, Thanks for your feedback. On 2017-02-13 15:19:13 +0100, Hans Verkuil wrote: > Hi Niklas, > > One general remark: in many commit logs you mistype 'subdeivce'. Can you > fix that for the v2? Will fix for v2. > > On 01/31/2017 04:40 PM, Niklas Söderlund wrote: > > Hi, > > > > This

Re: [PATCH 5/8] v4l: Switch from V4L2 OF not V4L2 fwnode API

2017-02-13 Thread Benoit Parrot
Sakari Ailus wrote on Mon [2017-Feb-13 15:28:13 +0200]: > Switch users of the v4l2_of_ APIs to the more generic v4l2_fwnode_ APIs. > > Existing OF matching continues to be supported. omap3isp and smiapp > drivers are converted to fwnode matching as well. > >

[PATCH 1/4] smiapp: Remove smiapp.h header under include

2017-02-13 Thread Sakari Ailus
As platform data isn't supported anymore, there's no reason to maintain a separate header under include/. Merge its contents to the one under drivers/media/i2c/smiapp. Signed-off-by: Sakari Ailus --- MAINTAINERS | 1 -

[PATCH 3/4] smiapp: Get clock rate if it's not available through DT

2017-02-13 Thread Sakari Ailus
Obtain the clock rate from the clock framework if it's not available through DT. The assumption is that the parent device (camera module) defines the rate as clock control is a part of the power on and power off sequences --- which are camera module specific. Also use the clock rate from DT if no

[PATCH 0/4] smiapp cleanups, clock control changes

2017-02-13 Thread Sakari Ailus
Hi folks, With this set, the smiapp driver can support clocks not coming from the clock framework (e.g. ACPI). The smiapp.h header under include/media/i2c/ is also removed as it is no longer needed. -- Kind regards, Sakari

[PATCH 4/4] smiapp: Make clock control optional

2017-02-13 Thread Sakari Ailus
The clock control is not explicitly controlled by the driver in two cases: ACPI based systems and when the clock is part of the power sequence of the camera module. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 5 - 1 file changed, 4

[PATCH 2/4] smiapp: Verify clock frequency after setting it, prevent changing it

2017-02-13 Thread Sakari Ailus
The external clock frequency was set by the driver but the obtained frequency was never verified. Do that. Being able to obtain the exact frequency is important as the value is used for PLL calculations which may result in frequencies that violate the PLL tree limits. Signed-off-by: Sakari Ailus

[PATCH 1/1] smiapp: Make VANA regulator optional

2017-02-13 Thread Sakari Ailus
On ACPI based systems ACPI will control the camera module's power resources. In that case the sensor driver does not explicitly need to control them, thus make them optional. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 2 +- 1 file

Re: [PATCH 00/11] media: rcar-vin: fix OPS and format/pad index issues

2017-02-13 Thread Laurent Pinchart
Hi Hans, On Monday 13 Feb 2017 15:19:13 Hans Verkuil wrote: > Hi Niklas, > > One general remark: in many commit logs you mistype 'subdeivce'. Can you > fix that for the v2? > > On 01/31/2017 04:40 PM, Niklas Söderlund wrote: > > Hi, > > > > This series address issues with the R-Car Gen2 VIN

Re: [PATCH 00/11] media: rcar-vin: fix OPS and format/pad index issues

2017-02-13 Thread Hans Verkuil
On 02/13/2017 04:31 PM, Laurent Pinchart wrote: > Hi Hans, > > On Monday 13 Feb 2017 15:19:13 Hans Verkuil wrote: >> Hi Niklas, >> >> One general remark: in many commit logs you mistype 'subdeivce'. Can you >> fix that for the v2? >> >> On 01/31/2017 04:40 PM, Niklas Söderlund wrote: >>> Hi, >>>

Re: patch superseded? (was: [linux-media] Patch notification: 1 patch updated)

2017-02-13 Thread Guennadi Liakhovetski
On Mon, 13 Feb 2017, Hans Verkuil wrote: > This is the v2 patch: > > https://patchwork.linuxtv.org/patch/32648/ Oh, ok, thanks! Guennadi > Hans > > On 02/13/2017 04:10 PM, Guennadi Liakhovetski wrote: > > Hi, > > > > According to the explanations below, "superseded" means, that either

Re: patch superseded? (was: [linux-media] Patch notification: 1 patch updated)

2017-02-13 Thread Hans Verkuil
This is the v2 patch: https://patchwork.linuxtv.org/patch/32648/ Hans On 02/13/2017 04:10 PM, Guennadi Liakhovetski wrote: > Hi, > > According to the explanations below, "superseded" means, that either a > newer version of the patch is available, or it's been included in a pull >

patch superseded? (was: [linux-media] Patch notification: 1 patch updated)

2017-02-13 Thread Guennadi Liakhovetski
Hi, According to the explanations below, "superseded" means, that either a newer version of the patch is available, or it's been included in a pull request. Since I don't see a newer version, I should assume, that it's been included in a pull request. However, I don't see one on linux-media

[RFC simple allocator v2 0/2] Simple allocator

2017-02-13 Thread Benjamin Gaignard
version 2: - rebase code on 4.10-rc7 - fix bug in CMA allocator - do more tests with wayland dmabuf protocol: https://git.linaro.org/people/benjamin.gaignard/simple_allocator.git The goal of this RFC is to understand if a common ioctl for specific memory regions allocations is needed/welcome.

[RFC simple allocator v2 2/2] add CMA simple allocator module

2017-02-13 Thread Benjamin Gaignard
This patch add simple allocator for CMA regions. version 2: - fix size and page count computation Signed-off-by: Benjamin Gaignard --- drivers/simpleallocator/Kconfig| 7 + drivers/simpleallocator/Makefile | 1 +

[RFC simple allocator v2 1/2] Create Simple Allocator module

2017-02-13 Thread Benjamin Gaignard
This is the core of simple allocator module. It aim to offert one common ioctl to allocate specific memory. version 2: - rebased on 4.10-rc7 Signed-off-by: Benjamin Gaignard --- Documentation/simple-allocator.txt | 81 +++ drivers/Kconfig

Re: [PATCH 0/2] [media] exynos-gsc: Fix support for NV21 and NV61 formats

2017-02-13 Thread Javier Martinez Canillas
Hello Sylwester, On 02/13/2017 11:34 AM, Sylwester Nawrocki wrote: > Hi Javier, > > On 02/13/2017 01:53 PM, Javier Martinez Canillas wrote: >> Any comments on this series? > > The patches look good to me, I will Ack the patches in case > Mauro wants to apply them directly. Alternatively I will

Re: [PATCH 2/2] [media] exynos-gsc: Add support for NV{16,21,61}M pixel formats

2017-02-13 Thread Sylwester Nawrocki
On 02/01/2017 09:05 PM, Javier Martinez Canillas wrote: > From: Thibault Saunier > > Those are useful formats that should be handled. > > Signed-off-by: Thibault Saunier > Signed-off-by: Javier Martinez Canillas

Re: [PATCH 1/2] [media] exynos-gsc: Do not swap cb/cr for semi planar formats

2017-02-13 Thread Sylwester Nawrocki
On 02/01/2017 09:05 PM, Javier Martinez Canillas wrote: > From: Thibault Saunier > > In the case of semi planar formats cb and cr are in the same plane > in memory, meaning that will be set to 'cb' whatever the format is, > and whatever the (packed) order of

Re: [PATCH 0/2] [media] exynos-gsc: Fix support for NV21 and NV61 formats

2017-02-13 Thread Sylwester Nawrocki
Hi Javier, On 02/13/2017 01:53 PM, Javier Martinez Canillas wrote: > Any comments on this series? The patches look good to me, I will Ack the patches in case Mauro wants to apply them directly. Alternatively I will add them to my tree for v4.12 after the merge window. -- Thanks, Sylwester

Re: [PATCH 4/8] v4l2-async: Provide interoperability between OF and fwnode matching

2017-02-13 Thread kbuild test robot
Hi Sakari, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20170213] [cannot apply to v4.10-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l

Re: [PATCH 00/11] media: rcar-vin: fix OPS and format/pad index issues

2017-02-13 Thread Hans Verkuil
Hi Niklas, One general remark: in many commit logs you mistype 'subdeivce'. Can you fix that for the v2? On 01/31/2017 04:40 PM, Niklas Söderlund wrote: > Hi, > > This series address issues with the R-Car Gen2 VIN driver. The most > serious issue is the OPS when unbind and rebinding the i2c

Re: [PATCH 5/8] v4l: Switch from V4L2 OF not V4L2 fwnode API

2017-02-13 Thread kbuild test robot
Hi Sakari, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20170213] [cannot apply to v4.10-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l

Re: [PATCH 5/8] v4l: Switch from V4L2 OF not V4L2 fwnode API

2017-02-13 Thread kbuild test robot
Hi Sakari, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20170213] [cannot apply to v4.10-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l

[GIT PULL FOR v4.12] Various fixes/enhancements

2017-02-13 Thread Hans Verkuil
Various fixes and enhancements. Regards, Hans The following changes since commit 9eeb0ed0f30938f31a3d9135a88b9502192c18dd: [media] mtk-vcodec: fix build warnings without DEBUG (2017-02-08 12:08:20 -0200) are available in the git repository at:

Re: [PATCH 2/4] [media] em28xx: reduce stack usage in probe functions

2017-02-13 Thread Hans Verkuil
Hi Arnd, I'll take the others of this patch series, but will postpone this one until it has been tested. I've asked Frank to see if he can test it, if not, then it will have to wait until March when I have access to an omnivision-em28xx device. Regards, Hans On 02/02/2017 03:53 PM,

Re: [PATCH 1/8] v4l: flash led class: Use fwnode_handle instead of device_node in init

2017-02-13 Thread kbuild test robot
Hi Sakari, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.10-rc8 next-20170213] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l-flash-led-class-Use

Re: [PATCH 1/8] v4l: flash led class: Use fwnode_handle instead of device_node in init

2017-02-13 Thread kbuild test robot
Hi Sakari, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.10-rc8 next-20170213] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l-flash-led-class-Use

Re: [PATCH] [MEDIA] add device ID to ati remote

2017-02-13 Thread Sean Young
On Tue, Feb 07, 2017 at 09:42:47AM +0100, v...@helmutauer.de wrote: > > Author: Helmut Auer > Date: Fri Jan 27 19:09:35 2017 +0100 > > Adding 1 device ID to ati_remote driver. If possible, a more descriptive message would be preferred, e.g. what device do you have, what

[PATCH 3/8] v4l: async: Add fwnode match support

2017-02-13 Thread Sakari Ailus
Add fwnode matching to complement OF node matching. And fwnode may also be an OF node. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-async.c | 12 include/media/v4l2-async.h | 5 + include/media/v4l2-subdev.h | 3

[PATCH 7/8] v4l: Improve header file ordering

2017-02-13 Thread Sakari Ailus
Improve header file ordering and remove a few duplicates and unnecessary headers for drivers the header file ordering of which was adversely affected by V4L2 OF to V4L2 fwnode API changes. Signed-off-by: Sakari Ailus --- drivers/media/i2c/adv7604.c

[PATCH 1/8] v4l: flash led class: Use fwnode_handle instead of device_node in init

2017-02-13 Thread Sakari Ailus
Pass the more generic fwnode_handle to the init function than the device_node. Signed-off-by: Sakari Ailus --- drivers/leds/leds-aat1290.c| 5 +++-- drivers/leds/leds-max77693.c | 5 +++--

[PATCH 2/8] v4l: fwnode: Support generic fwnode for parsing standardised properties

2017-02-13 Thread Sakari Ailus
The fwnode_handle is a more generic way than OF device_node to describe firmware nodes. Instead of the OF API, use more generic fwnode API to obtain the same information. As the V4L2 fwnode support will be required by a small minority of e.g. ACPI based systems (the same might actually go for

  1   2   >