Am 05.01.2014 14:08, schrieb Mauro Carvalho Chehab:
Em Sun, 05 Jan 2014 11:55:34 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Add a message with consistent prints before and after each
extension initialization, and provide
Am 05.01.2014 14:10, schrieb Mauro Carvalho Chehab:
Em Sun, 05 Jan 2014 12:03:51 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
The I2C wait completion/timeout logic currently assumes that
msleep(5) will wait exaclty 5 ms
Am 05.01.2014 15:40, schrieb Mauro Carvalho Chehab:
Em Sun, 05 Jan 2014 11:26:14 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
There are several init code inside em28xx-cards that are actually
part of analog initialization
Am 05.01.2014 16:18, schrieb Mauro Carvalho Chehab:
Em Sun, 05 Jan 2014 10:56:33 -0200
Mauro Carvalho Chehab m.che...@samsung.com escreveu:
Em Sun, 05 Jan 2014 11:47:00 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Now
*dev);
void em28xx_release_analog_resources(struct em28xx *dev);
Reviewed-by: Frank Schäfer fschaefer@googlemail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
; /* stream should be running if true */
Reviewed-by: Frank Schäfer fschaefer@googlemail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
There are several init code inside em28xx-cards that are actually
part of analog initialization. Move the code to em28x-video, in
order to remove part of the mess.
In thesis, no functional changes so far.
Signed-off-by: Mauro Carvalho
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Now that all analog-specific code are at em28xx-video, convert
it into an em28xx extension and load it as a separate module.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/Kconfig | 6 ++-
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
In order to initialize the analog tuner, v4l2 should be registere
first, or otherwise we get an oops:
[ 51.783537] BUG: unable to handle kernel NULL pointer dereference at
)
[ 51.784479] IP: [81319fbb]
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
changeset 45f04e82d035 added a logic to check if em28xx got
a timeout on an I2C transfer.
That patch started to produce a series of errors that is present
with HVR-950, like:
[ 4032.218656] xc2028 19-0061: Error on line 1299: -19
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Add a message with consistent prints before and after each
extension initialization, and provide a better text for module
load.
While here, add a missing sanity check for extension finish
code at em28xx-v4l extension.
Signed-off-by: Mauro
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
The I2C wait completion/timeout logic currently assumes that
msleep(5) will wait exaclty 5 ms. This is not true at all,
as it depends on CONFIG_HZ.
Convert it to use jiffies, in order to not wait for more time
than needed.
Signed-off-by:
i/o error: rc == %d (should be 2)\n, rc);
+ return rc 0 ? rc : -EIO;
}
v4l2_dbg(2, debug, sd, tvp5150: read 0x%02x = 0x%02x\n, addr,
buffer[0]);
Reviewed-by: Frank Schäfer fschaefer@googlemail.com
Tested-by: Frank Schäfer fschaefer@googlemail.com
;\
_rc = tuner_i2c_xfer_send_recv(priv-i2c_props, obuf, osize, \
Reviewed-by: Frank Schäfer fschaefer@googlemail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Better to split chipset detection from the audio setup. So, move the
detection code to em28xx_init_dev().
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 11 +++
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Instead of assuming that msleep() is precise, use a jiffies
based code to wait for AC97 to be available.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-core.c | 7 +--
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
Better to first write the GPIOs of the input mux, before initializing
the audio.
Why are you making this change ?
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-video.c | 40
now. :)
Reviewed-by: Frank Schäfer fschaefer@googlemail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, em28xx_extension_devlist, next) {
if (ops-fini)
ops-fini(dev);
}
+ mutex_unlock(dev-lock);
list_del(dev-devlist);
mutex_unlock(em28xx_devlist_mutex);
}
Reviewed-by: Frank Schäfer fschaefer@googlemail.com
Thank you for fixing this issue.
I
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
In the lack of a better spec, let's assume the timeout
values compatible with SMBus spec:
http://smbus.org/specs/smbus110.pdf
at chapter 8 - Electrical Characteristics of SMBus devices
Ok, SMBus is a subset of I2C, and not all
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
The proper error code for I2C errors are EREMOTEIO. The em28xx driver
is using EIO instead.
Replace all occurrences of EIO at em28xx-i2c, in order to fix it.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
-ENODEV reports a permanent condition where a device is not found,
and used only during device probing or device removal, as stated
at the V4L2 spec:
http://linuxtv.org/downloads/v4l-dvb-apis/gen_errors.html
Except during device
-by: Frank Schäfer fschaefer@googlemail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;
urb-complete = em28xx_audio_isocirq;
Reviewed-by: Frank Schäfer fschaefer@googlemail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
From: Mauro Carvalho Chehab mche...@redhat.com
Is this line still correct ? ;)
Instead of allocating/deallocating URBs and transfer buffers
every time stream is started/stopped, just do it once.
That reduces the memory allocation pressure
Am 04.01.2014 11:55, schrieb Mauro Carvalho Chehab:
I2C read operations can also take some time to happen.
Try again, if it fails with return code different than 0x10
until timeout.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-i2c.c | 62
Am 05.01.2014 13:05, schrieb Mauro Carvalho Chehab:
Fix the error handling logic, making it to unregister i2c bus 0, in
case of a failure to register the second bus.
Reported-by: Frank Schäfer fschaefer@googlemail.com
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
for i2c xfers to finish */
-#define EM2800_I2C_XFER_TIMEOUT 20
+#define EM28XX_I2C_XFER_TIMEOUT 20
/* time in msecs to wait for AC97 xfers to finish */
#define EM28XX_AC97_XFER_TIMEOUT 100
Reviewed-by: Frank Schäfer fschaefer@googlemail.com
--
To unsubscribe
Am 04.01.2014 18:58, schrieb Markus Rechberger:
Did you trace the i2c messages on the bus? This seems like papering
the actual bug.
The USB traces are clear:
i2c status 0x10 is treated as _final_ i2c transfer status and the driver
does _not_ retry.
Yes, it's papering over the actual bug.
We
Am 28.12.2013 13:16, schrieb Mauro Carvalho Chehab:
From: Mauro Carvalho Chehab m.che...@samsung.com
When em28xx extensions are loaded/removed, there are two locks:
a single static em28xx_devlist_mutex that registers each extension
and the struct em28xx dev-lock.
When extensions are
Am 28.12.2013 13:15, schrieb Mauro Carvalho Chehab:
This patch series split em28xx into a separate V4L2 driver,
allowing the new dvb-only chips to be supported without requiring
V4L2.
While testing the original patchset, I noticed several issues with
HVR-950. The remaining patches on this
On 02.01.2014 20:20, Mauro Carvalho Chehab wrote:
Em Wed, 01 Jan 2014 19:52:08 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 28.12.2013 13:16, schrieb Mauro Carvalho Chehab:
From: Mauro Carvalho Chehab m.che...@samsung.com
Instead of using two I2C operations between write
Am 28.12.2013 13:16, schrieb Mauro Carvalho Chehab:
From: Mauro Carvalho Chehab m.che...@samsung.com
Instead of using two I2C operations between write and read,
use just one i2c_transfer. That allows I2C mutexes to not
let any other I2C transfer between the two.
Signed-off-by: Mauro
Am 28.12.2013 13:16, schrieb Mauro Carvalho Chehab:
From: Mauro Carvalho Chehab m.che...@samsung.com
This macro is not used. remove it.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/tuners/tuner-xc2028.c | 9 -
1 file changed, 9 deletions(-)
diff
Hi,
With the Hauppauge HVR900 (em2882/3 / xc2028 / tvp5150 / zl10353), I'm
getting lot's of i2c error messages for ages:
...
[ 99.590735] xc2028 10-0061: Error on line 1299: -19
[ 99.645650] usbcore: registered new interface driver snd-usb-audio
[ 99.755362] xc2028 10-0061: Error on line
anyone comes up with a better solution.
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/tuners/tuner-xc2028.c |4 +++-
1 Datei geändert, 3 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
diff --git a/drivers/media/tuners/tuner-xc2028.c
b/drivers/media/tuners/tuner-xc2028
I just noticed the following em28xx bug:
Steps to reproduce:
1) open device with qv4l2
2) start streaming
3) unplugg the device
4) close qv4l2
Result:
[19188.227756] [ cut here ]
[19188.227766] WARNING: CPU: 0 PID: 12773 at fs/sysfs/group.c:214
Am 30.12.2013 15:05, schrieb Frank Schäfer:
I just noticed the following em28xx bug:
Steps to reproduce:
1) open device with qv4l2
2) start streaming
3) unplugg the device
4) close qv4l2
Result:
[19188.227756] [ cut here ]
[19188.227766] WARNING: CPU: 0 PID
Hi Mauro,
Am 22.12.2013 13:47, schrieb Mauro Carvalho Chehab:
Now that dvb-only devices start to happen, it makes sense
to split the analog part on a separate module.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
-
This is a respin of https://patchwork.linuxtv.org/patch/17967/
Am 21.12.2013 20:55, schrieb Antti Palosaari:
On 21.12.2013 18:51, Frank Schäfer wrote:
Hi Antti,
thank you for reporting this issue.
Am 18.12.2013 17:04, schrieb Antti Palosaari:
That same lock debug deadlock is still there (maybe ~4 times I report
it during 2 years). Is that possible
reproted by the USB device
descriptor (32k only).
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-core.c | 24 +---
drivers/media/usb/em28xx/em28xx-i2c.c | 10 --
drivers/media/usb/em28xx/em28xx-reg.h | 10
Am 22.12.2013 15:34, schrieb Antti Palosaari:
On 22.12.2013 15:51, Frank Schäfer wrote:
Am 21.12.2013 20:55, schrieb Antti Palosaari:
On 21.12.2013 18:51, Frank Schäfer wrote:
Hi Antti,
thank you for reporting this issue.
Am 18.12.2013 17:04, schrieb Antti Palosaari:
That same lock debug
Am 22.12.2013 15:53, schrieb Mauro Carvalho Chehab:
Em Sun, 22 Dec 2013 14:51:53 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 21.12.2013 20:55, schrieb Antti Palosaari:
On 21.12.2013 18:51, Frank Schäfer wrote:
Hi Antti,
thank you for reporting this issue.
Am 18.12.2013
Am 22.12.2013 17:09, schrieb Mauro Carvalho Chehab:
Em Sun, 22 Dec 2013 15:17:46 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
The audio configuration in chip config register 0x00 and eeprom are always
consistent. But currently the audio configuration #defines for the chip
Am 22.12.2013 19:14, schrieb Antti Palosaari:
On 22.12.2013 20:02, Frank Schäfer wrote:
Am 22.12.2013 15:34, schrieb Antti Palosaari:
On 22.12.2013 15:51, Frank Schäfer wrote:
Am 21.12.2013 20:55, schrieb Antti Palosaari:
On 21.12.2013 18:51, Frank Schäfer wrote:
Hi Antti,
thank you
Hi Antti,
thank you for reporting this issue.
Am 18.12.2013 17:04, schrieb Antti Palosaari:
That same lock debug deadlock is still there (maybe ~4 times I report
it during 2 years). Is that possible to fix easily at all?
Patches are always welcome. ;)
Antti
joulu 18 17:56:37
For GPI-connected buttons without (hardware) debouncing, the polling interval
needs to be reduced to detect button presses properly.
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-input.c | 21 ++---
drivers/media/usb/em28xx
Some devices are equipped with a capturing status LED that needs to be
switched on/off explicitly via a GPO port.
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-core.c | 69 +---
drivers/media/usb/em28xx/em28xx.h
needs to be improved
- AV-mute button doesn't work yet
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 72 +++
drivers/media/usb/em28xx/em28xx.h |1 +
2 Dateien geändert, 73 Zeilen hinzugefügt(+)
diff
For GPI-connected buttons without (hardware) debouncing, the polling interval
needs to be reduced to detect button presses properly.
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-input.c |2 +-
1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile
to 640x480 (sensor supports 1600x1200)
- picture quality needs to be improved
- audio/video mute button doesn't work yet
Frank Schäfer (7):
em28xx: add support for GPO controlled analog capturing LEDs
em28xx: extend the support for device buttons
em28xx: add debouncing mechanism for GPI
Introduce a LED role and store all LEDs in an array.
Also provide a helper function to retrieve a specific LED.
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-core.c | 31 ---
drivers/media/usb/em28xx/em28xx.h
to different
GPI-ports / register addresses and bits.
Also make easier to extend the code with further button types.
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 20 -
drivers/media/usb/em28xx/em28xx-input.c | 150
So far, the driver only supports a snapshot button which is assigned to
register 0x0c bit 5. This special port has a built-in debouncing mechanism.
For buttons connected to ordinary GPI ports, this patch implements a software
debouncing mechanism.
Signed-off-by: Frank Schäfer fschaefer
The SpeedLink VAD Laplace webcam is equipped with an illumination button and
an illumination LED. When the button is pressed, the driver must toggle the
LED state via the corresponding GPO port.
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-core.c
Am 02.11.2013 17:39, schrieb Mauro Carvalho Chehab:
Em Sat, 02 Nov 2013 14:00:13 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 31.10.2013 13:13, schrieb Patchwork:
Hello,
The following patch (submitted by you) has been updated in patchwork:
* linux-media: em28xx: make sure
Am 31.10.2013 13:13, schrieb Patchwork:
Hello,
The following patch (submitted by you) has been updated in patchwork:
* linux-media: em28xx: make sure that all subdevices are powered on when
needed
- http://patchwork.linuxtv.org/patch/20422/
- for: Linux Media kernel patches
Hi Guennadi,
thanks for the patches and sorry for the delay.
I've tested them a few minutes ago and they are working fine.
2 minor things/questions:
1.) Why not always balance v4l2_clk_enable/disable() calls ?
2.) For someone who reads the code it likely looks a bit odd that if the
flag
Am 23.10.2013 19:26, schrieb Guennadi Liakhovetski:
Hi Frank
On Wed, 23 Oct 2013, Frank Schäfer wrote:
Hi Guennadi,
thanks for the patches and sorry for the delay.
I've tested them a few minutes ago and they are working fine.
2 minor things/questions:
1.) Why not always balance
Hi Guennadi,
Am 19.10.2013 18:32, schrieb Guennadi Liakhovetski:
Hi Frank
On Sat, 19 Oct 2013, Frank SchÀfer wrote:
Am 18.10.2013 22:30, schrieb Guennadi Liakhovetski:
Hi Frank
Thanks for the patch
On Wed, 16 Oct 2013, Frank SchÀfer wrote:
Commit 622b828ab7 (v4l2_subdev: rename
Am 18.10.2013 22:30, schrieb Guennadi Liakhovetski:
Hi Frank
Thanks for the patch
On Wed, 16 Oct 2013, Frank Schäfer wrote:
Commit 622b828ab7 (v4l2_subdev: rename tuner s_standby operation to
core s_power) replaced the tuner s_standby call in the em28xx driver with
a (s_power, 0) call
Am 13.10.2013 16:00, schrieb Frank Schäfer:
[snip]
Am 12.10.2013 05:45, schrieb Mauro Carvalho Chehab:
Changing the input will likely power on the device. The design of the
old suspend callback were to call it when the device is not being used.
Any try to use the device makes it to wake up
on again when needed.
This patch fixes this issue by adding a (s_power, 1) call to
function em28xx_wake_i2c().
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-core.c |1 +
1 Datei geändert, 1 Zeile hinzugefügt(+)
diff --git a/drivers/media/usb
[snip]
Am 12.10.2013 05:45, schrieb Mauro Carvalho Chehab:
Changing the input will likely power on the device. The design of the
old suspend callback were to call it when the device is not being used.
Any try to use the device makes it to wake up, as it makes no sense to
use a device in
Am 08.10.2013 18:38, schrieb Guennadi Liakhovetski:
Hi Frank,
On Tue, 8 Oct 2013, Frank SchÀfer wrote:
Am 18.08.2013 17:20, schrieb Mauro Carvalho Chehab:
Em Sun, 18 Aug 2013 13:40:25 +0200
Frank SchÀfer fschaefer@googlemail.com escreveu:
Am 17.08.2013 12:51, schrieb Guennadi
Am 09.10.2013 15:48, schrieb Jean-Francois Thibert:
On Tue, Oct 8, 2013 at 12:24 PM, Frank Schäfer
fschaefer@googlemail.com wrote:
This adds support for the UB435-Q V2. It seems that you might need to
use the device once with the official driver to reprogram the device
descriptors. Thanks
.
Or the other way around: wouldn't TDA18271_GATE_DIGITAL also work for
the A340 ?
Apart from that:
Reviewed-by: Frank Schäfer fschaefer@googlemail.com
Regards,
Frank
+};
+
+
static struct zl10353_config em28xx_zl10353_xc3028_no_i2c_gate = {
.demod_address = (0x1e 1),
.no_tuner = 1
Am 10.10.2013 15:50, schrieb Guennadi Liakhovetski:
Hi Frank,
On Thu, 10 Oct 2013, Frank Schäfer wrote:
Am 08.10.2013 18:38, schrieb Guennadi Liakhovetski:
Hi Frank,
On Tue, 8 Oct 2013, Frank SchÀfer wrote:
Am 18.08.2013 17:20, schrieb Mauro Carvalho Chehab:
Em Sun, 18 Aug 2013 13:40
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
include/media/v4l2-ctrls.h |2 +-
1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
index 47ada23..16f7f26 100644
--- a/include/media/v4l2-ctrls.h
Sorry, there is no PATCH 2/2, this one is the only one. :)
Frank
Am 10.10.2013 19:21, schrieb Frank Schäfer:
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
include/media/v4l2-ctrls.h |2 +-
1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
diff --git
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 102 +++
drivers/media/usb/em28xx/em28xx-dvb.c | 16 ++---
2 Dateien geändert, 59 Zeilen hinzugefügt(+), 59 Zeilen entfernt(-)
diff --git a/drivers/media/usb
Increase the streaming_users count only if streaming start succeeds.
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
Cc: sta...@kernel.org
---
drivers/media/usb/em28xx/em28xx-video.c |7 ---
1 Datei geändert, 4 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-)
diff --git a/drivers
Am 10.10.2013 19:50, schrieb Guennadi Liakhovetski:
On Thu, 10 Oct 2013, Frank Schäfer wrote:
Am 10.10.2013 15:50, schrieb Guennadi Liakhovetski:
Hi Frank,
On Thu, 10 Oct 2013, Frank Schäfer wrote:
Am 08.10.2013 18:38, schrieb Guennadi Liakhovetski:
Hi Frank,
On Tue, 8 Oct 2013, Frank
Am 10.10.2013 20:38, schrieb Frank Schäfer:
[...]
Hmm... your patch didn't change this, but:
Why do we call these functions only in case of V4L2_BUF_TYPE_VIDEO_CAPTURE
?
Isn't it needed for VBI capturing, too ?
em28xx_wake_i2c() is probably also needed for radio mode...
Right, my patch
-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-video.c | 17 +++--
1 Datei geändert, 11 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb/em28xx/em28xx-video.c
index fc5d60e
Am 18.08.2013 17:20, schrieb Mauro Carvalho Chehab:
Em Sun, 18 Aug 2013 13:40:25 +0200
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 17.08.2013 12:51, schrieb Guennadi Liakhovetski:
Hi Frank,
As I mentioned on the list, I'm currently on a holiday, so, replying
briefly.
Sorry, I
you please elaborate on this ?
What's the official driver and what changes after using it ?
Are these changes permanent ?
The commit message should be included in the patch and not be sent as a
separate message.
Can you fix the patch and resend it ?
Regards,
Frank Schäfer
Jean-Francois Thibert (1
Hi Guennadi,
thank you for looking at this. A few thoughts:
Am 05.09.2013 15:11, schrieb Guennadi Liakhovetski:
The em28xx USB driver powers off its subdevices, by calling their .s_power()
methods to save power, but actually never powers them on. Apparently this
works with currently used
Am 09.09.2013 19:27, schrieb Frank Schäfer:
Am 05.09.2013 17:57, schrieb Guennadi Liakhovetski:
On Thu, 5 Sep 2013, Mauro Carvalho Chehab wrote:
Rewriting that part of the code would require to test the changes on
several hundreds of different devices, and even if you find someone
with all
Am 05.09.2013 17:57, schrieb Guennadi Liakhovetski:
On Thu, 5 Sep 2013, Mauro Carvalho Chehab wrote:
Em Thu, 05 Sep 2013 17:22:36 +0200
Frank Schäfer fschaefer@googlemail.com escreveu:
Hi Guennadi,
sorry for delayed replies, I'm currently burried under lots of stuff
with a higher
Hi Guennadi,
sorry for delayed replies, I'm currently burried under lots of stuff
with a higher priority...
Am 03.09.2013 08:34, schrieb Guennadi Liakhovetski:
Hi Frank
Thanks for testing! Let's have a look then:
On Mon, 2 Sep 2013, Frank Schäfer wrote:
Am 28.08.2013 15:28, schrieb
Sorry for the delayed reply.
A few remarks:
Am 27.08.2013 14:52, schrieb Laurent Pinchart:
...
Even if the bridge doesn't control the clock, it provides a clock to the
sensor. As such, it's the responsibility of the bridge driver to provide the
clock to the sensor driver. The sensor
Am 28.08.2013 15:28, schrieb Guennadi Liakhovetski:
This patch series adds a V4L2 clock support to em28xx with an ov2640
sensor. Only compile tested, might need fixing, please, test.
Guennadi Liakhovetski (3):
V4L2: add v4l2-clock helpers to register and unregister a fixed-rate
clock
Hi Guennadi,
Am 30.08.2013 12:30, schrieb Guennadi Liakhovetski:
Hi Frank,
On Fri, 23 Aug 2013, Frank Schäfer wrote:
Hi Sylwester,
Am 21.08.2013 23:42, schrieb Sylwester Nawrocki:
Hi Frank,
On 08/21/2013 10:39 PM, Frank Schäfer wrote:
Am 20.08.2013 18:34, schrieb Frank Schäfer:
Am
Hi Laurent,
Am 21.08.2013 23:20, schrieb Laurent Pinchart:
Hi Frank,
On Wednesday 21 August 2013 22:45:17 Frank Schäfer wrote:
commit 9aea470b soc-camera: switch I2C subdevice drivers to use v4l2-clk
made a v4l2_clk mandatory for each sensor.
While this isn't necessary, it also broke
Hi Sylwester,
Am 21.08.2013 23:42, schrieb Sylwester Nawrocki:
Hi Frank,
On 08/21/2013 10:39 PM, Frank Schäfer wrote:
Am 20.08.2013 18:34, schrieb Frank Schäfer:
Am 20.08.2013 15:38, schrieb Laurent Pinchart:
Hi Mauro,
On Sunday 18 August 2013 12:20:08 Mauro Carvalho Chehab wrote:
Em Sun
Am 20.08.2013 18:34, schrieb Frank Schäfer:
Am 20.08.2013 15:38, schrieb Laurent Pinchart:
Hi Mauro,
On Sunday 18 August 2013 12:20:08 Mauro Carvalho Chehab wrote:
Em Sun, 18 Aug 2013 13:40:25 +0200 Frank Schäfer escreveu:
Am 17.08.2013 12:51, schrieb Guennadi Liakhovetski:
Hi Frank,
As I
commit 9aea470b soc-camera: switch I2C subdevice drivers to use v4l2-clk
made a v4l2_clk mandatory for each sensor.
While this isn't necessary, it also broke the em28xx driver in connection
with ov2640 subdevices and maybe other drivers outside soc_camera as well.
Signed-off-by: Frank Schäfer
Am 20.08.2013 15:38, schrieb Laurent Pinchart:
Hi Mauro,
On Sunday 18 August 2013 12:20:08 Mauro Carvalho Chehab wrote:
Em Sun, 18 Aug 2013 13:40:25 +0200 Frank Schäfer escreveu:
Am 17.08.2013 12:51, schrieb Guennadi Liakhovetski:
Hi Frank,
As I mentioned on the list, I'm currently
Am 20.08.2013 17:31, schrieb Mauro Carvalho Chehab:
Em Tue, 20 Aug 2013 15:38:57 +0200
Laurent Pinchart laurent.pinch...@ideasonboard.com escreveu:
Hi Mauro,
On Sunday 18 August 2013 12:20:08 Mauro Carvalho Chehab wrote:
Em Sun, 18 Aug 2013 13:40:25 +0200 Frank Schäfer escreveu:
Am
-
From: Frank Schäfer fschaefer@googlemail.com
To: Guennadi Liakhovetski g.liakhovet...@gmx.de, Linux Media Mailing List
linux-media@vger.kernel.org
Sent: Fr., 16 Aug 2013 21:03
Subject: em28xx + ov2640 and v4l2-clk
Hi Guennadi,
since commit 9aea470b399d797e88be08985c489855759c6c60 soc
Hi Guennadi,
since commit 9aea470b399d797e88be08985c489855759c6c60 soc-camera:
switch I2C subdevice drivers to use v4l2-clk, the em28xx driver fails
to register the ov2640 subdevice (if needed).
The reason is that v4l2_clk_get() fails in ov2640_probe().
Does the em28xx driver have to register a
Am 28.07.2013 16:05, schrieb Devin Heitmueller:
On Sun, Jul 28, 2013 at 9:58 AM, Chris Rankin ranki...@yahoo.com wrote:
- Original Message -
From: Devin Heitmueller dheitmuel...@kernellabs.com
The amount of output is not inconsistent with most other linuxtv drivers
though.
It's
EM28XX_CHIPCFG_AUDIOMASK) = 0x30, and the if - else if
statements compares this with ==.
So how can 0x30 be 0x20 ???
Regards,
Frank
2013/7/18 Frank Schäfer fschaefer@googlemail.com
mailto:fschaefer@googlemail.com
Am 17.07.2013 01:05, schrieb Alban Browaeys
.
D[1:0] USB Max Power Select
00 – USB Max Power 500 mA
01 – USB Max Power 400 mA
10 – USB Max Power 300 mA
11 – USB Max Power 200 mA
But you current code attempt to read the usb configuration 09H .
2013/7/18 Frank Schäfer fschaefer@googlemail.com
@@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned
bus,
*eedata = data;
*eedata_len = len;
- dev_config = (void *)eedata;
+ dev_config = (void *)*eedata;
switch (le16_to_cpu(dev_config-chip_conf) 4 0x3) {
case 0:
Signed-off-by: Frank Schäfer
Am 17.07.2013 01:05, schrieb Alban Browaeys:
As:
EM28XX_CHIPCFG_I2S_3_SAMPRATES 0x20
EM28XX_CHIPCFG_I2S_5_SAMPRATES 0x30
the board chipcfg is 0xf0 thus if 3_SAMPRATES is tested
first and matches while it is a 5_SAMPRATES.
Signed-off-by: Alban Browaeys pra...@yahoo.com
---
Am 17.07.2013 01:06, schrieb Alban Browaeys:
According to the em2860 datasheet, eeprom byte 08H is Chip
Configuration Low Byte and 09H is High Byte.
Usb power configuration is in the Low byte (same as the usb audio
class config).
Signed-off-by: Alban Browaeys pra...@yahoo.com
---
Am 18.07.2013 17:51, schrieb Antti Palosaari:
On 07/18/2013 06:13 PM, Frank Schäfer wrote:
Am 17.07.2013 00:57, schrieb Alban Browaeys:
Set the config structure pointer to the eeprom data pointer (data,
here eedata dereferenced) not the pointer to the pointer to
the eeprom data (eedata itself
of extending the caching, get rid of it, because it has no real
benefits and just bloats/complicates the code.
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 12
drivers/media/usb/em28xx/em28xx-core.c | 27
201 - 300 of 801 matches
Mail list logo
