[PATCH v2 1/2] media: ov2680: don't register the v4l2 subdevice before checking chip ID

Signed-off-by: Javier Martinez Canillas --- Changes in v2: - Just move ov2680_check_id() before ov2680_v4l2_init() - Suggested by Sakari. drivers/media/i2c/ov2680.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/ov2680.c b/drivers/media/i2c/ov26

Re: [PATCH] media: ov2680: register the v4l2 subdev async at the end of probe

Hi Sakari, Thanks for the feedback. On 09/01/2018 01:46 PM, Sakari Ailus wrote: > Hi Javier, > > On Fri, Aug 31, 2018 at 05:19:06PM +0200, Javier Martinez Canillas wrote: >> The driver registers the subdev async in the middle of the probe function >> but this has to be

Re: [PATCH 18/22] partial revert of "[media] tvp5150: add HW input connectors support"

Hi Marco, On 08/01/2018 05:49 PM, Marco Felsch wrote: > Hi Javier, > > On 18-07-31 15:30, Marco Felsch wrote: >> Hi Javier, >> >> On 18-07-31 14:52, Javier Martinez Canillas wrote: >>> Hi Marco, >>> >>> On 07/31/2018 02:36 PM, Marco Felsch wr

Re: [PATCH 18/22] partial revert of "[media] tvp5150: add HW input connectors support"

y I said that the output port should be the first one in your enum tvp5150_ports and not the last one. > Regards, > Marco > Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat

Re: [PATCH 18/22] partial revert of "[media] tvp5150: add HW input connectors support"

Hi Mauro, On 07/31/2018 12:06 PM, Mauro Carvalho Chehab wrote: > Em Tue, 31 Jul 2018 10:52:56 +0200 > Javier Martinez Canillas escreveu: > >> Hello Mauro, >> >> On 07/30/2018 08:18 PM, Mauro Carvalho Chehab wrote: >>> Em Thu, 28 Jun 2018 18:20

Re: [PATCH 18/22] partial revert of "[media] tvp5150: add HW input connectors support"

Hello Mauro, On 07/30/2018 08:18 PM, Mauro Carvalho Chehab wrote: > Em Thu, 28 Jun 2018 18:20:50 +0200 > Marco Felsch escreveu: > >> From: Javier Martinez Canillas >> >> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") >>

Re: Software-only image processing for Intel "complex" cameras

Hi Mauro, On Mon, Jun 25, 2018 at 3:10 PM, Mauro Carvalho Chehab wrote: > Em Mon, 25 Jun 2018 09:48:56 + > "Zheng, Jian Xu" escreveu: > >> Hi Mauro, >> >> > -Original Message- >> > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >> > ow...@vger.kernel.org] On Behalf Of

Re: Devices with a front and back webcam represented as a single UVC device

Hi Laurent, On Thu, Jul 12, 2018 at 3:01 PM, Laurent Pinchart wrote: [snip] >> >> Laurent, thank you for your input on this. I thought it was a bit weird that >> the cam on my HP X2 only had what appears to be the debug controls, so I >> opened it up and as I suspect (after your analysis) it

Re: [PATCH 00/21] TVP5150 fixes and new features

2]. > Thanks for working on this! I've felt guilty that I never re-worked my patch-set after the discussion from [2]. I'll try to review these patches next week. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

subdev8 pad0: Sink pad1: Source [fmt:UYVY2X8/720x240 field:alternate crop.bounds:(0,0)/720x480 crop:(0,0)/720x480] -> "OMAP3 ISP CCDC":0 [ENABLED] Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat

Re: [ANN v2] Complex Camera Workshop - Tokyo - Jun, 19

egrate them in a particular camera stack, and should be as >> platform-agnostic as possible. >> >> In the case of the Android camera HAL, ideally it would be a glue that >> could be used with different camera vendors (probably with some kind of >> vendor-specific configuration

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

On Thu, May 31, 2018 at 4:19 PM, Hans Verkuil wrote: > On 05/31/18 15:58, Hans Verkuil wrote: >> On 05/31/18 15:22, Mauro Carvalho Chehab wrote: >>> Em Mon, 28 May 2018 10:43:51 -0300 >>> Mauro Carvalho Chehab escreveu: >>> Em Thu, 17 May 2018 16:07:08 -0300 Mauro Carvalho Chehab

Re: [RESEND PATCH] partial revert of "[media] tvp5150: add HW input connectors support"

Hello Mauro, On 12/14/2017 06:02 PM, Mauro Carvalho Chehab wrote: > Em Wed, 6 Dec 2017 01:33:05 +0100 > Javier Martinez Canillas <javi...@redhat.com> escreveu: > >> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") >> added

[RESEND PATCH] partial revert of "[media] tvp5150: add HW input connectors support"

nly anymore. But all the code related to the DT parsing logic and input entities creation are removed. Suggested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Javier Martinez Canillas <javi...@redhat.com> Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboa

Re: [RFT PATCH] [media] partial revert of "[media] tvp5150: add HW input connectors support"

Hello Philipp, On Thu, Aug 17, 2017 at 3:05 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > Hi, > > On Tue, 2016-12-13 at 12:39 -0300, Javier Martinez Canillas wrote: >> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") >> added

Re: [PATCH 2/3] leds: as3645a: Add LED flash class driver

Hello Sakari, I haven't looked at the driver, but just have a comment about the I2C subsystem. On Wed, Aug 16, 2017 at 2:55 PM, Sakari Ailus wrote: [snip] > + > +static const struct of_device_id as3645a_of_table[] = { > + { .compatible = "ams,as3645a" }, >

Re: [PATCH] media: i2c: adv748x: Export I2C device table entries as module aliases

On 08/09/2017 01:05 PM, Kieran Bingham wrote: > On 09/08/17 11:58, Javier Martinez Canillas wrote: >> Hi Kieran, >> >> On 08/09/2017 12:29 PM, Kieran Bingham wrote: >>> Hi Javier, >>> >>> Thankyou for the patch >> >> You are welcome

Re: [PATCH] media: i2c: adv748x: Export I2C device table entries as module aliases

Hi Kieran, On 08/09/2017 12:29 PM, Kieran Bingham wrote: > Hi Javier, > > Thankyou for the patch > You are welcome. > On 09/08/17 10:37, Javier Martinez Canillas wrote: >> The I2C core always reports a MODALIAS of the form i2c: even if the >> device was regist

[PATCH] media: i2c: adv748x: Export I2C device table entries as module aliases

/adv748x/adv748x.ko | grep alias alias: of:N*T*Cadi,adv7482C* alias: of:N*T*Cadi,adv7482 alias: of:N*T*Cadi,adv7481C* alias: of:N*T*Cadi,adv7481 alias: i2c:adv7482 alias: i2c:adv7481 Signed-off-by: Javier Martinez Canillas <javi...@redhat.

Re: [PATCH] media: vimc: cleanup a few warnings

On Thu, Jul 13, 2017 at 5:47 PM, Javier Martinez Canillas <jav...@dowhile0.org> wrote: > On Thu, Jul 13, 2017 at 5:38 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: [snip] >> >> Shouldn't these be set to the corresponding driver structs' id_table >&g

[PATCH] [media] vimc: set id_table for platform drivers

vimc_sen_driver_ids[] = { ^~~ Reported-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Suggested-by: Sakari Ailus <sakari.ai...@iki.fi> Signed-off-by: Javier Martinez Canillas <javi...@redhat.com> --- drivers/media/

Re: [PATCH] media: vimc: cleanup a few warnings

On Thu, Jul 13, 2017 at 5:38 PM, Sakari Ailus wrote: [snip] >> >> -static const struct platform_device_id vimc_sen_driver_ids[] = { >> +static const __maybe_unused >> +struct platform_device_id vimc_sen_driver_ids[] = { >> { >> .name =

Re: [RFC 00/10] V4L2 explicit synchronization support

Hello Gustavo, On 04/06/2017 10:08 AM, Gustavo Padovan wrote: > Hi Javier, > > 2017-04-05 Javier Martinez Canillas <jav...@osg.samsung.com>: > >> Hello Gustavo, >> >> On 04/05/2017 11:09 AM, Gustavo Padovan wrote: >>> 2017-04-03 Javier Martinez Cani

Re: [RFC 00/10] V4L2 explicit synchronization support

Hello Gustavo, On 04/05/2017 11:09 AM, Gustavo Padovan wrote: > 2017-04-03 Javier Martinez Canillas <jav...@osg.samsung.com>: > >> Hello Mauro and Gustavo, >> >> On 04/03/2017 07:16 AM, Mauro Carvalho Chehab wrote: >>> Hi Gustavo, >>> >>&g

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

Hello Philipp, On Wed, Apr 5, 2017 at 5:34 AM, Philipp Zabel wrote: > On Wed, 2017-04-05 at 09:21 +0100, Russell King - ARM Linux wrote: [snip] > I think the output part is accurate, as the audio pad is an artifact of > an unrelated change. I'm not so sure about the VBI

Re: [RFC 00/10] V4L2 explicit synchronization support

f we do that, then fences will be per fence since the dma-buf/reservation objet are also per fence in v4l2/vb2. > >> * other open topics are how to deal with hw-fences and Request API. > > Let's not mix issues here. Request API is already complex enough > without explicit fences. The same is true for explicit fences: it is > also complex to add support for it with multi-planes and a not > ordered DQ. > > So, my suggestion here is to not delay Request API due to fences, > nor to delay fences due to Request API, letting them to be merged > on different Kernel releases. When both features got added, someone > can work on a patchset that would allow using Request API with fences. > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [RFC 03/10] [media] vb2: add in-fence support to QBUF

!= VB2_MEMORY_DMABUF) > + return -EINVAL; > + I wonder if is correct to check this. Only one side of the pipeline uses V4L2_MEMORY_DMABUF while the other uses V4L2_MEMORY_MMAP + VIDIOC_EXPBUF. So that means that fences can only be used in one direction? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH v2 00/15] Exynos MFC v6+ - remove the need for the reserved memory

Hello Marian, On Wed, Mar 15, 2017 at 9:00 AM, Marian Mihailescu wrote: > Thanks for the quick reply. > > Decoding works without issues for me too. > I did not change the CMA size or used s5p_mfc.mem parameter. However, > according to the Marek, the default 8M should be

Re: [PATCH v2 00/15] Exynos MFC v6+ - remove the need for the reserved memory

Hello Marian, On Wed, Mar 15, 2017 at 8:36 AM, Marian Mihailescu wrote: > Hi, > > After testing these patches, encoding using MFC fails when requesting > buffers for capture (it works for output) with ENOMEM (it complains it > cannot allocate memory on bank1). > Did

Re: [PATCH] media: mfc: Fix race between interrupt routine and device functions

9a7bb83f0d8 ]--- > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > Fixes: af93574678108 ("[media] MFC: Add MFC 5.1 V4L2 driver") > CC: sta...@vger.kernel.org # v4.5+ > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH] [media] exynos4-is: Add missing 'of_node_put'

gt; > Thanks for the patch, but Krzysztof sent the exact same patch before [0]. There was feedback from Sylwester at the time that you can also look at [0]. Could you please take that into account and post a patch according to what he suggested? [0]: http://lists.infradead.org/pipermail

Re: [PATCH 2/2] media: s5p-mfc: fix MMAP of mfc buffer during reqbufs

hat case both the left and right device is treated as mfc0 only. > I see, so likely you were facing the issue described in patch 1/2 after this patch since the driver doesn't set alloc_devs when IOMMU is disabled, right? In any case, I guess these patches have been superseded by Marek's se

Re: [PATCH 1/2] media: s5p-mfc: convert drivers to use the new vb2_queue dev field

; > q->ops = get_dec_queue_ops(); > Please correct me if I'm wrong, but AFAIU this shouldn't be needed in the s5p-mfc driver since the videobuf2 core either uses the vb2_queue .dev field or the vb2_queue .alloc_devs. And the latter is set in the s5p_mfc_queue_setup() function, so the .dev field shouldn't be used. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table

change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/i2c/soc_camera/ov5642.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers

[PATCH 2/3] [media] tc358743: Add OF device ID table

change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/i2c/tc358743.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/med

[PATCH 3/3] [media] si4713: Add OF device ID table

change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/radio/si4713/si4713.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers

[PATCH] [media] et8ek8: Export OF device ID as module aliases

-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/i2c/et8ek8/et8ek8_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c b/drivers/media/i2c/et8ek8/et8ek8_driver.c index bec4a563a09c..f39f5179dd95 100644 --- a/drivers/media/i2c/

Re: [PATCH v2 08/15] media: s5p-mfc: Move firmware allocation to DMA configure function

irmware() call > from the s5p_mfc_probe() function to the s5p_mfc_configure_dma_memory(). > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 14/15] media: s5p-mfc: Use preallocated block allocator always for MFC v6+

Hello Marek, On 02/20/2017 10:23 AM, Marek Szyprowski wrote: > Hi Javier, > > On 2017-02-17 22:13, Javier Martinez Canillas wrote: >> On 02/14/2017 04:52 AM, Marek Szyprowski wrote: >>> It turned out that all versions of MFC v6+ hardware doesn't have a strict >>

Re: [PATCH 00/15] Exynos MFC v6+ - remove the need for the reserved memory

2dec capture-io-mode=dmabuf ! v4l2video0convert \ output-io-mode=dmabuf-import capture-io-mode=dmabuf ! kmssink Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 15/15] ARM: dts: exynos: Remove MFC reserved buffers

Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 14/15] media: s5p-mfc: Use preallocated block allocator always for MFC v6+

v6+ devices in device tree. Now the driver is fully > functional without them. > Great! > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- The patch looks good to me though and it works on my tests, I've just one comment below. Reviewed-by: Javier Martinez Canil

Re: [PATCH 13/15] media: s5p-mfc: Remove special configuration of IOMMU domain

gt; specific DMA-mapping and IOMMU glue code functions. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, --

Re: [PATCH 12/15] media: s5p-mfc: Add support for probe-time preallocated block based allocator

er to force larger (or smaller) buffer (for example by adding > "s5p_mfc.mem=16M" to kernel command line). > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Mart

Re: [PATCH 11/15] media: s5p-mfc: Split variant DMA memory configuration into separate functions

ng > @@ -1188,26 +1160,74 @@ static int s5p_mfc_configure_dma_memory(struct > s5p_mfc_dev *mfc_dev) > DMA_BIT_MASK(32)); > vb2_dma_contig_set_max_seg_size(mfc_dev->mem_dev[BANK2_CTX], > DMA_BIT_MASK(32

Re: [PATCH 10/15] media: s5p-mfc: Reduce firmware buffer size for MFC v6+ variants

arek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 09/15] media: s5p-mfc: Allocate firmware with internal private buffer alloc function

> patches. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 08/15] media: s5p-mfc: Move firmware allocation to DMA configure function

? Also, ret is not declared so this patch will cause a compile error, breaking git bisect-ability. > + return ret; > + > + mfc_dev->dma_base[BANK1_CTX] = mfc_dev->fw_buf.dma; Same comment than before, probably you wanted to use fw_buf->dma here? The rest of the patch looks good to me. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 07/15] media: s5p-mfc: Put firmware to private buffer structure

Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 06/15] media: s5p-mfc: Move setting DMA max segmetn size to DMA configure function

m> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 05/15] media: s5p-mfc: Simplify alloc/release private buffer functions

d-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 01/15] media: s5p-mfc: Remove unused structures and dead code

Hello Marek, On 02/14/2017 04:51 AM, Marek Szyprowski wrote: > Remove unused structures, definitions and functions that are no longer > called from the driver code. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas &l

Re: [PATCH 02/15] media: s5p-mfc: Use generic of_device_get_match_data helper

Hello Marek, On 02/14/2017 04:51 AM, Marek Szyprowski wrote: > Replace custom code with generic helper to retrieve driver data. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by:

Re: [PATCH 04/15] media: s5p-mfc: Replace bank1/bank2 entries with an array

fy > code in the next patches. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 03/15] media: s5p-mfc: Replace mem_dev_* entries with an array

ll > help to simplify code in the next patches. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Jav

Re: [PATCH] media: s5p-mfc: Fix initialization of internal structures

gt; > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Also tested on an Exynos5422 Odroid XU4 and Exynos5800 Peach Pi: Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 0/2] [media] exynos-gsc: Fix support for NV21 and NV61 formats

Hello Sylwester, On 02/13/2017 11:34 AM, Sylwester Nawrocki wrote: > Hi Javier, > > On 02/13/2017 01:53 PM, Javier Martinez Canillas wrote: >> Any comments on this series? > > The patches look good to me, I will Ack the patches in case > Mauro wants to apply them di

Re: [PATCH 0/2] [media] exynos-gsc: Fix support for NV21 and NV61 formats

Hello, On Wed, Feb 1, 2017 at 5:05 PM, Javier Martinez Canillas <jav...@osg.samsung.com> wrote: > Hello, > > Commit 652bb68018a5 ("[media] exynos-gsc: do proper bytesperline and > sizeimage calculation") fixed corrupted frames for most exynos-gsc > formats, but e

Re: [PATCH] [media] exynos-gsc: Avoid spamming the log on VIDIOC_TRY_FMT

Hello Shuah, On 02/01/2017 11:25 PM, Shuah Khan wrote: > On 01/24/2017 02:42 PM, Javier Martinez Canillas wrote: >> There isn't an ioctl to enum the supported field orders, so a user-space >> application can call VIDIOC_TRY_FMT using different field orders to know >>

[PATCH 2/2] [media] exynos-gsc: Add support for NV{16,21,61}M pixel formats

From: Thibault Saunier <thibault.saun...@osg.samsung.com> Those are useful formats that should be handled. Signed-off-by: Thibault Saunier <thibault.saun...@osg.samsung.com> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/platform/exynos-g

[PATCH 0/2] [media] exynos-gsc: Fix support for NV21 and NV61 formats

Hello, Commit 652bb68018a5 ("[media] exynos-gsc: do proper bytesperline and sizeimage calculation") fixed corrupted frames for most exynos-gsc formats, but even after that patch two issues were still remaining: 1) Frames were still not correct for NV21 and NV61 formats. 2) Y42B format didn't

[PATCH 1/2] [media] exynos-gsc: Do not swap cb/cr for semi planar formats

las.dufre...@collabora.com> Signed-off-by: Thibault Saunier <thibault.saun...@osg.samsung.com> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/platform/exynos-gsc/gsc-core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platfo

[PATCH] [media] exynos-gsc: Avoid spamming the log on VIDIOC_TRY_FMT

] Not supported field order(4) Instead of printing this as an error, just keep it as debug information. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/platform/exynos-gsc/gsc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

Hello Steve, On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: > From: Philipp Zabel [snip] > > +config VIDEO_MULTIPLEXER > + tristate "Video Multiplexer" > + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER The driver can

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

CLK_IS_CRITICAL. So please also ignore my clk patch. Sorry for the noise and the mess with these patches. Thought I also tested on linux-next to see if the issue was solved there, but it seems I didn't. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To un

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

Hello, On 01/20/2017 07:06 AM, Javier Martinez Canillas wrote: > Hello Marek, > > On 01/20/2017 05:37 AM, Marek Szyprowski wrote: > > [snip] >> >> Please send this patch instead of adding more clocks to the power domains. >> This way we will avoid adding more

Re: [PATCH v2 2/2] [media] exynos-gsc: Only reset the GSC HW on probe() if !CONFIG_PM

Hello, On 01/19/2017 07:36 PM, Javier Martinez Canillas wrote: > Commit 15f90ab57acc ("[media] exynos-gsc: Make driver functional when > CONFIG_PM is unset") removed the implicit dependency that the driver > had with CONFIG_PM, since it relied on the config option to be ena

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

t want to mark more clocks as CLK_IGNORE_UNUSED or CLK_IS_CRITICAL but I agree this can be done as a temporary workaround until a proper runtime PM based solution gets merged. > Best regards Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscrib

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

urned on (like > IOMMU integration), so marking them as critical solves that problem too. > Ok, I understand your point. > Best regards Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/2] [media] exynos-gsc: Fix unbalanced pm_runtime_enable() error

gement at ->remove()") Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Acked-by: Marek Szyprowski <m.szyprow...@samsung.com> --- Changes in v2: - Added Marek Szyprowski's Acked-by tag. drivers/media/platform/exynos-gsc/gsc-core.c | 1 + 1 file changed, 1 in

[PATCH v2 2/2] [media] exynos-gsc: Only reset the GSC HW on probe() if !CONFIG_PM

he runtime resume callback had to be executed on the probe function. But there's no need to do this if CONFIG_PM is enabled, since in this case the runtime PM resume callback will be called by VIDIOC_STREAMON ioctl, so the resume handler will call the GSC HW reset function. Signed-off-by: Javie

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

Hello Marek, On 01/19/2017 11:56 AM, Javier Martinez Canillas wrote: > On 01/19/2017 11:17 AM, Marek Szyprowski wrote: [snip] > > Also when removing the exynos_gsc driver, I get the same error: > > # rmmod s5p_mfc > [ 106.405972] s5p-mfc 1100.codec: Removing 11

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

Hello Marek, Thanks a lot for your feedback. On 01/19/2017 11:17 AM, Marek Szyprowski wrote: > Hi Javier, > > On 2017-01-18 01:30, Javier Martinez Canillas wrote: >> Commit 15f90ab57acc ("[media] exynos-gsc: Make driver functional when >> CONFIG_PM is unset")

Re: [PATCH 1/2] [media] exynos-gsc: Fix unbalanced pm_runtime_enable() error

Hello Marek, On 01/19/2017 11:12 AM, Marek Szyprowski wrote: > Hi Javier, > > On 2017-01-18 01:30, Javier Martinez Canillas wrote: >> Commit a006c04e6218 ("[media] exynos-gsc: Fixup clock management at >> ->remove()") changed the driver's

[PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

the reset in probe unneeded. Fixes: 15f90ab57acc ("[media] exynos-gsc: Make driver functional when CONFIG_PM is unset") Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- I-ve only tested with CONFIG_PM enabled since my Exynos5422 Odroid XU4 board fails to b

[PATCH 1/2] [media] exynos-gsc: Fix unbalanced pm_runtime_enable() error

gement at ->remove()") Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/platform/exynos-gsc/gsc-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c index c

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

are gone. I understand that's what Sakari's RFC patches do. I'll try to make some time tomorrow to test and review his patches. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-media"

[RFT PATCH] [media] partial revert of "[media] tvp5150: add HW input connectors support"

nly anymore. But all the code related to the DT parsing logic and input entities creation are removed. Suggested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- Hello Laurent, I've tested this patch on

Re: [PATCH v2 0/6] Fix tvp5150 regression with em28xx

rking for both composite input AIP1A (after changing the hardcoded selected input) and AIP1B. The patches also look good to me, so please feel free to add my Reviewed-by and Tested-by tags on these. I wasn't able to test S-Video since my S-Video source broke (an old DVD player) but this never wor

Re: [PATCH v6 0/5] davinci: VPIF: add DT support

Hello Kevin, On Wed, Dec 7, 2016 at 3:30 PM, Kevin Hilman wrote: > Prepare the groundwork for adding DT support for davinci VPIF drivers. > This series does some fixups/cleanups and then adds the DT binding and > DT compatible string matching for DT probing. > > The

Re: [PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay

t; different. We are not interested in matching the pointer, what we > want to match is that the path is the one we are expecting. Change to > use of_node_cmp() so that we continue matching after the overlay has > been removed and reapplied. > > Cc: Mauro Carvalho Chehab &l

Re: [GIT PULL] Samsung fixes for 4.8

any of the patches in the media/v4.9-2 tag to be merged in v4.9-rc7. >> Oops, sorry, I didn't check it properly. Would be nice to see that >> patch also in linux-next. > > I'll likely add all patches at linux-next today, after handling more > patches. > > Thanks, >

Re: [PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

port { cam_ep: endpoint { ... }; }; }; } } > Cc: Mauro Carvalho Chehab <mche...@kernel.org> > Cc: Javier Martinez Canillas <jav...@osg.samsu

Re: [RFC PATCH v2 1/2] [media] tvp5150: Add input connectors DT bindings

[adding Kevin as cc since he was interested in this feature as well] Hello Hans, On 11/11/2016 01:11 PM, Hans Verkuil wrote: > This old mail came up in a discussion today so let me comment on this: > Thanks a lot for the feedback. > On 04/27/2016 09:12 PM, Javier Martinez Canil

Re: [RFC PATCH 6/6] [media] davinci: vpif_capture: get subdevs from DT

On Fri, Nov 11, 2016 at 12:50 PM, Javier Martinez Canillas <jav...@dowhile0.org> wrote: [snip] > So if you can comment on this and see if the DT bindings fits your, > would be very useful. > Sorry, I wanted to write "if the DT bindings fits your needs, it would be very us

Re: [RFC PATCH 6/6] [media] davinci: vpif_capture: get subdevs from DT

Hello, On Fri, Nov 11, 2016 at 12:36 PM, Hans Verkuil wrote: > On 10/26/2016 01:55 AM, Kevin Hilman wrote: >> First pass at getting subdevs from DT ports and endpoints. >> >> The _get_pdata() function was larely inspired by (i.e. stolen from) >> am437x-vpfe.c >> >> Questions:

Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver

Hello Hans, On Fri, Nov 11, 2016 at 8:49 AM, Hans Verkuil wrote: > Hi Stanimir, > > Overall it looks good. As you saw, I do have some comments but nothing major. > > One question: you use qcom as the directory name. How about using qualcomm? > > It's really not that much

Re: [PATCH 1/2] exynos-gsc: Enable driver on ARCH_EXYNOS

ds on HAS_DMA > select VIDEOBUF2_DMA_CONTIG > select V4L2_MEM2MEM_DEV > Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung

Re: [PATCH 2/2] exynos-gsc: Add support for Exynos5433 specific version

(Exynos 5433) I would also add 5800 to the list. Besides these minor comments, the patch looks good to me: Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> And I've also tested in an Exynos5800 Peach Pi Chromebook: Tested-by: Javier Martinez Canillas <jav...@osg.samsu

Re: [PATCH 00/12] media: Exynos GScaller driver fixes

ext branch: git://linuxtv.org/snawrocki/samsung.git for-v4.10/media/next So feel free to add for the whole series: Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this li

Re: [Patch 20/35] media: ti-vpe: vpe: Added MODULE_DEVICE_TABLE hint

Hello Benoit, On Wed, Sep 28, 2016 at 5:22 PM, Benoit Parrot <bpar...@ti.com> wrote: > ti_vpe module currently does not get loaded automatically. > Added MODULE_DEVICE_TABLE hint to the driver to assist. > > Signed-off-by: Benoit Parrot <bpar...@ti.com> > --- R

[PATCH 4/5] [media] s5p-cec: Fix module autoload

drivers/staging/media/s5p-cec/s5p-cec.ko | grep alias $ After this patch: $ modinfo drivers/staging/media/s5p-cec/s5p-cec.ko | grep alias alias: of:N*T*Csamsung,s5p-cecC* alias: of:N*T*Csamsung,s5p-cec Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- d

[PATCH 5/5] [media] st-cec: Fix module autoload

drivers/staging/media//st-cec/stih-cec.ko | grep alias $ After this patch: $ modinfo drivers/staging/media//st-cec/stih-cec.ko | grep alias alias: of:N*T*Cst,stih-cecC* alias: of:N*T*Cst,stih-cec Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/s

[PATCH 3/5] [media] rc: meson-ir: Fix module autoload

: of:N*T*Camlogic,meson6-irC* alias: of:N*T*Camlogic,meson6-ir Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/rc/meson-ir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/rc/meson-ir.c b/drivers/media/rc/meson-ir.c

[PATCH 0/5] [media] Fix module autoload for media platform drivers

Hello Mauro, I noticed that module autoload won't be working in a bunch of media platform drivers because the module alias information is not filled in the modules. This patch series contains the fixes for them. Best regards, Javier Javier Martinez Canillas (5): [media] v4l: vsp1: Fix module

[PATCH 2/5] [media] v4l: rcar-fcp: Fix module autoload for OF registration

: of:N*T*Crenesas,fcpf Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/platform/rcar-fcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/rcar-fcp.c b/drivers/media/platform/rcar-fcp.c index f3a3f31cdfa9..7146fc5ef168

[PATCH 1/5] [media] v4l: vsp1: Fix module autoload for OF registration

: of:N*T*Crenesas,vsp1 Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/platform/vsp1/vsp1_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c index 57c713a4e1df..aa237b

[PATCH 3/3] [media] exynos-gsc: cleanup m2m src and dst vb2 queues on STREAMOFF

this by passing back to vb2 all the received buffers that were not processed. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/platform/exynos-gsc/gsc-m2m.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/media/platform/exynos-g

[PATCH 2/3] [media] exynos-gsc: unregister video device node on driver removal

] [] (do_filp_open) from [] (do_sys_open+0x10c/0x1bc) [ 36.830235] [] (do_sys_open) from [] (ret_fast_syscall+0x0/0x3c) [ 36.837942] Code: 0a1c e1a04000 e3a1 ebfec92d (e5943000) Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/platform/exynos-g

[PATCH 0/3] [media] exynos-gsc: Another round of cleanup and fixes

, Javier Javier Martinez Canillas (3): [media] exynos-gsc: don't release a non-dynamically allocated video_device [media] exynos-gsc: unregister video device node on driver removal [media] exynos-gsc: cleanup m2m src and dst vb2 queues on STREAMOFF drivers/media/platform/exynos-gsc/gsc

  1   2   3   4   5   >