Correct the debug output message to show correct format.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
b/drivers/media/platform/soc_camera/atmel-isi.c
output a pass-through formats, which means no swap.
Just setup YCC_SWAP as default with no swap.
Signed-off-by: Josh Wu
---
Changes in v2:
- remove the duplicated variable: cfg2_yuv_swap.
drivers/media/platform/soc_camera/atmel-isi.c | 39 ---
1 file changed, 29
Atmel ISI support a preview path which can output RGB data.
So this patch introduces a bool variable to choose which path is
enabled currently. And also we need setup corresponding path registers.
By default the preview path is disabled. We only use Codec path.
Signed-off-by: Josh Wu
t_rgb() function
which only used once. Also move the code into the for loop.
Josh Wu (5):
media: atmel-isi: correct yuv swap according to different sensor
outputs
media: atmel-isi: prepare for the support of preview path
media: atmel-isi: add code to setup correct resolution for preview
The preview path only can convert UYVY format to RGB data.
To make preview path work correctly, we need to set up YCC_SWAP
according to sensor output and convert them to UYVY.
Signed-off-by: Josh Wu
---
Changes in v2:
- remove cfg2_yuv_swap for rgb format
- correct the comment style
drivers
Not like codec path, preview path can do downsampling, so we should setup
a extra preview width, height for it.
This patch add preview resolution setup without down sampling. So currently
preview path will output same size as sensor output size.
Signed-off-by: Josh Wu
---
Changes in v2: None
This patch enable Atmel ISI preview path to convert the YUV to RGB format.
Signed-off-by: Josh Wu
---
Changes in v2:
- According to Guennadi's suggestion, remove the is_output_rgb() function
which only used once. Also move the code into the for loop.
drivers/media/platform/soc_camera/
This patch set will fix a bug in soc-camera, which will fail to search
the v4l2-clk if the i2c sensor is probed later than soc-camera host.
It also add some clean up for v4l2-clk code and usage.
Josh Wu (4):
soc_camera: get the clock name by using macro: v4l2_clk_name_i2c()
v4l2-clk: add
This macro is used to generate a OF string for a v4l2 clock.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/soc_camera.c | 4 ++--
include/media/v4l2-clk.h | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform
Since v4l2_clk_name_i2c() is defined, so just reuse it.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/soc_camera.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/soc_camera/soc_camera.c
b/drivers/media/platform
Make all v4l2-clk's clock name use V4L2_CLK_NAME_SIZE definition.
In future, if the string increased we just need to change the
V4L2_CLK_NAME_SIZE once.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/soc_camera.c | 6 +++---
drivers/media/usb/em28xx/em28xx-camera.c
ot;.
This patch will search the clock with OF string name if fail to find the
clock with I2C string name.
Signed-off-by: Josh Wu
---
drivers/media/v4l2-core/v4l2-clk.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-clk.c
b/drivers/media/v4l2-core/
Dear Guennadi,
On 10/19/2015 10:03 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Wed, 14 Oct 2015, Josh Wu wrote:
Dear Guennadi,
Thanks for the review.
On 10/5/2015 1:02 AM, Guennadi Liakhovetski wrote:
On Tue, 22 Sep 2015, Josh Wu wrote:
This patch enable Atmel ISI preview path to
Dear Guennadi,
On 10/19/2015 9:48 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Wed, 14 Oct 2015, Josh Wu wrote:
Hi, Dear Guennadi
Thanks for the review.
On 10/5/2015 12:43 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Tue, 22 Sep 2015, Josh Wu wrote:
we need to configure the YCC_SWAP
Dear Guennadi,
Thanks for the review.
On 10/5/2015 1:02 AM, Guennadi Liakhovetski wrote:
On Tue, 22 Sep 2015, Josh Wu wrote:
This patch enable Atmel ISI preview path to convert the YUV to RGB format.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 38
Dear Gueannadi,
On 10/5/2015 1:04 AM, Guennadi Liakhovetski wrote:
Even simpler:
On Sun, 4 Oct 2015, Guennadi Liakhovetski wrote:
Hi Josh,
On Tue, 22 Sep 2015, Josh Wu wrote:
we need to configure the YCC_SWAP bits in ISI_CFG2 according to current
sensor output and Atmel ISI output format
Hi, Dear Guennadi
On 10/5/2015 12:50 AM, Guennadi Liakhovetski wrote:
On Tue, 22 Sep 2015, Josh Wu wrote:
The preview path only can convert UYVY format to RGB data.
To make preview path work correctly, we need to set up YCC_SWAP
according to sensor output and convert them to UYVY.
Signed
Hi, Dear Guennadi
Thanks for the review.
On 10/5/2015 12:43 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Tue, 22 Sep 2015, Josh Wu wrote:
we need to configure the YCC_SWAP bits in ISI_CFG2 according to current
sensor output and Atmel ISI output format.
Current there are two cases Atmel ISI
This patch enable Atmel ISI preview path to convert the YUV to RGB format.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 38 ---
1 file changed, 29 insertions(+), 9 deletions(-)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
b
The preview path only can convert UYVY format to RGB data.
To make preview path work correctly, we need to set up YCC_SWAP
according to sensor output and convert them to UYVY.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 16
1 file changed, 16
Not like codec path, preview path can do downsampling, so we should setup
a extra preview width, height for it.
This patch add preview resolution setup without down sampling. So currently
preview path will output same size as sensor output size.
Signed-off-by: Josh Wu
---
drivers/media
Atmel ISI support a preview path which can output RGB data.
So this patch introduces a bool variable to choose which path is
enabled currently. And also we need setup corresponding path registers.
By default the preview path is disabled. We only use Codec path.
Signed-off-by: Josh Wu
output a pass-through formats, which means no swap.
Just setup YCC_SWAP as default with no swap.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 43 ---
1 file changed, 33 insertions(+), 10 deletions(-)
diff --git a/drivers/media/platform
This series will enable preview path support in atmel-isi. Which can
make atmel-isi convert the YUV format (from sensor) to RGB565 format.
Josh Wu (5):
media: atmel-isi: correct yuv swap according to different sensor
outputs
media: atmel-isi: prepare for the support of preview path
h - thanks! But,
please make sure, that all patches also appear in my mailbox at least
once, especially if they are (even trivially) modified - like in this
case, where patches 2 and 3 have been merged into 1.
yes, got it. I will make sure of that in future. Thanks for the remind.
Best Regard
create a branch here:
https://github.com/JoshWu/linux-at91/commits/atmel-isi-v4.3,
which collected all the Atmel-isi patches that still not merged. You can
take it as a reference.
Of cause, if you want I can sent out a pull request for it. thanks.
Best Regards,
Josh Wu
Thanks
Guennadi
On Fri
o into 4.3.
Best Regards,
Josh Wu
Thanks
Guennadi
On Tue, 4 Aug 2015, Josh Wu wrote:
Since in soc_of_bind() it may use the of node's full name as the clk_name,
and this full name may be longer than 32 characters, take at91 i2c sensor
as an example, length is 34 bytes:
/ahb/apb/i2c@
After adding the format check in try_fmt()/set_fmt(), we don't need any
format check in configure_geometry(). So make configure_geometry() as
void type.
Signed-off-by: Josh Wu
---
Hi, Laurent
For the similiarity between set_fmt() and try_frm() function, it need more work
than I thought.
As in set_fmt() function we only need to know which format is been set,
we don't need to access the ISI hardware in this moment.
So move the configure_geometry(), which access the ISI hardware, to
start_streaming() will make code more consistent and simpler.
Signed-off-by: Josh Wu
Review
.
Signed-off-by: Josh Wu
Reviewed-by: Laurent Pinchart
---
Changes in v4:
- add a COL_SPACE_YCbCr for cfg2
Changes in v3: None
Changes in v2:
- add Laurent's reviewed-by tag.
drivers/media/platform/soc_camera/atmel-isi.c | 20 +++-
include/media/atmel-
:
‘atmel_isi_runtime_resume’ defined but not used
Protect the unused functions by #ifdef CONFIG_PM to fix this.
Signed-off-by: Geert Uytterhoeven
Acked-by: Josh Wu
Best Regards,
Josh Wu
---
Resend with correct suject
---
drivers/media/platform/soc_camera/atmel-isi.c | 2 ++
1 file changed, 2
Hi, Guennadi
Thanks for the review.
On 8/30/2015 4:48 PM, Guennadi Liakhovetski wrote:
Hi Josh,
On Wed, 17 Jun 2015, Josh Wu wrote:
In the function configure_geometry(), we will setup the ISI CFG2
according to the sensor output format.
It make no sense to just read back the CFG2 register
Hi, Laurent
On 8/22/2015 2:22 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Friday 21 August 2015 16:08:14 Josh Wu wrote:
After adding the format check in try_fmt()/set_fmt(), we don't need any
format check in configure_geometry(). So make configure_geometry() as
void
.
Signed-off-by: Josh Wu
Reviewed-by: Laurent Pinchart
---
Changes in v3: None
Changes in v2:
- add Laurent's reviewed-by tag.
drivers/media/platform/soc_camera/atmel-isi.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/media/platform/soc_c
As in set_fmt() function we only need to know which format is been set,
we don't need to access the ISI hardware in this moment.
So move the configure_geometry(), which access the ISI hardware, to
start_streaming() will make code more consistent and simpler.
Signed-off-by: Josh Wu
Review
After adding the format check in try_fmt()/set_fmt(), we don't need any
format check in configure_geometry(). So make configure_geometry() as
void type.
Signed-off-by: Josh Wu
---
Changes in v3:
- check the whether format is supported, if no then return a default
format.
- misc ch
Hi, Laurent
Thanks for the review.
On 8/21/2015 2:30 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Wednesday 05 August 2015 11:26:29 Josh Wu wrote:
After adding the format check in set_fmt(), we don't need any format check
in configure_geometry(). So
Hi, Laurent
Could you have time to review this patch? so that I can send a pull
request with your reviewed-by tags.
Best Regards,
Josh Wu
On 8/5/2015 11:26 AM, Josh Wu wrote:
After adding the format check in set_fmt(), we don't need any format check
in configure_geometry(). So
}
So if you agree with it, I will squash this patch with
[PATCH 3/4] Remove support for platform data
in my tree. Does it sound ok for you?
Best Regards,
Josh Wu
struct soc_camera_host *soc_host;
struct isi_platform_data *pdata;
--
To unsubscribe from this list: send
Hi, Laurent
On 8/5/2015 6:08 AM, Laurent Pinchart wrote:
Hi Josh,
On Monday 03 August 2015 10:56:29 Josh Wu wrote:
On 8/1/2015 5:22 PM, Laurent Pinchart wrote:
Hello,
While reviewing patches for the atmel-isi I noticed a couple of small
issues with the driver. Here's a patch series t
.
Signed-off-by: Josh Wu
Reviewed-by: Laurent Pinchart
---
Changes in v2:
- add Laurent's reviewed-by tag.
drivers/media/platform/soc_camera/atmel-isi.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/media/platform/soc_camera/atmel-isi
After adding the format check in set_fmt(), we don't need any format check
in configure_geometry(). So make configure_geometry() as void type.
Signed-off-by: Josh Wu
---
Changes in v2:
- new added patch
drivers/media/platform/soc_camera/atmel-isi.c | 39 +--
1
As in set_fmt() function we only need to know which format is been set,
we don't need to access the ISI hardware in this moment.
So move the configure_geometry(), which access the ISI hardware, to
start_streaming() will make code more consistent and simpler.
Signed-off-by: Josh Wu
Review
nough so far.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/soc_camera.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/soc_camera/soc_camera.c
b/drivers/media/platform/soc_camera/soc_camera.c
index d708df4..fcf3e97 100644
--- a/drivers/
This patch will get the DT parameters of vsync/hsync/pixclock polarity, and
pass to driver.
Also add a debug information for test purpose.
Signed-off-by: Josh Wu
---
Changes in v3:
- add embedded sync dt property support.
Changes in v2:
- rewrite the debug message and add pix clock polarity
Hi, Laurent
On 8/4/2015 4:33 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Tuesday 04 August 2015 14:47:07 Josh Wu wrote:
This patch will get the DT parameters of vsync/hsync/pixclock polarity, and
pass to driver.
Also add a debug information for test purpose.
Signed-off
This patch will get the DT parameters of vsync/hsync/pixclock polarity, and
pass to driver.
Also add a debug information for test purpose.
Signed-off-by: Josh Wu
---
Changes in v2:
- rewrite the debug message and add pix clock polarity setup thanks to
Laurent.
- update the commit log
Hi, Laurent
On 8/1/2015 5:11 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Friday 31 July 2015 18:33:32 Josh Wu wrote:
This patch will get the DT parameters of vsync/hsync polarity, and pass to
the platform data.
Also add a debug information for test purpose.
Signed-off
Hi, Laurent
On 8/3/2015 9:27 PM, Laurent Pinchart wrote:
Hi Josh,
On Monday 03 August 2015 11:56:01 Josh Wu wrote:
On 7/31/2015 10:37 PM, Laurent Pinchart wrote:
On Wednesday 17 June 2015 18:39:39 Josh Wu wrote:
As in set_fmt() function we only need to know which format is been set,
we
HI, Laurent
On 7/31/2015 10:37 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Wednesday 17 June 2015 18:39:39 Josh Wu wrote:
As in set_fmt() function we only need to know which format is been set,
we don't need to access the ISI hardware in this moment.
So mov
to DT.
Thanks for the patches. It's perfectly make sense.
The patches have been compile-tested only. Josh, would you be able to test
them on hardware ?
For the whole series, here is my:
Acked-by: Josh Wu
Tested-by: Josh Wu
Best Regards,
Josh Wu
Laurent Pinchart (4):
v4l: atmel-isi
This patch will get the DT parameters of vsync/hsync polarity, and pass to
the platform data.
Also add a debug information for test purpose.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/media
Hi, list
Ping..., any feedback for this series?
Best Regards,
Josh Wu
On 6/17/2015 6:39 PM, Josh Wu wrote:
In the function configure_geometry(), we will setup the ISI CFG2
according to the sensor output format.
It make no sense to just read back the CFG2 register and just set part
of it.
So
.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
b/drivers/media/platform/soc_camera/atmel-isi.c
index 9070172..8bc40ca 100644
--- a
As in set_fmt() function we only need to know which format is been set,
we don't need to access the ISI hardware in this moment.
So move the configure_geometry(), which access the ISI hardware, to
start_streaming() will make code more consistent and simpler.
Signed-off-by: Josh Wu
---
dr
If ISI is working on a 1024x768 or higher resolution, it needs longer
time to disable ISI. So this patch will increase timeout to 500ms.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media
Hi, Guennadi
Any feedback for this patch series?
Best Regards,
Josh Wu
On 5/26/2015 5:54 PM, Josh Wu wrote:
This patch series fix the peripheral clock code and enable runtime support.
Also it clean up the code which is for the compatiblity of mck.
Changes in v5:
- add new patch to fix the
, as clock_start()/clock_stop() is used to control the
mclk not ISI peripheral clock. So move this to start[stop]_streaming()
function.
Signed-off-by: Josh Wu
---
Changes in v5:
- fix the error path in start_streaming() thanks to Laurent.
Changes in v4:
- need to call pm_runtime_disable() in
On 5/26/2015 5:14 PM, Josh Wu wrote:
Hi, Laurent
On 5/26/2015 4:16 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Tuesday 26 May 2015 16:00:09 Josh Wu wrote:
The runtime pm resume/suspend will enable/disable pclk (ISI peripheral
clock).
And we need to call
:
- merged v1 two patch into one.
- use runtime_pm_put() instead of runtime_pm_put_sync()
- enable peripheral clock before access ISI registers.
- totally remove clock_start()/clock_stop() as they are optional.
Josh Wu (3):
media: atmel-isi: disable ISI even it has codec request in
The master clock should handled by sensor itself.
Signed-off-by: Josh Wu
Acked-by: Laurent Pinchart
---
Changes in v5: None
Changes in v4: None
Changes in v3:
- remove useless definition: ISI_DEFAULT_MCLK_FREQ
Changes in v2:
- totally remove clock_start()/clock_stop() as they are optional
In current code, stop_streaming() will just return if ISI is still
working in the codec. But this is incorrect, we need to disable ISI even
it is working on the codec. otherwise stop_streaming() will not work as
we expected.
Signed-off-by: Josh Wu
---
Changes in v5:
- add new patch to fix the
Hi, Laurent
On 5/26/2015 4:16 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Tuesday 26 May 2015 16:00:09 Josh Wu wrote:
The runtime pm resume/suspend will enable/disable pclk (ISI peripheral
clock).
And we need to call runtime_pm_get_sync()/runtime_pm_put() when we need
, as clock_start()/clock_stop() is used to control the
mclk not ISI peripheral clock. So move this to start[stop]_streaming()
function.
Signed-off-by: Josh Wu
---
Changes in v4:
- need to call pm_runtime_disable() in atmel_isi_remove().
- merged the patch which remove isi disable code in
The master clock should handled by sensor itself.
Signed-off-by: Josh Wu
Acked-by: Laurent Pinchart
---
Changes in v4: None
Changes in v3:
- remove useless definition: ISI_DEFAULT_MCLK_FREQ
Changes in v2:
- totally remove clock_start()/clock_stop() as they are optional.
drivers/media
runtime_pm_put_sync()
- enable peripheral clock before access ISI registers.
- totally remove clock_start()/clock_stop() as they are optional.
Josh Wu (2):
media: atmel-isi: add runtime pm support
media: atmel-isi: remove mck back compatiable code as it's not need
drivers/media/platform/soc_camera/
On 5/6/2015 6:25 PM, Josh Wu wrote:
The runtime pm resume/suspend will enable/disable pclk (ISI peripheral
clock).
And we need to call runtime_pm_get_sync()/runtime_pm_put() when we need
access ISI registers.
In the meantime, as clock_start()/clock_stop() is used to control the
mclk not ISI
then switching the ISI off as in the current
version helps save some power, unless it breaks anything?
So what about to keep the isi_write(isi, ISI_CTRL, ISI_CTRL_DIS) in
configure_geometry() and isi_camera_set_bus_param().
Only remove it from atmel_isi_probe()?
Best Regards,
Josh Wu
Thanks
Guen
The master clock should handled by sensor itself.
Signed-off-by: Josh Wu
Acked-by: Laurent Pinchart
---
Changes in v3:
- remove useless definition: ISI_DEFAULT_MCLK_FREQ
Changes in v2:
- totally remove clock_start()/clock_stop() as they are optional.
drivers/media/platform/soc_camera/atmel
[stop]_streaming()
function.
Signed-off-by: Josh Wu
---
Changes in v3: None
Changes in v2:
- merged v1 two patch into one.
- use runtime_pm_put() instead of runtime_pm_put_sync()
- enable peripheral clock before access ISI registers.
drivers/media/platform/soc_camera/atmel-isi.c | 51
To program ISI control register, the pixel clock should be enabled.
So without pixel clock (from sensor) enabled, disable ISI controller is
not make sense. So this patch remove those code.
Signed-off-by: Josh Wu
---
Changes in v3: None
Changes in v2:
- this file is new added.
drivers/media
runtime_pm_put() instead of runtime_pm_put_sync()
- enable peripheral clock before access ISI registers.
- totally remove clock_start()/clock_stop() as they are optional.
Josh Wu (3):
media: atmel-isi: remove the useless code which disable isi
media: atmel-isi: add runtime pm support
media: atmel-isi
Hi, Laurent
On 4/12/2015 9:10 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Thursday 09 April 2015 17:01:46 Josh Wu wrote:
To program ISI control register, the pixel clock should be enabled.
That's an awful hardware design :-(
yes, But I need to live with this.
Hi, Laurent
On 4/12/2015 9:08 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Thursday 09 April 2015 17:01:48 Josh Wu wrote:
The master clock should handled by sensor itself.
Signed-off-by: Josh Wu
---
Changes in v2:
- totally remove clock_start()/clock_stop() as they are
To program ISI control register, the pixel clock should be enabled.
So without pixel clock (from sensor) enabled, disable ISI controller is
not make sense. So this patch remove those code.
Signed-off-by: Josh Wu
---
Changes in v2:
- this file is new added.
drivers/media/platform/soc_camera
The master clock should handled by sensor itself.
Signed-off-by: Josh Wu
---
Changes in v2:
- totally remove clock_start()/clock_stop() as they are optional.
drivers/media/platform/soc_camera/atmel-isi.c | 45 ---
1 file changed, 45 deletions(-)
diff --git a/drivers
[stop]_streaming()
function.
Signed-off-by: Josh Wu
---
Changes in v2:
- merged v1 two patch into one.
- use runtime_pm_put() instead of runtime_pm_put_sync()
- enable peripheral clock before access ISI registers.
drivers/media/platform/soc_camera/atmel-isi.c | 51 +++
1
registers.
- totally remove clock_start()/clock_stop() as they are optional.
Josh Wu (3):
media: atmel-isi: remove the useless code which disable isi
media: atmel-isi: add runtime pm support
media: atmel-isi: remove mck back compatiable code as it's not need
drivers/media/platform/soc_camera/
Hi, Laurent
On 3/8/2015 8:28 AM, Laurent Pinchart wrote:
On Friday 06 March 2015 21:25:36 Guennadi Liakhovetski wrote:
On Fri, 6 Mar 2015, Josh Wu wrote:
On 3/5/2015 6:41 PM, Laurent Pinchart wrote:
On Thursday 05 March 2015 13:01:01 Josh Wu wrote:
The master clock should handled by sensor
On 3/5/2015 6:39 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Thursday 05 March 2015 13:00:59 Josh Wu wrote:
As the clock_start/stop() use to control the mclk for the sensor not the
ISI peripheral clock.
So we move them to start/stop_stream() function.
Then the driver
On 3/5/2015 6:41 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Thursday 05 March 2015 13:01:01 Josh Wu wrote:
The master clock should handled by sensor itself.
I like that :-)
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 32
On 3/5/2015 6:36 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Thursday 05 March 2015 13:01:00 Josh Wu wrote:
The runtime pm resume/suspend will enable/disable pclk (ISI peripheral
clock).
And we need to call rumtime_pm_get/put_sync function to make pm
resume/suspend
The master clock should handled by sensor itself.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 32 ---
1 file changed, 32 deletions(-)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
b/drivers/media/platform/soc_camera/atmel
The runtime pm resume/suspend will enable/disable pclk (ISI peripheral
clock).
And we need to call rumtime_pm_get/put_sync function to make pm
resume/suspend.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 36 ---
1 file changed, 32
As the clock_start/stop() use to control the mclk for the sensor not the
ISI peripheral clock.
So we move them to start/stop_stream() function.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
This patch series fix the peripheral clock code and enable runtime pm
support.
Aslo clean up the code which is for the compatiblity of mck.
Josh Wu (3):
media: atmel-isi: move the peripheral clock to start/stop_stream()
function
media: atmel-isi: add runtime pm support
media: atmel-isi
In async probe, there is a case that ov2640 is probed before the
host device which provided 'mclk'.
To support this async probe, we will get 'mclk' at first in the probe(),
if failed it will return -EPROBE_DEFER. That will let ov2640 wait for
the host device probed.
Si
On 3/2/2015 5:06 AM, Guennadi Liakhovetski wrote:
Hi Josh,
Thanks for a patch update. I think it looks good as a first step in your
patch series, just a minor comment below:
On Tue, 10 Feb 2015, Josh Wu wrote:
In async probe, there is a case that ov2640 is probed before the
host device which
Hi, Prabhakar Lad
On 2/17/2015 12:48 AM, Lad, Prabhakar wrote:
Hi Josh,
Thanks for the patch.
On Tue, Feb 10, 2015 at 9:31 AM, Josh Wu wrote:
[Snip]
- priv->clk = v4l2_clk_get(&client->dev, "mclk");
+ priv->clk = v4l2_clk_get(&client->dev, "x
In async probe, there is a case that ov2640 is probed before the
host device which provided 'mclk'.
To support this async probe, we will get 'mclk' at first in the probe(),
if failed it will return -EPROBE_DEFER. That will let ov2640 wait for
the host device probed.
Si
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
Acked-by: Laurent Pinchart
Acked-by: Sylwester Nawrocki
---
Changes in v5: None
Changes in v4:
- remove aggsigned-clocks as it's general.
- refine the explation.
Changes in v3:
- fix incorrect descri
Add device tree support for ov2640.
In device tree, user needs to provide the master clock (xvclk).
User can add the reset/pwdn pins if they have.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
Acked-by: Laurent Pinchart
---
Changes in v5:
- change the 'mclk' to 'xvcl
icd->control is the sub device dev, i.e. i2c device.
icd->pdev is the soc camera device's device.
To be consitent with power() function, we will call reset() with
icd->control as well.
Signed-off-by: Josh Wu
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Chang
x27;s acked-by.
v2->v3:
1. fix the gpiod_xxx api usage as we use reset pin as ACTIVE_LOW.
2. update the devicetree binding document.
v1 -> v2:
1. modified the dt bindings according to Laurent's suggestion.
2. add a fix patch for soc_camera. Otherwise the .reset() function
w
Hi, Guennadi
On 2/2/2015 6:22 PM, Guennadi Liakhovetski wrote:
Hi Josh,
On Mon, 2 Feb 2015, Josh Wu wrote:
Hi, Guennadi
Ping? what about the status of this patch?
Right, got lost, sorry... Added to the queue now.
Thank you.
Best Regards,
Josh Wu
Thanks
Guennadi
Best Regards,
Josh Wu
handle such clocks. This patch adds support
for such cases.
Signed-off-by: Guennadi Liakhovetski
Acked-by: Laurent Pinchart
Thanks for the patch.
Tested-by: Josh Wu
Best Regards,
Josh Wu
---
v4: sizeof(*clk) :)
drivers/media/v4l2-core/v4l2-clk.c | 48
.
Tested-by: Josh Wu
Best Regards,
Josh Wu
v3: .id field removed from the struct. Since CCF clocks won't be added to
the V4L2 clock list at all in patch 2 in this series, no clock ID
comparison is needed in v4l2_clk_find() either.
drivers/media/platform/soc_camera/soc_camera.c
Hi, Guennadi
Ping? what about the status of this patch?
Best Regards,
Josh Wu
On 11/25/2014 5:30 PM, Josh Wu wrote:
The burst length could be BEATS_4/8/16. Before this patch, isi use default
value BEATS_4. To imporve the performance we could set it to BEATS_16.
Otherwise sometime it would
Hi, Guennadi
On 11/28/2014 4:13 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Thu, 27 Nov 2014, Josh Wu wrote:
Hi, Guennadi
On 11/26/2014 6:23 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Tue, 25 Nov 2014, Josh Wu wrote:
Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h.
The
On 1/12/2015 6:38 PM, Laurent Pinchart wrote:
Hi Josh,
On Monday 12 January 2015 17:14:33 Josh Wu wrote:
On 1/9/2015 6:47 AM, Laurent Pinchart wrote:
On Thursday 08 January 2015 23:37:58 Guennadi Liakhovetski wrote:
On Wed, 7 Jan 2015, Josh Wu wrote:
On 1/7/2015 6:17 AM, Guennadi
1 - 100 of 232 matches
Mail list logo
