[RFC PATCHv2 1/3] libv4l2rds: support RDS-EON and TMC-tuning info

2013-06-04 Thread Konke Radlow
Signed-off-by: Konke Radlow libv4l2rds: added support to decode RDS-EON information Signed-off-by: Konke Radlow libv4l2rds: added support to decode RDS-TMC tuning information Signed-off-by: Konke Radlow libv4l2rds.c: fixing compiler warnings due to missing pointer dereferencing and

[RFC PATCHv2 2/3] rds-ctl: support RDS-EON and TMC-tuning info

2013-06-04 Thread Konke Radlow
Signed-off-by: Konke Radlow rds-ctl.cpp: added functionality to print RDS-EON information Signed-off-by: Konke Radlow rds-ctl.cpp: added functionality to print RDS-TMC tuning information Signed-off-by: Konke Radlow rds-ctl.cpp: clarify option description, change trigger condition for

[RFC PATCHv2 3/3] libv4l2rds.c: moving functions to get rid of declarations Signed-off-by: Konke Radlow

2013-06-04 Thread Konke Radlow
Signed-off-by: Konke Radlow --- lib/libv4l2rds/libv4l2rds.c | 243 +-- 1 file changed, 120 insertions(+), 123 deletions(-) diff --git a/lib/libv4l2rds/libv4l2rds.c b/lib/libv4l2rds/libv4l2rds.c index 28b78ce..333bf95 100644 --- a/lib/libv4l2rds

[RFC PATCHv2 0/3] libv4l2rds: add support for RDS-EON and TMC-tuning decoding

2013-06-04 Thread Konke Radlow
This patch series is based on the commments to: [RFC PATCH 0/4] libv4l2rds: support for decoding RDS tuning information [RFC PATCH 1/4] libv4l2rds: added support to decode RDS-EON information [RFC PATCH 2/4] rds-ctl.cpp: added functionality to print RDS-EON information [RFC PATCH 3/4] libv4l2rds:

Re: [RFC PATCH 3/4] libv4l2rds: added support to decode RDS-TMC tuning information

2013-05-20 Thread Konke Radlow
d now. And I agree that human readable output for the TMC messages would be nice to have, but I'm quite busy with my thesis atm and will not make any promises ;) Cheers, Konke On Fri, May 10, 2013 at 12:46 PM, Hans Verkuil wrote: > On Tue May 7 2013 18:24:22 Konke Radlow wrote: >> S

[RFC PATCH 4/4] rds-ctl.cpp: added functionality to print RDS-TMC tuning information

2013-05-07 Thread Konke Radlow
Signed-off-by: Konke Radlow --- utils/rds-ctl/rds-ctl.cpp | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/utils/rds-ctl/rds-ctl.cpp b/utils/rds-ctl/rds-ctl.cpp index 51536cf..445c11f 100644 --- a/utils/rds-ctl/rds-ctl.cpp +++ b/utils/rds-ctl/rds

[RFC PATCH 3/4] libv4l2rds: added support to decode RDS-TMC tuning information

2013-05-07 Thread Konke Radlow
Signed-off-by: Konke Radlow --- lib/include/libv4l2rds.h| 39 +++ lib/libv4l2rds/libv4l2rds.c | 159 +-- 2 files changed, 194 insertions(+), 4 deletions(-) diff --git a/lib/include/libv4l2rds.h b/lib/include/libv4l2rds.h index 62b28bc

[RFC PATCH 2/4] rds-ctl.cpp: added functionality to print RDS-EON information

2013-05-07 Thread Konke Radlow
Signed-off-by: Konke Radlow --- utils/rds-ctl/rds-ctl.cpp | 29 + 1 file changed, 29 insertions(+) diff --git a/utils/rds-ctl/rds-ctl.cpp b/utils/rds-ctl/rds-ctl.cpp index de76d9f..51536cf 100644 --- a/utils/rds-ctl/rds-ctl.cpp +++ b/utils/rds-ctl/rds-ctl.cpp

[RFC PATCH 1/4] libv4l2rds: added support to decode RDS-EON information

2013-05-07 Thread Konke Radlow
Signed-off-by: Konke Radlow --- lib/include/libv4l2rds.h| 35 +++- lib/libv4l2rds/libv4l2rds.c | 190 --- 2 files changed, 208 insertions(+), 17 deletions(-) diff --git a/lib/include/libv4l2rds.h b/lib/include/libv4l2rds.h index 6a6c7f3

[RFC PATCH 0/4] libv4l2rds: support for decoding RDS tuning information

2013-05-07 Thread Konke Radlow
This set of patches adds support to decode information about other networks and radio stations which can submitted as a part of the RDS and RDS-TMC data stream. RDS-EON: Enhanced Other Network information that can be used to update the information stored in the receiver about programme service o

[RFC PATCHv2] Add core TMC (Traffic Message Channel) support

2012-08-15 Thread Konke Radlow
Signed-off-by: Konke Radlow --- lib/include/libv4l2rds.h| 65 + lib/libv4l2rds/libv4l2rds.c | 309 ++- utils/rds-ctl/rds-ctl.cpp | 31 - 3 files changed, 402 insertions(+), 3 deletions(-) diff --git a/lib/include/libv4l2rds.h b/lib

[RFC PATCHv2 0/1] Adding core TMC decoding support to RDS library

2012-08-15 Thread Konke Radlow
this patch is an updated version of the last RDS-TMC core support patch. The changes proposed by Hans Verkuil were implemented. In addition the handling and decoding of multi-group TMC messages was heavily modified, in order to improve read- and maintainability Regards, Konke -- To unsubscribe

[Announcement] pcimax3000+ (RDS-transmitter) control tool

2012-08-10 Thread Konke Radlow
Hello, during the last weeks I've been working on a RDS (Radio Data System) decoding library (libv4l2rds) and a corresponding test and control tool (rds-ctl), that might make it into v4l soon. In the course of this process I created a command line tool for controlling the PCIMAX3000+ RDS-transmiss

[RFC PATCH] Add core TMC (Traffic Message Channel) support

2012-08-10 Thread Konke Radlow
Signed-off-by: Konke Radlow --- lib/include/libv4l2rds.h| 64 lib/libv4l2rds/libv4l2rds.c | 340 ++- utils/rds-ctl/rds-ctl.cpp | 31 +++- 3 files changed, 432 insertions(+), 3 deletions(-) diff --git a/lib/include/libv4l2rds.h b/lib

[RFC PATCH 0/1] Adding core TMC decoding support to RDS library

2012-08-10 Thread Konke Radlow
Hello, this patch adds the core of TMC decoding support to the RDS library. Single and multigroup TMC messages as well as TMC system messages are decoded into an easily accessable format and can be used as the basis for a complete TMC decoding implementation. The part that's missing from the code

[PATCHv2 1/2] Add libv4l2rds library

2012-08-10 Thread Konke Radlow
Signed-off-by: Konke Radlow --- Makefile.am |3 +- configure.ac|2 + lib/include/libv4l2rds.h| 218 + lib/libv4l2rds/Makefile.am | 11 + lib/libv4l2rds/libv4l2rds.c | 964 +++ lib

[PATCHv2 2/2] Add rds-ctl tool

2012-08-10 Thread Konke Radlow
Signed-off-by: Konke Radlow --- Makefile.am |3 +- configure.ac |1 + utils/rds-ctl/Makefile.am |5 + utils/rds-ctl/rds-ctl.cpp | 938 + 4 files changed, 946 insertions(+), 1 deletion(-) create mode 100644

[PATCHv2 0/2] Add support for RDS decoding

2012-08-10 Thread Konke Radlow
Hello, after the positive feedback from the last RFC session, here now a patch including all minor changes that were proposed. embarrassingly, I missed a minor bug introduced by removing the version field from the v4l2_rds struct, hence the resend Regards, Konke -- To unsubscribe f

[PATCH 2/2] Add rds-ctl tool

2012-08-10 Thread Konke Radlow
Signed-off-by: Konke Radlow --- Makefile.am |3 +- configure.ac |1 + utils/rds-ctl/Makefile.am |5 + utils/rds-ctl/rds-ctl.cpp | 938 + 4 files changed, 946 insertions(+), 1 deletion(-) create mode 100644

[PATCH 1/2] Add libv4l2rds library

2012-08-10 Thread Konke Radlow
Signed-off-by: Konke Radlow --- Makefile.am |3 +- configure.ac|2 + lib/include/libv4l2rds.h| 218 + lib/libv4l2rds/Makefile.am | 11 + lib/libv4l2rds/libv4l2rds.c | 965 +++ lib

[PATCH 0/2] Add support for RDS decoding

2012-08-10 Thread Konke Radlow
Hello, after the positive feedback from the last RFC session, here now a patch including all minor changes that were proposed. Regards, Konke -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [RFC PATCH 2/2] Add rds-ctl tool (with changes proposed in RFC)

2012-08-09 Thread Konke Radlow
On Thu, Aug 9, 2012 at 12:05 PM, Hans de Goede wrote: > Hi, > > Comments inline. > > > On 08/07/2012 05:11 PM, Konke Radlow wrote: >> >> --- >> Makefile.am |3 +- >> configure.ac |1 + >> utils/rds-ctl/Mak

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Konke Radlow
t; --- /dev/null >> +++ b/lib/include/libv4l2rds.h >> @@ -0,0 +1,228 @@ >> +/* >> + * Copyright 2012 Cisco Systems, Inc. and/or its affiliates. All rights >> reserved. >> + * Author: Konke Radlow >> + * >> + * This program is free software; you can redi

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Konke Radlow
regor Jasny wrote: > Hello Konke, > > > On 8/7/12 5:11 PM, Konke Radlow wrote: >> >> diff --git a/configure.ac b/configure.ac >> index 8ddcc9d..1109c4d 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -146,9 +148,12 @@ AC_ARG_WITH(libv4l2subdir, &

Re: [RFC PATCH 0/2] Add support for RDS decoding (updated)

2012-08-08 Thread Konke Radlow
just for the record, these patches are: Signed-off-by: Konke Radlow Regards, Konke On Tue, Aug 7, 2012 at 3:11 PM, Konke Radlow wrote: > Hello, > first of all: thank you for the comments to my previous RFC for the > libv4l2rds library and the rds-ctl control & testing tool. &

[RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-07 Thread Konke Radlow
00644 index 000..4aa8593 --- /dev/null +++ b/lib/include/libv4l2rds.h @@ -0,0 +1,228 @@ +/* + * Copyright 2012 Cisco Systems, Inc. and/or its affiliates. All rights reserved. + * Author: Konke Radlow + * + * This program is free software; you can redistribute it and/or modify + * it under the te

[RFC PATCH 2/2] Add rds-ctl tool (with changes proposed in RFC)

2012-08-07 Thread Konke Radlow
@@ -0,0 +1,959 @@ +/* + * rds-ctl.cpp is based on v4l2-ctl.cpp + * + * the following applies for all RDS related parts: + * Copyright 2012 Cisco Systems, Inc. and/or its affiliates. All rights reserved. + * Author: Konke Radlow + * + * This program is free software; you can redistribute it and/or

[RFC PATCH 0/2] Add support for RDS decoding (updated)

2012-08-07 Thread Konke Radlow
Hello, first of all: thank you for the comments to my previous RFC for the libv4l2rds library and the rds-ctl control & testing tool. The proposed changes have been implemented, and the code has been further improved after a thorough code review by Hans Verkuil. Changes: -the code is rebase

Re: [RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow

2012-07-30 Thread Konke Radlow
Hello Hans, no need to thank me for working on it. First of all I do it as a part of a summerjob, and more importantly I quite enjoy it and intend to stay a active member of the development process after my time at Cisco is over. Thank you for your comments. > Most fields in this struct (and in

Re: [RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow

2012-07-30 Thread Konke Radlow
for working on this! Note I've also taken > a quick look at the original patch with the actual implementation and that > looks good. I'm replying here because in my mind the API is the most > interesting thing to discuss. > > Comments inline. > > On 07/26/2012 06:21 P

Re: [RFC PATCH 0/2] Add support for RDS decoding

2012-07-30 Thread Konke Radlow
thank you for the info, it's working now (I went for the include solution) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 0/2] Add support for RDS decoding

2012-07-27 Thread Konke Radlow
Yes, I realized too late that the library header file was missing from the submitted patch. I created a additional patch and attached it to the [RFC PATCH 1/2] thread. I updated the repository. It should now be based on the most recent version of the tree (I used git://git.linuxtv.org/v4l-utils

Re: [RFC PATCH 2/2] Initial version of RDS Control utility Signed-off-by: Konke Radlow

2012-07-26 Thread Konke Radlow
r comments so far. I'll incorporate them tomorrow morning when I'm back on my working machine, regards, Konke On Thu, Jul 26, 2012 at 9:13 PM, Gregor Jasny wrote: > > On 7/25/12 7:44 PM, Konke Radlow wrote: > > > +static void print_rds_af(struct v4l2_rds_af_set *af_

Re: [RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow

2012-07-26 Thread Konke Radlow
Cisco Systems, Inc. and/or its affiliates. All rights reserved. + * Author: Konke Radlow + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 2.1 o

[RFC PATCH 0/2] Add support for RDS decoding

2012-07-25 Thread Konke Radlow
Hello, Over the last couple of weeks I have been working on a library that adds RDS decoding support to the v4l-utils repository. It currently supports the core RDS standard but no advanced features yet like ODA (TMC). I also wrote a control application that can be used to test the library with a

[RFC PATCH 2/2] Initial version of RDS Control utility Signed-off-by: Konke Radlow

2012-07-25 Thread Konke Radlow
@@ -0,0 +1,978 @@ +/* + * rds-ctl.cpp is based on v4l2-ctl.cpp + * + * the following applies for all RDS related parts: + * Copyright 2012 Cisco Systems, Inc. and/or its affiliates. All rights reserved. + * Author: Konke Radlow + * + * This program is free software; you can redistribute it and/or

[RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow

2012-07-25 Thread Konke Radlow
9 +libv4l2rds_la_LDFLAGS = -version-info 0 -lpthread $(DLOPEN_LIBS) $(ENFORCE_LIBV4L_STATIC) diff --git a/lib/libv4l2rds/libv4l2rds.c b/lib/libv4l2rds/libv4l2rds.c new file mode 100644 index 000..0bacaa2 --- /dev/null +++ b/lib/libv4l2rds/libv4l2rds.c @@ -0,0 +1,871 @@ +/* + * Copyright 2012 Cisco Sys