Hi Hans,
Am Montag, den 13.07.2015, 12:57 +0200 schrieb Hans Verkuil:
[...]
> > @@ -69,6 +72,7 @@ static const struct v4l2_dv_timings_cap
> > tc358743_timings_cap = {
> >
> > struct tc358743_state {
> > struct tc358743_platform_data pdata;
> > + struct v4l2_of_bus_mipi_csi2 bus;
>
> Whe
Am Montag, den 13.07.2015, 13:07 +0200 schrieb Hans Verkuil:
> On 07/10/2015 03:11 PM, Philipp Zabel wrote:
> > This is useful to subscribe to HDMI hotplug events via the
> > V4L2_CID_DV_RX_POWER_PRESENT control.
> >
> > Signed-off-by: Philipp Zabel
> > ---
>
Trace events with exactly the same parameters and trace output, such as
v4l2_qbuf and v4l2_dqbuf, are supposed to use the DECLARE_EVENT_CLASS and
DEFINE_EVENT macros instead of duplicated TRACE_EVENT macro calls.
Suggested-by: Steven Rostedt
Signed-off-by: Philipp Zabel
---
include/trace
the timeline of trace events in combination with others that might
be triggered by __enqueue_in_driver.
Also two new trace events vb2_buf_queue and vb2_buf_done are added,
allowing to trace the handover between videobuf2 framework and driver.
Signed-off-by: Philipp Zabel
---
Changes since v2
: Philipp Zabel
---
drivers/media/v4l2-core/v4l2-mem2mem.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c
b/drivers/media/v4l2-core/v4l2-mem2mem.c
index dc853e5..af8d6b4 100644
--- a/drivers/media/v4l2-core/v4l2-mem2mem.c
+++ b
Am Freitag, den 10.07.2015, 15:35 +0200 schrieb Philipp Zabel:
> The encoder needs to know the nominal framerate for the constant bitrate
> control mechanism to work. Currently the only way to set the framerate is
> by using VIDIOC_S_PARM on the output queue.
>
> Signed-off-by
The encoder needs to know the nominal framerate for the constant bitrate
control mechanism to work. Currently the only way to set the framerate is
by using VIDIOC_S_PARM on the output queue.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-common.c | 102
The encoder allows to specify the VBV model reference decoder's initial
delay and buffer size. Export the corresponding V4L2 controls.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c| 5 -
drivers/media/platform/coda/coda-common.c | 14 ++
dr
On i.MX6, sometimes after decoding a stream, encoding will produce macroblock
errors caused by missing 8-byte sequences in the output stream. Until the cause
for this is found, reset the hardware after sequence end, which seems to help.
Signed-off-by: Philipp Zabel
---
drivers/media/platform
The encoder needs to know the nominal framerate for the constant bitrate
control mechanism to work. Currently the only way to set the framerate is
by using VIDIOC_S_PARM on the output queue.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-common.c | 102
This is useful to subscribe to HDMI hotplug events via the
V4L2_CID_DV_RX_POWER_PRESENT control.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index 4a889d4
Add support for probing the TC358743 subdevice from device tree.
The reference clock must be supplied using the common clock bindings.
MIPI CSI-2 specific properties are parsed from the OF graph endpoint
node and support for a non-continuous MIPI CSI-2 clock is added.
Signed-off-by: Philipp Zabel
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index 48d1575..0be6d9f 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
When probed from device tree, the i2c client driver can handle the interrupt
on its own.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index
Add support for registering the sensor subdevice using the v4l2-async API.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index 34d4f32..48d1575 100644
Hi Mats,
thanks for the update! With a few changes on top
Tested-by: Philipp Zabel
Am Donnerstag, den 09.07.2015, 10:45 +0200 schrieb matra...@cisco.com:
> From: Mats Randgaard
>
> Improvements based on feedback from Hans Verkuil:
> - Use functions in linux/hdmi.h to print AVI
ore.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c| 8
drivers/media/platform/coda/coda-common.c | 4 +---
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/coda/coda-bit.c
b/drivers/media/platform/coda/coda-bit.c
index 0f8d
adds
a timestamp so it can share an event class with coda_bit_queue.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c | 2 +-
drivers/media/platform/coda/trace.h| 89 ++
2 files changed, 26 insertions(+), 65 deletions(-)
diff --git a
In stream end mode the hardware will read the bitstream to its end,
overshooting the write pointer. Do not write additional data into
the bitstream in this mode.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a
The mvcol buffer is allocated at the end of the first internal buffer.
This patch fixes an out of bounds array access.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/coda/coda
All decoder instances using the BIT processor should preload buffers
into the bitstream ring buffer, including MPEG4 decoding. Fix this
by explicitly stating the above condition instead of listing all
relevant input formats.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda
The v4l2_m2m_num_src_bufs_ready() function is called in multiple places
in coda_cob_ready, and there already is a variable src_bufs that is
assigned to its result. Move it to the beginning and use it everywhere.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-common.c | 13
Since commit ba3002045f80 ("[media] v4l2-ioctl: fill in the description
for VIDIOC_ENUM_FMT"), all pixel formats are assigned their description
in a central place. We can now drop the custom list.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-com
ormat just clamp the HW counter
to the same 16 bits. This should be enough to detect most of the errors
and saves us from doing different comparisons based on the decoded format.
Signed-off-by: Lucas Stach
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c | 9 -
1 file
Otherwise a restarted stream won't queue buffers.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-common.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/coda/coda-common.c
b/drivers/media/platform/coda/coda-common.c
index de0e245..8b
Keep count of number of buffer meta structures in the list and use
a separate spinlock for operations on this counted list instead
of reusing the bitstream mutex in some places and none at all in
others.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c| 16
Hi Zahari,
Am Mittwoch, den 08.07.2015, 15:37 +0200 schrieb Zahari Doychev:
> The coda context queue sequence counter is incremented only if the vb2
> source buffer payload is non zero. This makes possible to signal EOS
> otherwise the condition in coda_buf_is_end_of_stream is never met or more
>
the timeline of trace events in combination with others that might
be triggered by __enqueue_in_driver.
Also two new trace events vb2_buf_queue and vb2_buf_done are added,
allowing to trace the handover between videobuf2 framework and driver.
Signed-off-by: Philipp Zabel
---
Changes since v1
: Philipp Zabel
---
drivers/media/v4l2-core/v4l2-mem2mem.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c
b/drivers/media/v4l2-core/v4l2-mem2mem.c
index dc853e5..af8d6b4 100644
--- a/drivers/media/v4l2-core/v4l2-mem2mem.c
+++ b
Trace events with exactly the same parameters and trace output, such as
v4l2_qbuf and v4l2_dqbuf, are supposed to use the DECLARE_EVENT_CLASS and
DEFINE_EVENT macros instead of duplicated TRACE_EVENT macro calls.
Suggested-by: Steven Rostedt
Signed-off-by: Philipp Zabel
---
include/trace
Am Freitag, den 26.06.2015, 10:28 +0200 schrieb Sylwester Nawrocki:
[...]
> >> How about modifying v4l2_m2m_ioctl_reqbufs() instead ?
> >
> > The coda, gsc-m2m, m2m-deinterlace, mx2_emmaprp, and sh_veu drivers all
> > have their own implementation of vidioc_reqbufs that call
> > v4l2_m2m_reqbufs d
Am Donnerstag, den 25.06.2015, 09:07 -0400 schrieb Steven Rostedt:
> On Thu, 25 Jun 2015 12:01:27 +0200
> Philipp Zabel wrote:
>
> > diff --git a/include/trace/events/v4l2.h b/include/trace/events/v4l2.h
> > index 89d0497..3d15cf1 100644
> > --- a/include/trace/even
Hi Kamil,
Am Donnerstag, den 25.06.2015, 15:10 +0100 schrieb Kamil Debski:
> Hi Philipp,
>
> On 25 June 2015 at 11:01, Philipp Zabel wrote:
> > Signed-off-by: Philipp Zabel
>
> Please add the patch description no matter how simple it is and how
> well the subject c
Hi Sylwester,
Am Donnerstag, den 25.06.2015, 15:11 +0200 schrieb Sylwester Nawrocki:
> Hello Philipp,
>
> On 25/06/15 12:01, Philipp Zabel wrote:
> > Signed-off-by: Philipp Zabel
> > ---
> > drivers/media/v4l2-core/v4l2-mem2mem.c | 9 -
> > 1 file cha
Hi Javier,
Am Dienstag, den 23.06.2015, 12:20 +0200 schrieb Javier Martin:
[...]
> media-ctl -l '"IPU0 SMFC0":1->"imx-ipuv3-camera.2":0[1]'
>
> The last command will fail like this:
>
> imx-ipuv3 240.ipu: invalid link 'IPU0 SMFC0'(5):1 ->
> 'imx-ipuv3-camera.2'(2):0
> Unable to parse link:
Signed-off-by: Philipp Zabel
---
drivers/media/v4l2-core/v4l2-mem2mem.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c
b/drivers/media/v4l2-core/v4l2-mem2mem.c
index dc853e5..511caaa 100644
--- a/drivers/media/v4l2-core/v4l2
the timeline of trace events in combination with others that might
be triggered by __enqueue_in_driver.
Also two new trace events vb2_buf_queue and vb2_buf_done are added,
allowing to trace the handover between videobuf2 framework and driver.
Signed-off-by: Philipp Zabel
---
drivers/media/v4l2
Am Donnerstag, den 28.05.2015, 13:31 +0200 schrieb Enrico Weigelt, metux
IT consult:
> Am 28.05.2015 um 12:44 schrieb Philipp Zabel:
>
> Hi,
>
> >> Are these patches same as in your git branch tmp/imx-ipu-scaler ?
> >
> > No, that is an older version.
>
Hi Enrico,
Am Donnerstag, den 28.05.2015, 11:00 +0200 schrieb Enrico Weigelt, metux
IT consult:
> Am 27.05.2015 um 20:42 schrieb Jean-Michel Hautbois:
>
>
>
> @Phillip,
>
> I've missed the previous mails (just subscribed here yesterday) ...
>
> Are these patches same as in your git branch tmp/
Hi Jean-Michel,
Am Mittwoch, den 27.05.2015, 20:42 +0200 schrieb Jean-Michel Hautbois:
[...]
> > The tiling code has a parameter to optionally round frame sizes up or down
> > and avoid overdraw in compositing scenarios.
>
> Can you detail what you call "compositing scenarios" ?
I meant using th
ot define TRACE_SYSTEM_STRING"). As he points out, this is the
result of a bogus copy & paste. Kamil, would you queue either of them
with my
Acked-by: Philipp Zabel
thanks
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
driver must explicitly
call vb2_clear_last_buffer_queued. The last buffer queued flag is
cleared automatically during STREAMOFF.
Signed-off-by: Philipp Zabel
Acked-by: Hans Verkuil
---
drivers/media/v4l2-core/v4l2-mem2mem.c | 10 +-
drivers/media/v4l2-core/videobuf2-core.c | 19
being dequeued
from the capture queue, and the poll and VIDIOC_DQBUF ioctl return values once
the queue is drained.
Signed-off-by: Philipp Zabel
Acked-by: Hans Verkuil
---
Changes since v5:
- Drop "mem2mem" from subject.
- Mention possibly empty last buffer in the documentation.
---
Doc
From: Peter Seiderer
This v4l2_buffer flag can be used by drivers to mark a capture buffer
as the last generated buffer, for example after a V4L2_DEC_CMD_STOP
command was issued.
Signed-off-by: Peter Seiderer
Signed-off-by: Philipp Zabel
Acked-by: Hans Verkuil
---
include/trace/events/v4l2
buffer is dequeued.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c| 4 ++--
drivers/media/platform/coda/coda-common.c | 27 +++
drivers/media/platform/coda/coda.h| 3 +++
3 files changed, 16 insertions(+), 18 deletions(-)
diff --git
Setting the last buffer flag causes the videobuf2 core to return -EPIPE from
DQBUF calls on the capture queue after the last buffer is dequeued.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform
_FLAG_LAST
Philipp Zabel (4):
[media] DocBook media: document codec draining flow
[media] videobuf2: return -EPIPE from DQBUF after the last buffer
[media] coda: Set last buffer flag and fix EOS event
[media] s5p-mfc: Set last buffer flag
Documentation/DocBook/media/v4l/io.xml
Hi Hans, Kamil,
thank you for your comments.
Am Montag, den 27.04.2015, 15:23 +0200 schrieb Hans Verkuil:
> Hi Philipp,
>
> I finally got around to reviewing this patch series. Sorry for the delay, but
> here are my comments:
>
> On 04/20/2015 10:28 AM, Philipp Zabel wrote
Hi Hans,
Am Freitag, den 24.04.2015, 08:43 +0200 schrieb Hans Verkuil:
> Hi Philipp,
>
> Thank you for the patch, but I have one question:
>
> On 04/23/2015 03:52 PM, Philipp Zabel wrote:
> > Use the VIVID_WEBCAM_SIZES constant where appropriate and add a 1920x1080
>
Use the VIVID_WEBCAM_SIZES constant where appropriate and add a 1920x1080 pixel
frame size setting with frame rates of 2 fps and 5 fps.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/vivid/vivid-vid-cap.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a
ilipp
Peter Seiderer (1):
[media] videodev2: Add V4L2_BUF_FLAG_LAST
Philipp Zabel (4):
[media] DocBook media: document mem2mem draining flow
[media] videobuf2: return -EPIPE from DQBUF after the last buffer
[media] coda: Set last buffer flag and fix EOS event
[media] s5p-mfc: Set last buffer
Setting the last buffer flag causes the videobuf2 core to return -EPIPE from
DQBUF calls on the capture queue after the last buffer is dequeued.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform
being dequeued
from the capture queue, and the poll and VIDIOC_DQBUF ioctl return values once
the queue is drained.
Signed-off-by: Philipp Zabel
---
Changes since v4:
- Split out documentation changes into a separate patch
- Changed wording following Pawel's suggestions.
---
Documentation/Do
From: Peter Seiderer
This v4l2_buffer flag can be used by drivers to mark a capture buffer
as the last generated buffer, for example after a V4L2_DEC_CMD_STOP
command was issued.
Signed-off-by: Peter Seiderer
Signed-off-by: Philipp Zabel
---
Changes since v4:
- Split out DocBook changes into
driver must explicitly
call vb2_clear_last_buffer_queued. The last buffer queued flag is
cleared automatically during STREAMOFF.
Signed-off-by: Philipp Zabel
---
Changes since v4:
- Split out DocBook changes into a separate patch.
- Documented last_buffer_dequeued flag in vb2_queue comment.
- Moved
buffer is dequeued.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c| 4 ++--
drivers/media/platform/coda/coda-common.c | 27 +++
drivers/media/platform/coda/coda.h| 3 +++
3 files changed, 16 insertions(+), 18 deletions(-)
diff --git
Am Donnerstag, den 16.04.2015, 10:23 +0200 schrieb Kamil Debski:
[...]
> > > But, in general, in what kind of scenario would the driver want to
> > > call this function, as opposed to vb2 clearing this flag by itself on
> > > STREAMOFF?
> >
> > There is VIDIOC_DECODER_CMD / V4L2_DEC_CMD_START.
> >
Am Montag, den 13.04.2015, 14:42 +0900 schrieb Pawel Osciak:
> Hi,
> Thanks for working on this!
>
> On Wed, Mar 25, 2015 at 2:46 AM, Philipp Zabel wrote:
> > From: Peter Seiderer
> >
> > This v4l2_buffer flag can be used by drivers to mark a capture buffer
> &g
Hi Pawel,
thanks for the review!
Am Montag, den 13.04.2015, 15:30 +0900 schrieb Pawel Osciak:
> Hi,
>
> On Wed, Mar 25, 2015 at 2:46 AM, Philipp Zabel wrote:
> > If the last buffer was dequeued from a capture queue, let poll return
> > immediately and let DQBUF return -
T: git git://linuxtv.org/media_tree.git
> S: Maintained
> +F: Documentation/devicetree/bindings/media/i2c/mt9v032.txt
> F: drivers/media/i2c/mt9v032.c
> F: include/media/mt9v032.h
>
> diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c
> index 25
E2BIG is meant to be returned by S_EDID if userspace provided more data than
the hardware can handle. If userspace requested too much data with G_EDID, we
should silently correct the number of EDID blocks downwards.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 9 +
1
Parse the MIPI CSI-2 specific properties in the OF graph endpoint and
add support for the 'clock-noncontinuous' property.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/drivers
From: Mats Randgaard
The driver is tested on our hardware and all the implemented features
works as expected.
Missing features:
- CEC support
- HDCP repeater support
- IR support
Signed-off-by: Mats Randgaard
Signed-off-by: Philipp Zabel
---
MAINTAINERS|6
Hi Mats,
did you have time to work on the TC358743 driver some more in the meanwhile?
These are the changes I have made locally to v1 to get it to work on i.MX6.
regards
Philipp
Mats Randgaard (1):
[media] Driver for Toshiba TC358743 CSI-2 to HDMI bridge
Philipp Zabel (11):
[media
When resetting the CPU instead of power cycling, IntMask is still set
from last boot. Instead of depending on it to be set to its reset
defaults, check the ChipID register and rewrite IntMask if needed.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 12 +---
1 file
Instead of only using the visible width and height, also add the
horizontal and vertical blanking to calculate the bit rate.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/tc358743.c b
This is useful to subscribe to HDMI hotplug events via the
V4L2_CID_DV_RX_POWER_PRESENT control.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index 7d70acc
Add support for registering the sensor subdevice using the v4l2-async API.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index a86cbe0..dfc10f0 100644
igned-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index 74e83c5..34acfed 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -
Add support for probing the TC358743 subdevice from device tree.
The reference clock must be supplied using the common clock bindings.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 133 +--
1 file changed, 128 insertions(+), 5 deletions
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index 34acfed..a510a14 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -749,6 +749,8
set_pll not only skips PLL changes but also doesn't enable it in the
first place if the rate is the same as the default values.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/tc35874
When probed from device tree, the i2c client driver can handle the interrupt
on its own.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 29 -
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media
Am Donnerstag, den 26.03.2015, 09:48 -0700 schrieb Hans Verkuil:
> On 03/26/2015 02:21 AM, Philipp Zabel wrote:
> > Subdevice nodes don't implement VIDIOC_QUERYCAP. This check doesn't
> > allow any operations on v42-subdev nodes, such as setting EDID.
>
> Nack becau
Subdevice nodes don't implement VIDIOC_QUERYCAP. This check doesn't
allow any operations on v42-subdev nodes, such as setting EDID.
Signed-off-by: Philipp Zabel
---
utils/v4l2-ctl/v4l2-ctl.cpp | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2
Issuing a cache flush for the whole bitstream buffer is not optimal in the first
place when only a part of it was written. But given that the buffer is mapped in
writecombine mode, it is not needed at all.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c | 4
1 file
Hi Rob,
Am Dienstag, den 24.03.2015, 23:42 -0500 schrieb Rob Herring:
> On Tue, Mar 24, 2015 at 4:15 AM, Russell King - ARM Linux
> wrote:
> > On Mon, Mar 23, 2015 at 05:29:02PM +0100, Heiko Stuebner wrote:
> >> Hi Rob, Philipp,
> >>
> >> Am Mittwoch,
Setting the last buffer flag causes the videobuf2 core to return -EPIPE from
DQBUF calls on the capture queue after the last buffer is dequeued.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform
driver must explicitly
call vb2_clear_last_buffer_queued. The last buffer queued flag is
cleared automatically during STREAMOFF.
Signed-off-by: Philipp Zabel
---
Changes since v3:
- Added DocBook update mentioning DQBUF returning -EPIPE in the encoder/decoder
stop command documentation
V4L2_DEC_CMD_STOP and VIDIOC_ENCODER_CMD
V4L2_ENC_CMD_STOP documentation.
Signed-off-by: Peter Seiderer
Signed-off-by: Philipp Zabel
---
Changes since v3:
- Added DocBook update mentioning V4L2_BUF_FLAG_LAST in the encoder/decoder
stop command documentation.
---
Documentation/DocBook/media/v4l
buffer is dequeued.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c| 4 ++--
drivers/media/platform/coda/coda-common.c | 27 +++
drivers/media/platform/coda/coda.h| 3 +++
3 files changed, 16 insertions(+), 18 deletions(-)
diff --git
.
regards
Philipp
Peter Seiderer (1):
[media] videodev2: Add V4L2_BUF_FLAG_LAST
Philipp Zabel (3):
[media] videobuf2: return -EPIPE from DQBUF after the last buffer
[media] coda: Set last buffer flag and fix EOS event
[media] s5p-mfc: Set last buffer flag
Documentation/DocBook/media/v4l/io.xml
The parameter buffer is a per-context buffer, so we can allocate and free it
together with the other context buffers during REQBUFS.
Since this was the last context buffer allocated in coda-common.c, we can now
move coda_alloc_context_buf into coda-bit.c.
Signed-off-by: Philipp Zabel
Seiderer
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/coda/coda-common.c
b/drivers/media/platform/coda/coda-common.c
index c81af1b..37bbd57 100644
--- a/drivers/media/platform
non-zero buffer
count.
Signed-off-by: Peter Seiderer
[fixed a resource leak preventing repeatedly decoding]
Signed-off-by: Philipp Zabel
---
Changes since v1:
- Merged Peter's fix, calling coda_free_bitstream_buffer from coda_bit_release.
---
drivers/media/platform/coda/coda-
coda_alloc_aux_buf already prints an error, no need to print duplicate
error messages all over the place.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c| 21 -
drivers/media/platform/coda/coda-common.c | 12 +++-
2 files changed, 7
: Philipp Zabel
---
drivers/media/platform/coda/coda-common.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/coda/coda-common.c
b/drivers/media/platform/coda/coda-common.c
index 4441179..54c972f 100644
--- a/drivers/media/platform/coda/coda-common.c
+++ b
Allocate the per-context buffers from REQBUFS instead in start_encoding or
start_decoding. This allows to stop and start streaming independently of
buffer (re)allocation
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c| 55 ---
drivers
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-common.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/coda/coda-common.c
b/drivers/media/platform/coda/coda-common.c
index b42ccfc..4441179 100644
--- a/drivers/media
From: Peter Seiderer
kasprintf might fail if free memory is low.
Signed-off-by: Peter Seiderer
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-common.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/media/platform/coda/coda-common.c
b/drivers/media
From: Philipp Zabel
When queueing a buffer into the bitstream fails, it has to be requeued
in the videobuf2 queue before streaming starts, but while streaming it
should be returned to userspace with an error.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c| 11
There is no need to take the detour through a "%s" format string
to create a copy of a string.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-common.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/coda/coda-common.c
kfifo_len is unsigned int, return it as such.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/coda/coda.h
b/drivers/media/platform/coda/coda.h
index 0c35cd5..499049f 100644
--- a
the format".
Peter Seiderer (2):
[media] coda: check kasprintf return value in coda_open
[media] coda: fix double call to debugfs_remove
Philipp Zabel (9):
[media] coda: bitstream payload is unsigned
[media] coda: use strlcpy instead of snprintf
[media] coda: allocate per-context buff
Hi Mauro,
Am Donnerstag, den 12.03.2015, 10:58 +0100 schrieb Philipp Zabel:
> Currently the imx-drm driver misuses the V4L2_PIX_FMT constants to describe
> the
> pixel format on the parallel bus between display controllers and encoders. Now
> that MEDIA_BUS_FMT is available, use
Hi Mauro,
Am Montag, den 02.02.2015, 13:24 -0200 schrieb Mauro Carvalho Chehab:
[...]
> Submit the full patch series with the imx-drm driver, mentioning at the
> V4L2 patch that it will be applied via the DRM tree. We'll review
> and give our ack for it to be applied via DRM tree.
I think I also
ption and flags.
>
> If the format is not found in the list, and if the description field is
> filled in, then just return but call WARN_ONCE to let developers know
> that this list needs to be extended.
>
> Based on an earlier patch from Philipp Zabel:
> http://comments.gmane
Am Mittwoch, den 18.03.2015, 17:20 +0100 schrieb Kamil Debski:
> Hi Philipp,
>
> > From: Hans Verkuil [mailto:hverk...@xs4all.nl]
> > Sent: Tuesday, March 17, 2015 5:09 PM
> >
> > On 03/17/2015 11:46 AM, Philipp Zabel wrote:
> > > Hi,
> > >
>
Hi Kamil,
Am Mittwoch, den 18.03.2015, 11:44 +0100 schrieb Kamil Debski:
> Hi Philipp,
>
> > From: Jean-Michel Hautbois [mailto:jhautb...@gmail.com]
> > Sent: Friday, February 27, 2015 10:00 AM
> > To: Philipp Zabel
> > Cc: Kamil Debski; Peter Seiderer; Linux Media
Am Freitag, den 27.02.2015, 09:59 +0100 schrieb Jean-Michel Hautbois:
> Hi Philipp,
>
> 2015-02-23 16:20 GMT+01:00 Philipp Zabel :
> > Signed-off-by: Philipp Zabel
> > ---
> > drivers/media/platform/coda/coda-common.c | 13 -
> > 1 file chan
1001 - 1100 of 1896 matches
Mail list logo