Re: [RFC PATCH] [media] mt9v032: Add support for mt9v022 and mt9v024

2014-05-28 Thread Philipp Zabel
Hi Laurent, Am Mittwoch, den 28.05.2014, 13:43 +0200 schrieb Laurent Pinchart: Hi Philipp, Thank you for the patch. On Monday 26 May 2014 16:03:05 Philipp Zabel wrote: From the looks of it, mt9v022 and mt9v032 are very similar, as are mt9v024 and mt9v034. With minimal changes

Re: [PATCH] [media] mt9v032: do not clear reserved bits in read mode register

2014-05-28 Thread Philipp Zabel
Hi Laurent, Am Mittwoch, den 28.05.2014, 13:30 +0200 schrieb Laurent Pinchart: Hi Philipp, Thank you for the patch. On Monday 26 May 2014 15:59:35 Philipp Zabel wrote: The read mode register bits 8 and 9 are set and marked as reserved. Don't clear them. Good catch. Have you noticed

Re: [RFC PATCH] [media] mt9v032: Add support for mt9v022 and mt9v024

2014-05-28 Thread Philipp Zabel
Hi Guennadi, Laurent, Am Mittwoch, den 28.05.2014, 13:04 +0200 schrieb Laurent Pinchart: Hello, On Wednesday 28 May 2014 12:07:57 Guennadi Liakhovetski wrote: On Wed, 28 May 2014, Philipp Zabel wrote: Am Dienstag, den 27.05.2014, 21:48 +0200 schrieb Guennadi Liakhovetski: On Mon, 26

Re: [PATCH v2] [media] mt9v032: fix hblank calculation

2014-05-28 Thread Philipp Zabel
Hi Laurent, Am Mittwoch, den 28.05.2014, 13:12 +0200 schrieb Laurent Pinchart: Hi Philipp, Thank you for the patch. On Monday 26 May 2014 15:55:51 Philipp Zabel wrote: Since (min_row_time - crop-width) can be negative, we have to do a signed comparison here. Otherwise max_t casts

[PATCH] [media] mem2mem: make queue lock in v4l2_m2m_poll interruptible

2014-05-26 Thread Philipp Zabel
This patch makes the queue lock taken in v4l2_m2m_poll interruptible. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/v4l2-core/v4l2-mem2mem.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media

[PATCH v2] [media] mt9v032: fix hblank calculation

2014-05-26 Thread Philipp Zabel
Since (min_row_time - crop-width) can be negative, we have to do a signed comparison here. Otherwise max_t casts the negative value to unsigned int and sets min_hblank to that invalid value. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v1: - Remove now unneeded casts

[RFC PATCH] [media] mt9v032: reset is self clearing

2014-05-26 Thread Philipp Zabel
According to the publicly available MT9V032 data sheet, the reset bits are self clearing and the reset register always reads 0. The reset will be asserted for 15 SYSCLK cycles. Instead of writing 0 to the register, wait using ndelay. Signed-off-by: Philipp Zabel p.za...@pengutronix.de

[PATCH] [media] mt9v032: register v4l2 asynchronous subdevice

2014-05-26 Thread Philipp Zabel
Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/i2c/mt9v032.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c index 29d8d8f..ded97c2 100644 --- a/drivers/media/i2c/mt9v032.c +++ b/drivers/media/i2c/mt9v032.c

[PATCH] [media] mt9v032: do not clear reserved bits in read mode register

2014-05-26 Thread Philipp Zabel
The read mode register bits 8 and 9 are set and marked as reserved. Don't clear them. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/i2c/mt9v032.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c

[RFC PATCH] [media] mt9v032: Add support for mt9v022 and mt9v024

2014-05-26 Thread Philipp Zabel
From the looks of it, mt9v022 and mt9v032 are very similar, as are mt9v024 and mt9v034. With minimal changes it is possible to support mt9v02[24] with the same driver. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/i2c/mt9v032.c | 56

[PATCH] [media] videobuf2-dma-contig: allow to vmap contiguous dma buffers

2014-05-26 Thread Philipp Zabel
registers and tables are set up. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/v4l2-core/videobuf2-dma-contig.c b/drivers/media/v4l2-core/videobuf2-dma-contig.c index

[PATCH] [media] videobuf2: call __verify_length only for MMAP and USERPTR memory

2014-05-26 Thread Philipp Zabel
For DMABUF memory, buffer length is allowed to be zero on QBUF because the actual buffer size can be taken from the DMABUF. Therefore, the length check can only be done later in __qbuf_dmabuf, once the dmabuf was obtained. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media

[PATCH] [media] mt9v032: fix hblank calculation

2014-05-23 Thread Philipp Zabel
Since (min_row_time - crop-width) can be negative, we have to do a signed comparison here. Otherwise max_t casts the negative value to unsigned int and sets min_hblank to that invalid value. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/i2c/mt9v032.c | 2 +- 1 file

[PATCH] [media] vb2: fix num_buffers calculation if req-count VIDEO_MAX_FRAMES

2014-05-09 Thread Philipp Zabel
Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/v4l2-core/videobuf2-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index 40024d7..4d4f6ba 100644 --- a/drivers

[PATCH] [media] vb2: drop queued buffers while q-start_streaming_called is still set

2014-05-09 Thread Philipp Zabel
Otherwise yet another warning will trigger in vb2_buffer_done. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/v4l2-core/videobuf2-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2

Re: [PATCH] media: coda: Use full device name for request_irq()

2014-04-29 Thread Philipp Zabel
Acked-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index 3e5199e..11023b1 100644 --- a/drivers/media/platform/coda.c +++ b/drivers

Re: [PATCH 2/2] [media] coda: Propagate the correct error on devm_request_threaded_irq()

2014-04-29 Thread Philipp Zabel
-by: Philipp Zabel p.za...@pengutronix.de 2/2 trivially conflicts with [PATCH] media: coda: Use full device name for request_irq() by Alexander Shiyan. --- drivers/media/platform/coda.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/coda.c b

Re: [GIT PULL for v3.15-rc1] media updates

2014-04-06 Thread Philipp Zabel
On Fri, Apr 4, 2014 at 9:17 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Linus, On Friday 04 April 2014 10:26:42 Linus Torvalds wrote: So guys, can you please verify the end result? It looks sane to me, but there's no good way for me to do even basic compile testing of the

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-14 Thread Philipp Zabel
Hi Laurent, Am Donnerstag, den 13.03.2014, 18:13 +0100 schrieb Laurent Pinchart: Hi Philipp, On Thursday 13 March 2014 12:08:16 Philipp Zabel wrote: Am Montag, den 10.03.2014, 14:37 + schrieb Grant Likely: Nak. I made comments that haven't been resolved yet. I've replied

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-13 Thread Philipp Zabel
Hi, Am Montag, den 10.03.2014, 14:37 + schrieb Grant Likely: Nak. I made comments that haven't been resolved yet. I've replied with more detail tonight. The big issues are how drivers handle the optional 'ports' node and I do not agree to the double-linkage in the binding

Re: [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-11 Thread Philipp Zabel
Hi Laurent, Am Montag, den 10.03.2014, 20:19 +0100 schrieb Laurent Pinchart: On Friday 07 March 2014 18:40:54 Philipp Zabel wrote: While we look at of_graph_get_next_endpoint(), could you explain the reason behind the extra reference count increase on the prev node: /* * Avoid

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Philipp Zabel
Hi, Am Dienstag, den 11.03.2014, 15:27 +0200 schrieb Tomi Valkeinen: On 11/03/14 15:16, Laurent Pinchart wrote: And if I gathered Grant's opinion correctly (correct me if I'm wrong), he thinks things should be explicit, i.e. the bindings for, say, an encoder should state that the

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Philipp Zabel
and return -EPROBE_DEFER from their component framework bind callback until all their endpoints are connected. From fdda1fb2bd133200d4620adcbb28697cb360e1cb Mon Sep 17 00:00:00 2001 From: Philipp Zabel p.za...@pengutronix.de Date: Tue, 11 Mar 2014 15:56:18 +0100 Subject: [PATCH] of: Implement

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Philipp Zabel
Hi Laurent, Am Dienstag, den 11.03.2014, 16:21 +0100 schrieb Laurent Pinchart: Hi Philipp, On Tuesday 11 March 2014 16:07:00 Philipp Zabel wrote: Am Montag, den 10.03.2014, 14:58 + schrieb Grant Likely: On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: [snip

Re: [PATCH v6 2/8] Documentation: of: Document graph bindings

2014-03-10 Thread Philipp Zabel
Hi Grant, Am Freitag, den 07.03.2014, 18:27 + schrieb Grant Likely: On Wed, 5 Mar 2014 10:20:36 +0100, Philipp Zabel p.za...@pengutronix.de wrote: The device tree graph bindings as used by V4L2 and documented in Documentation/device-tree/bindings/media/video-interfaces.txt contain

Re: [PATCH v6 2/8] Documentation: of: Document graph bindings

2014-03-10 Thread Philipp Zabel
Am Montag, den 10.03.2014, 12:37 +0100 schrieb Laurent Pinchart: Hi Philipp, On Monday 10 March 2014 10:28:10 Philipp Zabel wrote: Hi Grant, Am Freitag, den 07.03.2014, 18:27 + schrieb Grant Likely: On Wed, 5 Mar 2014 10:20:36 +0100, Philipp Zabel wrote: The device tree

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-10 Thread Philipp Zabel
Am Montag, den 10.03.2014, 16:15 +0100 schrieb Laurent Pinchart: Hi Grant, On Monday 10 March 2014 14:58:15 Grant Likely wrote: On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: On 08/03/14 13:41, Grant Likely wrote:

Re: [PATCH v6 6/8] of: Implement simplified graph binding for single port devices

2014-03-09 Thread Philipp Zabel
On Fri, Mar 07, 2014 at 06:38:02PM +, Grant Likely wrote: On Wed, 5 Mar 2014 10:20:40 +0100, Philipp Zabel p.za...@pengutronix.de wrote: For simple devices with only one port, it can be made implicit. The endpoint node can be a direct child of the device node. Signed-off

Re: [PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-08 Thread Philipp Zabel
Hi Grant, On Fri, Mar 7, 2014 at 6:18 PM, Grant Likely grant.lik...@linaro.org wrote: On Wed, 26 Feb 2014 16:24:57 +0100, Philipp Zabel p.za...@pengutronix.de wrote: The 'ports' node is optional. It is only needed if the parent node has its own #address-cells and #size-cells properties

Re: [PATCH] of: Fix of_graph_parse_endpoint stub for !CONFIG_OF builds

2014-03-07 Thread Philipp Zabel
Am Freitag, den 07.03.2014, 15:57 +0100 schrieb Philipp Zabel: This patch fixes the following build error: In file included from drivers/media/i2c/adv7343.c:29:0: include/linux/of_graph.h:41:1: error: expected identifier or '(' before '{' token { ^ include/linux

Re: [PATCH] of: Fix of_graph_parse_endpoint stub for !CONFIG_OF builds

2014-03-07 Thread Philipp Zabel
Hi Russell, Am Freitag, den 07.03.2014, 15:49 + schrieb Russell King - ARM Linux: On Fri, Mar 07, 2014 at 04:06:10PM +0100, Philipp Zabel wrote: I have also updated the git branch. The following changes since commit d484700a36952c6675aa47dec4d7a536929aa922: of: Warn

Re: [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-07 Thread Philipp Zabel
Hi Laurent, Am Freitag, den 07.03.2014, 01:12 +0100 schrieb Laurent Pinchart: Hi Philipp, Thank you for the patch. I've submitted a fix for the of_graph_get_next_endpoint() function, but it hasn't been applied yet due to the patch series that contained it needing more work. The

Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of

2014-03-06 Thread Philipp Zabel
Am Donnerstag, den 06.03.2014, 15:24 + schrieb Russell King - ARM Linux: On Wed, Mar 05, 2014 at 10:20:34AM +0100, Philipp Zabel wrote: this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Philipp, You mention in your other

Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of

2014-03-06 Thread Philipp Zabel
Am Donnerstag, den 06.03.2014, 16:47 +0100 schrieb Sylwester Nawrocki: On 06/03/14 16:17, Mauro Carvalho Chehab wrote: Em Thu, 06 Mar 2014 14:16:57 + Russell King - ARM Linux li...@arm.linux.org.uk escreveu: On Wed, Mar 05, 2014 at 03:42:34PM +0100, Philipp Zabel wrote: Am Mittwoch

Re: [PATCH v9][ 3/8] staging: imx-drm: Correct BGR666 and the board's dts that use them.

2014-03-06 Thread Philipp Zabel
Hi Denis, Am Donnerstag, den 06.03.2014, 17:01 +0100 schrieb Denis Carikli: The current BGR666 is not consistent with the other color mapings like BGR24. BGR666 should be in the same byte order than BGR24. Signed-off-by: Denis Carikli de...@eukrea.com patches 1 to 3 Acked-by: Philipp Zabel

Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of

2014-03-06 Thread Philipp Zabel
Am Donnerstag, den 06.03.2014, 17:32 +0100 schrieb Sylwester Nawrocki: On 06/03/14 17:21, Philipp Zabel wrote: Am Donnerstag, den 06.03.2014, 16:47 +0100 schrieb Sylwester Nawrocki: Yes, it's going to conflict with my patch series. I thought it could be put onto a stable a topic branch, e.g

[GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-06 Thread Philipp Zabel
) Philipp Zabel (6): [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of Documentation: of: Document graph bindings of: Warn if of_graph_get_next_endpoint is called with the root node of: Reduce indentation in of_graph_get_next_endpoint [media] of: move

Re: [PATCH v6 01/10] Documentation: dt: Add binding documentation for S5K6A3 image sensor

2014-03-06 Thread Philipp Zabel
Hi Sylwester, On Thu, Mar 6, 2014 at 5:20 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: This patch adds binding documentation for the Samsung S5K6A3(YX) raw image sensor. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH v6 7/8] of: Document simplified graph binding for single port devices

2014-03-05 Thread Philipp Zabel
For simple devices with only one port, it can be made implicit. The endpoint node can be a direct child of the device node. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Documentation/devicetree/bindings/graph.txt | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v6 1/8] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-05 Thread Philipp Zabel
, respectively. Since there are not that many current users yet, switch all of them to the new functions right away. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/i2c/adv7343.c | 4 +- drivers/media/i2c/mt9p031.c | 4 +- drivers/media

[PATCH v6 3/8] of: Warn if of_graph_get_next_endpoint is called with the root node

2014-03-05 Thread Philipp Zabel
If of_graph_get_next_endpoint is given a parentless node instead of an endpoint node, it is clearly a bug. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v5: - Added parentless previous endpoint's full name to warning --- drivers/of/base.c | 4 ++-- 1 file changed, 2

[PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-05 Thread Philipp Zabel
A 'return endpoint;' at the end of the (!prev) case allows to reduce the indentation level of the (prev) case. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/of/base.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git

[PATCH v6 6/8] of: Implement simplified graph binding for single port devices

2014-03-05 Thread Philipp Zabel
For simple devices with only one port, it can be made implicit. The endpoint node can be a direct child of the device node. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v5: - Unrolled for-loop in of_graph_get_remote_port_parent --- drivers/of/base.c | 42

[PATCH v6 8/8] of: Warn if of_graph_parse_endpoint is called with the root node

2014-03-05 Thread Philipp Zabel
If of_graph_parse_endpoint is given a parentless node instead of an endpoint node, it is clearly a bug. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/of/base.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/of/base.c b/drivers/of/base.c index ffd0217..75de6bd

[PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of

2014-03-05 Thread Philipp Zabel
for of_graph_parse_endpoint - Unrolled for-loop in of_graph_get_remote_port_parent Philipp Zabel (8): [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of Documentation: of: Document graph bindings of: Warn if of_graph_get_next_endpoint is called with the root node

[PATCH v6 5/8] [media] of: move common endpoint parsing to drivers/of

2014-03-05 Thread Philipp Zabel
properties and is used by v4l2_of_parse_endpoint, which just adds the V4L2 MBUS information to the containing v4l2_of_endpoint structure. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v5: - Fixed documentation comment for of_graph_parse_endpoint --- drivers/media/platform/exynos4

[PATCH v6 2/8] Documentation: of: Document graph bindings

2014-03-05 Thread Philipp Zabel
bindings. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v5: - Fixed spelling errors and a wrong device node name in the link section Documentation/devicetree/bindings/graph.txt | 129 1 file changed, 129 insertions(+) create mode 100644

Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of

2014-03-05 Thread Philipp Zabel
Hi Tomi, Am Mittwoch, den 05.03.2014, 13:35 +0200 schrieb Tomi Valkeinen: Hi, On 05/03/14 11:20, Philipp Zabel wrote: Hi, this version of the OF graph helper move series further addresses a few of Tomi's and Sylwester's comments. Changes since v5: - Fixed spelling errors

Re: [PATCH v5 6/7] of: Implement simplified graph binding for single port devices

2014-03-04 Thread Philipp Zabel
Am Dienstag, den 04.03.2014, 11:06 +0200 schrieb Tomi Valkeinen: On 27/02/14 19:35, Philipp Zabel wrote: For simple devices with only one port, it can be made implicit. The endpoint node can be a direct child of the device node. snip @@ -2105,9 +2112,11 @@ struct device_node

Re: [PATCH v5 5/7] [media] of: move common endpoint parsing to drivers/of

2014-03-04 Thread Philipp Zabel
Am Freitag, den 28.02.2014, 22:09 +0100 schrieb Sylwester Nawrocki: [...] --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -1985,6 +1985,37 @@ struct device_node *of_find_next_cache_node(const struct device_node *np) } /** + * of_graph_parse_endpoint() - parse common

Re: [PATCH v5 3/7] of: Warn if of_graph_get_next_endpoint is called with the root node

2014-03-04 Thread Philipp Zabel
Am Freitag, den 28.02.2014, 22:09 +0100 schrieb Sylwester Nawrocki: On 02/27/2014 06:35 PM, Philipp Zabel wrote: If of_graph_get_next_endpoint is given a parentless node instead of an endpoint node, it is clearly a bug. Signed-off-by: Philipp Zabelp.za...@pengutronix.de --- drivers

Re: [PATCH v5 2/7] Documentation: of: Document graph bindings

2014-03-04 Thread Philipp Zabel
Hi Sylwester, Am Freitag, den 28.02.2014, 22:08 +0100 schrieb Sylwester Nawrocki: Hi Philipp, Just couple minor comments... Thanks, I'll fix all of those. On 02/27/2014 06:35 PM, Philipp Zabel wrote: The device tree graph bindings as used by V4L2 and documented in Documentation/device

Re: [PATCH v5 5/7] [media] of: move common endpoint parsing to drivers/of

2014-03-04 Thread Philipp Zabel
Hi Tomi, Am Dienstag, den 04.03.2014, 10:58 +0200 schrieb Tomi Valkeinen: [...] +int of_graph_parse_endpoint(const struct device_node *node, + struct of_endpoint *endpoint) +{ + struct device_node *port_node = of_get_parent(node); Can port_node be NULL? Probably

Re: [PATCH v5 5/7] [media] of: move common endpoint parsing to drivers/of

2014-03-04 Thread Philipp Zabel
Am Dienstag, den 04.03.2014, 14:21 +0200 schrieb Tomi Valkeinen: On 04/03/14 13:36, Philipp Zabel wrote: [...] Can port_node be NULL? Probably only if something is quite wrong, but maybe it's safer to return error in that case. both of_property_read_u32 and of_node_put can handle

[PATCH 1/2] [media] tvp5150: Fix type mismatch warning in clamp macro

2014-02-27 Thread Philipp Zabel
-height = clamp(rect-height, ^ Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/i2c/tvp5150.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c index 542d252..8ac52fc 100644

[PATCH 2/2] [media] tvp5150: Make debug module parameter visible in sysfs

2014-02-27 Thread Philipp Zabel
Set permissions on the debug module parameter to make it appear in sysfs. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/i2c/tvp5150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c index

[PATCH v5 6/7] of: Implement simplified graph binding for single port devices

2014-02-27 Thread Philipp Zabel
For simple devices with only one port, it can be made implicit. The endpoint node can be a direct child of the device node. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/of/base.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git

[PATCH v5 0/7] Move device tree graph parsing helpers to drivers/of

2014-02-27 Thread Philipp Zabel
bindings from simple phandle graphs. Made it clear that this is not necessarily specific to data connections - Added cleanups to of_graph_get_next_endpoint routine - Added simplified binding for single port devices regards Philipp Philipp Zabel (7): [media] of: move graph helpers from drivers

[PATCH v5 1/7] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-27 Thread Philipp Zabel
, respectively. Since there are not that many current users yet, switch all of them to the new functions right away. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v4: - Moved into drivers/of/base.c instead of creating of_graph.c --- drivers/media/i2c/adv7343.c

[PATCH v5 7/7] of: Document simplified graph binding for single port devices

2014-02-27 Thread Philipp Zabel
For simple devices with only one port, it can be made implicit. The endpoint node can be a direct child of the device node. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Documentation/devicetree/bindings/graph.txt | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v5 4/7] of: Reduce indentation in of_graph_get_next_endpoint

2014-02-27 Thread Philipp Zabel
A 'return endpoint;' at the end of the (!prev) case allows to reduce the indentation level of the (prev) case. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/of/base.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git

[PATCH v5 3/7] of: Warn if of_graph_get_next_endpoint is called with the root node

2014-02-27 Thread Philipp Zabel
If of_graph_get_next_endpoint is given a parentless node instead of an endpoint node, it is clearly a bug. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/of/base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index

[PATCH v5 2/7] Documentation: of: Document graph bindings

2014-02-27 Thread Philipp Zabel
bindings. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v4: - Differentiate from graphs made by simple phandle links - Do not mention data flow except in video-interfaces example - --- Documentation/devicetree/bindings/graph.txt | 129 1 file

[PATCH v5 5/7] [media] of: move common endpoint parsing to drivers/of

2014-02-27 Thread Philipp Zabel
properties and is used by v4l2_of_parse_endpoint, which just adds the V4L2 MBUS information to the containing v4l2_of_endpoint structure. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v4: - Fixed users of struct v4l2_of_endpoint - Removed left-over #include media/of_graph.h from

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-26 Thread Philipp Zabel
Hi Grant, thank you for the comments. Am Mittwoch, den 26.02.2014, 11:01 + schrieb Grant Likely: On Mon, 24 Feb 2014 18:36:29 +0100, Philipp Zabel p.za...@pengutronix.de wrote: Am Dienstag, den 18.02.2014, 16:26 + schrieb Grant Likely: You can find it under

Re: [PATCH v4 3/3] Documentation: of: Document graph bindings

2014-02-26 Thread Philipp Zabel
Hi Tomi, Am Mittwoch, den 26.02.2014, 15:14 +0200 schrieb Tomi Valkeinen: On 25/02/14 16:58, Philipp Zabel wrote: +Optional endpoint properties + + +- remote-endpoint: phandle to an 'endpoint' subnode of a remote device node. Why is that optional? What

Re: [PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-26 Thread Philipp Zabel
Hi Grant, Am Mittwoch, den 26.02.2014, 11:37 + schrieb Grant Likely: [...] drivers/media/v4l2-core/v4l2-of.c | 117 -- drivers/of/Makefile | 1 + drivers/of/of_graph.c | 134

Re: [PATCH v4 3/3] Documentation: of: Document graph bindings

2014-02-26 Thread Philipp Zabel
Am Mittwoch, den 26.02.2014, 16:50 +0200 schrieb Tomi Valkeinen: On 26/02/14 16:57, Philipp Zabel wrote: Hi Tomi, Am Mittwoch, den 26.02.2014, 15:14 +0200 schrieb Tomi Valkeinen: On 25/02/14 16:58, Philipp Zabel wrote: +Optional endpoint properties

[PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-25 Thread Philipp Zabel
From: Philipp Zabel philipp.za...@gmail.com This patch moves the parsing helpers used to parse connected graphs in the device tree, like the video interface bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt, from drivers/media/v4l2-core to drivers

[PATCH v4 2/3] [media] of: move common endpoint parsing to drivers/of

2014-02-25 Thread Philipp Zabel
parses those properties and is used by v4l2_of_parse_endpoint, which just adds the V4L2 MBUS information to the containing v4l2_of_endpoint structure. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/v4l2-core/v4l2-of.c | 16 +++- drivers/of/of_graph.c | 32

[PATCH v4 0/3] Move device tree graph parsing helpers to drivers/of

2014-02-25 Thread Philipp Zabel
description Documentation/devicetree/bindings/graph.txt. Changes since v3: - Moved back to drivers/of - Added DT binding documentation regards Philipp Philipp Zabel (3): [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of [media] of: move common endpoint parsing to drivers

[PATCH v4 3/3] Documentation: of: Document graph bindings

2014-02-25 Thread Philipp Zabel
bindings. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Documentation/devicetree/bindings/graph.txt | 98 + 1 file changed, 98 insertions(+) create mode 100644 Documentation/devicetree/bindings/graph.txt diff --git a/Documentation/devicetree/bindings/graph.txt b

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-24 Thread Philipp Zabel
wrote: On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel p.za...@pengutronix.de wrote: From: Philipp Zabel philipp.za...@gmail.com This patch moves the parsing helpers used to parse connected graphs in the device tree, like the video interface bindings documented

Re: [PATCH v2 0/3] uvcvideo VIDIOC_CREATE_BUFS support

2014-02-19 Thread Philipp Zabel
v4l2-compliance test. Laurent Pinchart (2): uvcvideo: Remove duplicate check for number of buffers in queue_setup uvcvideo: Support allocating buffers larger than the current frame size Philipp Zabel (1): uvcvideo: Enable VIDIOC_CREATE_BUFS drivers/media/usb/uvc/uvc_queue.c | 20

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-18 Thread Philipp Zabel
Hi Grant, Am Montag, den 17.02.2014, 18:14 + schrieb Grant Likely: On Tue, 11 Feb 2014 07:56:33 -0600, Rob Herring robherri...@gmail.com wrote: On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel p.za...@pengutronix.de wrote: From: Philipp Zabel philipp.za...@gmail.com This patch

Re: [PATCH 0/3] uvcvideo VIDIOC_CREATE_BUFS support

2014-02-18 Thread Philipp Zabel
implementation and supporting allocation of buffers larger than the current frame size. As you've submitted patch 3/3 I assume you have a use case, could you then please test the patch set to make sure 1/3 and 2/3 don't break anything ? Tested-by: Philipp Zabel p.za...@pengutronix.de Using

[PATCH v3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/media

2014-02-14 Thread Philipp Zabel
From: Philipp Zabel philipp.za...@gmail.com This patch moves the parsing helpers used to parse connected graphs in the device tree, like the video interface bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt, from drivers/media/v4l2-core to drivers/media

[PATCH] [media] of: move common endpoint parsing to drivers/media

2014-02-14 Thread Philipp Zabel
adds the V4L2 MBUS information to the containing v4l2_of_endpoint structure. of_graph_parse_endpoint is split out so that non-V4L2 drivers don't have to open code reading the port and endpoint ids from the reg properties. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media

Re: [PATCH v2] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/media

2014-02-12 Thread Philipp Zabel
Hi Mauro, Am Mittwoch, den 12.02.2014, 06:53 +0900 schrieb Mauro Carvalho Chehab: [...] diff --git a/include/media/of_graph.h b/include/media/of_graph.h new file mode 100644 index 000..3bbeb60 --- /dev/null +++ b/include/media/of_graph.h @@ -0,0 +1,46 @@ +/* + * OF graph

Re: [PATCH v2] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/media

2014-02-12 Thread Philipp Zabel
Hi Mauro, Am Mittwoch, den 12.02.2014, 22:35 +0900 schrieb Mauro Carvalho Chehab: Em Wed, 12 Feb 2014 10:11:54 +0100 Philipp Zabel p.za...@pengutronix.de escreveu: Hi Mauro, Am Mittwoch, den 12.02.2014, 06:53 +0900 schrieb Mauro Carvalho Chehab: [...] diff --git a/include/media

[RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Philipp Zabel
From: Philipp Zabel philipp.za...@gmail.com This patch moves the parsing helpers used to parse connected graphs in the device tree, like the video interface bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt, from drivers/media/v4l2-core to drivers

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Philipp Zabel
Hi Rob, Am Dienstag, den 11.02.2014, 07:56 -0600 schrieb Rob Herring: On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel p.za...@pengutronix.de wrote: From: Philipp Zabel philipp.za...@gmail.com This patch moves the parsing helpers used to parse connected graphs in the device tree, like

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Philipp Zabel
Am Dienstag, den 11.02.2014, 16:23 +0100 schrieb Laurent Pinchart: Hi Russell, On Tuesday 11 February 2014 14:52:48 Russell King - ARM Linux wrote: On Tue, Feb 11, 2014 at 07:56:33AM -0600, Rob Herring wrote: On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel wrote: This allows to reuse

[PATCH v2] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/media

2014-02-11 Thread Philipp Zabel
From: Philipp Zabel philipp.za...@gmail.com This patch moves the parsing helpers used to parse connected graphs in the device tree, like the video interface bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt, from drivers/media/v4l2-core to drivers/media

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-11 Thread Philipp Zabel
Hi Sylwester, On Tue, Feb 11, 2014 at 06:22:34PM +0100, Sylwester Nawrocki wrote: drivers/media sounds like a good alternative to me. I would just remove also v4l2_of_{parse/get}* and update the users to call of_graph_* directly, there should not be many of them. For now I'd like to skip

[PATCH] [media] uvcvideo: Check format and frame size in VIDIOC_CREATE_BUFS

2014-02-03 Thread Philipp Zabel
Verify that create_bufs requests buffers with the currently selected format and frame size, return an error otherwise. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/usb/uvc/uvc_v4l2.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/media/usb

Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-02-02 Thread Philipp Zabel
On Sun, Feb 02, 2014 at 11:21:13AM +0100, Laurent Pinchart wrote: Hi Hans, On Friday 31 January 2014 09:43:00 Hans Verkuil wrote: I think you might want to add a check in uvc_queue_setup to verify the fmt that create_bufs passes. The spec says that: Unsupported formats will result in an

[PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-01-29 Thread Philipp Zabel
This patch enables the ioctl to create additional buffers on the videobuf2 capture queue. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/usb/uvc/uvc_queue.c | 11 +++ drivers/media/usb/uvc/uvc_v4l2.c | 10 ++ drivers/media/usb/uvc/uvcvideo.h | 2 ++ 3

Re: [PATCH] [media] v4l: vb2-dma-contig: add support for file access mode flags for DMABUF exporting

2013-10-08 Thread Philipp Zabel
is needed to map videobuf2 exported dmabuf fds writeable from userspace, for example for timestamp software rendering into frames passing from a v4l2 capture device to a v4l2 output device. regards Philipp On 05/21/2013 10:11 AM, Philipp Zabel wrote: Currently it is not possible for userspace

Re: iram pool not available for MX27

2013-09-30 Thread Philipp Zabel
Hi Chris, Am Montag, den 30.09.2013, 13:40 +0800 schrieb Chris Ruehl: Hi Phillipp, hope things doing OK. I recently update to the 3.12-rc kernel and hit this problem below. [ 3.377790] coda coda-imx27.0: iram pool not available [ 3.383363] coda: probe of coda-imx27.0 failed with error

Re: [PATCH 04/10] [media] coda: fix FMO value setting for CodaDx6

2013-09-30 Thread Philipp Zabel
Am Montag, den 30.09.2013, 13:48 +0200 schrieb Hans Verkuil: On 09/19/2013 11:13 AM, Philipp Zabel wrote: The register is only written on CodaDx6, so the temporary variable to be written only needs to be initialized on CodaDx6. Signed-off-by: Philipp Zabel p.za...@pengutronix.de

Re: [PATCH 07/10] [media] coda: prefix v4l2_ioctl_ops with coda_

2013-09-30 Thread Philipp Zabel
Am Montag, den 30.09.2013, 13:50 +0200 schrieb Hans Verkuil: On 09/19/2013 11:13 AM, Philipp Zabel wrote: Moving the ioctl handler callbacks into the coda namespace helps tremendously to make sense of backtraces. I like the idea, but I would just use the coda_ prefix, not coda_vidioc_

[PATCH v2 01/10] [media] coda: allow more than four instances on CODA7541

2013-09-30 Thread Philipp Zabel
With the new firmware, there are not anymore four register sets, but a single register set, which the driver has to conserve across context switches. This allows to handle more than four instances at the same time. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform

[PATCH v2 03/10] [media] coda: add compressed flag to format enumeration output

2013-09-30 Thread Philipp Zabel
Correctly flag compressed formats in the ENUM_FMT ioctl output. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index 945c539..53539c1 100644

[PATCH v2 06/10] [media] coda: use picture type returned from hardware

2013-09-30 Thread Philipp Zabel
Instead of copying v4l2_buf.flags from the source buffer, set the destination buffer flags as reported by the hardware codec. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media

[PATCH v2 09/10] [media] coda: v4l2-compliance fix: implement try_decoder_cmd

2013-09-30 Thread Philipp Zabel
Implement try_decoder_cmd to let userspace determine available commands and flags. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/coda.c

[PATCH v2 07/10] [media] coda: prefix v4l2_ioctl_ops with coda_ instead of vidioc_

2013-09-30 Thread Philipp Zabel
Moving the ioctl handler callbacks into the coda namespace helps tremendously to make sense of backtraces. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v1: - Use coda_ instead of coda_vidioc_ prefix --- drivers/media/platform/coda.c | 123

[PATCH v2 08/10] [media] coda: v4l2-compliance fix: overwrite invalid pixel formats with the current setting

2013-09-30 Thread Philipp Zabel
This patch fixes the v4l2-compliance TRY_FMT(G_FMT) != G_FMT issue. The driver now overwrites invalid formats with the current setting, using coda_get_max_dimensions to find device specific max width/height. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c

[PATCH v2 10/10] [media] coda: v4l2-compliance fix: zero pixel format priv field

2013-09-30 Thread Philipp Zabel
If unused, the pixel format priv field has to be cleared by the driver in try_fmt. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v1: - Clear pixel format priv in try_fmt only --- drivers/media/platform/coda.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers

[PATCH v2 0/10] CODA driver fixes

2013-09-30 Thread Philipp Zabel
This series contains a few fixes for the CODA driver to allow more than four simultaneous instances on i.MX53, and to make v4l2-compliance a bit happier. Changes since v1: - Removed no-op lines leaving FMOPARAM fields of CMD_ENC_SEQ_FMO at zero values on CodaDx6. - Use coda_ instead of

<    9   10   11   12   13   14   15   16   >