Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-18 Thread Samuel Bobrowicz
> On Oct 18, 2018, at 3:03 AM, jacopo mondi wrote: > >> On Thu, Oct 18, 2018 at 11:31:52AM +0200, Maxime Ripard wrote: >>> On Wed, Oct 17, 2018 at 09:51:43PM +0200, jacopo mondi wrote: >>> Hello Sam and Maxime (and other ov5640-ers :) >>> On Wed, Oct 17, 2018 at 10:54:01AM -0700, Sam

Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-18 Thread Samuel Bobrowicz
Hey Jacobi, Not a lot of time to respond right now, these days I’m bouncing around between a couple jobs. I’ll be trying your and Maximes patches and responding to tech details this weekend. Just want to say that as long as we get the driver working I’m happy :) The VAST majority of time put

Re: [PATCH 1/4] media: ov5640: fix resolution update

2018-10-16 Thread Samuel Bobrowicz
Glad this is spurring a lot of conversation, and I’m happy to see this many contributors too. I think we have all solved many of these problems (and the many others) offline, and now it’s the hard part to try to glue them all together. I decided to jump back in the mix with these patches

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-04-18 Thread Samuel Bobrowicz
--- Sam Bobrowicz Elite Embedded Consulting LLC elite-embedded.com On Tue, Apr 17, 2018 at 9:01 AM, Maxime Ripard <maxime.rip...@bootlin.com> wrote: > On Mon, Apr 16, 2018 at 04:22:39PM -0700, Samuel Bobrowicz wrote: >> I've been digging around the ov5640.c code for

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-04-16 Thread Samuel Bobrowicz
I've been digging around the ov5640.c code for a few weeks now, these look like some solid improvements. I'll give them a shot and let you know how they work. On that note, I'm bringing up a module that uses dual lane MIPI with a 12MHz fixed oscillator for xclk (Digilent's Pcam 5c). The mainline

Re: OV5640 with 12MHz xclk

2018-04-16 Thread Samuel Bobrowicz
, Apr 16, 2018 at 11:44 AM, Steve Longerbeam <slongerb...@gmail.com> wrote: > Hi Sam, > > On 04/16/2018 05:26 AM, Hans Verkuil wrote: >> >> On 04/16/2018 03:39 AM, Samuel Bobrowicz wrote: >>> >>> Can anyone verify if the OV5640 driver works with

OV5640 with 12MHz xclk

2018-04-15 Thread Samuel Bobrowicz
Can anyone verify if the OV5640 driver works with input clocks other than the typical 24MHz? The driver suggests anything from 6MHz-24MHz is acceptable, but I am running into issues while bringing up a module that uses a 12MHz oscillator. I'd expect that different xclk's would necessitate