Signed-off-by: Phil Edworthy
---
v2:
- Fix silly mistake with missing break.
drivers/media/platform/soc_camera/rcar_vin.c |9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/media/platform/soc_camera/rcar_vin.c
b/drivers/media/platform/soc_camera/rcar_vin.c
index 3b1c05a
Signed-off-by: Phil Edworthy
---
drivers/media/platform/soc_camera/rcar_vin.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/platform/soc_camera/rcar_vin.c
b/drivers/media/platform/soc_camera/rcar_vin.c
index 3b1c05a..9929375 100644
--- a/drivers/media/platform
Hi Guennadi,
> > Ok, now I see. My comment about the sensor output size changing is
wrong.
> > The sensor doesn't do any scaling, so we are cropping it.
>
> Ah, ok, then you shouldn't change video sizes in your .s_fmt(), just
> return the current cropping rectangle.
I'm reworking the code but
Hi Guennadi,
> > There is one issue with setting the camera to achieve different
framerate.
> > The camera can work at up to 60fps with lower resolutions, i.e. when
> > vertical sub-sampling is used. However, the API uses separate
functions
> > for changing resolution and framerate. So, users
Hi Guennadi,
> > +{
> > + struct i2c_client *client = v4l2_get_subdevdata(sd);
> > + struct ov10635_priv *priv = to_ov10635(client);
> > + struct v4l2_captureparm *cp = &parms->parm.capture;
> > + enum v4l2_mbus_pixelcode code;
> > + int ret;
> > +
> > + if (parms->type != V4L2_BUF_TYP
Hi Laurent,
> From: Laurent Pinchart
> To: Phil Edworthy ,
> Cc: linux-media@vger.kernel.org, Jean-Philippe Francois
> , Hans Verkuil , Guennadi
> Liakhovetski , Mauro Carvalho Chehab
> Date: 16/07/2013 13:05
> Subject: Re: [PATCH v3] ov10635: Add OmniVision ov106
Hi Guennadi,
> > > > +/* read a register */
> > > > +static int ov10635_reg_read(struct i2c_client *client, u16 reg,
u8
> > *val)
> > > > +{
> > > > + int ret;
> > > > + u8 data[2] = { reg >> 8, reg & 0xff };
> > > > + struct i2c_msg msg = {
> > > > + .addr = client->addr,
> > > > +
Hi Guennadi,
Thanks for the review.
> I'll comment to this version, although the driver has to be updated to
the
> V4L2 clock API at least, preferably also to asynchronous probing.
Ok, I'll have to look into that.
> > + * FIXME:
> > + * Horizontal flip (mirroring) does not work correctly. T
Hi Guennadi,
> Well, I think, both of you will agree, that these register value lists
> look horrible and actually have little to do with open-source software,
> but I don't know what to do about them either. We could just reject them
> and only accept drivers, properly describing what they d
Hi Guennadi,
> Thanks for the patch. I'll look at it in more detail hopefully soon
> enough... One remark so far to Jean-Philippe's comment:
>
[snip]
> > Register 0x3042 is only touched by the enable part, not by the "change
> > mode" part
> > I think you could move the {0x3042, 0xf0} sequence i
Signed-off-by: Phil Edworthy
---
v3:
- Removed dupplicated writes to reg 0x3042
- Program all the standard registers after checking the ID
v2:
- Simplified flow in ov10635_s_ctrl.
- Removed chip ident code - build tested only
drivers/media/i2c/soc_camera/Kconfig |6 +
drivers/media
Hi Jean-Philippe,
Thanks for the review.
> > +static const struct ov10635_reg ov10635_regs_enable[] = {
> > + { 0x3042, 0xf0 }, { 0x3042, 0xf0 }, { 0x3042, 0xf0 }, {
> 0x3042, 0xf0 },
> > + { 0x3042, 0xf0 }, { 0x3042, 0xf0 }, { 0x3042, 0xf0 }, {
> 0x3042, 0xf0 },
> > + { 0x30
Signed-off-by: Phil Edworthy
---
v2:
- Simplified flow in ov10635_s_ctrl.
- Removed chip ident code - build tested only
drivers/media/i2c/soc_camera/Kconfig |6 +
drivers/media/i2c/soc_camera/Makefile |1 +
drivers/media/i2c/soc_camera/ov10635.c | 1141
Hi Hans,
> Subject: Re: [PATCH] ov10635: Add OmniVision ov10635 SoC camera driver
> > +#include
>
> Don't implement chip_ident or use this header: it's going to be
> removed in 3.11.
> > +/* Set status of additional camera capabilities */
> > +static int ov10635_s_ctrl(struct v4l2_ctrl *ctrl
Signed-off-by: Phil Edworthy
---
drivers/media/i2c/soc_camera/Kconfig |6 +
drivers/media/i2c/soc_camera/Makefile |1 +
drivers/media/i2c/soc_camera/ov10635.c | 1169
include/media/v4l2-chip-ident.h|1 +
4 files changed, 1177 insertions
Hi Sergei, Vladimir,
> > Oops, the comments about the captured image contents are my fault.
> > However, the unhandled irq after stopping capture is still an issue.
>
> Thanks for letting us know.
The good news is that your driver works fine.
The problem I saw only occurs when your patches
Hi Sergei, Vladimir,
> > >> Subject: [PATCH v5] V4L2: soc_camera: Renesas R-Car VIN driver
> >
> > >> From: Vladimir Barinov
> >
> > >> Add Renesas R-Car VIN (Video In) V4L2 driver.
> >
> > >> Based on the patch by Phil Edwo
Hi Sergei, Vladimir,
> >> Subject: [PATCH v5] V4L2: soc_camera: Renesas R-Car VIN driver
>
> >> From: Vladimir Barinov
>
> >> Add Renesas R-Car VIN (Video In) V4L2 driver.
>
> >> Based on the patch by Phil Edworthy .
>
> > I've see
Hi Sergei, Vladimir,
> Subject: [PATCH v5] V4L2: soc_camera: Renesas R-Car VIN driver
>
> From: Vladimir Barinov
>
> Add Renesas R-Car VIN (Video In) V4L2 driver.
>
> Based on the patch by Phil Edworthy .
I've seen old patches that add VIN to the Marzen board, do yo
Hi Guennadi,
> From: Guennadi Liakhovetski
> To: phil.edwor...@renesas.com,
> Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab
> Date: 26/04/2013 22:00
> Subject: Re: [PATCH] soc_camera: Add V4L2_MBUS_FMT_YUYV10_2X10 format
>
> Hi Phil
>
> On Fri, 26 Apr 2013, phil.edwor...@renesas.com
Hi Guennadi,
> > > > > Wow, what kind of host can pack two 10-bit samples into 3 bytes
and
> > > > write
> > > > > 3-byte pixels to memory?
> > > > I think I might have misunderstood how this is used. From my
> > > > understanding, the MBUS formats are used to describe the hardware
> > > > i
Hi Guennadi,
> > > On Wed, 17 Apr 2013, Phil Edworthy wrote:
> > >
> > > > The V4L2_MBUS_FMT_YUYV10_2X10 format has already been added to
> > mediabus, so
> > > > this patch just adds SoC camera support.
> > > >
> > > > S
Hi Guennadi,
Thanks for the review!
> On Wed, 17 Apr 2013, Phil Edworthy wrote:
>
> > The V4L2_MBUS_FMT_YUYV10_2X10 format has already been added to
mediabus, so
> > this patch just adds SoC camera support.
> >
> > Signed-off-by: Phil Edworthy
> > ---
&g
The V4L2_MBUS_FMT_YUYV10_2X10 format has already been added to mediabus, so
this patch just adds SoC camera support.
Signed-off-by: Phil Edworthy
---
drivers/media/platform/soc_camera/soc_mediabus.c | 15 +++
include/media/soc_mediabus.h |3 +++
2 files
Based on work done by Katsuya Matsubara.
Signed-off-by: Phil Edworthy
---
v2:
- Added documentation.
- Added SOCAM_DATAWIDTH_12 definition.
Documentation/DocBook/media/v4l/subdev-formats.xml | 206 +++-
Documentation/DocBook/media_api.tmpl |1 +
drivers
Hi Guennadi,
> From: Guennadi Liakhovetski
> To: Phil Edworthy ,
> Cc: Mauro Carvalho Chehab ,
linux-media@vger.kernel.org
> Date: 08/03/2013 13:30
> Subject: Re: [PATCH] soc_camera: Add RGB666 & RGB888 formats
>
> Hi Phil
>
> On Thu, 14 Feb 2013, Phil Edwor
Hi Guennadi,
Thanks for the review, I'll try to find some time to fix & send a new
version.
Phil
> On Thu, 14 Feb 2013, Phil Edworthy wrote:
>
> > Based on work done by Katsuya Matsubara.
> >
> > Signed-off-by: Phil Edworthy
>
> Looks mostly goo
Based on work done by Katsuya Matsubara.
Signed-off-by: Phil Edworthy
---
drivers/media/platform/soc_camera/soc_mediabus.c | 42 ++
include/media/soc_camera.h |6 +++-
include/media/soc_mediabus.h |3 ++
include/uapi/linux
Hi Guennadi, Morimoto-san,
> > > Both are needed.
> > > These are bug fix patches
> >
> > I tried to capture several frames beginning with the very first one
(as
> > much as performance allowed), and I do see several black or wrongly
> > coloured framed in the beginning, but none of those patc
29 matches
Mail list logo
