Re: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-27 Thread Guennadi Liakhovetski
Mauro, Hans Can I pull this patch as is via my tree, or shall we ask the author to split it into two: to add the subdev operation and to implement it for soc-camera? Thanks Guennadi On Thu, 20 Jan 2011, Qing Xu wrote: add vidioc_enum_framesizes implementation, follow default_g_parm() and

RE: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-21 Thread Guennadi Liakhovetski
-camera: add enum-frame-size ioctl add vidioc_enum_framesizes implementation, follow default_g_parm() and g_mbus_fmt() method Signed-off-by: Qing Xu qi...@marvell.com --- drivers/media/video/soc_camera.c | 37 + include/media/soc_camera.h |1

Re: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-21 Thread Hans Verkuil
. Regards, Hans Thanks Guennadi -Qing -Original Message- From: Qing Xu [mailto:qi...@marvell.com] Sent: 2011年1月21日 9:48 To: g.liakhovet...@gmx.de Cc: linux-media@vger.kernel.org; Qing Xu Subject: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

Re: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-21 Thread Guennadi Liakhovetski
: soc-camera: add enum-frame-size ioctl add vidioc_enum_framesizes implementation, follow default_g_parm() and g_mbus_fmt() method Signed-off-by: Qing Xu qi...@marvell.com --- drivers/media/video/soc_camera.c | 37 + include/media

RE: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-21 Thread Qing Xu
-Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: 2011年1月21日 18:43 To: Hans Verkuil Cc: Qing Xu; linux-media@vger.kernel.org; Laurent Pinchart Subject: Re: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl On Fri, 21 Jan 2011, Hans Verkuil wrote

[PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-20 Thread Qing Xu
add vidioc_enum_framesizes implementation, follow default_g_parm() and g_mbus_fmt() method Signed-off-by: Qing Xu qi...@marvell.com --- drivers/media/video/soc_camera.c | 37 + include/media/soc_camera.h |1 + include/media/v4l2-subdev.h |

Re: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-20 Thread Guennadi Liakhovetski
On Thu, 20 Jan 2011, Qing Xu wrote: add vidioc_enum_framesizes implementation, follow default_g_parm() and g_mbus_fmt() method Yes, thanks, that's more like what I meant! Now, this patch also touches a generic v4l2 file include/media/v4l2-subdev.h, and that in a very essential way - it ads a

RE: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-20 Thread Qing Xu
Hi Guennadi, Thanks for your careful review and patient and your time!! -Qing -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: 2011年1月20日 16:28 To: Qing Xu Cc: Linux Media Mailing List; Hans Verkuil Subject: Re: [PATCH] [media] v4l: soc-camera: add

[PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-20 Thread Qing Xu
add vidioc_enum_framesizes implementation, follow default_g_parm() and g_mbus_fmt() method Signed-off-by: Qing Xu qi...@marvell.com --- drivers/media/video/soc_camera.c | 37 + include/media/soc_camera.h |1 + 2 files changed, 38 insertions(+), 0

RE: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-20 Thread Qing Xu
To: g.liakhovet...@gmx.de Cc: linux-media@vger.kernel.org; Qing Xu Subject: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl add vidioc_enum_framesizes implementation, follow default_g_parm() and g_mbus_fmt() method Signed-off-by: Qing Xu qi...@marvell.com --- drivers/media/video

RE: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-19 Thread Guennadi Liakhovetski
. -Original Message- From: Qing Xu [mailto:qi...@marvell.com] Sent: 2011年1月19日 10:37 To: g.liakhovet...@gmx.de Cc: linux-media@vger.kernel.org; Qing Xu Subject: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl add vidioc_enum_framesizes implementation Signed-off

[PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-19 Thread Qing Xu
add vidioc_enum_framesizes implementation, follow default_g_parm() and g_mbus_fmt() method Signed-off-by: Qing Xu qi...@marvell.com --- drivers/media/video/soc_camera.c | 36 include/media/soc_camera.h |1 + include/media/v4l2-subdev.h |2

Re: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-19 Thread Guennadi Liakhovetski
On Thu, 20 Jan 2011, Qing Xu wrote: add vidioc_enum_framesizes implementation, follow default_g_parm() and g_mbus_fmt() method Signed-off-by: Qing Xu qi...@marvell.com --- drivers/media/video/soc_camera.c | 36 include/media/soc_camera.h |

RE: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-19 Thread Guennadi Liakhovetski
Hm, sorry! My below comment: On Wed, 19 Jan 2011, Guennadi Liakhovetski wrote: On Tue, 18 Jan 2011, Qing Xu wrote: [snip] @@ -1160,6 +1169,28 @@ static int default_s_parm(struct soc_camera_device *icd, return v4l2_subdev_call(sd, video, s_parm, parm); } +static int

Re: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-18 Thread Guennadi Liakhovetski
On Mon, 17 Jan 2011, Qing Xu wrote: add vidioc_enum_framesizes implementation, follow default_g_parm() and g_mbus_fmt() method Signed-off-by: Qing Xu qi...@marvell.com --- drivers/media/video/soc_camera.c | 42 ++ include/media/soc_camera.h |

[PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-18 Thread Qing Xu
add vidioc_enum_framesizes implementation Signed-off-by: Qing Xu qi...@marvell.com --- drivers/media/video/soc_camera.c | 34 ++ include/media/soc_camera.h |1 + include/media/v4l2-subdev.h |2 ++ 3 files changed, 37 insertions(+), 0

RE: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-18 Thread Qing Xu
[mailto:qi...@marvell.com] Sent: 2011年1月19日 10:37 To: g.liakhovet...@gmx.de Cc: linux-media@vger.kernel.org; Qing Xu Subject: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl add vidioc_enum_framesizes implementation Signed-off-by: Qing Xu qi...@marvell.com --- drivers/media/video

[PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-17 Thread Qing Xu
add vidioc_enum_framesizes implementation, follow default_g_parm() and g_mbus_fmt() method Signed-off-by: Qing Xu qi...@marvell.com --- drivers/media/video/soc_camera.c | 42 ++ include/media/soc_camera.h |1 + include/media/v4l2-subdev.h |

RE: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-10 Thread Guennadi Liakhovetski
On Sun, 9 Jan 2011, Qing Xu wrote: On Mon, 10 Jan 2011, Qing Xu wrote: On Fri, 7 Jan 2011, Guennadi Liakhovetski wrote: On Fri, 7 Jan 2011, Qing Xu wrote: pass VIDIOC_ENUM_FRAMESIZES down to sub device drivers. So far no special handling in soc-camera core. Hm, no, guess

Re: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-10 Thread Laurent Pinchart
Hi Guennadi, On Monday 10 January 2011 09:20:05 Guennadi Liakhovetski wrote: On Sun, 9 Jan 2011, Qing Xu wrote: On Fri, 7 Jan 2011, Guennadi Liakhovetski wrote: On Fri, 7 Jan 2011, Qing Xu wrote: pass VIDIOC_ENUM_FRAMESIZES down to sub device drivers. So far no special handling in

Re: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-07 Thread Laurent Pinchart
Hi Guennadi, On Friday 07 January 2011 15:37:35 Guennadi Liakhovetski wrote: On Fri, 7 Jan 2011, Qing Xu wrote: pass VIDIOC_ENUM_FRAMESIZES down to sub device drivers. So far no special handling in soc-camera core. Hm, no, guess what? I don't think this can work. The parameter, that this

[PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-06 Thread Qing Xu
pass VIDIOC_ENUM_FRAMESIZES down to sub device drivers. So far no special handling in soc-camera core. Signed-off-by: Kassey Lee y...@marvell.com Signed-off-by: Qing Xu qi...@marvell.com --- drivers/media/video/soc_camera.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-)