[PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

2014-12-22 Thread Matthias Schwarzott
Unconditionally attaching Si2161/Si2165 demod driver breaks Hauppauge WinTV Starburst. So create own card entry for this. Add card name comments to the subsystem ids. This fixes a regression introduced in 3.17 by 36efec48e2e6016e05364906720a0ec350a5d768 ([media] cx23885: Add si2165 support for H

Re: [PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

2014-12-22 Thread Steven Toth
> In my understanding Starburst is HVR-4400, but only satellite tuner is > installed to PCB - whilst terrestrial/cable is left out. I went back through my engineering notes from my Hauppauge engineering days, this statement is correct. -- Steven Toth - Kernel Labs http://www.kernellabs.com -- To

Re: [PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

2014-12-22 Thread Antti Palosaari
On 12/22/2014 03:36 PM, Matthias Schwarzott wrote: On 22.12.2014 14:25, Mauro Carvalho Chehab wrote: Em Sun, 21 Dec 2014 21:07:02 +0100 Matthias Schwarzott escreveu: Hi! Should the commit message directly point to the breaking commit 36efec48e2e6016e05364906720a0ec350a5d768? Yes, if this

Re: [PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

2014-12-22 Thread Matthias Schwarzott
On 22.12.2014 14:25, Mauro Carvalho Chehab wrote: > Em Sun, 21 Dec 2014 21:07:02 +0100 > Matthias Schwarzott escreveu: > >> Hi! >> >> Should the commit message directly point to the breaking commit >> 36efec48e2e6016e05364906720a0ec350a5d768? > > Yes, if this fixes an issue that happened on a pr

Re: [PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

2014-12-22 Thread Mauro Carvalho Chehab
Em Sun, 21 Dec 2014 21:07:02 +0100 Matthias Schwarzott escreveu: > Hi! > > Should the commit message directly point to the breaking commit > 36efec48e2e6016e05364906720a0ec350a5d768? Yes, if this fixes an issue that happened on a previous commit, then you should add the original commit there.

Re: [PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

2014-12-22 Thread Steven Toth
>> Please change CX23885_BOARD_HAUPPAUGE_STARBURST to >> CX23885_BOARD_HAUPPAUGE_HVR5500. >> >> Thanks, >> > Hi Steven, > > thank you for your feedback. > > I rechecked the names and this are the more or less supported devices: > * Starburst supports DVB-S2 only > * HVR-4400 supports DVB-S2 + DVB-T

Re: [PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

2014-12-22 Thread Matthias Schwarzott
On 22.12.2014 13:59, Steven Toth wrote: > On Sun, Dec 21, 2014 at 2:59 PM, Matthias Schwarzott wrote: >> Unconditionally attaching Si2161/Si2165 demod driver >> breaks Hauppauge WinTV Starburst. >> So create own card entry for this. >> >> Add card name comments to the subsystem ids. >> >> Signed-o

Re: [PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

2014-12-22 Thread Steven Toth
On Sun, Dec 21, 2014 at 2:59 PM, Matthias Schwarzott wrote: > Unconditionally attaching Si2161/Si2165 demod driver > breaks Hauppauge WinTV Starburst. > So create own card entry for this. > > Add card name comments to the subsystem ids. > > Signed-off-by: Matthias Schwarzott Matthias, Thank you

Re: [PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

2014-12-21 Thread Antti Palosaari
Works now media: Linux media interface: v0.10 Linux video capture interface: v2.00 cx23885 driver version 0.0.4 loaded CORE cx23885[0]: subsystem: 0070:c12a, board: Hauppauge WinTV Starburst [card=52,autodetected] tveeprom 5-0050: Hauppauge model 121200, rev B2C3, serial# 4034388477 tveeprom 5-

Re: [PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

2014-12-21 Thread Matthias Schwarzott
Hi! Should the commit message directly point to the breaking commit 36efec48e2e6016e05364906720a0ec350a5d768? This commit hopefully reverts the problematic attach for the Starburst card. I kept the GPIO-part in common, but I can split this also if necessary. Regards Matthias -- To unsubscribe f

[PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

2014-12-21 Thread Matthias Schwarzott
Unconditionally attaching Si2161/Si2165 demod driver breaks Hauppauge WinTV Starburst. So create own card entry for this. Add card name comments to the subsystem ids. Signed-off-by: Matthias Schwarzott --- drivers/media/pci/cx23885/cx23885-cards.c | 23 +-- drivers/media/pci