Re: [PATCH] gspca - ov534: Fix the light frequency filter

2012-11-29 Thread Hans de Goede
Hi Jean-Francois, Antonio Ospite, Could it be that you're both right, and that the register Jean-Francois suggest is used (0x13) and uses in his patch is for enabling / disabling the light-freq filter, where as the register which were used before this patch (0x2a, 0x2b) are used to select the

Re: [PATCH] gspca - ov534: Fix the light frequency filter

2012-11-29 Thread Antonio Ospite
On Thu, 29 Nov 2012 10:25:19 +0100 Hans de Goede hdego...@redhat.com wrote: Hi Jean-Francois, Antonio Ospite, Could it be that you're both right, and that the register Jean-Francois suggest is used (0x13) and uses in his patch is for enabling / disabling the light-freq filter, where as the

Re: [PATCH] gspca - ov534: Fix the light frequency filter

2012-11-26 Thread Antonio Ospite
On Fri, 23 Nov 2012 19:12:32 +0100 Jean-Francois Moine moin...@free.fr wrote: On Fri, 23 Nov 2012 18:09:09 +0100 Antonio Ospite osp...@studenti.unina.it wrote: [...] In the datasheet I have for ov772x, bit[6] of register 0x13 is described as: Bit[6]: AEC - Step size limit 0:

Re: [PATCH] gspca - ov534: Fix the light frequency filter

2012-11-26 Thread Jean-Francois Moine
On Mon, 26 Nov 2012 14:08:06 +0100 Antonio Ospite osp...@studenti.unina.it wrote: For now I'd NAK the patch since it is a regression for users with 50Hz power sources and it looks like it does not _always_ work for 60Hz either. Should I remove it from patchwork as well? As I have the

Re: [PATCH] gspca - ov534: Fix the light frequency filter

2012-11-26 Thread Antonio Ospite
On Mon, 26 Nov 2012 16:23:18 +0100 Jean-Francois Moine moin...@free.fr wrote: On Mon, 26 Nov 2012 14:08:06 +0100 Antonio Ospite osp...@studenti.unina.it wrote: For now I'd NAK the patch since it is a regression for users with 50Hz power sources and it looks like it does not _always_ work

Re: [PATCH] gspca - ov534: Fix the light frequency filter

2012-11-26 Thread Jean-Francois Moine
On Mon, 26 Nov 2012 18:12:41 +0100 Antonio Ospite osp...@studenti.unina.it wrote: BTW the documentation might also be wrong or inaccurate. The ov7670 documentation has exactly the same description of the register 0x2b, and I don't think that the manufacturer would greatly change the meaning of

Re: [PATCH] gspca - ov534: Fix the light frequency filter

2012-11-23 Thread Antonio Ospite
On Thu, 22 Nov 2012 12:46:52 +0100 Jean-Francois Moine moin...@free.fr wrote: (fix lack of signature) From: Jean-François Moine moin...@free.fr The exchanges relative to the light frequency filter were adapted from a description found in a ms-windows driver. It seems that the registers

Re: [PATCH] gspca - ov534: Fix the light frequency filter

2012-11-23 Thread Jean-Francois Moine
On Fri, 23 Nov 2012 18:09:09 +0100 Antonio Ospite osp...@studenti.unina.it wrote: On Thu, 22 Nov 2012 12:46:52 +0100 [snip] Jean-Francois Moine moin...@free.fr wrote: This patch was done thanks to the documentation of the right OmniVision sensors. In the datasheet I have for

[PATCH] gspca - ov534: Fix the light frequency filter

2012-11-22 Thread Jean-Francois Moine
(fix lack of signature) From: Jean-François Moine moin...@free.fr The exchanges relative to the light frequency filter were adapted from a description found in a ms-windows driver. It seems that the registers were the ones of some other sensor. This patch was done thanks to the documentation of

[PATCH] gspca - ov534: Fix the light frequency filter.

2012-11-22 Thread Jean-Francois Moine
From: Jean-François Moine moin...@free.fr The exchanges relative to the light frequency filter were adapted from a description found in a ms-windows driver. It seems that the registers were the ones of some other sensor. This patch was done thanks to the documentation of the right OmniVision