> even when not used. I think it will also cause the compiler to emit warnings
> for unused functions. I don't think that's a good idea.
Where is my brown paper bag? :/
> > But if you insist on drivers/i2c/i2c-sccb.c, then it should be a
> > seperate module, I'd think?
>
> Given how small the
Hi Wolfram,
On Tuesday, 10 July 2018 15:07:47 EEST Wolfram Sang wrote:
> >> +static inline int sccb_read_byte(struct i2c_client *client, u8 addr)
> >> +{
> >> + int ret;
> >> + union i2c_smbus_data data;
> >> +
> >> + i2c_lock_bus(client->adapter, I2C_LOCK_SEGMENT);
> >> +
> >> + ret =
> > +static inline int sccb_read_byte(struct i2c_client *client, u8 addr)
> > +{
> > + int ret;
> > + union i2c_smbus_data data;
> > +
> > + i2c_lock_bus(client->adapter, I2C_LOCK_SEGMENT);
> > +
> > + ret = __i2c_smbus_xfer(client->adapter, client->addr, client->flags,
> > +
Hi Akinobu,
Thank you for the patch.
On Monday, 9 July 2018 18:41:13 EEST Akinobu Mita wrote:
> This adds Serial Camera Control Bus (SCCB) helpers (sccb_is_available,
> sccb_read_byte, and sccb_write_byte) that are intended to be used by some
> of Omnivision sensor drivers.
>
> The ov772x
Hi,
yes! From a first look this nails it for me. Thanks for doing it.
Minor comments follow...
> +#if 0
> + /*
> + * sccb_xfer not needed yet, since there is no driver support currently.
> + * Just showing how it should be done if we ever need it.
> + */
> + if
This adds Serial Camera Control Bus (SCCB) helpers (sccb_is_available,
sccb_read_byte, and sccb_write_byte) that are intended to be used by some
of Omnivision sensor drivers.
The ov772x driver is going to use these helpers.
It was previously only worked with the i2c controller drivers that
