> > +static inline int sccb_read_byte(struct i2c_client *client, u8 addr)
> > +{
> > + int ret;
> > + union i2c_smbus_data data;
> > +
> > + i2c_lock_bus(client->adapter, I2C_LOCK_SEGMENT);
> > +
> > + ret = __i2c_smbus_xfer(client->adapter, client->addr, client->flags,
> > + I2C_SMBUS_WRITE, addr, I2C_SMBUS_BYTE, NULL);
> > + if (ret < 0)
> > + goto out;
> > +
> > + ret = __i2c_smbus_xfer(client->adapter, client->addr, client->flags,
> > + I2C_SMBUS_READ, 0, I2C_SMBUS_BYTE, &data);
> > +out:
> > + i2c_unlock_bus(client->adapter, I2C_LOCK_SEGMENT);
> > +
> > + return ret < 0 ? ret : data.byte;
> > +}
>
> I think I mentioned in a previous review of this patch that the function is
> too big to be a static inline. It should instead be moved to a .c file.Can be argued. I assume just removing the 'inline' won't do it for you? I'd be fine with that, there are not many SCCB useres out there... But if you insist on drivers/i2c/i2c-sccb.c, then it should be a seperate module, I'd think?
signature.asc
Description: PGP signature
