[PATCH 1/5] media: ov7670: add support for ov7675.

2012-09-26 Thread Javier Martin
ov7675 and ov7670 share the same registers but there is no way to distinguish them at runtime. However, they require different tweaks to achieve the desired resolution. For this reason this patch adds a new ov7675 entry to the ov7670_id table. Signed-off-by: Javier Martin --- drivers/media/i2c/o

Re: [PATCH 1/5] media: ov7670: add support for ov7675.

2012-09-26 Thread Jonathan Corbet
This is going to have to be quick, sorry... On Wed, 26 Sep 2012 11:47:53 +0200 Javier Martin wrote: > +static struct ov7670_win_size ov7670_win_sizes[2][4] = { > + /* ov7670 */ I must confess I don't like this; now we've got constants in an array that was automatically sized before and ov76

Re: [PATCH 1/5] media: ov7670: add support for ov7675.

2012-09-26 Thread javier Martin
Hi Jonathan, thank you for your time. On 26 September 2012 18:40, Jonathan Corbet wrote: > This is going to have to be quick, sorry... > > On Wed, 26 Sep 2012 11:47:53 +0200 > Javier Martin wrote: > >> +static struct ov7670_win_size ov7670_win_sizes[2][4] = { >> + /* ov7670 */ > > I must con

Re: [PATCH 1/5] media: ov7670: add support for ov7675.

2012-10-06 Thread Mauro Carvalho Chehab
Em Thu, 27 Sep 2012 08:58:33 +0200 javier Martin escreveu: > Hi Jonathan, > thank you for your time. > > On 26 September 2012 18:40, Jonathan Corbet wrote: > > This is going to have to be quick, sorry... > > > > On Wed, 26 Sep 2012 11:47:53 +0200 > > Javier Martin wrote: > > > >> +static struc

Re: [PATCH 1/5] media: ov7670: add support for ov7675.

2012-10-08 Thread javier Martin
On 6 October 2012 17:19, Mauro Carvalho Chehab wrote: > Em Thu, 27 Sep 2012 08:58:33 +0200 > javier Martin escreveu: > >> Hi Jonathan, >> thank you for your time. >> >> On 26 September 2012 18:40, Jonathan Corbet wrote: >> > This is going to have to be quick, sorry... >> > >> > On Wed, 26 Sep 20