Re: [PATCH 16/16] media: imx: add mem2mem device

2018-07-23 Thread Steve Longerbeam
On 07/23/2018 12:31 AM, Philipp Zabel wrote: ipu_image_convert_adjust tries to adjust both input and output image at the same time, here we just have the format of either input or output image. Do you suggest to split this function into an input and an output version? See b4362162c0

Re: [PATCH 16/16] media: imx: add mem2mem device

2018-07-23 Thread Philipp Zabel
On Sun, 2018-07-22 at 11:02 -0700, Steve Longerbeam wrote: > On 07/16/2018 07:12 AM, Philipp Zabel wrote: [...] > > > > + /* > > > > +* The IC burst reads 8 pixels at a time. Reading > > > > beyond the > > > > +* end of the line is usually acceptable.

Re: [PATCH 16/16] media: imx: add mem2mem device

2018-07-22 Thread Steve Longerbeam
On 07/16/2018 07:12 AM, Philipp Zabel wrote: Hi Steve, On Thu, 2018-07-05 at 15:09 -0700, Steve Longerbeam wrote: [...] [...] + halign = 0; + break; + } + if (f->type == V4L2_BUF_TYPE_VIDEO_OUTPUT) { + /* +* The IC burst

Re: [PATCH 16/16] media: imx: add mem2mem device

2018-07-16 Thread Philipp Zabel
Hi Steve, On Thu, 2018-07-05 at 15:09 -0700, Steve Longerbeam wrote: [...] > > +static int mem2mem_try_fmt(struct file *file, void *priv, > > + struct v4l2_format *f) > > +{ [...] > > + /* > > +* Horizontally/vertically chroma subsampled formats must have even > > +

Re: [PATCH 16/16] media: imx: add mem2mem device

2018-07-16 Thread Philipp Zabel
Hi Pavel, On Tue, 2018-07-10 at 14:07 +0200, Pavel Machek wrote: [...] > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * i.MX IPUv3 mem2mem Scaler/CSC driver > > + * > > + * Copyright (C) 2011 Pengutronix, Sascha Hauer > > + * Copyright (C) 2018 Pengutronix, Philipp Zabel > > + * > > + *

Re: [PATCH 16/16] media: imx: add mem2mem device

2018-07-10 Thread Pavel Machek
Hi! > Add a single imx-media mem2mem video device that uses the IPU IC PP > (image converter post processing) task for scaling and colorspace > conversion. > On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used. > > The hardware only supports writing to destination buffers up to

Re: [PATCH 16/16] media: imx: add mem2mem device

2018-07-05 Thread Steve Longerbeam
Hi Philipp, On 06/22/2018 08:52 AM, Philipp Zabel wrote: Add a single imx-media mem2mem video device that uses the IPU IC PP (image converter post processing) task for scaling and colorspace conversion. On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used. The hardware only

Re: [PATCH 16/16] media: imx: add mem2mem device

2018-06-22 Thread kbuild test robot
Hi Philipp, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.18-rc1 next-20180622] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 16/16] media: imx: add mem2mem device

2018-06-22 Thread Nicolas Dufresne
Le vendredi 22 juin 2018 à 17:52 +0200, Philipp Zabel a écrit : > Add a single imx-media mem2mem video device that uses the IPU IC PP > (image converter post processing) task for scaling and colorspace > conversion. > On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used. > > The

[PATCH 16/16] media: imx: add mem2mem device

2018-06-22 Thread Philipp Zabel
Add a single imx-media mem2mem video device that uses the IPU IC PP (image converter post processing) task for scaling and colorspace conversion. On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used. The hardware only supports writing to destination buffers up to 1024x1024 pixels