Re: [PATCH 2/2] mn88472: fix firmware loading

2014-12-08 Thread Benjamin Larsson
On 12/07/2014 11:36 PM, Antti Palosaari wrote: On 12/08/2014 12:10 AM, Benjamin Larsson wrote: The firmware must be loaded one byte at a time via the 0xf6 register. I don't think so. Currently it downloads firmware in 22 byte chunks and it seems to work, at least for me, both mn88472 and

Re: [PATCH 2/2] mn88472: fix firmware loading

2014-12-08 Thread Benjamin Larsson
On 12/07/2014 11:36 PM, Antti Palosaari wrote: On 12/08/2014 12:10 AM, Benjamin Larsson wrote: The firmware must be loaded one byte at a time via the 0xf6 register. I don't think so. Currently it downloads firmware in 22 byte chunks and it seems to work, at least for me, both mn88472 and

Re: [PATCH 2/2] mn88472: fix firmware loading

2014-12-08 Thread Antti Palosaari
Moikka! On 12/08/2014 01:12 PM, Benjamin Larsson wrote: On 12/07/2014 11:36 PM, Antti Palosaari wrote: On 12/08/2014 12:10 AM, Benjamin Larsson wrote: The firmware must be loaded one byte at a time via the 0xf6 register. I don't think so. Currently it downloads firmware in 22 byte chunks

Re: [PATCH 2/2] mn88472: fix firmware loading

2014-12-08 Thread Antti Palosaari
Hello! On 12/08/2014 06:04 PM, Benjamin Larsson wrote: On 12/07/2014 11:36 PM, Antti Palosaari wrote: On 12/08/2014 12:10 AM, Benjamin Larsson wrote: The firmware must be loaded one byte at a time via the 0xf6 register. I don't think so. Currently it downloads firmware in 22 byte chunks and

Re: [PATCH 2/2] mn88472: fix firmware loading

2014-12-08 Thread Benjamin Larsson
On 12/08/2014 06:46 PM, Antti Palosaari wrote: Hello! [...] regmap_bulk_write(): Write multiple registers to the device In this case we want to write multiple bytes to the same register. So I think that my patch is correct in principle. You haven't make any test whether it is possible to

[PATCH 2/2] mn88472: fix firmware loading

2014-12-07 Thread Benjamin Larsson
The firmware must be loaded one byte at a time via the 0xf6 register. Signed-off-by: Benjamin Larsson benja...@southpole.se --- drivers/staging/media/mn88472/mn88472.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git

Re: [PATCH 2/2] mn88472: fix firmware loading

2014-12-07 Thread Antti Palosaari
On 12/08/2014 12:10 AM, Benjamin Larsson wrote: The firmware must be loaded one byte at a time via the 0xf6 register. I don't think so. Currently it downloads firmware in 22 byte chunks and it seems to work, at least for me, both mn88472 and mn88473. Signed-off-by: Benjamin Larsson