Hi Phil,
On Mon, 29 Jul 2013, phil.edwor...@renesas.com wrote:
> Hi Guennadi,
>
> > > Ok, now I see. My comment about the sensor output size changing is
> wrong.
> > > The sensor doesn't do any scaling, so we are cropping it.
> >
> > Ah, ok, then you shouldn't change video sizes in your .s_fm
Hi Guennadi,
> > Ok, now I see. My comment about the sensor output size changing is
wrong.
> > The sensor doesn't do any scaling, so we are cropping it.
>
> Ah, ok, then you shouldn't change video sizes in your .s_fmt(), just
> return the current cropping rectangle.
I'm reworking the code but
Hi Guennadi,
> > There is one issue with setting the camera to achieve different
framerate.
> > The camera can work at up to 60fps with lower resolutions, i.e. when
> > vertical sub-sampling is used. However, the API uses separate
functions
> > for changing resolution and framerate. So, users
Hi Phil
On Thu, 18 Jul 2013, phil.edwor...@renesas.com wrote:
> Hi Guennadi,
>
> > > +{
> > > + struct i2c_client *client = v4l2_get_subdevdata(sd);
> > > + struct ov10635_priv *priv = to_ov10635(client);
> > > + struct v4l2_captureparm *cp = &parms->parm.capture;
> > > + enum v4l2_mbus_
Hi Guennadi,
> > +{
> > + struct i2c_client *client = v4l2_get_subdevdata(sd);
> > + struct ov10635_priv *priv = to_ov10635(client);
> > + struct v4l2_captureparm *cp = &parms->parm.capture;
> > + enum v4l2_mbus_pixelcode code;
> > + int ret;
> > +
> > + if (parms->type != V4L2_BUF_TYP
Hi Phil,
On Tuesday 16 July 2013 14:54:41 phil.edwor...@renesas.com wrote:
> On 16/07/2013 13:05 Laurent Pinchart wrote:
> > On Wednesday 05 June 2013 10:11:35 Phil Edworthy wrote:
> > > Signed-off-by: Phil Edworthy
> > > ---
> > >
> > > v3:
> > > - Removed dupplicated writes to reg 0x3042
> >
Hi Laurent,
> From: Laurent Pinchart
> To: Phil Edworthy ,
> Cc: linux-media@vger.kernel.org, Jean-Philippe Francois
> , Hans Verkuil , Guennadi
> Liakhovetski , Mauro Carvalho Chehab
> Date: 16/07/2013 13:05
> Subject: Re: [PATCH v3] ov10635: Add OmniVision ov106
Hi Phil,
Thank you for the patch.
On Wednesday 05 June 2013 10:11:35 Phil Edworthy wrote:
> Signed-off-by: Phil Edworthy
> ---
> v3:
> - Removed dupplicated writes to reg 0x3042
> - Program all the standard registers after checking the ID
>
> v2:
> - Simplified flow in ov10635_s_ctrl.
> - R
On Mon, 15 Jul 2013, phil.edwor...@renesas.com wrote:
> Ok, now I see. My comment about the sensor output size changing is wrong.
> The sensor doesn't do any scaling, so we are cropping it.
Ah, ok, then you shouldn't change video sizes in your .s_fmt(), just
return the current cropping rectangl
Hi Guennadi,
> > > > +/* read a register */
> > > > +static int ov10635_reg_read(struct i2c_client *client, u16 reg,
u8
> > *val)
> > > > +{
> > > > + int ret;
> > > > + u8 data[2] = { reg >> 8, reg & 0xff };
> > > > + struct i2c_msg msg = {
> > > > + .addr = client->addr,
> > > > +
Hi Phil
On Mon, 15 Jul 2013, phil.edwor...@renesas.com wrote:
[snip]
> > > +/* read a register */
> > > +static int ov10635_reg_read(struct i2c_client *client, u16 reg, u8
> *val)
> > > +{
> > > + int ret;
> > > + u8 data[2] = { reg >> 8, reg & 0xff };
> > > + struct i2c_msg msg = {
> > >
Hi Guennadi,
Thanks for the review.
> I'll comment to this version, although the driver has to be updated to
the
> V4L2 clock API at least, preferably also to asynchronous probing.
Ok, I'll have to look into that.
> > + * FIXME:
> > + * Horizontal flip (mirroring) does not work correctly. T
Hi Phil
I'll comment to this version, although the driver has to be updated to the
V4L2 clock API at least, preferably also to asynchronous probing.
On Wed, 5 Jun 2013, Phil Edworthy wrote:
> Signed-off-by: Phil Edworthy
> ---
> v3:
> - Removed dupplicated writes to reg 0x3042
> - Program al
Signed-off-by: Phil Edworthy
---
v3:
- Removed dupplicated writes to reg 0x3042
- Program all the standard registers after checking the ID
v2:
- Simplified flow in ov10635_s_ctrl.
- Removed chip ident code - build tested only
drivers/media/i2c/soc_camera/Kconfig |6 +
drivers/media/i2
14 matches
Mail list logo
