Re: [PATCH v5] media: video-i2c: add video-i2c driver

2017-01-13 Thread Matt Ranostay
On Fri, Jan 13, 2017 at 3:47 AM, Laurent Pinchart wrote: > Hi Matt, > > Thank you for the patch. > > On Friday 23 Dec 2016 19:04:26 Matt Ranostay wrote: >> There are several thermal sensors that only have a low-speed bus >> interface but output valid video data. This patchset enables support >> fo

Re: [PATCH v5] media: video-i2c: add video-i2c driver

2017-01-13 Thread Matt Ranostay
On Fri, Jan 13, 2017 at 2:22 AM, Laurent Pinchart wrote: > Hi Matt, > > On Thursday 12 Jan 2017 20:45:21 Matt Ranostay wrote: >> On Sun, Jan 8, 2017 at 9:33 PM, Marek Vasut wrote: >> > On 01/09/2017 06:17 AM, Matt Ranostay wrote: >> >> Gentle ping on this! :) >> > >> > Just some high-level feedba

Re: [PATCH v5] media: video-i2c: add video-i2c driver

2017-01-13 Thread Laurent Pinchart
Hi Matt, Thank you for the patch. On Friday 23 Dec 2016 19:04:26 Matt Ranostay wrote: > There are several thermal sensors that only have a low-speed bus > interface but output valid video data. This patchset enables support > for the AMG88xx "Grid-Eye" sensor family. > > Cc: Attila Kinali > Cc:

Re: [PATCH v5] media: video-i2c: add video-i2c driver

2017-01-13 Thread Laurent Pinchart
Hi Matt, On Thursday 12 Jan 2017 20:45:21 Matt Ranostay wrote: > On Sun, Jan 8, 2017 at 9:33 PM, Marek Vasut wrote: > > On 01/09/2017 06:17 AM, Matt Ranostay wrote: > >> Gentle ping on this! :) > > > > Just some high-level feedback ... You should use regmap instead. Also, > > calling a driver wh

Re: [PATCH v5] media: video-i2c: add video-i2c driver

2017-01-12 Thread Matt Ranostay
On Sun, Jan 8, 2017 at 9:33 PM, Marek Vasut wrote: > On 01/09/2017 06:17 AM, Matt Ranostay wrote: >> Gentle ping on this! :) > > Just some high-level feedback ... You should use regmap instead. Also, > calling a driver which is specific to a particular sensor (amg88x) by > generic name (video_i2c)

Re: [PATCH v5] media: video-i2c: add video-i2c driver

2017-01-08 Thread Marek Vasut
On 01/09/2017 06:17 AM, Matt Ranostay wrote: > Gentle ping on this! :) Just some high-level feedback ... You should use regmap instead. Also, calling a driver which is specific to a particular sensor (amg88x) by generic name (video_i2c) is probably not a good idea. > Thanks, > > Matt > >> On De

Re: [PATCH v5] media: video-i2c: add video-i2c driver

2017-01-08 Thread Matt Ranostay
Gentle ping on this! :) Thanks, Matt > On Dec 23, 2016, at 19:04, Matt Ranostay wrote: > > There are several thermal sensors that only have a low-speed bus > interface but output valid video data. This patchset enables support > for the AMG88xx "Grid-Eye" sensor family. > > Cc: Attila Kinali

[PATCH v5] media: video-i2c: add video-i2c driver

2016-12-23 Thread Matt Ranostay
There are several thermal sensors that only have a low-speed bus interface but output valid video data. This patchset enables support for the AMG88xx "Grid-Eye" sensor family. Cc: Attila Kinali Cc: Marek Vasut Cc: Luca Barbato Cc: Laurent Pinchart Signed-off-by: Matt Ranostay --- Changes from