[PATCHv4] Add Freescale MC44S803 tuner driver

2009-01-15 Thread Jochen Friedrich
Signed-off-by: Jochen Friedrich --- Changes since v1: - rebase against official linux tree. v1 was based against a local tree and didn't apply cleanly. Changes since v2: - fix typo KERN_ERROR -> KERN_ERR Changes since v3: - fix circuit adjust (reserved bits should be 1) - don't initialize priv

[PATCHv4] Add Freescale MC44S803 tuner driver

2009-01-19 Thread Jochen Friedrich
Signed-off-by: Jochen Friedrich --- Changes since v1: - rebase against official linux tree. v1 was based against a local tree and didn't apply cleanly. Changes since v2: - fix typo KERN_ERROR -> KERN_ERR Changes since v3: - fix circuit adjust (reserved bits should be 1) - don't initialize priv

Re: [PATCHv4] Add Freescale MC44S803 tuner driver

2009-01-17 Thread Antti Palosaari
Hello Jochen, I just reviewed this patch and here is my comments; Jochen Friedrich wrote: + buf[0] = (val & 0xFF) >> 16; I am not sure where it comes I have seen comments sometimes that we should use lower case hex numbers. + return -EREMOTEIO; [...] + u8 re

Re: [PATCHv4] Add Freescale MC44S803 tuner driver

2009-01-17 Thread Detlef Rohde
Hi All, I have to apologize being a stupid newbie not able to put Antti's latest source (mc44s803-71b0ef33303a) into my kernel (2.6.27-11-generic). Have performed successfully a "make", but running "install" failed because of missed option settings for this operation. I am uncertain if I must

Re: [PATCHv4] Add Freescale MC44S803 tuner driver

2009-01-17 Thread Roberto Ragusa
Detlef Rohde wrote: > > Hi All, > I have to apologize being a stupid newbie not able to put Antti's latest > source (mc44s803-71b0ef33303a) into my kernel (2.6.27-11-generic). > Have performed successfully a "make", but running "install" failed > because of missed option settings for this operatio

Re: [PATCHv4] Add Freescale MC44S803 tuner driver

2009-01-18 Thread Detlef Rohde
Good morning Roberto, thanks for the firmware file which finally helped getting my DVB-T running! I pasted it in the /lib/firmware tree and could get a new message: Jan 18 11:42:56 detlef-laptop kernel: [ 7677.396309] usb 4-3.3: new high speed USB device using ehci_hcd and address 6 Jan 18 11:42:

Re: [PATCHv4] Add Freescale MC44S803 tuner driver

2009-01-19 Thread Jochen Friedrich
Hi Antti, >> +buf[0] = (val & 0xFF) >> 16; > > I am not sure where it comes I have seen comments sometimes that we > should use lower case hex numbers. OK, will fix. >> +return -EREMOTEIO; > [...] >> +u8 ret, id; > > Error status (-EREMOTEIO) is stored to the u8, which

Re: [PATCHv4] Add Freescale MC44S803 tuner driver

2009-01-19 Thread Antti Palosaari
Jochen Friedrich wrote: This is definitely a BUG. I'll also fix this. Do you want me to post an update to the tuner or an incremental patch against your repository? Post new patch. I hope Mauro will pick up your patch and add it to the master when no more comments are given. Anyhow, I don't kn

Re: [PATCHv4] Add Freescale MC44S803 tuner driver

2009-01-19 Thread Jochen Friedrich
I hope some day I will learn to number my patches correctly :-(. This should have been: [PATCHv5] Add Freescale MC44S803 tuner driver -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger