Re: [RFC PATCH 0/2] Add support for RDS decoding (updated)

2012-08-08 Thread Konke Radlow
just for the record, these patches are: Signed-off-by: Konke Radlow krad...@cisco.com Regards, Konke On Tue, Aug 7, 2012 at 3:11 PM, Konke Radlow krad...@cisco.com wrote: Hello, first of all: thank you for the comments to my previous RFC for the libv4l2rds library and the rds-ctl control

[RFC PATCH 0/2] Add support for RDS decoding (updated)

2012-08-07 Thread Konke Radlow
Hello, first of all: thank you for the comments to my previous RFC for the libv4l2rds library and the rds-ctl control testing tool. The proposed changes have been implemented, and the code has been further improved after a thorough code review by Hans Verkuil. Changes: -the code is

Re: [RFC PATCH 0/2] Add support for RDS decoding

2012-07-30 Thread Konke Radlow
thank you for the info, it's working now (I went for the include solution) -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 0/2] Add support for RDS decoding

2012-07-29 Thread Gregor Jasny
Hello Konke, On 7/27/12 4:27 PM, Konke Radlow wrote: changing the condition in the library header from #if __GNUC__ = 4 #define LIBV4L_PUBLIC __attribute__ ((visibility(default))) #else #define LIBV4L_PUBLIC #endif to #if HAVE_VISIBILITY #define LIBV4L_PUBLIC __attribute__

Re: [RFC PATCH 0/2] Add support for RDS decoding

2012-07-27 Thread Konke Radlow
Yes, I realized too late that the library header file was missing from the submitted patch. I created a additional patch and attached it to the [RFC PATCH 1/2] thread. I updated the repository. It should now be based on the most recent version of the tree (I used

Re: [RFC PATCH 0/2] Add support for RDS decoding

2012-07-26 Thread Gregor Jasny
Hello Konke, On 7/25/12 7:43 PM, Konke Radlow wrote: The latest version of the code can always be found in my github repository: https://github.com/koradlow/v4l2-rds-ctl In the github dir is a lib/include/libv4l2rd.h file. I cannot find it in the patchset. It also looks like you're bases on an

[RFC PATCH 0/2] Add support for RDS decoding

2012-07-25 Thread Konke Radlow
Hello, Over the last couple of weeks I have been working on a library that adds RDS decoding support to the v4l-utils repository. It currently supports the core RDS standard but no advanced features yet like ODA (TMC). I also wrote a control application that can be used to test the library with