Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-13 Thread Sylwester Nawrocki
On 01/11/2012 11:36 PM, Sakari Ailus wrote: This is what the spec says: This is an action control. When set (the value is ignored), the device will do a white balance and then hold the current setting. Contrast this with the boolean V4L2_CID_AUTO_WHITE_BALANCE, which, when activated, keeps

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-11 Thread Sakari Ailus
On Wed, Jan 04, 2012 at 11:06:13PM +0100, Sylwester Nawrocki wrote: Hi Sakari, On 01/04/2012 10:24 PM, Sakari Ailus wrote: I don't quite understand the purpose of the do_white_balance; the automatic white balance algorithm is operational until it's disabled, and after disabling it the

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-04 Thread Sakari Ailus
Hi Sylwester, On Sun, Jan 01, 2012 at 04:38:21PM +0100, Sylwester Nawrocki wrote: On 12/30/2011 09:41 PM, Sakari Ailus wrote: On Fri, Dec 30, 2011 at 11:14:39AM +0100, Sylwester Nawrocki wrote: On 12/30/2011 12:34 AM, Sakari Ailus wrote: On Wed, Dec 28, 2011 at 02:51:38PM +0100, Laurent

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-04 Thread Laurent Pinchart
Hi Sakari, On Wednesday 04 January 2012 21:39:34 Sakari Ailus wrote: On Sun, Jan 01, 2012 at 04:38:21PM +0100, Sylwester Nawrocki wrote: On 12/30/2011 09:41 PM, Sakari Ailus wrote: On Fri, Dec 30, 2011 at 11:14:39AM +0100, Sylwester Nawrocki wrote: On 12/30/2011 12:34 AM, Sakari Ailus

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-04 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: Hi Sakari, On Wednesday 04 January 2012 21:39:34 Sakari Ailus wrote: On Sun, Jan 01, 2012 at 04:38:21PM +0100, Sylwester Nawrocki wrote: On 12/30/2011 09:41 PM, Sakari Ailus wrote: On Fri, Dec 30, 2011 at 11:14:39AM +0100, Sylwester Nawrocki wrote: On

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-02 Thread Sylwester Nawrocki
Hi, On 12/28/2011 02:35 PM, Sylwester Nawrocki wrote: On 12/28/2011 07:23 AM, HeungJun, Kim wrote: It adds the new CID for setting White Balance Preset. This CID is provided as menu type using the following items: How about adding V4L2_WHITE_BALANCE_PRESET_NONE or

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-02 Thread Sylwester Nawrocki
Hi HeungJun, On 01/02/2012 05:38 AM, Kim, Heungjun wrote: On 2011년 12월 30일 19:30, Sylwester Nawrocki wrote: On 12/29/2011 06:08 AM, HeungJun, Kim wrote: I guess the WBP menu controls of pwc driver is probably defined in the other headers, for users being well known the PWC hardware. So it

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-01 Thread Sylwester Nawrocki
Hi, On 12/30/2011 09:41 PM, Sakari Ailus wrote: On Fri, Dec 30, 2011 at 11:14:39AM +0100, Sylwester Nawrocki wrote: On 12/30/2011 12:34 AM, Sakari Ailus wrote: On Wed, Dec 28, 2011 at 02:51:38PM +0100, Laurent Pinchart wrote: On Wednesday 28 December 2011 14:35:00 Sylwester Nawrocki wrote:

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-01 Thread Kim, Heungjun
To: Sylwester Nawrocki Cc: HeungJun, Kim; linux-media@vger.kernel.org; mche...@redhat.com; hverk...@xs4all.nl; sakari.ai...@iki.fi; kyungmin.p...@samsung.com; Hans de Goede Subject: Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control Hi, On Wednesday 28 December 2011 14:35:00

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-30 Thread Hans de Goede
Hi, On 12/30/2011 07:35 AM, HeungJun, Kim wrote: Hi Sakari, Thanks for the comments! Your comments help me to order my thoughts and re-send RFC. snip The value of the new control would have an effect as long as automatic white balance is enabled. No, it's a kind of Manual White Balance,

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-30 Thread Sylwester Nawrocki
Hi Sakari, On 12/30/2011 12:34 AM, Sakari Ailus wrote: On Wed, Dec 28, 2011 at 02:51:38PM +0100, Laurent Pinchart wrote: On Wednesday 28 December 2011 14:35:00 Sylwester Nawrocki wrote: On 12/28/2011 07:23 AM, HeungJun, Kim wrote: It adds the new CID for setting White Balance Preset. This CID

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-30 Thread Sylwester Nawrocki
-media@vger.kernel.org; mche...@redhat.com; hverk...@xs4all.nl; sakari.ai...@iki.fi; kyungmin.p...@samsung.com; Hans de Goede Subject: Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control Hi, On Wednesday 28 December 2011 14:35:00 Sylwester Nawrocki wrote: On 12/28/2011 07

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-30 Thread Sylwester Nawrocki
Hi HeungJun, On 12/28/2011 07:23 AM, HeungJun, Kim wrote: It adds the new CID for setting White Balance Preset. This CID is provided as menu type using the following items: 0 - V4L2_WHITE_BALANCE_INCANDESCENT, 1 - V4L2_WHITE_BALANCE_FLUORESCENT, 2 - V4L2_WHITE_BALANCE_DAYLIGHT, 3 -

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-30 Thread 'Sakari Ailus'
: Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control Hi Laurent, Sylwester and HeungJun, On Wed, Dec 28, 2011 at 02:51:38PM +0100, Laurent Pinchart wrote: Hi, On Wednesday 28 December 2011 14:35:00 Sylwester Nawrocki wrote: On 12/28/2011 07:23 AM, HeungJun

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-30 Thread 'Sakari Ailus'
Hi Hans, On Fri, Dec 30, 2011 at 09:41:57AM +0100, Hans de Goede wrote: ... Right, so the above is exactly why I ended up making the pwc whitebalance control the way it is, the user can essentially choice between a number of options: 1) auto whitebal 2) a number of preset whitebal values

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-30 Thread Hans de Goede
Hi, On 12/30/2011 07:42 PM, 'Sakari Ailus' wrote: Hi Hans, On Fri, Dec 30, 2011 at 09:41:57AM +0100, Hans de Goede wrote: ... Right, so the above is exactly why I ended up making the pwc whitebalance control the way it is, the user can essentially choice between a number of options: 1) auto

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-30 Thread Sakari Ailus
Hi Sylwester, On Fri, Dec 30, 2011 at 11:14:39AM +0100, Sylwester Nawrocki wrote: Hi Sakari, On 12/30/2011 12:34 AM, Sakari Ailus wrote: On Wed, Dec 28, 2011 at 02:51:38PM +0100, Laurent Pinchart wrote: On Wednesday 28 December 2011 14:35:00 Sylwester Nawrocki wrote: On 12/28/2011 07:23

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-30 Thread 'Sakari Ailus'
Hi Hans, On Fri, Dec 30, 2011 at 07:56:39PM +0100, Hans de Goede wrote: Hi, On 12/30/2011 07:42 PM, 'Sakari Ailus' wrote: Hi Hans, On Fri, Dec 30, 2011 at 09:41:57AM +0100, Hans de Goede wrote: ... Right, so the above is exactly why I ended up making the pwc whitebalance control the

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-29 Thread Sakari Ailus
Hi Laurent, Sylwester and HeungJun, On Wed, Dec 28, 2011 at 02:51:38PM +0100, Laurent Pinchart wrote: Hi, On Wednesday 28 December 2011 14:35:00 Sylwester Nawrocki wrote: On 12/28/2011 07:23 AM, HeungJun, Kim wrote: It adds the new CID for setting White Balance Preset. This CID is

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-29 Thread Laurent Pinchart
Hi, On Thursday 29 December 2011 06:08:07 HeungJun, Kim wrote: On Wednesday, December 28, 2011 10:52 PM Laurent Pinchart wrote: On Wednesday 28 December 2011 14:35:00 Sylwester Nawrocki wrote: On 12/28/2011 07:23 AM, HeungJun, Kim wrote: It adds the new CID for setting White Balance

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-29 Thread Kim, Heungjun
Hi, On 2011년 12월 30일 08:58, Laurent Pinchart wrote: Hi, On Thursday 29 December 2011 06:08:07 HeungJun, Kim wrote: On Wednesday, December 28, 2011 10:52 PM Laurent Pinchart wrote: On Wednesday 28 December 2011 14:35:00 Sylwester Nawrocki wrote: On 12/28/2011 07:23 AM, HeungJun, Kim wrote:

RE: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-29 Thread HeungJun, Kim
, December 30, 2011 8:34 AM To: Laurent Pinchart Cc: Sylwester Nawrocki; HeungJun, Kim; linux-media@vger.kernel.org; mche...@redhat.com; hverk...@xs4all.nl; kyungmin.p...@samsung.com; Hans de Goede Subject: Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control Hi Laurent

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-28 Thread Sylwester Nawrocki
Hi, On 12/28/2011 07:23 AM, HeungJun, Kim wrote: It adds the new CID for setting White Balance Preset. This CID is provided as menu type using the following items: 0 - V4L2_WHITE_BALANCE_INCANDESCENT, 1 - V4L2_WHITE_BALANCE_FLUORESCENT, 2 - V4L2_WHITE_BALANCE_DAYLIGHT, 3 -

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-28 Thread Laurent Pinchart
Hi, On Wednesday 28 December 2011 14:35:00 Sylwester Nawrocki wrote: On 12/28/2011 07:23 AM, HeungJun, Kim wrote: It adds the new CID for setting White Balance Preset. This CID is provided as menu type using the following items: 0 - V4L2_WHITE_BALANCE_INCANDESCENT, 1 -

RE: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-28 Thread HeungJun, Kim
To: HeungJun, Kim Cc: linux-media@vger.kernel.org; mche...@redhat.com; hverk...@xs4all.nl; sakari.ai...@iki.fi; laurent.pinch...@ideasonboard.com; kyungmin.p...@samsung.com; Hans de Goede Subject: Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control Hi, On 12/28/2011 07:23

RE: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-28 Thread HeungJun, Kim
...@redhat.com; hverk...@xs4all.nl; sakari.ai...@iki.fi; kyungmin.p...@samsung.com; Hans de Goede Subject: Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control Hi, On Wednesday 28 December 2011 14:35:00 Sylwester Nawrocki wrote: On 12/28/2011 07:23 AM, HeungJun, Kim wrote

[RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-27 Thread HeungJun, Kim
It adds the new CID for setting White Balance Preset. This CID is provided as menu type using the following items: 0 - V4L2_WHITE_BALANCE_INCANDESCENT, 1 - V4L2_WHITE_BALANCE_FLUORESCENT, 2 - V4L2_WHITE_BALANCE_DAYLIGHT, 3 - V4L2_WHITE_BALANCE_CLOUDY, 4 - V4L2_WHITE_BALANCE_SHADE, Signed-off-by: