On Sat May 5 2012 09:43:01 Hans de Goede wrote:
Hi,
I'm slowly working my way though this series today (both review, as well
as some tweaks and testing).
Thanks for that!
One note: I initialized the controls in sd_init. That's wrong, it should be
sd_config. sd_init is also called on resume,
On Sat May 5 2012 09:43:01 Hans de Goede wrote:
Hi,
I'm slowly working my way though this series today (both review, as well
as some tweaks and testing).
More comments inline...
On 04/28/2012 05:09 PM, Hans Verkuil wrote:
From: Hans Verkuilhans.verk...@cisco.com
Make the necessary
Hi,
On 05/05/2012 11:14 AM, Hans Verkuil wrote:
On Sat May 5 2012 09:43:01 Hans de Goede wrote:
Hi,
I'm slowly working my way though this series today (both review, as well
as some tweaks and testing).
More comments inline...
On 04/28/2012 05:09 PM, Hans Verkuil wrote:
From: Hans
Hi,
On 05/05/2012 10:34 AM, Hans Verkuil wrote:
On Sat May 5 2012 09:43:01 Hans de Goede wrote:
Hi,
I'm slowly working my way though this series today (both review, as well
as some tweaks and testing).
Thanks for that!
One note: I initialized the controls in sd_init. That's wrong, it
On Sat May 5 2012 16:46:32 Hans de Goede wrote:
Hi,
On 05/05/2012 10:34 AM, Hans Verkuil wrote:
On Sat May 5 2012 09:43:01 Hans de Goede wrote:
Hi,
I'm slowly working my way though this series today (both review, as well
as some tweaks and testing).
Thanks for that!
One note:
Hi,
On 05/05/2012 04:50 PM, Hans Verkuil wrote:
On Sat May 5 2012 16:46:32 Hans de Goede wrote:
Hi,
On 05/05/2012 10:34 AM, Hans Verkuil wrote:
On Sat May 5 2012 09:43:01 Hans de Goede wrote:
Hi,
I'm slowly working my way though this series today (both review, as well
as some tweaks and
On Sat May 5 2012 16:44:34 Hans de Goede wrote:
Hi,
On 05/05/2012 11:14 AM, Hans Verkuil wrote:
On Sat May 5 2012 09:43:01 Hans de Goede wrote:
Hi,
I'm slowly working my way though this series today (both review, as well
as some tweaks and testing).
More comments inline...
On
Hi,
On 05/05/2012 04:44 PM, Hans de Goede wrote:
Hi,
On 05/05/2012 11:14 AM, Hans Verkuil wrote:
So you get:
vidioc_foo()
lock(mylock)
v4l2_ctrl_s_ctrl(ctrl, val)
s_ctrl(ctrl, val)
lock(mylock)
Easy solution here, remove the first lock(mylock), since we are not using
v4l2-dev's
locking,
Hi,
Oops, forgot the attachment it is here now...
Regards,
Hans
On 05/05/2012 05:05 PM, Hans de Goede wrote:
Hi,
On 05/05/2012 04:44 PM, Hans de Goede wrote:
Hi,
On 05/05/2012 11:14 AM, Hans Verkuil wrote:
So you get:
vidioc_foo()
lock(mylock)
v4l2_ctrl_s_ctrl(ctrl, val)
s_ctrl(ctrl,
Hi,
On 05/05/2012 05:02 PM, Hans Verkuil wrote:
BTW, this is getting messy: both of us producing patches for the same driver :-)
For those reading along on the mailinglist, we've got together on irc and
coordinated how we are going to handle this there.
Regards,
Hans
--
To unsubscribe from
On Sat, 05 May 2012 16:59:30 +0200
Hans de Goede hdego...@redhat.com wrote:
Unless there is another good reason for doing the probing in sd_init I
prefer
to move it to sd_config.
Sensor probing does more then just sensor probing, it also configures
things like the i2c clockrate, and
On Sat, 05 May 2012 17:05:28 +0200
Hans de Goede hdego...@redhat.com wrote:
Now I see that we are doing exactly that in for example vidioc_g_jpegcomp
in gspca.c, so
we should stop doing that. We can make vidioc_g/s_jpegcomp only do the usb
locking if
gspca_dev-vdev.ctrl_handler ==
From: Hans Verkuil hans.verk...@cisco.com
Make the necessary changes to allow subdrivers to use the control framework.
This does not add control event support, that needs more work.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/video/gspca/gspca.c | 13 +
1
13 matches
Mail list logo
