Re: [yavta PATCH 1/3] Support integer menus.

2012-04-13 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. The code looks fine, but unfortunately breaks compilation when using kernel headers v3.5 (which is a pretty common case as of today ;-)). V4L2_CTRL_TYPE_INTEGER_MENU is an enumerated value, not a pre-processor #define, so it's difficult to test for it using

Re: [yavta PATCH 1/3] Support integer menus.

2012-04-13 Thread Rémi Denis-Courmont
Le vendredi 13 avril 2012 22:47:14 Laurent Pinchart, vous avez écrit : Hi Sakari, Thanks for the patch. The code looks fine, but unfortunately breaks compilation when using kernel headers v3.5 (which is a pretty common case as of today ;-)). V4L2_CTRL_TYPE_INTEGER_MENU is an enumerated

Re: [yavta PATCH 1/3] Support integer menus.

2012-04-13 Thread Sakari Ailus
Hi Laurent, Thanks for the comments. Laurent Pinchart wrote: Hi Sakari, Thanks for the patch. The code looks fine, but unfortunately breaks compilation when using kernel headers v3.5 (which is a pretty common case as of today ;-)). V4L2_CTRL_TYPE_INTEGER_MENU is an enumerated value, not a

[yavta PATCH 1/3] Support integer menus.

2012-04-12 Thread Sakari Ailus
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- yavta.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/yavta.c b/yavta.c index 72679c2..8db6e1e 100644 --- a/yavta.c +++ b/yavta.c @@ -564,19 +564,22 @@ static int video_enable(struct device *dev, int