Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-03 Thread Hans Verkuil
On Tuesday, May 03, 2011 17:03:13 Mauro Carvalho Chehab wrote: > Em 03-05-2011 10:59, Hans Verkuil escreveu: > > On Tuesday, May 03, 2011 14:49:43 Devin Heitmueller wrote: > > > What better non-embedded driver to implement vb2 in than one that doesn't > > yet > > do stream I/O? The risks of brea

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-03 Thread Mauro Carvalho Chehab
Em 03-05-2011 10:59, Hans Verkuil escreveu: > On Tuesday, May 03, 2011 14:49:43 Devin Heitmueller wrote: > What better non-embedded driver to implement vb2 in than one that doesn't yet > do stream I/O? The risks of breaking anything are much smaller and it would > be > a good 'gentle introducti

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-03 Thread Simon Farnsworth
On Tuesday 3 May 2011, Hans Verkuil wrote: > On Tuesday, May 03, 2011 14:49:43 Devin Heitmueller wrote: > > Asking us to be the "guinea pig" for this new framework just because > > cx18 is the most recent driver to get a videobuf related patch just > > isn't appropriate. > > I don't get it. > >

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-03 Thread Hans Verkuil
On Tuesday, May 03, 2011 14:49:43 Devin Heitmueller wrote: > On Mon, May 2, 2011 at 5:31 PM, Hans Verkuil wrote: > > It's also a good idea if the author of a patch pings the list if there > > has been no feedback after one or two weeks. It's easy to forget patches, > > people can be on vacation, b

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-03 Thread Devin Heitmueller
Hi Andy, On Mon, May 2, 2011 at 10:40 PM, Andy Walls wrote: > Hi All, > > Ah crud, what a mess.  Where to begin...? > > Where have I been: > > On 30 March 2011, my 8-year-old son was diagnosed with Necrotizing > Fasciitis caused by Invasive Group A Streptococcous - otherwise known as > "Flesh-eat

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-03 Thread Devin Heitmueller
On Mon, May 2, 2011 at 5:31 PM, Hans Verkuil wrote: > It's also a good idea if the author of a patch pings the list if there > has been no feedback after one or two weeks. It's easy to forget patches, > people can be on vacation, be sick, or in the case of Andy, have a family > emergency. In prin

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-03 Thread Mauro Carvalho Chehab
Em 03-05-2011 02:15, Hans Verkuil escreveu: > On Tuesday, May 03, 2011 05:28:02 Mauro Carvalho Chehab wrote: >>> 2. I'd at least like Simon's revised patch to be merged instead, to fix >>> the known deficincies in this one. >> >> IMO, the proper workflow would be that Simon should send his changes,

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-03 Thread Mauro Carvalho Chehab
Em 03-05-2011 06:03, Simon Farnsworth escreveu: > On Monday 2 May 2011, Mauro Carvalho Chehab wrote: >> Em 02-05-2011 16:11, Hans Verkuil escreveu: >>> NACK. >>> >>> For two reasons: first of all it is not signed off by Andy Walls, the >>> cx18 maintainer. I know he has had other things on his pla

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-03 Thread Simon Farnsworth
On Monday 2 May 2011, Mauro Carvalho Chehab wrote: > Em 02-05-2011 16:11, Hans Verkuil escreveu: > > NACK. > > > > For two reasons: first of all it is not signed off by Andy Walls, the > > cx18 maintainer. I know he has had other things on his plate recently > > which is probably why he hasn't ha

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-02 Thread Hans Verkuil
On Tuesday, May 03, 2011 05:28:02 Mauro Carvalho Chehab wrote: > Em 02-05-2011 23:40, Andy Walls escreveu: > > Hi All, > > > > Ah crud, what a mess. Where to begin...? > > > > Where have I been: > > > > On 30 March 2011, my 8-year-old son was diagnosed with Necrotizing > > Fasciitis caused by I

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-02 Thread Mauro Carvalho Chehab
Em 02-05-2011 23:40, Andy Walls escreveu: > Hi All, > > Ah crud, what a mess. Where to begin...? > > Where have I been: > > On 30 March 2011, my 8-year-old son was diagnosed with Necrotizing > Fasciitis caused by Invasive Group A Streptococcous - otherwise known as > "Flesh-eating bacteria": >

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-02 Thread Andy Walls
Hi All, Ah crud, what a mess. Where to begin...? Where have I been: On 30 March 2011, my 8-year-old son was diagnosed with Necrotizing Fasciitis caused by Invasive Group A Streptococcous - otherwise known as "Flesh-eating bacteria": http://en.wikipedia.org/wiki/Necrotizing_fasciitis http://www

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-02 Thread Mauro Carvalho Chehab
Em 02-05-2011 18:31, Hans Verkuil escreveu: > On Monday, May 02, 2011 22:59:09 Devin Heitmueller wrote: >> On Mon, May 2, 2011 at 4:02 PM, Hans Verkuil wrote: >>> It was merged without *asking* Andy. I know he has had some private stuff to >>> deal with this month so I wasn't surprised that he had

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-02 Thread Hans Verkuil
On Monday, May 02, 2011 22:59:09 Devin Heitmueller wrote: > On Mon, May 2, 2011 at 4:02 PM, Hans Verkuil wrote: > > It was merged without *asking* Andy. I know he has had some private stuff to > > deal with this month so I wasn't surprised that he hadn't reviewed it yet. > > > > It would have been

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-02 Thread Devin Heitmueller
On Mon, May 2, 2011 at 4:02 PM, Hans Verkuil wrote: > It was merged without *asking* Andy. I know he has had some private stuff to > deal with this month so I wasn't surprised that he hadn't reviewed it yet. > > It would have been nice if he was reminded first of this patch. It's a > fairly substa

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-02 Thread Hans Verkuil
On Monday, May 02, 2011 21:35:45 Mauro Carvalho Chehab wrote: > Em 02-05-2011 16:11, Hans Verkuil escreveu: > > NACK. > > > > For two reasons: first of all it is not signed off by Andy Walls, the cx18 > > maintainer. I know he has had other things on his plate recently which is > > probably why he

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-02 Thread Devin Heitmueller
On Mon, May 2, 2011 at 3:35 PM, Mauro Carvalho Chehab wrote: > Em 02-05-2011 16:11, Hans Verkuil escreveu: >> NACK. >> >> For two reasons: first of all it is not signed off by Andy Walls, the cx18 >> maintainer. I know he has had other things on his plate recently which is >> probably why he hasn'

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-02 Thread Mauro Carvalho Chehab
Em 02-05-2011 16:11, Hans Verkuil escreveu: > NACK. > > For two reasons: first of all it is not signed off by Andy Walls, the cx18 > maintainer. I know he has had other things on his plate recently which is > probably why he hasn't had the chance to review this. > > Secondly, while doing a quick

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-02 Thread Devin Heitmueller
On Mon, May 2, 2011 at 3:11 PM, Hans Verkuil wrote: > NACK. > > For two reasons: first of all it is not signed off by Andy Walls, the cx18 > maintainer. I know he has had other things on his plate recently which is > probably why he hasn't had the chance to review this. > > Secondly, while doing a

Re: [git:v4l-dvb/for_v2.6.40] [media] cx18: mmap() support for raw YUV video capture

2011-05-02 Thread Hans Verkuil
NACK. For two reasons: first of all it is not signed off by Andy Walls, the cx18 maintainer. I know he has had other things on his plate recently which is probably why he hasn't had the chance to review this. Secondly, while doing a quick scan myself I noticed that this code does a conversion fro