On Tue, Mar 04, 2014 at 08:50:38AM +0100, Maarten Lankhorst wrote:
op 03-03-14 22:11, Daniel Vetter schreef:
On Mon, Feb 17, 2014 at 04:57:19PM +0100, Maarten Lankhorst wrote:
Android syncpoints can be mapped to a timeline. This removes the need
to maintain a separate api for synchronization.
op 04-03-14 09:14, Daniel Vetter schreef:
On Tue, Mar 04, 2014 at 08:50:38AM +0100, Maarten Lankhorst wrote:
op 03-03-14 22:11, Daniel Vetter schreef:
On Mon, Feb 17, 2014 at 04:57:19PM +0100, Maarten Lankhorst wrote:
Android syncpoints can be mapped to a timeline. This removes the need
to
Hi,
On Tuesday 04 March 2014 01:13 PM, Hans Verkuil wrote:
On 03/04/2014 08:38 AM, Archit Taneja wrote:
Hi Hans,
On Monday 03 March 2014 01:20 PM, Hans Verkuil wrote:
Hi Archit!
On 03/03/2014 08:33 AM, Archit Taneja wrote:
Add crop ioctl ops. For VPE, cropping only makes sense with the
This patch set mainly consists of minor fixes for the VPE driver. These fixes
ensure the following:
- The VPE module can be inserted and removed successively.
- Make sure that smaller resolutions like qcif work correctly.
- Prevent race condition between firmware loading and an open call to the
For OMAP and DRA7x, we generally allocate video and graphics buffers through
omapdrm since the corresponding omap-gem driver provides DMM-Tiler backed
contiguous buffers. omapdrm is a dma-buf exporter. These buffers are used by
other drivers in the video pipeline.
Add VB2_DMABUF flag to the
vpe fops(vpe_open in particular) should be called only when VPDMA firmware
is loaded. File operations on the video device are possible the moment it is
registered.
Currently, we register the video device for VPE at driver probe, after calling
a vpdma helper to initialize VPDMA and load firmware.
The video_device struct is currently embedded in the driver data struct vpe_dev.
A vpe_dev instance is allocated by the driver, and the memory for the vfd is a
part of this struct.
The v4l2 core, however, manages the removal of the vfd region, through the
video_device's .release() op, which
VPE has a ctrl parameter which decides how many mem to mem transactions the
active job from the job queue can perform.
The driver's job_ready() made sure that the number of ready source buffers are
sufficient for the job to execute successfully. But it didn't make sure if
there are sufficient
The minimum width and height for VPE input/output was kept as 128 pixels. VPE
doesn't have a constraint on the image height, it requires the image width to
be at least 16 bytes.
Change the minimum supported dimensions to 32x32. This allows us to de-interlace
qcif content. A smaller image size
Add selection ioctl ops. For VPE, cropping makes sense only for the input to
VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense
only for the output of VPE(or V4L2_BUF_TYPE_VIDEO_CAPTURE/MPLANE buffers).
For the CAPTURE type, V4L2_SEL_TGT_COMPOSE results in VPE writing the
Some parameters of the VPE descriptors were understood incorrectly. They are now
fixed. The fixes are explained as follows:
- When adding an inbound data descriptor to the VPDMA descriptor list, we intend
to use c_rect as the cropped region fetched by VPDMA. Therefore, c_rect-width
shouldn't
Hi Philipp,
On 27/02/14 19:35, Philipp Zabel wrote:
This patch adds a new struct of_endpoint which is then embedded in struct
v4l2_of_endpoint and contains the endpoint properties that are not V4L2
(or even media) specific: the port number, endpoint id, local device tree
node and remote
On 27/02/14 19:35, Philipp Zabel wrote:
For simple devices with only one port, it can be made implicit.
The endpoint node can be a direct child of the device node.
snip
@@ -2105,9 +2112,11 @@ struct device_node *of_graph_get_remote_port_parent(
/* Get remote endpoint node. */
np
Hi Archit,
On 03/04/14 09:49, Archit Taneja wrote:
Add selection ioctl ops. For VPE, cropping makes sense only for the input to
VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense
only for the output of VPE(or V4L2_BUF_TYPE_VIDEO_CAPTURE/MPLANE buffers).
For the
On Tue, Mar 04, 2014 at 09:20:58AM +0100, Maarten Lankhorst wrote:
op 04-03-14 09:14, Daniel Vetter schreef:
On Tue, Mar 04, 2014 at 08:50:38AM +0100, Maarten Lankhorst wrote:
op 03-03-14 22:11, Daniel Vetter schreef:
On Mon, Feb 17, 2014 at 04:57:19PM +0100, Maarten Lankhorst wrote:
Android
Am Dienstag, den 04.03.2014, 11:06 +0200 schrieb Tomi Valkeinen:
On 27/02/14 19:35, Philipp Zabel wrote:
For simple devices with only one port, it can be made implicit.
The endpoint node can be a direct child of the device node.
snip
@@ -2105,9 +2112,11 @@ struct device_node
Am Freitag, den 28.02.2014, 22:09 +0100 schrieb Sylwester Nawrocki:
[...]
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1985,6 +1985,37 @@ struct device_node *of_find_next_cache_node(const
struct device_node *np)
}
/**
+ * of_graph_parse_endpoint() - parse common
Am Freitag, den 28.02.2014, 22:09 +0100 schrieb Sylwester Nawrocki:
On 02/27/2014 06:35 PM, Philipp Zabel wrote:
If of_graph_get_next_endpoint is given a parentless node instead of an
endpoint node, it is clearly a bug.
Signed-off-by: Philipp Zabelp.za...@pengutronix.de
---
Hi Sylwester,
Am Freitag, den 28.02.2014, 22:08 +0100 schrieb Sylwester Nawrocki:
Hi Philipp,
Just couple minor comments...
Thanks, I'll fix all of those.
On 02/27/2014 06:35 PM, Philipp Zabel wrote:
The device tree graph bindings as used by V4L2 and documented in
The fourth version, hopefully the last as well.
Changes since REVIEWv3:
- Split off the pwc patch into the buf_finish return type change and
the patch that only decompresses the image if the buffer state is
DONE.
- Extend the comments in patch 07/18: explain that the buf_finish call in
op 04-03-14 11:00, Daniel Vetter schreef:
On Tue, Mar 04, 2014 at 09:20:58AM +0100, Maarten Lankhorst wrote:
op 04-03-14 09:14, Daniel Vetter schreef:
On Tue, Mar 04, 2014 at 08:50:38AM +0100, Maarten Lankhorst wrote:
op 03-03-14 22:11, Daniel Vetter schreef:
On Mon, Feb 17, 2014 at
Fix an incorrect test in vb2_internal_qbuf() where only DEQUEUED buffers
are allowed. But PREPARED buffers are also OK.
Introduced by commit 4138111a27859dcc56a5592c804dd16bb12a23d1
(vb2: simplify qbuf/prepare_buf by removing callback).
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
From: Hans Verkuil hans.verk...@cisco.com
Commit 88e268702bfba78448abd20a31129458707383aa (vb2: Improve file I/O
emulation to handle buffers in any order) broke read/write support if
the size of the buffer being read/written is less than the size of the
image.
When the commit was tested
From: Hans Verkuil hans.verk...@cisco.com
When a vb2_queue is freed check if all the mem_ops and queue ops were balanced.
So the number of calls to e.g. buf_finish has to match the number of calls to
buf_prepare, etc.
This code is only enabled if CONFIG_VIDEO_ADV_DEBUG is set.
Signed-off-by:
From: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
This patch adds a test preventing streamon() if there is no buffer
ready.
Without this patch, a user could call streamon() before
preparing any buffer. This leads to a situation where if he calls
close() before calling streamoff() the
From: Hans Verkuil hans.verk...@cisco.com
If __reqbufs was called then existing buffers are freed. However, if that
happens without ever having started STREAMON, but if buffers have been queued,
then the buf_finish op is never called.
Add a call to __vb2_queue_cancel in __reqbufs so that these
From: Hans Verkuil hans.verk...@cisco.com
No need to oops for this, WARN_ON is good enough.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Sakari Ailus sakari.ai...@linux.intel.com
---
drivers/media/v4l2-core/videobuf2-core.c | 6 +++---
1 file changed, 3 insertions(+), 3
From: Hans Verkuil hans.verk...@cisco.com
__vb2_queue_free() would init the queued_list at all times, even if
q-num_buffers 0. This should only happen if num_buffers == 0.
This situation can happen if a CREATE_BUFFERS call couldn't allocate
enough buffers and had to free those it did manage to
From: Hans Verkuil hans.verk...@cisco.com
In commit 02f142ecd24aaf891324ffba8527284c1731b561 support was added to
start_streaming to return -ENOBUFS if insufficient buffers were queued
for the DMA engine to start. The vb2 core would attempt calling
start_streaming again if another buffer would be
From: Hans Verkuil hans.verk...@cisco.com
The buf_finish op should always work, so change the return type to void.
Update the few drivers that use it.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Pawel Osciak pa...@osciak.com
Reviewed-by: Pawel Osciak pa...@osciak.com
---
From: Hans Verkuil hans.verk...@cisco.com
This function never checked if width and height are correct. Add such
a check so the v4l2-compliance tool returns OK again for vivi.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/vivi.c | 6 +-
1 file changed, 5
From: Hans Verkuil hans.verk...@cisco.com
Sometimes sentences in comments ended with a period, and sometimes they
didn't. Add periods. No other changes.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
include/media/videobuf2-core.h | 40
1 file
From: Hans Verkuil hans.verk...@cisco.com
If start_streaming fails then any queued buffers must be given back
to the vb2 core.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/vivi.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
If you request buffers, then queue buffers and then call STREAMOFF
those buffers are not returned to their dequeued state because streamoff
will just return if q-streaming was 0.
This means that afterwards you can never QBUF that same buffer again unless
From: Hans Verkuil hans.verk...@cisco.com
'queued_count' is a bit vague since it is not clear to which queue it
refers to: the vb2 internal list of buffers or the driver-owned list
of buffers.
Rename to make it explicit.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Pawel Osciak
From: Hans Verkuil hans.verk...@cisco.com
Ensure that these ops are properly balanced.
There are two scenarios:
1) for MMAP buf_init is called when the buffers are created and buf_cleanup
must be called when the queue is finally freed. This scenario was always
working.
2) for USERPTR and
From: Hans Verkuil hans.verk...@cisco.com
If a queue was canceled, then the buf_finish op was never called for the
pending buffers. So add this call to queue_cancel. Before calling buf_finish
set the buffer state to PREPARED, which is the correct state. That way the
states DONE and ERROR will
From: Hans Verkuil hans.verk...@cisco.com
Don't call buf_finish unless we know that the buffer is in a valid state.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Sakari Ailus sakari.ai...@linux.intel.com
---
drivers/media/v4l2-core/videobuf2-core.c | 4 ++--
1 file changed, 2
From: Hans Verkuil hans.verk...@cisco.com
There is no point in trying to decompress a captured frame unless
the buffer state is OK. It won't be used in any other state, and
in fact the contents of the buffer might well be corrupt.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
Acked-by: Ricardo Ribalda ricardo.riba...@gmail.com
(Sorry for the delay)
On Sat, Feb 15, 2014 at 1:04 PM, Hans Verkuil hverk...@xs4all.nl wrote:
Previously hidden controls were not allowed in the user class due to
backwards compatibility reasons (QUERYCTRL should not see them), but
by simply
Hi Mark,
On Friday 28 February 2014 10:34:24 Mark Ryan wrote:
On 02/26/2014 04:40 PM, Laurent Pinchart wrote:
[ ... ]
With the information I've given you, could you try to log more information
in the driver to try and find what goes wrong ? You could for instance
log the content of
Hi,
On Tuesday 04 March 2014 03:10 PM, Hans Verkuil wrote:
Hi Archit,
On 03/04/14 09:49, Archit Taneja wrote:
Add selection ioctl ops. For VPE, cropping makes sense only for the input to
VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense
only for the output of VPE(or
From: Hans Verkuil hans.verk...@cisco.com
Struct v4l2_subdev_edid and the VIDIOC_SUBDEV_G/S_EDID ioctls were
specific for subdevices, but for hardware with a simple video pipeline
you do not need/want to create subdevice nodes to just get/set the EDID.
Move the v4l2_subdev_edid struct to
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/ad9389b.c | 2 +-
drivers/media/i2c/adv7511.c | 2 +-
drivers/media/i2c/adv7604.c | 4 ++--
drivers/media/i2c/adv7842.c | 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
From: Hans Verkuil hans.verk...@cisco.com
Document that it is now possible to call G/S_EDID from video nodes, not
just sub-device nodes.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
Documentation/DocBook/media/v4l/v4l2.xml | 2 +-
...{vidioc-subdev-g-edid.xml =
From: Hans Verkuil hans.verk...@cisco.com
Support this ioctl as part of the v4l2 core. Use the new ioctl
name and struct v4l2_edid type in the existing core code.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 32
Currently the VIDIOC_SUBDEV_G/S_EDID and struct v4l2_subdev_edid are subdev
APIs. However, that's in reality quite annoying since for simple video
pipelines there is no need to create v4l-subdev device nodes for anything
else except for setting or getting EDIDs.
What happens in practice is that
On 03/04/14 12:25, Archit Taneja wrote:
I had a minor question about the selection API:
Are the V4L2_SET_TGT_CROP/COMPOSE_DEFAULT and the corresponding
'BOUNDS' targets supposed to be used with VIDIOC_S_SELECTION? If so,
what's the expect behaviour?
No, those are read only in practice. So
Hi Tomi,
Am Dienstag, den 04.03.2014, 10:58 +0200 schrieb Tomi Valkeinen:
[...]
+int of_graph_parse_endpoint(const struct device_node *node,
+ struct of_endpoint *endpoint)
+{
+ struct device_node *port_node = of_get_parent(node);
Can port_node be NULL? Probably
On 04/03/14 13:36, Philipp Zabel wrote:
Hi Tomi,
Am Dienstag, den 04.03.2014, 10:58 +0200 schrieb Tomi Valkeinen:
[...]
+int of_graph_parse_endpoint(const struct device_node *node,
+ struct of_endpoint *endpoint)
+{
+ struct device_node *port_node =
Hi Archit,
From: Archit Taneja [mailto:arc...@ti.com]
Sent: Tuesday, March 04, 2014 12:25 PM
Hi,
On Tuesday 04 March 2014 03:10 PM, Hans Verkuil wrote:
Hi Archit,
On 03/04/14 09:49, Archit Taneja wrote:
Add selection ioctl ops. For VPE, cropping makes sense only for the
input to
This device has a led at bit 7 of GPIO reg. 0x80 to indicate
when a DVB capture is happening.
Add support for it.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 12
1 file changed, 12 insertions(+)
diff --git
Some devices have a LED to indicate when DVB capture started.
Add support for it.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-core.c | 26 ++
drivers/media/usb/em28xx/em28xx.h | 1 +
2 files changed, 15
Am Dienstag, den 04.03.2014, 14:21 +0200 schrieb Tomi Valkeinen:
On 04/03/14 13:36, Philipp Zabel wrote:
[...]
Can port_node be NULL? Probably only if something is quite wrong, but
maybe it's safer to return error in that case.
both of_property_read_u32 and of_node_put can handle
On Mon, Mar 3, 2014 at 5:05 AM, Mauro Carvalho Chehab
m.che...@samsung.com wrote:
This patch series finally merge a long waited driver, for Micronas/Trident
DRX-J ATSC frontends.
It is based on a previous work from Devin, who made the original port
of the Trident driver and got license to
Hi Laurent,
Thanks again for your reply.
On 03/04/2014 12:11 PM, Laurent Pinchart wrote:
Hi Mark,
On Friday 28 February 2014 10:34:24 Mark Ryan wrote:
On 02/26/2014 04:40 PM, Laurent Pinchart wrote:
[ ... ]
With the information I've given you, could you try to log more information
in the
From a5cfa1881de152a887d195e8c880dcca3e6b766e Mon Sep 17 00:00:00 2001
From: Stefan Ringel linu...@stefanringel.de
Date: Tue, 4 Mar 2014 20:50:32 +0100
Subject: [PATCH] v4l-utils: bugfix memory chunk
Bug 1070855 - [abrt] v4l-utils: parse_string(): dvbv5-scan killed by SIGABRT
From a5cfa1881de152a887d195e8c880dcca3e6b766e Mon Sep 17 00:00:00 2001
From: Stefan Ringel linu...@stefanringel.de
Date: Tue, 4 Mar 2014 20:50:32 +0100
Subject: [PATCH] v4l-utils: bugfix memory chunk
Bug 1070855 - [abrt] v4l-utils: parse_string(): dvbv5-scan killed by SIGABRT
From a5cfa1881de152a887d195e8c880dcca3e6b766e Mon Sep 17 00:00:00 2001
From: Stefan Ringel linu...@stefanringel.de
Date: Tue, 4 Mar 2014 20:50:32 +0100
Subject: [PATCH] v4l-utils: bugfix memory chunk
Bug 1070855 - [abrt] v4l-utils: parse_string(): dvbv5-scan killed by SIGABRT
tree: git://linuxtv.org/media_tree.git master
head: 59432be1c7fbf2a4f608850855ff649bee0f7b3b
commit: 57afe2f0bb0cca758701679f141c9fa92a034415 [428/499] [media] drx-j: Don't
use CamelCase
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by )
Instead of keeping the led always on, use it to indicate
when DVB is streaming.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git
tree: git://linuxtv.org/media_tree.git master
head: 59432be1c7fbf2a4f608850855ff649bee0f7b3b
commit: b240eacdd536bac23c9d48dfc3d527ed6870ddad [463/499] [media] drx-j: get
rid of drx_driver.c
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by )
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Mar 5 04:00:26 CET 2014
git branch: test
git hash: 59432be1c7fbf2a4f608850855ff649bee0f7b3b
gcc
tree: git://linuxtv.org/media_tree.git master
head: 59432be1c7fbf2a4f608850855ff649bee0f7b3b
commit: 9e4c509d7444e067d39d3ac96a3398721bca4f01 [485/499] [media] drx-j: Use
single master mode
reproduce: make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by )
64 matches
Mail list logo
