Copying structs by assignment is type safe.
Plus, is shorter and easier to read.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/saa7164/saa7164-i2c.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/media/video/saa7164/saa7164
Copying structs by assignment is type safe.
Plus, is shorter and easier to read.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/cx25821/cx25821-i2c.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/media/video/cx25821/cx25821
The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with
struct i2c_algorithm. Moreover, i2c_algo field is not used since
i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus().
Therefore, it's safe to remove it.
Tested by compilation only.
Signed-off-by: Ezequiel
The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with
struct i2c_algorithm. Moreover, i2c_algo field is not used since
i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus().
Therefore, it's safe to remove it.
Tested by compilation only.
Signed-off-by: Ezequiel
Hey Peter,
On Wed, Jun 27, 2012 at 7:18 PM, Peter Senna Tschudin
peter.se...@gmail.com wrote:
- no_signal = stv090x_chk_signal(state);
+ (void) stv090x_chk_signal(state);
Why are you casting return to void? I can't see there is a reason to it.
On Thu, Jun 28, 2012 at 10:17 AM, Peter Senna Tschudin
peter.se...@gmail.com wrote:
Hey Ezequiel,
On Thu, Jun 28, 2012 at 1:02 AM, Ezequiel Garcia elezegar...@gmail.com
wrote:
Hey Peter,
On Wed, Jun 27, 2012 at 7:18 PM, Peter Senna Tschudin
peter.se...@gmail.com wrote
Hey Gianluca,
On Mon, Jun 25, 2012 at 11:47 AM, Devin Heitmueller
dheitmuel...@kernellabs.com wrote:
On Mon, Jun 25, 2012 at 10:36 AM, Ezequiel Garcia elezegar...@gmail.com
wrote:
Others issue related to memory allocation on platforms like ARM with
limited coherent memory (if the device
Hi Robert,
I've added linux-media on Cc since someone might find your
question on interest.
On Wed, Jul 4, 2012 at 3:16 AM, Robert Walter rolin...@gmail.com wrote:
I wonder if you could point me in the right direction? I bought an easy-cap
video capture device but it doesn't look like anything
Hi Mauro,
On Thu, Jul 5, 2012 at 1:57 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS);
dev-adev.capture_pcm_substream = substream;
- runtime-private_data = dev;
Are you sure that this can be removed? I
On Thu, Jul 5, 2012 at 6:21 PM, Sakari Ailus sakari.ai...@iki.fi wrote:
There was a discussion between Ezequiel and Hans that in my understanding
led to a conclusion there's no such use case, at least one which would be
properly supported by the hardware. (Please correct me if I'm mistaken.)
Mauro,
On Thu, Jul 5, 2012 at 2:22 PM, Ezequiel Garcia Are you sure that
this can be removed? I think this is used internally
by the alsa API, but maybe something has changed and this is not
required anymore.
Yes, I'm sure.
This should be: I'm almost sure :-)
Anyway, probably the patch
On Thu, Jul 5, 2012 at 9:01 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Em 05-07-2012 19:36, Sylwester Nawrocki escreveu:
On 07/06/2012 12:11 AM, Mauro Carvalho Chehab wrote:
+static int vidioc_dqbuf(struct file *file, void *priv, struct v4l2_buffer
*p)
+{
+ struct stk1160 *dev =
/media/video/stk1160/stk1160-ac97.c
@@ -0,0 +1,152 @@
+/*
+ * STK1160 driver
+ *
+ * Copyright (C) 2012 Ezequiel Garcia
+ * elezegarcia--a.t--gmail.com
+ *
+ * Based on Easycap driver by R.M. Thomas
+ * Copyright (C) 2010 R.M. Thomas
+ * rmthomas--a.t--sciolus.org
+ *
+ * This program
Gianluca,
On Mon, Jun 25, 2012 at 4:09 AM, Gianluca Bergamo
gianluca.berg...@gmail.com wrote:
In my environment this command line gives only one format supported (UYVY)
and then yavta freezes.
I suspect it freezes on an ioctl to the driver. I must check it.
This freezing is actually a dead
On Fri, Jul 6, 2012 at 12:12 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Em 06-07-2012 11:33, Ezequiel Garcia escreveu:
Mauro,
On Thu, Jul 5, 2012 at 2:22 PM, Ezequiel Garcia Are you sure that
this can be removed? I think this is used internally
by the alsa API, but maybe something
Hey Mauro,
On Fri, Jul 6, 2012 at 11:41 AM, Ezequiel Garcia elezegar...@gmail.com wrote:
On Thu, Jul 5, 2012 at 9:01 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Em 05-07-2012 19:36, Sylwester Nawrocki escreveu:
On 07/06/2012 12:11 AM, Mauro Carvalho Chehab wrote:
+static int
Hi Hans,
On Tue, Jul 10, 2012 at 3:39 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On Tue July 10 2012 05:17:41 Ezequiel Garcia wrote:
Hey Mauro,
On Fri, Jul 6, 2012 at 11:41 AM, Ezequiel Garcia elezegar...@gmail.com
wrote:
On Thu, Jul 5, 2012 at 9:01 PM, Mauro Carvalho Chehab
mche
Hi Devendra,
Thanks for the patch.
On Tue, Jul 10, 2012 at 3:45 AM, Devendra Naga devendra.a...@gmail.com wrote:
the driver duplicates the module_pci_driver code,
how?
module_pci_driver is used for those drivers whose
init and exit paths does only register and unregister
Hi Ismael,
On Thu, Jun 21, 2012 at 4:53 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
Hi Mauro,
This patchset aims at cleaning most issues reported by
./scripts/checkpatch.pl.
I'm not sure if all of them are useful, so if you feel any of the
patches are too dumb just drop it.
I'm
Hans,
On Tue, Jul 10, 2012 at 3:39 AM, Hans Verkuil hverk...@xs4all.nl wrote:
Take a look at the latest videobuf2-core.h: I've added helper functions
that check the owner. You can probably simplify the driver code quite a bit
by using those helpers.
Indeed, using latest vb2_xxx_fop and
This lock was being taken using two different names
(pointers) in the same function.
Both names refer to the same lock,
so this wasn't an error; but it looked very strange.
Cc: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/pwc/pwc
Hi Radek,
On Wed, Jul 18, 2012 at 9:52 AM, Radek Mašín ra...@masin.eu wrote:
Hello,
I have upgraded my testing system with cx25821 based video capture card to
system (OpenSuSE 12.1)
with kernel 3.4.4 and driver for cx25821 doesn't work. Previous system was
with kernel 2.6.37 (OpenSuSE
Radek,
On Wed, Jul 18, 2012 at 10:14 AM, Ezequiel Garcia elezegar...@gmail.com wrote:
Hi Radek,
I think the attached patch will solve this issue.
Please test and tell me if it did,
Ezequiel.
0001-cx25821-Remove-bad-strcpy-to-read-only-char.patch
Description: Binary data
On Wed, Jul 18, 2012 at 10:45 AM, Radek Mašín ra...@masin.eu wrote:
Hello,
I can test it without problems. Please send me a patch.
I already did :-) Please checkout my previous mail.
Thanks,
Ezequiel.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a
On Wed, Jul 18, 2012 at 11:38 AM, Radek Mašín ra...@masin.eu wrote:
Hello,
with your patch driver is working properly. I see devices in /dev directory
and in dmesg
is attached output:
Great! That's good news. I'll send the patch to the list later.
If you encounter any other problems, please
...@masin.eu
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
Hi Mauro,
I believe without this patch cx25821 driver
is completely unusable.
So perhaps this patch should also go to stable tree?
I'm a bit unsure about this procedure.
Regards,
Ezequiel.
---
drivers/media/video/cx25821/cx25821
On Wed, Jul 18, 2012 at 7:26 PM, Ismael Luceno ismael.luc...@gmail.com wrote:
On Thu, Jun 21, 2012 at 4:52 PM, Ezequiel Garcia elezegar...@gmail.com
wrote:
This patch moves video_nr module parameter to core.c
and then passes that parameter as an argument to functions
that need it.
This way
On Thu, Jul 19, 2012 at 8:17 AM, Hans Verkuil hverk...@xs4all.nl wrote:
Ezequiel,
Can you post this patch again, but this time to Linus Torvalds as well?
See e.g. http://www.spinics.net/lists/linux-media/msg50407.html how I did
that.
It would be good to have this fixed in 3.5. I'm afraid
on vacation, I'm sending directly to you so
this can be merged for 3.5 before it is released.
Thanks,
Ezequiel.
From 1859521e76226687e79e1452b040fd3e02c469d8 Mon Sep 17 00:00:00 2001
From: Ezequiel Garcia elezegar...@gmail.com
Date: Wed, 18 Jul 2012 10:05:26 -0300
Subject: [PATCH] cx25821: Remove bad
On Thu, Jul 19, 2012 at 3:41 PM, Ismael Luceno ismael.luc...@gmail.com wrote:
On Thu, 19 Jul 2012 10:25:09 -0300
Ezequiel Garcia elezegar...@gmail.com wrote:
On Wed, Jul 18, 2012 at 7:26 PM, Ismael Luceno
ismael.luc...@gmail.com wrote:
On Thu, Jun 21, 2012 at 4:52 PM, Ezequiel Garcia
On Thu, Jul 19, 2012 at 4:48 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On Thu July 19 2012 20:41:11 Ismael Luceno wrote:
On Thu, 19 Jul 2012 10:25:09 -0300
Ezequiel Garcia elezegar...@gmail.com wrote:
On Wed, Jul 18, 2012 at 7:26 PM, Ismael Luceno
ismael.luc...@gmail.com wrote:
On Thu
On Thu, Jul 19, 2012 at 5:41 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On Thu July 19 2012 21:55:20 Ezequiel Garcia wrote:
On Thu, Jul 19, 2012 at 4:48 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On Thu July 19 2012 20:41:11 Ismael Luceno wrote:
On Thu, 19 Jul 2012 10:25:09 -0300
Ezequiel
On Thu, Jul 19, 2012 at 5:45 PM, Hans Verkuil hverk...@xs4all.nl wrote:
Remove the pointless video_nr++. It doesn't do anything useful and it has
the unexpected side-effect of changing the video_nr module option, so
cat /sys/module/vivi/parameters/video_nr gives a different value back
then
On Thu, Jul 19, 2012 at 6:05 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
On Thu, Jul 19, 2012 at 5:45 PM, Hans Verkuil hverk...@xs4all.nl wrote:
Remove the pointless video_nr++. It doesn't do anything useful and it has
the unexpected side-effect of changing the video_nr module option, so
Hey Hans,
On Thu, Jul 19, 2012 at 10:41 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On Thu 19 July 2012 15:32:21 Ezequiel Garcia wrote:
On Thu, Jul 19, 2012 at 8:17 AM, Hans Verkuil hverk...@xs4all.nl wrote:
Ezequiel,
Can you post this patch again, but this time to Linus Torvalds as well
...@vger.kernel.org in the patch (right?).
Now I know it :-)
If I'm doing anything wrong, just yell at me.
Thanks,
Ezequiel.
From 1859521e76226687e79e1452b040fd3e02c469d8 Mon Sep 17 00:00:00 2001
From: Ezequiel Garcia elezegar...@gmail.com
Date: Wed, 18 Jul 2012 10:05:26 -0300
Subject: [PATCH] cx25821: Remove bad
It is possible that video_put() releases video_device struct,
provoking a panic when debug printk wants to get video_device node name.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/v4l2-dev.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions
Hi Konke,
+
+libv4l2rds_la_SOURCES = libv4l2rds.c
+libv4l2rds_la_CPPFLAGS = -fvisibility=hidden $(ENFORCE_LIBV4L_STATIC)
-std=c99
+libv4l2rds_la_LDFLAGS = -version-info 0 -lpthread $(DLOPEN_LIBS)
$(ENFORCE_LIBV4L_STATIC)
diff --git a/lib/libv4l2rds/libv4l2rds.c
On Thu, Jul 26, 2012 at 11:39 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On Thu 26 July 2012 16:28:20 Ezequiel Garcia wrote:
Hi Konke,
+
+libv4l2rds_la_SOURCES = libv4l2rds.c
+libv4l2rds_la_CPPFLAGS = -fvisibility=hidden $(ENFORCE_LIBV4L_STATIC)
-std=c99
+libv4l2rds_la_LDFLAGS
Commit 65d9ff9c85d3c2e06d22aed78efee8404563eff6:
V4L/DVB (11390): 2-dev.c: return 0 for NULL open and release callbacks,
introduced this bug.
The bug this patch fixes is almost innocuous because nobody
really cares about release() exit code.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
Hi Takashi,
On Fri, Jul 27, 2012 at 5:03 AM, Takashi Iwai ti...@suse.de wrote:
This is achieved through snd_ac97_codec/ac97_bus drivers.
Mauro suggested that this ac97 handling should be put
inside -alsa tree, but I'm still not sure about it.
This approach is working well in practice, but
Hi Ben,
On Sun, Jul 29, 2012 at 10:56 PM, Ben Hutchings b...@decadent.org.uk wrote:
If I'm doing anything wrong, just yell at me.
[...]
An upstream commit hash would have helped, but I found it anyway.
Queued up for 3.2.y.
Thanks for the hint and sorry for the trouble...
Ezequiel.
--
To
Hi,
I received some reports of stk1160 working on
the world famous ARM raspberrypi devices; with some changes to current code:
https://github.com/ezequielgarcia/stk1160-standalone/issues/5
This gently user did some changes on my suggestion and then could capture a png
with mplayer. However the
This was introduced on commit c2a6b54a9:
em28xx: fix: don't do image interlacing on webcams
It is a known bug that has already been reported several times
and confirmed by Mauro.
Tested by compilation only.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
Hi,
I have no idea why
On Fri, Aug 3, 2012 at 2:52 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
This was introduced on commit c2a6b54a9:
em28xx: fix: don't do image interlacing on webcams
It is a known bug that has already been reported several times
and confirmed by Mauro.
Tested by compilation only.
I
Hi Devin,
Thanks for answering.
On Fri, Aug 3, 2012 at 3:26 PM, Devin Heitmueller
dheitmuel...@kernellabs.com wrote:
On Fri, Aug 3, 2012 at 2:11 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
On Fri, Aug 3, 2012 at 2:52 PM, Ezequiel Garcia elezegar...@gmail.com
wrote:
This was introduced
On Fri, Aug 3, 2012 at 3:55 PM, Devin Heitmueller
dheitmuel...@kernellabs.com wrote:
On Fri, Aug 3, 2012 at 2:42 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
Wait a minute, unless I completely misunderstood the bug (which is possible),
I think this patch is straightforward.
By the look
Hello James,
On Sat, Aug 4, 2012 at 12:52 PM, James bjloc...@lockie.ca wrote:
There's a big pause before the 'unable'
[2.243856] usb 4-1: Manufacturer: Logitech
[ 62.739097] cx25840 6-0044: unable to open firmware
v4l-cx23885-avcore-01.fw
I have a cx23885
cx23885[0]: registered
Hi Devendra,
On Sat, Aug 4, 2012 at 3:12 PM, Devendra Naga
develkernel412...@gmail.com wrote:
mutex_init(ci-lock);
memcpy(ci-cfg, cfg, sizeof(struct cxd2099_cfg));
While you're still looking at this driver, perhaps you can change the memcpy
with a plain struct assignment (if
Hi Devendra,
On Sun, Aug 5, 2012 at 1:04 AM, Devendra Naga
develkernel412...@gmail.com wrote:
Hello Ezequiel,
On Sun, Aug 5, 2012 at 12:24 AM, Ezequiel Garcia elezegar...@gmail.com
wrote:
Hi Devendra,
On Sat, Aug 4, 2012 at 3:12 PM, Devendra Naga
develkernel412...@gmail.com wrote
Hi Devendra,
Thanks for the patch,
On Sun, Aug 5, 2012 at 5:40 PM, Devendra Naga
develkernel412...@gmail.com wrote:
structure variables can be assigned, no memcpy needed,
remove the memcpy and use assignment for the cfg and en variables.
Tested by Compilation Only
Suggested-by: Ezequiel
On Mon, Aug 6, 2012 at 2:28 AM, Devendra Naga
develkernel412...@gmail.com wrote:
Hi Ezequiel,
On Mon, Aug 6, 2012 at 3:36 AM, Ezequiel Garcia elezegar...@gmail.com wrote:
Hi Devendra,
Thanks for the patch,
On Sun, Aug 5, 2012 at 5:40 PM, Devendra Naga
develkernel412...@gmail.com wrote
Hi Mauro,
On Sat, Jul 28, 2012 at 11:18 AM, Ezequiel Garcia elezegar...@gmail.com wrote:
This driver adds support for stk1160 usb bridge as used in some
video/audio usb capture devices.
It is a complete rewrite of staging/media/easycap driver and
it's expected as a future replacement.
Cc
On Mon, Aug 6, 2012 at 9:42 AM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Em 06-08-2012 09:28, Ezequiel Garcia escreveu:
Hi Mauro,
On Sat, Jul 28, 2012 at 11:18 AM, Ezequiel Garcia elezegar...@gmail.com
wrote:
This driver adds support for stk1160 usb bridge as used in some
video
On Mon, Aug 6, 2012 at 9:46 AM, Ezequiel Garcia elezegar...@gmail.com wrote:
On Mon, Aug 6, 2012 at 9:42 AM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Em 06-08-2012 09:28, Ezequiel Garcia escreveu:
Hi Mauro,
On Sat, Jul 28, 2012 at 11:18 AM, Ezequiel Garcia elezegar...@gmail.com
Hi Mauro,
On Mon, Aug 6, 2012 at 10:38 AM, Ezequiel Garcia elezegar...@gmail.com wrote:
This driver adds support for stk1160 usb bridge as used in some
video/audio usb capture devices.
It is a complete rewrite of staging/media/easycap driver and
it's expected as a replacement.
---
I just
On Mon, Aug 6, 2012 at 11:18 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On Mon August 6 2012 16:08:33 Mauro Carvalho Chehab wrote:
Em 06-08-2012 10:58, Ezequiel Garcia escreveu:
Hi Mauro,
On Mon, Aug 6, 2012 at 10:38 AM, Ezequiel Garcia elezegar...@gmail.com
wrote:
This driver adds
Hi Mauro,
On Mon, Aug 6, 2012 at 12:21 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
On Mon, Aug 6, 2012 at 11:18 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On Mon August 6 2012 16:08:33 Mauro Carvalho Chehab wrote:
Em 06-08-2012 10:58, Ezequiel Garcia escreveu:
Hi Mauro,
On Mon, Aug
Hello,
On Mon, Aug 6, 2012 at 12:42 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
Hi Mauro,
On Mon, Aug 6, 2012 at 12:21 PM, Ezequiel Garcia elezegar...@gmail.com
wrote:
On Mon, Aug 6, 2012 at 11:18 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On Mon August 6 2012 16:08:33 Mauro Carvalho
Hi Mauro,
On Mon, Aug 6, 2012 at 4:13 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
On a second thought, perhaps it makes sense to have a git repo (on
linuxtv.org)
for me to work on stk1160.
That way I could simply send git pull requests instead of patches.
I'm not sure
On Thu, Aug 9, 2012 at 9:33 AM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Em 09-08-2012 09:24, Ezequiel Garcia escreveu:
Hi Mauro,
On Mon, Aug 6, 2012 at 4:13 PM, Ezequiel Garcia elezegar...@gmail.com
wrote:
On a second thought, perhaps it makes sense to have a git repo
On Thu, Aug 9, 2012 at 5:25 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Patch looks ok. Just a few comments:
Em 06-08-2012 10:38, Ezequiel Garcia escreveu:
This driver adds support for stk1160 usb bridge as used in some
video/audio usb capture devices.
It is a complete rewrite
Hi!
Here's the stk1160 inclusion patch, splitted as two patches
(easycap removal and stk1160 add) as requested by Mauro.
I'd like to thanks Hans, Sylwester, Takashi and Mauro
(and everyone else) for their reviewing and their help.
Regards,
Ezequiel.
Ezequiel Garcia (2):
staging: media: Remove
On Sat, Aug 11, 2012 at 9:06 PM, Andy Walls awa...@md.metrocast.net wrote:
On Wed, 2012-08-08 at 13:18 -0400, bjloc...@lockie.ca wrote:
How hard would it be to get an official kernel option not to load firmware
Submit a patch for the cx23885 driver to the list. It could add a
module option
Hi Dan,
On Tue, Aug 14, 2012 at 3:59 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
There are some unlocks missing on error.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Applies on top of linux-next.
diff --git a/drivers/media/video/stk1160/stk1160-v4l.c
Hi Dan,
On Tue, Aug 14, 2012 at 3:58 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
We need to move the unlock before the kfree(dev);
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Applies to linux-next.
diff --git a/drivers/media/video/em28xx/em28xx-video.c
On Tue, Aug 14, 2012 at 8:05 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Tue, Aug 14, 2012 at 07:50:12AM -0300, Ezequiel Garcia wrote:
Hi Dan,
On Tue, Aug 14, 2012 at 3:58 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
We need to move the unlock before the kfree(dev
On Wed, Aug 15, 2012 at 6:53 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Em 14-08-2012 07:51, Ezequiel Garcia escreveu:
Hi Dan,
On Tue, Aug 14, 2012 at 3:59 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
There are some unlocks missing on error.
Signed-off-by: Dan Carpenter
Hello,
I was trying to debug a bug in stk1160, triggered by a low memory situation.
After some struggling I found out that I'm suppose to clear the queued buffers
if start_streaming() fails (which I wasn't doing).
This seems most awkward since I didn't queue the buffers in start_streaming,
but
This is just a cleaning patch to produce more useful
debug messages.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/usb/stk1160/stk1160-video.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/media/usb/stk1160/stk1160-video.c
When an urb buffer can't be allocated, the currently allocated
buffer count must be saved so they can properly released.
Moreover, it's sufficient to call stk1160_free_isoc to have
all urb buffers released.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/usb/stk1160
The driver was expecting to get a valid pixelformat on s_fmt and try_fmt.
This is wrong, since the user may pass a bitmask and expect the driver
to change it, returning a valid (fourcc) pixelformat.
This problem was spotted by v4l2-compliance.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
If start_streaming() fails (e.g. out of memory) the driver needs to
rewind the start procedure. This implies possibly stopping the device
and clearing the buffer queue.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/usb/stk1160/stk1160-v4l.c | 16
1
Hello,
This is a simple patch that replaces vb2_queue_init return type.
Currently vb2_queue_init is returning an integer, but it always return 0
since it's a very simple function and doesn't take any actions that can fail.
For this reason some drivers (e.g. pwc) don't bother to check the return
Cc: Pawel Osciak pa...@osciak.com
Cc: Marek Szyprowski m.szyprow...@samsung.com
Cc: Kyungmin Park kyungmin.p...@samsung.com
Cc: Hans Verkuil hans.verk...@cisco.com
Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de
Cc: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Ezequiel Garcia elezegar
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/em28xx/em28xx.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/em28xx/em28xx.h
b/drivers/media/video/em28xx/em28xx.h
index 87766f1..b004dd8 100644
--- a/drivers/media/video
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/em28xx/em28xx.h |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/media/video/em28xx/em28xx.h
b/drivers/media/video/em28xx/em28xx.h
index b004dd8..b5bac9c 100644
--- a/drivers/media
Nobody ever waits on any of these wait_queue's,
so this patch removes them completely.
Tested by compilation only.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/em28xx/em28xx-cards.c |7 ---
drivers/media/video/em28xx/em28xx-video.c |1 -
drivers/media
Hola Sebastián, :)
On Fri, May 4, 2012 at 12:13 PM, Sebastián Misuraca
smisur...@3way.com.ar wrote:
Hi,
I add a tv card support for saa7134 driver, the card name is Genius
TV Go A12 and i test the RF capture with pal-nc and I test the
composite input too. I want to known if I would make a
Hi Sebastián,
On Mon, May 7, 2012 at 11:49 PM, Sebastián Misuraca
smisur...@3way.com.ar wrote:
Ezequiel,
Thanks for the reply.
No problem.
I am going to watch the video and make the correct patch. When i finished i
will send again.
Great. If you have *any* problems, feel free to ask.
Hi,
Also please output lsmod with your device plugged and the list of your
installed modules (do you know how to do this?)
I may be wrong, but this device should be supported by usbvision module.
Thanks,
Ezequiel.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the
Hi,
On Wed, May 9, 2012 at 2:56 PM, Ondrej Zary li...@rainbow-software.org wrote:
On Wednesday 09 May 2012 18:54:58 Ezequiel Garcia wrote:
Hi,
Also please output lsmod with your device plugged and the list of your
installed modules (do you know how to do this?)
I may be wrong
Hi,
Another one here, hope you don't mind ;)
This is minimal changes needed for start up go7007wis2804 to work correctly
in 3.4 branch
^^^
These are minimal changes.
---
One question... shouldn't this changeset be splitted into shorter patches?
Good luck!
Ezequiel.
--
On Fri, May 11, 2012 at 2:06 PM, vol...@telros.ru wrote:
One question... shouldn't this changeset be splitted into shorter patches?
Yes, should it.
In next iteration i`ll learn how to do that.
As a git newbie I've found very useful to work like this:
1. Always work on a branch that's
Hi Mauro,
On Thu, May 24, 2012 at 12:34 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Ezequiel Garcia (2):
[media] em28xx: Make card_setup() and pre_card_setup() static
[media] em28xx: Remove unused list_head struct for queued buffers
Ezequiel García (19):
[media
Hi Hans,
Thanks for your review (I'm a bit amazed at how fast you went through
the code :).
I'll address your excellent comments soon.
I'm still unsure about a numbre of things. Two of them:
1. It seems to mee tracing is not too nice and
I wasn't really sure how to handle it: dev_xxx, pr_xxx,
patch.
On Sat May 26 2012 18:41:00 Ezequiel Garcia wrote:
This driver adds support for stk1160 usb bridge as used in some
video/audio usb capture devices.
It is a complete rewrite of staging/media/easycap driver and
it's expected as a future replacement.
Signed-off-by: Ezequiel Garcia elezegar
Hi Sylwester,
On Sat, May 26, 2012 at 4:31 PM, Sylwester Nawrocki snj...@gmail.com wrote:
You can drop this line, it's overwritten with KERNEL_VERSION in v4l2-ioctl.c.
Also I could imagine there might be better names, than dev, for
capabilities.
Yes, indeed. Starting with cap.
+
Hi Hans,
On Mon, May 28, 2012 at 7:27 AM, Hans Verkuil hverk...@xs4all.nl wrote:
Hi Ezequiel,
I'm just bringing this proposal to your attention as I am wondering how your
driver (and
the old easycap driver that your driver will replace) handle the easycap
device with
multiple inputs? Is
Hi again,
On Mon, May 28, 2012 at 8:52 AM, Ezequiel Garcia elezegar...@gmail.com wrote:
I'm just bringing this proposal to your attention as I am wondering how your
driver (and
the old easycap driver that your driver will replace) handle the easycap
device with
multiple inputs
On Mon, May 28, 2012 at 2:10 PM, Hans Verkuil hverk...@xs4all.nl wrote:
I may be missing something, but I don't see any relation between
video buffer queue and selected input.
(Perhaps this is OT and we should discuss this in another thread)
Well, this particular API was intended to let the
On Mon, May 28, 2012 at 7:22 AM, Hans Verkuil hverk...@xs4all.nl wrote:
In practice it seems that the easiest approach is not to clean up anything in
the
disconnect, just take the lock, do the bare minimum necessary for the
disconnect,
unregister the video nodes, unlock and end with
Hi Martin,
On Tue, May 29, 2012 at 7:24 PM, Martin Blumenstingl
martin.blumensti...@googlemail.com wrote:
What would you use as the first (dev) argument for dev_*?
I simply tried using the USB-device (dev-udev-dev) there, and I
think it's less
descriptive if one removes the driver name and
://patches.openembedded.org/patch/21469/
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
configure.ac | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 98fad38..92ee050 100644
--- a/configure.ac
+++ b/configure.ac
@@ -83,8 +83,17 @@ AS_IF
Hi,
On Sat, May 26, 2012 at 4:18 PM, Volokh Konstantin volok...@gmail.com wrote:
Signed-off-by: Volokh Konstantin volok...@gmail.com
---
drivers/media/video/bt8xx/bttv-driver.c | 6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git
On Wed, May 30, 2012 at 4:43 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
But the subject is *very* wrong. You should set it to something like:
[bt8xx] Remove duplicated pixel format entry.
Sorry this should be, [PATCH] bt8xx: Remove duplicated pixel format entry.
--
To unsubscribe
Hi Martin,
On Wed, May 30, 2012 at 4:50 PM, Martin Blumenstingl
martin.blumensti...@googlemail.com wrote:
Hello,
thanks to Fabio and Ezequiel for the suggestions.
This is the latest version of my patch.
It basically shows this when connecting my stick
(of course only if I remove my other
Hi Gregor,
On Thu, May 31, 2012 at 4:07 AM, Gregor Jasny gja...@googlemail.com wrote:
Hello,
On 5/30/12 3:42 PM, Ezequiel Garcia wrote:
This patch could ease the job of a few people,
by providing an option they actually need.
OpenWRT [1] and Openembedded [2] are already disabling
qv4l2
On Sat, Jun 2, 2012 at 12:32 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
This driver adds support for stk1160 usb bridge as used in some
video/audio usb capture devices.
It is a complete rewrite of staging/media/easycap driver and
it's expected as a future replacement.
Signed-off
Hi Hans,
On Sun, Jun 3, 2012 at 7:33 AM, Hans Verkuil hverk...@xs4all.nl wrote:
[snip]
Thanks. I've fixed several things reported by v4l2-compliance (see my patch
below), but you are using an older v4l2-compliance version. You should clone
and compile the v4l-utils.git repository yourself,
101 - 200 of 808 matches
Mail list logo
