Use the physical device rather than the i2c adapter as the reference
device when loading firmwares. This will prevent the sysfs name
collision with i2c-dev that has been reported many times.
I may have missed other drivers which need the same fix.
Signed-off-by: Jean Delvare kh...@linux-fr.org
On Fri, 17 Apr 2009 22:29:27 +0200, Jean Delvare wrote:
Here comes an update of my conversion of ir-kbd-i2c to the new i2c
binding model. I've split it into 6 pieces for easier review. (...)
Did anyone test these patches, please?
--
Jean Delvare
--
To unsubscribe from this list: send the line
On Fri, 1 May 2009 22:25:28 -0500 (CDT), Mike Isely wrote:
On Thu, 30 Apr 2009, Mike Isely wrote:
On Thu, 30 Apr 2009, Jean Delvare wrote:
The i2c core used to maintain a list of client for each adapter. This
is a duplication of what the driver core already does, so this list
/linux/ir-kbd-i2c/
Additionally I've put a combined patch there, to make testing easier:
http://jdelvare.pck.nerim.net/linux/ir-kbd-i2c/ir-kbd-i2c-conversion-ALL-IN-ONE.patch
But for review the individual patches are much better.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send
In the standard device driver binding model, the name field of
struct i2c_client is used to match devices to their drivers, so we
must stop using it for internal purposes. Define a separate field
in struct IR_i2c as a replacement, and use it.
Signed-off-by: Jean Delvare kh...@linux-fr.org
. This would be more efficient and less risky than always
probing extra addresses on all boards. I'll give it a try later.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Hans Verkuil hverk...@xs4all.nl
Cc: Andy Walls awa...@radix.net
Cc: Mike Isely
For specific boards, pass initialization data to ir-kbd-i2c instead
of modifying the settings after the device is initialized. This is
more efficient and easier to read.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux/drivers/media/video/cx231xx/cx231xx-cards.c |3
linux/drivers
crash on unsupported IR devices. Simply,
the driver will not bind to the unsupported devices.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Andy Walls awa...@radix.net
---
linux/drivers/media/video/ir-kbd-i2c.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
--- v4l
Now that we instantiate I2C IR devices explicitly, we can skip probing
altogether on boards where the I2C IR device address is known. The MSI
t...@nywhere Plus is one of these boards.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux/drivers/media/video/saa7134/saa7134-input.c | 28
Now that we instantiate I2C IR devices explicitly, we can skip probing
altogether on boards where the I2C IR device address is known. The
AVerMedia Cardbus E506R is one of these boards.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Tested-by: Oldrich Jedlicka oldium@seznam.cz
---
linux
Probe I2C addresses 0x71 and 0x6b for IR receiver devices (for the
PVR150 and Adaptec cards, respectively.)
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Hans Verkuil hverk...@xs4all.nl
---
linux/drivers/media/video/ivtv/ivtv-i2c.c|7 ++-
linux/drivers/media/video
Now that the ir-kbd-i2c driver has been converted to a new-style i2c
driver, we can instantiate the ir_video I2C device by default. The
pvr2_disable_ir_video is kept to disable the IR receiver, either
because the user doesn't use it, or for debugging purpose.
Signed-off-by: Jean Delvare kh
On Thu, 14 May 2009 21:25:02 +0200, Oldřich Jedlička wrote:
On Wednesday 13 of May 2009 at 21:45:59, Jean Delvare wrote:
Hi all,
Here comes an update of my conversion of ir-kbd-i2c to the new i2c
binding model. I've split it into 8 pieces for easier review. Firstly
there is 1
On Sun, 17 May 2009 16:55:54 -0500 (CDT), Mike Isely wrote:
On Wednesday 13 of May 2009 at 21:45:59, Jean Delvare wrote:
Here comes an update of my conversion of ir-kbd-i2c to the new i2c
binding model. I've split it into 8 pieces for easier review. Firstly
there is 1 preliminary patch
anyway, because you certainly need to run different
code paths depending on how the device is connected, and you also have
to differentiate between the I2C support is missing case and the I2C
device registration failed case, etc.
--
Jean Delvare
--
To unsubscribe from this list: send the line
Hi Mark,
On Wed, 27 May 2009 13:01:40 +0100, Mark Brown wrote:
On Wed, May 27, 2009 at 09:18:31AM +0200, Jean Delvare wrote:
Violent nack. Drivers which optionally use I2C are a minority.
It's extremely common for devices like the CODECs and PMICs used in
embedded systems to have both
Add missing __devexit_p() to several drivers. Also add a few missing
__init, __devinit and __exit markers. These errors could result in
build failures depending on the kernel configuration.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux/drivers/media/dvb/bt8xx/bt878.c
On Tue, 2 Jun 2009 10:34:32 +0100, Mark Brown wrote:
On Tue, Jun 02, 2009 at 09:12:29AM +0200, Jean Delvare wrote:
What could be done, OTOH, is to surround all the function declarations
in linux/i2c.h with a simple #ifdef CONFIG_I2C, so that mistakes are
caught earlier (build time instead
.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
that still
relies on autoprobing. If it comes first, then it seems to mess up tveeprom
for some reason. Once ir-kbd-i2c no longer does autoprobing, then it probably
should move back to the other i2c modules.
Hopefully this will happen in the next few days :)
--
Jean Delvare
--
To unsubscribe
There is no point in defining I2C adapter IDs when no code is using
them. As this field might go away in the future, stop using it when
we don't need to.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
There are 2 different cases:
* If ir-kbd-i2c tests the adapter ID on older kernels, we have
support fast I2C, up to 400 kHz but limited to
250 kHz by the i2c-algo-bit implementation.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
: i2c write to 71
failed
Oct 5 11:41:16 moon kernel: [45431.031468] ivtv0: i2c: Slave did not ack
That would be I2C probe attempts such as the ones done by ir-kbd-i2c.
Nothing to be afraid of.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media
Hi Andy,
On Sun, 04 Oct 2009 16:11:32 -0400, Andy Walls wrote:
On Sun, 2009-10-04 at 10:54 +0200, Jean Delvare wrote:
On Sat, 03 Oct 2009 11:44:20 -0400, Andy Walls wrote:
/* This array should match the IVTV_HW_ defines */
@@ -126,7 +131,8 @@
wm8739,
vp27smpx,
m52790
Hi Devin,
On Thu, 22 Oct 2009 15:27:20 -0400, Devin Heitmueller wrote:
On Thu, Oct 22, 2009 at 3:13 PM, Jean Delvare kh...@linux-fr.org wrote:
Hi folks,
I am looking for details regarding the DVB frontend API. I've read
linux-dvb-api-1.0.0.pdf, it roughly explains what the FE_READ_BER
On Thu, 22 Oct 2009 21:13:30 +0200, Jean Delvare wrote:
For example, the signal strength. All I know so far is that this is a
16-bit value. But then what? Do greater values represent stronger
signal or weaker signal? Are 0x and 0x special values? Is the
returned value meaningful even
calls are taken from the same original register value. One
advantage is that we thus did not have to map the API to the hardware
register constraints and thus have the guarantee that all hardware
designs fit.
I don't know if a similar logic would help for DVB.
--
Jean Delvare
--
To unsubscribe
to live in the
lm-sensors package (up to 2.10.x) but is now in i2c-tools:
http://www.lm-sensors.org/wiki/I2CTools
With that information, I should be able to figure out what I2C address
that microcontroller is listening to.
--
Jean Delvare
--
To unsubscribe from this list: send the line
commands for all the addresses. Beware though that some
chips are known to not like it at all (in particular the infamous
AT24RF08... not that I expect to ever see one on a TV adapter but you
never know.)
At least the above scan has already found 3 chips.
--
Jean Delvare
--
To unsubscribe from
On Sun, 22 Nov 2009 19:17:59 -0500, Andy Walls wrote:
On Sun, 2009-11-22 at 21:32 +0100, Jean Delvare wrote:
The fact that 0x30-0x37 and 0x50-0x5f all reply suggest that the bus
driver erroneously returns success to SMBus receive byte transactions
even when no device acks. This is a bug
.
Can't we have the cx88 driver poll the remote control only when the
device node is opened? I believe this would save some power by allowing
the CPU to stay in higher C states.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message
Hi Mauro,
On Wed, 31 Mar 2010 14:46:37 -0300, Mauro Carvalho Chehab wrote:
Hi Jean,
Jean Delvare wrote:
Hi Andrzej,
Last year, you submitted a fix for the cx88 remote control not behaving
properly on some cards. The fix works fine for me and lets me use my
remote control, and I am
The probe method used by i2c_new_probed_device() may not be suitable
for all cases. Let the caller provide its own, optional probe
function.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
Documentation/i2c/instantiating-devices |2
drivers/i2c/i2c-core.c| 65
Now that i2c-core offers the possibility to provide custom probing
function for I2C devices, let's make use of it.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
I wasn't too sure where to put the custom probe function: in each driver,
in the ir-common module or in the v4l2-common module. I
Hi Andy,
On Sun, 04 Apr 2010 21:54:39 -0400, Andy Walls wrote:
On Sun, 2010-04-04 at 16:14 +0200, Jean Delvare wrote:
Now that i2c-core offers the possibility to provide custom probing
function for I2C devices, let's make use of it.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Hi Mauro,
On Mon, 05 Apr 2010 15:26:32 -0300, Mauro Carvalho Chehab wrote:
Jean Delvare wrote:
Now that i2c-core offers the possibility to provide custom probing
function for I2C devices, let's make use of it.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
I wasn't too sure
Hi Mauro,
On Tue, 06 Apr 2010 02:34:46 -0300, Mauro Carvalho Chehab wrote:
Jean Delvare wrote:
On Mon, 05 Apr 2010 15:26:32 -0300, Mauro Carvalho Chehab wrote:
Please, don't add new things at ir-common module. It basically contains the
decoding functions for RC5 and pulse/distance, plus
Hi Mauro,
On Fri, 09 Apr 2010 01:09:08 -0300, Mauro Carvalho Chehab wrote:
Jean Delvare wrote:
There are no other probing functions yet, this is the first one. I have
added the mechanism to i2c-core for these very IR chips.
Putting all probe functions together would mean moving them
() could
be replaced with i2cdprintk (which is misnamed IMHO, BTW.)
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Dan,
On Tue, 25 May 2010 11:19:53 +0200, Dan Carpenter wrote:
The problem is that dprintk() dereferences dev which is null here.
The i2cdprintk() uses ir so that's OK.
Signed-off-by: Dan Carpenter erro...@gmail.com
---
v2: Jean Delvare suggested that I use i2cdprintk() instead
On Tue, 25 May 2010 11:21:50 +0200, Dan Carpenter wrote:
The original code had two break statements in a row.
Signed-off-by: Dan Carpenter erro...@gmail.com
Acked-by: Jean Delvare kh...@linux-fr.org
---
v3: Put this in a seperate patch.
diff --git a/drivers/media/video/saa7134/saa7134
a custom probing function.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Tested-by: Timothy D. Lenz tl...@vorgon.com
---
This fix applies to kernels 2.6.31 to 2.6.34. Should be sent to Linus
quickly. I had already sent on March 29th, but apparently it was
overlooked. I have further i2c patches which
On Sat, 29 May 2010 01:29:54 -0300, Mauro Carvalho Chehab wrote:
Em Sat, 22 May 2010 22:59:21 +0200
Jean Delvare kh...@linux-fr.org escreveu:
I would have used (null) instead of null for consistency with
lib/vsprintf.c:string().
But more importantly, I suspect that a better fix would
it all in one go.
If I take the patch in my i2c tree, the aim is to merge it upstream
immediately, so merge issues won't exist.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers.
As there is no need anymore to clear the clientdata-pointer, remove all
current
occurrences in the drivers to simplify the code and prevent confusion.
Signed-off-by: Wolfram Sang w.s...@pengutronix.de
Cc: Jean Delvare kh...@linux-fr.org
Mauro,
On Wed, 26 May 2010 15:05:11 +0200, Jean Delvare wrote:
IR support on FusionHDTV cards is broken since kernel 2.6.31. One side
effect of the switch to the standard binding model for IR I2C devices
was to let i2c-core do the probing instead of the ir-kbd-i2c driver.
There is a slight
The probe method used by i2c_new_probed_device() may not be suitable
for all cases. Let the caller provide its own, optional probe
function.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Acked-by: Mauro Carvalho Chehab mche...@redhat.com
---
Documentation/i2c/instantiating-devices |2
Now that i2c-core offers the possibility to provide custom probing
function for I2C devices, let's make use of it.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Acked-by: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/i2c/i2c-core.c|7 +++
drivers/media/video
Hi Wolfram,
On Wed, 9 Jun 2010 17:05:40 +0200, Wolfram Sang wrote:
Hi Jean,
On Tue, Jun 08, 2010 at 10:01:00AM +0200, Jean Delvare wrote:
Now that i2c-core offers the possibility to provide custom probing
function for I2C devices, let's make use of it.
Signed-off-by: Jean Delvare kh
of warning gcc 4.6.0 generates. Depends which warnings we value
more, as we can't sanely have both.
mutex_unlock(core_lock);
return 0;
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More
?
ud-model_id : SBP2_ROM_VALUE_MISSING;
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi David,
On Mon, 14 Jun 2010 14:28:57 -0700, David Daney wrote:
On 06/14/2010 01:53 PM, Jean Delvare wrote:
Hi Justin,
On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote:
could be a right solution, could be wrong
here is the warning:
CC drivers/i2c/i2c-core.o
Hi Justin,
On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote:
On 06/14/2010 01:53 PM, Jean Delvare wrote:
Hi Justin,
On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote:
could be a right solution, could be wrong
here is the warning:
CC drivers/i2c/i2c-core.o
On Tue, 15 Jun 2010 09:20:39 -0700, David Daney wrote:
On 06/15/2010 04:40 AM, Jean Delvare wrote:
__process_new_adapter() calls i2c_do_add_adapter() which always returns
0. Why should I check the return value of bus_for_each_drv() when I
know it will always be 0 by construction?
Also
to disable IR support (coming soon.)
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
drivers/media/video/cx88/cx88-cards.c |1 +
drivers/media/video/cx88/cx88-i2c.c |6 +-
drivers/media/video/cx88/cx88.h |1 +
3 files changed, 7 insertions(+), 1 deletion(-)
--- linux-2.6.34-rc3
It might be useful to be able to disable the IR support, either for
debugging purposes, or just for users who know they won't use the IR
remote control anyway. On many cards, IR support requires expensive
polling/sampling which is better avoided if never needed.
Signed-off-by: Jean Delvare kh
, as presumably this
only happens once at initialization time?
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Trent,
On Fri, 16 Jan 2009 05:34:59 -0800 (PST), Trent Piepho wrote:
On Fri, 16 Jan 2009, Jean Delvare wrote:
Hi Mauro, Trent,
On Fri, 16 Jan 2009 00:02:52 -0200, Mauro Carvalho Chehab wrote:
For now, we should finish the Hans approach, since it also helps to stop
using
Hi Trent,
On Sat, 17 Jan 2009 11:45:57 -0800 (PST), Trent Piepho wrote:
On Fri, 16 Jan 2009, Jean Delvare wrote:
On Fri, 16 Jan 2009 05:34:59 -0800 (PST), Trent Piepho wrote:
How will this work for drivers like bttv, where the i2c address of the
tuner chips isn't know for every supported
On Sun, 1 Feb 2009 11:42:57 -0200, Mauro Carvalho Chehab wrote:
On Sun, 1 Feb 2009 14:29:27 +0100
Jean Delvare kh...@linux-fr.org wrote:
On Thu, 29 Jan 2009 19:24:31 -0200, Mauro Carvalho Chehab wrote:
I have already a pull request almost ready that will fix this issue. I'll
likely
this.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 1 Feb 2009 11:42:57 -0200, Mauro Carvalho Chehab wrote:
On Sun, 1 Feb 2009 14:29:27 +0100
Jean Delvare kh...@linux-fr.org wrote:
Hi Mauro,
On Thu, 29 Jan 2009 19:24:31 -0200, Mauro Carvalho Chehab wrote:
On Thu, 29 Jan 2009 22:10:12 +0100
Jean Delvare kh...@linux-fr.org
happen on each rmmod cx8800, but as I managed to reproduce
it once, I guess I should be able to reproduce it again if needed.
Please let me know if you need more information or want me to test
something.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media
to be too high, so there's a balance to be found between users and
developers. At the moment the balance isn't right IMHO.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
The v4l-dvb repository supports kernel versions 2.6.16 and later only,
so no need to test for kernel version 2.6.15.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux/drivers/media/dvb/dvb-usb/af9015.c |3 ---
1 file changed, 3 deletions(-)
--- v4l-dvb-zoran.orig/linux/drivers/media
is the way to go, I'm not going to prevent you from going
down that road. As a kernel developer, that would make me very happy.
But I remember that the hg tree is there to help users test the newest
developments without running a bleeding-edge kernel, and that certainly
makes some sense.
Thanks,
--
Jean
Hi Mauro,
Only answering points Hans didn't already answered (and I agree with
him):
On Fri, 20 Feb 2009 21:23:27 -0300, Mauro Carvalho Chehab wrote:
On Wed, 18 Feb 2009 14:01:05 +0100
Jean Delvare kh...@linux-fr.org wrote:
Not necessarily something to be proud about. This only shows how
, why don't send your patches out to Hans and myself for review? If
you came up with simplifications that work, we will be very happy to
apply them.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
On Sat, 21 Feb 2009 14:28:31 +0100, Hans Verkuil wrote:
On Saturday 21 February 2009 14:11:30 Jean Delvare wrote:
Well, that's basically what Hans has been doing with
v4l2-i2c-drv-legacy.h for months now, isn't it? This is the easy part
(even though even this wasn't exactly trivial
on the result you then call i2c_new_device(A) or
i2c_new_device(B).
The 3rd method is very similar to the legacy i2c binding model.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
, and it is a good that I am
not in charge of anything.
Actually, it would totally please me :)
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Trent,
On Sat, 21 Feb 2009 05:58:10 -0800 (PST), Trent Piepho wrote:
On Sat, 21 Feb 2009, Jean Delvare wrote:
Well, that's basically what Hans has been doing with
v4l2-i2c-drv-legacy.h for months now, isn't it? This is the easy part
(even though even this wasn't exactly trivial
.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
them into ex-developers when they realize they lost all the fun, and
prevents new developers from joining the project because of the
complexity of the compatibility layer.
So let's just drop support for kernels 2.6.22 and focus on better
supporting upstream and recent kernels.
Thanks,
--
Jean
that, so if we can't find a tester and it
has to stay for a few more years, this really isn't a problem for me.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
users with failed buffer allocation
kmalloc() can fail for large video buffers. By default the kernel
complains loudly about allocation failures, but we don't want to
frighten the user, so ask kmalloc() to keep quiet on such failures.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux
Hi Andy,
On Mon, 02 Mar 2009 09:16:05 -0500, Andy Walls wrote:
On Mon, 2009-03-02 at 13:39 +0100, Jean Delvare wrote:
On Sun, 15 Feb 2009 21:41:08 +0100, Jean Delvare wrote:
Hi all,
Today I have hit the following general protection fault when removing
module cx8800:
This has
On Mon, 2 Mar 2009 17:03:49 +0100, Jean Delvare wrote:
As far as I can see the key difference between bttv-input and
cx88-input is that bttv-input only uses a simple self-rearming timer,
while cx88-input uses a timer and a separate workqueue. The timer runs
the workqueue, which rearms
On Tue, 3 Mar 2009 12:14:06 -0800 (PST), Trent Piepho wrote:
On Tue, 3 Mar 2009, Jean Delvare wrote:
On Tue, 3 Mar 2009 01:40:00 -0800 (PST), Trent Piepho wrote:
On Mon, 2 Mar 2009, Jean Delvare wrote:
In 2.6.20 delayed_work was split from work_struct. The concept of delayed
work
On Thu, 5 Mar 2009 01:43:55 -0800 (PST), Trent Piepho wrote:
On Thu, 5 Mar 2009, Jean Delvare wrote:
+#if LINUX_VERSION_CODE KERNEL_VERSION(2,6,20)
struct work_struct work;
struct timer_list timer;
+#else
+ struct delayed_work work;
+#endif
You don't need this compat
Hi Devin,
On Thu, 5 Mar 2009 13:03:00 -0500, Devin Heitmueller wrote:
On Thu, Mar 5, 2009 at 4:39 AM, Jean Delvare kh...@linux-fr.org wrote:
I would suggest that this patch be broken into three separate patches,
and then they can go in as the individual maintainers have the
opportunity
The lock_norm module parameter doesn't look terribly useful. If you
don't want to change the norm, just don't change it. As a matter of
fact, no other v4l driver has such a parameter.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Trent Piepho xy...@speakeasy.org
Cc: Hans Verkuil hverk
kmalloc() can fail for large video buffers. By default the kernel
complains loudly about allocation failures, but we don't want to
frighten the user, so ask kmalloc() to keep quiet on such failures.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Trent Piepho xy...@speakeasy.org
Cc: Hans
When unloading the cx8800 driver I sometimes get a general protection
fault. Analysis revealed a race in cx88_ir_stop(). It can be solved by
using a delayed work instead of a timer for infrared input polling.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
Thanks to Trent's compatibility
The removal of the timer which polls the infrared input is racy.
Replacing the timer with a delayed work solves the problem.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Devin Heitmueller devin.heitmuel...@gmail.com
---
linux/drivers/media/video/em28xx/em28xx-input.c | 24
The removal of the timer which polls the infrared input is racy.
Replacing the timer with a delayed work solves the problem.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux/drivers/media/video/ir-kbd-i2c.c | 22 ++
linux/include/media/ir-kbd-i2c.h |3
On Wed, 11 Mar 2009 04:55:19 +0100, Patch from Jean Delvare wrote:
The patch number 10935 was added via Mauro Carvalho Chehab
mche...@redhat.com
to http://linuxtv.org/hg/v4l-dvb master development tree.
Kernel patches in this development tree may be modified to be backward
compatible
Mailing list video4linux-l...@redhat.com is deprecated, so drop
references to it in MAINTAINERS.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@infradead.org
---
MAINTAINERS |2 --
1 file changed, 2 deletions(-)
--- linux-2.6.29-rc8.orig/MAINTAINERS 2009
The video4linux-l...@redhat.com list is deprecated, point the users to
the new linux-media list instead.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux/Documentation/video4linux/bttv/README |4 ++--
linux/drivers/media/radio/radio-si470x.c |4 ++--
linux/drivers/media
Hi Hans,
On Sat, 14 Mar 2009 22:39:35 +0100, Hans Verkuil wrote:
On Saturday 14 March 2009 22:25:14 Jean Delvare wrote:
The video4linux-l...@redhat.com list is deprecated, point the users to
the new linux-media list instead.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux
I see the following warning when building the zoran driver:
v4l/zoran_card.c: In function 'zoran_probe':
v4l/zoran_card.c:1243: warning: assignment from incompatible pointer type
Fixing the notify callback prototype solves it.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Hans Verkuil hverk
-i2c drivers, so I might as well be completely off track.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 15 Mar 2009 10:42:41 -0700 (PDT), Trent Piepho wrote:
On Sun, 15 Mar 2009, Jean Delvare wrote:
On Sun, 15 Mar 2009 13:44:01 +0100, Hans Verkuil wrote:
This is the typical multifunction device problem. It isn't specifically
related to I2C, the exact same problem happens for other
Hi Andy,
On Sun, 15 Mar 2009 15:34:33 -0400, Andy Walls wrote:
On Sun, 2009-03-15 at 18:12 +0100, Jean Delvare wrote:
Hi Hans,
On Sun, 15 Mar 2009 13:44:01 +0100, Hans Verkuil wrote:
Hi Mauro, Jean,
When converting the bttv driver to v4l2_subdev I found one probing
conflict
with the current situation. Or even slightly better
since we can now ensure that audio is working at least.
Agreed.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
the same I2C device. And even if only one driver
accesses the I2C device, all accesses that can happen in parallel (for
example triggered by sysfs attribute reads or writes) may have to be
serialized by the driver.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux
Hi Mauro,
On Mon, 16 Mar 2009 06:34:02 -0300, Mauro Carvalho Chehab wrote:
On Sun, 15 Mar 2009 18:53:13 +0100
Jean Delvare kh...@linux-fr.org wrote:
On Sun, 15 Mar 2009 10:42:41 -0700 (PDT), Trent Piepho wrote:
You can also split the device into multiple devices. Most SoCs have one
Hi Mauro,
On Mon, 16 Mar 2009 09:52:37 -0300, Mauro Carvalho Chehab wrote:
On Mon, 16 Mar 2009 12:18:01 +0100
Jean Delvare kh...@linux-fr.org wrote:
I really don't see any problem there. There are many drivers (i2c or
not) in the kernel which do exactly this and this works just fine. We
is supported since kernel 2.6.26, which looks promising.
However, before I actually buy it, I would love to hear from someone
actually using this device under Linux. Anyone? Is there anything to
worry about, or can I just buy it?
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line
101 - 200 of 309 matches
Mail list logo
