On 10/16/2016 05:18 AM, Laurent Pinchart wrote:
Hi Steve,
Thank you for the patch.
On Wednesday 03 Aug 2016 11:03:45 Steve Longerbeam wrote:
Parse the optional v4l2 endpoint DT node. If the bus type is
V4L2_MBUS_BT656 and the endpoint node specifies "newavmode",
configure the BT.
On 12/19/2017 03:42 AM, Philipp Zabel wrote:
Allow building this driver for other platforms under COMPILE_TEST.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Philipp Zabel
Acked-by: Steve Longerbeam
---
drivers/staging/media/imx/Kconfig | 3 ++-
1 file changed, 2 insertions
Hi Tim,
Happy New Year! And pardon the delay.
On 12/28/2017 01:56 PM, Tim Harvey wrote:
Steve/Hans,
I'm trying to get interlaced capture working with the TDA1997x driver
I've been working on which is connected to an IMX6 CSI.
The particular board I'm currently testing on is an IMX6Q which has
On 01/04/2018 09:57 AM, Tim Harvey wrote:
On Tue, Jan 2, 2018 at 6:00 PM, Steve Longerbeam wrote:
Hi Tim,
Happy New Year! And pardon the delay.
On 12/28/2017 01:56 PM, Tim Harvey wrote:
Steve/Hans,
I'm trying to get interlaced capture working with the TDA1997x driver
I've be
On 01/04/2018 10:51 AM, Steve Longerbeam wrote:
On 01/04/2018 09:57 AM, Tim Harvey wrote:
Try this hack as an experiment: modify is_parallel_16bit_bus() in
imx-media-csi.c to simply return false, and see if the above pipeline
works.
I'm currently on 4.15-rc1 which doesn
On 01/04/2018 01:11 PM, Tim Harvey wrote:
On Thu, Jan 4, 2018 at 10:51 AM, Steve Longerbeam wrote:
On 01/04/2018 09:57 AM, Tim Harvey wrote:
On Tue, Jan 2, 2018 at 6:00 PM, Steve Longerbeam
wrote:
Hi Tim,
Happy New Year! And pardon the delay.
On 12/28/2017 01:56 PM, Tim Harvey wrote
Acked-by: Steve Longerbeam
On 01/15/2018 12:11 AM, Dan Carpenter wrote:
We recently changed this error handling around but missed this error
pointer check. We're testing "priv->vdi_in_ch_n" instead of "ch" so the
error handling can't be triggered.
Fixes:
Acked-by: Steve Longerbeam
On 01/23/2018 04:43 PM, Gustavo A. R. Silva wrote:
Fix inconsistent IS_ERR and PTR_ERR in vdic_get_ipu_resources.
The proper pointer to be passed as argument is ch.
This issue was detected with the help of Coccinelle.
Fixes: 0b2e9e7947e7 ("media: stagin
On 07/16/2018 07:12 AM, Philipp Zabel wrote:
Hi Steve,
On Thu, 2018-07-05 at 15:09 -0700, Steve Longerbeam wrote:
[...]
[...]
+ halign = 0;
+ break;
+ }
+ if (f->type == V4L2_BUF_TYPE_VIDEO_OUTPUT) {
+ /*
+* The IC bu
Hi Philipp,
On 07/19/2018 08:30 AM, Philipp Zabel wrote:
Hi,
this is the second version of the i.MX mem2mem scaler series.
Patches 8 and 16 have been modified.
Changes since v1:
- Fix inverted allow_overshoot logic
- Correctly switch horizontal / vertical tile alignment when
determini
On 07/22/2018 11:30 AM, Steve Longerbeam wrote:
Hi Philipp,
On 07/19/2018 08:30 AM, Philipp Zabel wrote:
Hi,
this is the second version of the i.MX mem2mem scaler series.
Patches 8 and 16 have been modified.
Changes since v1:
- Fix inverted allow_overshoot logic
- Correctly switch
On 07/23/2018 12:31 AM, Philipp Zabel wrote:
ipu_image_convert_adjust tries to adjust both input and output image at
the same time, here we just have the format of either input or output
image. Do you suggest to split this function into an input and an output
version?
See b4362162c0 ("media:
driver unloads and reloads correctly
with no memory leaking of asd objects.
Suggested-by: Sakari Ailus
Signed-off-by: Steve Longerbeam
---
Changes since v5:
- remove reference to notifier.num_subdevs, and call
v4l2_async_notifier_init(). Suggested by Sakari Ailus.
- removed "OF" qualifier
ug in VDIC indirect mode.
- remove alternate field type from V4L2_FIELD_IS_SEQUENTIAL() macro
Suggested-by: Nicolas Dufresne .
- add macro V4L2_FIELD_IS_INTERLACED().
Philipp Zabel (1):
gpu: ipu-v3: Allow negative offsets for interlaced scanning
Steve Longerbeam (13):
media: videodev2.h: Add
Hi Jacopo,
On 08/14/2018 08:35 AM, jacopo mondi wrote:
Hi Steve,
sorry for resurecting this.
I'm sorry I'm not sur I'm following. Does this mean that with that bug
you are referring to up here fixed by my last patch you have capture
working?
No, capture still not working for me on Sabre
On 08/14/2018 10:38 AM, jacopo mondi wrote:
Hi Steve,
On Tue, Aug 14, 2018 at 09:51:04AM -0700, Steve Longerbeam wrote:
Hi Jacopo,
On 08/14/2018 08:35 AM, jacopo mondi wrote:
Hi Steve,
sorry for resurecting this.
I'm sorry I'm not sur I'm following. Does this mean
Hi Sakari,
On 08/27/2018 02:29 AM, Sakari Ailus wrote:
Hello everyone,
I've long thought the V4L2 fwnode framework requires some work (it's buggy
and it does not adequately serve common needs). This set should address in
particular these matters:
- Most devices support a particular media bus
the static register value table
has been sent to the sensor in the ov5640_load_regs() function.
Fixes: 476dec012f4c ("media: ov5640: Add horizontal and vertical totals")
Tested-by: Steve Longerbeam
on i.MX6q SabreSD with MIPI CSI-2 OV5640 module
Acked-by: Steve Longerbeam
Tested-
s stability on my testing platform
where MIPI capture often failed and returned all-purple frames.
fixes: f22996db44e2 ("media: ov5640: add support of DVP parallel interface")
Tested-by: Steve Longerbeam
on i.MX6q SabreSD with MIPI CSI-2 OV5640 module
Acked-by: Steve Longerbeam
Test
Hi Hughes,
The whole series,
Acked-by: Steve Longerbeam
and
Tested-by: Steve Longerbeam
on i.MX6q SabreSD with MIPI CSI-2 OV5640 module
On 09/11/2018 06:48 AM, Hugues Fruchet wrote:
This patch serie fixes some problems around exposure & gain in OV5640 driver.
The 4th patch a
: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-utils.c
b/drivers/staging/media/imx/imx-media-utils.c
index 8aa13403b09d..0eaa353d5cb3 100644
--- a/drivers/staging/media
-by: Marek Vasut
Cc: Philipp Zabel
Cc: Steve Longerbeam
Same here, I cannot merge with out Acks since I don't know the details
of the imx hardware.
I'm marking this patch as Obsoleted since there has been no activity for a long
time.
Hi Hans, yes that's fine. IIRC this issue has
.
Signed-off-by: Marek Vasut
Cc: Steve Longerbeam
Cc: Philipp Zabel
Steve, Philipp,
I saw there was a discussion about this patch, but no clear answer whether
or not this patch is OK. If it is, then please Ack this patch.
Marking this patch as Obsoleted since I have no seen any activity for a long
er->subdevs[] array is stripped from v4l2-async and v4l2-subdev
docs are updated to reflect the new method of adding asd's to notifiers.
Signed-off-by: Steve Longerbeam
Patches 07-14 (video-mux and the imx patches) are
Reviewed-by: Philipp Zabel
Patches 01-14 are
Tested-by: Philip
er->subdevs[] array is stripped from v4l2-async and v4l2-subdev
docs are updated to reflect the new method of adding asd's to notifiers.
Signed-off-by: Steve Longerbeam
Patches 07-14 (video-mux and the imx patches) are
Reviewed-by: Philipp Zabel
Patches 01-14 are
Tested-by: Philip
keeping an internal master asd_list, since this is
moved to the notifier's asd_list.
Signed-off-by: Steve Longerbeam
---
Changes since v6:
- none
Changes since v5:
- remove reference to notifier.num_subdevs and call
v4l2_async_notifier_init(). Suggested by Sakari Ailus.
---
drivers/st
tifier and return 0.
__v4l2_async_notifier_parse_fwnode_endpoints() will then continue
parsing the remaining port endpoints of the device.
Signed-off-by: Steve Longerbeam
Acked-by: Hans Verkuil
---
Changes since v6:
- none
Changes since v5:
- none
Changes since v4:
- none
Changes since v3:
- no
Hi Hans,
On 10/01/2018 03:07 AM, Hans Verkuil wrote:
Hi Steve,
On 08/01/2018 09:12 PM, Steve Longerbeam wrote:
A set of patches that fixes some bugs with capturing from an
interlaced source, and incompatibilites between IDMAC interlace
interweaving and 4:2:0 data write reduction.
I reviewed
On 10/04/2018 06:41 AM, Hans Verkuil wrote:
On 10/04/18 01:21, Steve Longerbeam wrote:
Hi Hans,
On 10/01/2018 03:07 AM, Hans Verkuil wrote:
Hi Steve,
On 08/01/2018 09:12 PM, Steve Longerbeam wrote:
A set of patches that fixes some bugs with capturing from an
interlaced source, and
e function.
- fix bug with resetting crop/compose rectangles.
- add a patch that fixes a field order bug in VDIC indirect mode.
- remove alternate field type from V4L2_FIELD_IS_SEQUENTIAL() macro
Suggested-by: Nicolas Dufresne .
- add macro V4L2_FIELD_IS_INTERLACED().
Steve Longerbeam (11):
media:
On 10/04/2018 12:34 PM, Hans Verkuil wrote:
On 10/04/2018 08:53 PM, Steve Longerbeam wrote:
A set of patches that fixes some bugs with capturing from an
interlaced source, and incompatibilites between IDMAC interlace
interweaving and 4:2:0 data write reduction.
History:
v4:
- rebased to
to the exposition
gpu: ipu-v3: image-convert: disable double buffering if necessary
gpu: ipu-v3: image-convert: allow three rows or columns
Steve Longerbeam (1):
gpu: ipu-cpmem: add WARN_ON_ONCE() for unaligned dma buffers
drivers/gpu/ipu-v3/ipu-cpmem.c| 6 +
dr
On 09/18/2018 02:34 AM, Philipp Zabel wrote:
+/*
+ * Tile left edges are required to be aligned to multiples of 8 bytes
+ * by the IDMAC.
+ */
+static inline u32 tile_left_align(const struct ipu_image_pixfmt *fmt)
+{
+ return fmt->planar ? 8 * fmt->uv_width_dec : 64 / fmt->bpp;
+}
A
.
- remove alternate field type from V4L2_FIELD_IS_SEQUENTIAL() macro
Suggested-by: Nicolas Dufresne .
- add macro V4L2_FIELD_IS_INTERLACED().
Steve Longerbeam (12):
media: videodev2.h: Add more field helper macros
gpu: ipu-csi: Swap fields according to input/output field types
gpu: ipu-v3:
iven field type is
'interlaced', that is a full frame is transmitted, or exists in
memory, as top field lines interlaced with bottom field lines.
Signed-off-by: Steve Longerbeam
---
Changes since v3:
- none
Changes since v2:
- none
Changes since v1:
- add the complement macro V4L2_FIELD_IS
On 10/17/18 4:05 PM, Tim Harvey wrote:
On Wed, Oct 17, 2018 at 2:33 PM Steve Longerbeam wrote:
Hi Tim,
On 10/17/18 1:38 PM, Tim Harvey wrote:
On Mon, Jun 4, 2018 at 1:58 AM Krzysztof Hałasa wrote:
I've just tested the PAL setup: in currect situation (v4.17 + Steve's
fix-csi-in
On 10/17/18 4:10 AM, Philipp Zabel wrote:
On Fri, 2018-10-12 at 17:33 -0700, Steve Longerbeam wrote:
On 09/18/2018 02:34 AM, Philipp Zabel wrote:
+/*
+ * Tile left edges are required to be aligned to multiples of 8 bytes
+ * by the IDMAC.
+ */
+static inline u32 tile_left_align(const
Hi Philipp,
On 10/12/18 5:29 PM, Steve Longerbeam wrote:
But one last thing. Conversions to and from YV12 are producing images
with wrong colors, it looks like the .uv_swapped boolean needs to be
checked
additionally somewhere. Any ideas?
Sorry, this was my fault. I fixed this in
&quo
Awesome, thanks Philipp.
For the whole series:
Acked-by: Steve Longerbeam
Tested-by: Steve Longerbeam
on i.MX6q SabreSD.
On 10/19/18 5:15 AM, Philipp Zabel wrote:
Hi,
this is the fourth version of the i.MX mem2mem scaler series.
An alignment issue with 24-bit RGB formats has been
On 10/18/18 10:56 AM, Tim Harvey wrote:
On Wed, Oct 17, 2018 at 4:37 PM Steve Longerbeam wrote:
On 10/17/18 4:05 PM, Tim Harvey wrote:
On Wed, Oct 17, 2018 at 2:33 PM Steve Longerbeam wrote:
Hi Tim,
On 10/17/18 1:38 PM, Tim Harvey wrote:
On Mon, Jun 4, 2018 at 1:58 AM Krzysztof Hałasa
On 10/19/18 2:53 AM, Philipp Zabel wrote:
Hi Tim,
On Thu, 2018-10-18 at 15:53 -0700, Tim Harvey wrote:
[...]
Philipp,
Thanks for submitting this!
I'm hoping this lets us use non-IMX capture devices along with the IMX
media controller entities to so we can use hardware
CSC,scaling,pixel-form
(resending as plain text)
On 10/21/18 10:43 AM, Philipp Zabel wrote:
On Fri, Oct 19, 2018 at 01:19:10PM -0700, Steve Longerbeam wrote:
On 10/19/18 2:53 AM, Philipp Zabel wrote:
Hi Tim,
On Thu, 2018-10-18 at 15:53 -0700, Tim Harvey wrote:
[...]
Philipp,
Thanks for submitting this!
I&#
Hi Jean-Michel,
We've done some work with another FPD-Link de-serializer (ds90ux940) and
IIRC we had some trouble figuring out how to coax the lanes into LP-11
state. But on the ds90ux940 it can be done by setting bit 7 in the CSI
Enable Port registers (offsets 0x13 and 0x14). But the "imx6-mi
Hi Philipp,
Thanks, I've been meaning this too. Comments below.
On 11/5/18 7:03 AM, Philipp Zabel wrote:
While subdevice and video device are in the same pipeline, pass
subdevice events on to userspace via the video device node.
Signed-off-by: Philipp Zabel
---
This would allow to see source
Hi Philipp,
On 11/5/18 7:20 AM, Philipp Zabel wrote:
Prepare for mbus format being smaller than the written rectangle
due to burst size.
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-capture.c | 55 +--
1 file changed, 38 insertions(+), 17 deletions(-
Hi Philipp,
On 11/5/18 7:20 AM, Philipp Zabel wrote:
Allowing to compose captured images into larger memory buffers
will let us lift alignment restrictions on CSI crop width.
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/imx-ic-prpencvf.c | 3 +-
drivers/staging/media/imx/im
On 11/5/18 7:20 AM, Philipp Zabel wrote:
The CSI subdevice shouldn't have to care about IDMAC line start
address alignment. With compose rectangle support in the capture
driver, it doesn't have to anymore.
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-capture.c | 9 +
On 11/9/18 6:50 AM, Philipp Zabel wrote:
On Thu, 2018-11-08 at 21:46 -0800, Steve Longerbeam wrote:
On 11/5/18 7:20 AM, Philipp Zabel wrote:
The CSI subdevice shouldn't have to care about IDMAC line start
address alignment. With compose rectangle support in the capture
driver, it do
Hi Fabio,
On 11/22/18 11:17 AM, Fabio Estevam wrote:
Hi Philipp,
On Thu, Nov 22, 2018 at 2:27 PM Philipp Zabel wrote:
There are empty endpoint nodes (without remote-endpoint property)
labeled ipu1_csi[01]_mux_from_parallel_sensor in the i.MX6 device trees
for board DT implementers' convenien
Reviewed-by: Steve Longerbeam
On 11/23/18 4:50 AM, Fabio Estevam wrote:
On a imx6q-wandboard the following warnings are observed:
[4.327794] video-mux 20e.iomuxc-gpr:ipu1_csi0_mux: bad remote port
parent
[4.336118] video-mux 20e.iomuxc-gpr:ipu2_csi1_mux: bad remote port
Hi Hans, Philipp,
One comment on my side...
On 12/3/18 7:21 AM, Hans Verkuil wrote:
+void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev)
+{
+ struct mem2mem_priv *priv = to_mem2mem_priv(vdev);
+ struct video_device *vfd = priv->vdev.vfd;
+
+ mutex_lock
On 12/5/18 10:50 AM, Hans Verkuil wrote:
On 12/05/2018 02:20 AM, Steve Longerbeam wrote:
Hi Hans, Philipp,
One comment on my side...
On 12/3/18 7:21 AM, Hans Verkuil wrote:
+void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev)
+{
+ struct mem2mem_priv *priv
Hi Hans,
On 12/6/18 4:32 AM, Hans Verkuil wrote:
On 12/06/18 00:13, Steve Longerbeam wrote:
On 12/5/18 10:50 AM, Hans Verkuil wrote:
On 12/05/2018 02:20 AM, Steve Longerbeam wrote:
Hi Hans, Philipp,
One comment on my side...
On 12/3/18 7:21 AM, Hans Verkuil wrote:
+void
17/2018 02:00 AM, Steve Longerbeam wrote:
A set of patches that fixes some bugs with capturing from an
interlaced source, and incompatibilites between IDMAC interlace
interweaving and 4:2:0 data write reduction.
History:
v5:
- Added a regression fix to allow empty endpoints to CSI (fix for imx6q
Hi Philipp,
On 10/05/2018 02:44 AM, Philipp Zabel wrote:
Hi Steve,
On Thu, 2018-10-04 at 11:53 -0700, Steve Longerbeam wrote:
+
+ /* framelines for NTSC / PAL */
+ height = (std & V4L2_STD_525_60) ? 525 : 625;
I think this is a bit convoluted. Instea
On 10/05/2018 02:48 AM, Philipp Zabel wrote:
On Thu, 2018-10-04 at 11:53 -0700, Steve Longerbeam wrote:
To support interlaced scan with planar formats, cpmem SLUV must
be programmed with the correct chroma line stride. For full and
partial planar 4:2:2 (YUV422P, NV16), chroma line stride
Hi Philipp,
On 10/05/2018 03:43 AM, Philipp Zabel wrote:
Hi Steve,
On Thu, 2018-10-04 at 11:54 -0700, Steve Longerbeam wrote:
Allow sequential->interlaced interweaving but with top/bottom
lines swapped to the output buffer.
This can be accomplished by adding one line length to IDMAC out
On 10/05/2018 03:52 AM, Philipp Zabel wrote:
Hi Steve,
On Thu, 2018-10-04 at 11:54 -0700, Steve Longerbeam wrote:
+or bottom-top or alternate, and the capture interface field type is set
+to interlaced (t-b, b-t, or unqualified interlaced). The capture interface
+will enforce the same
lines for one field.
Signed-off-by: Steve Longerbeam
---
Changes since v4:
- Cleaned up some convoluted code in ipu_csi_init_interface(), suggested
by Philipp Zabel.
- Fixed a regression in csi_setup(), caught by Philipp.
---
drivers/gpu/ipu-v3/ipu-csi.c | 119
If IDMAC interweaving is enabled in a write channel, the channel must
write the odd chroma rows for 4:2:0 formats. Skipping writing the odd
chroma rows produces corrupted captured 4:2:0 images when interweave
is enabled.
Reported-by: Krzysztof Hałasa
Signed-off-by: Steve Longerbeam
Reviewed-by
-> seq-bt
alternate -> seq-bt
Suggested-by: Philipp Zabel
Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
---
Changes since v4:
- Removed interweave_offset and replace with boolean interweave_swap,
suggested by Philipp Zabel.
---
drivers/staging/media/imx/imx-ic-
().
Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-csi.c | 27 ---
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-csi.c
b/drivers/staging/media/imx/imx-media-csi.c
index
If the incoming sink field type is alternate, the reset crop height
and crop height bounds must be set to twice the incoming height,
because in alternate field mode, upstream will report only the
lines for a single field, and the CSI captures the whole frame.
Signed-off-by: Steve Longerbeam
o fix prepare_vdi_in_buffers() to give the VDIC the fields in whatever
order they were received by the video source, and rely on the VDIC to
sort out which is top and which is bottom.
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-vdic.c | 12 ++--
1 file changed, 2 inser
Also add an example pipeline for unconverted capture with interweave
on SabreAuto.
Cleanup some language in various places in the process.
Signed-off-by: Steve Longerbeam
---
Changes since v4:
- Make clear that it is IDMAC channel that does pixel reordering and
interweave, not the CSI. Caught
an unconnected endpoint as an error.
Fixes: c893500a16baf ("media: imx: csi: Register a subdev notifier")
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-csi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx-medi
top lines.
The capture interface device allows selecting IDMAC interweave by
choosing INTERLACED_TB if the CSI/PRPENCVF source pad is seq-tb and
INTERLACED_BT if the source pad is seq-bt (for future support of seq-bt).
Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
---
drivers/staging/medi
Skip writing U/V components to odd rows for YVU420 in addition to
YUV420 and NV12.
Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-csi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/imx/imx-media-csi.c
b/drivers
doubled, since a single chroma line
is shared by two luma lines.
Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
Acked-by: Philipp Zabel
---
drivers/gpu/ipu-v3/ipu-cpmem.c | 26 +++--
drivers/staging/media/imx/imx-ic-prpencvf.c | 3 ++-
drivers/staging/media
Hi Adam,
On 10/16/18 12:46 PM, Adam Ford wrote:
On Thu, Sep 20, 2018 at 9:58 AM jacopo mondi wrote:
Hi imx6 people,
On Thu, May 31, 2018 at 08:39:20PM +0530, Jagan Teki wrote:
Hi All,
I'm trying to verify MIPI-CSI2 OV5640 camera on i.MX6 platform with
Mainline Linux.
Sorry to resurect thi
Hi Adam,
On 10/23/18 8:19 AM, Adam Ford wrote:
On Mon, Oct 22, 2018 at 7:40 AM Fabio Estevam wrote:
Hi Adam,
On Mon, Oct 22, 2018 at 9:37 AM Adam Ford wrote:
Thank you! This tutorial web site is exactly what I need. The
documentation page in Linux touched on the media-ctl links, but it
d
On 10/23/18 10:34 AM, Adam Ford wrote:
On Tue, Oct 23, 2018 at 11:36 AM Steve Longerbeam
wrote:
Hi Adam,
On 10/23/18 8:19 AM, Adam Ford wrote:
On Mon, Oct 22, 2018 at 7:40 AM Fabio Estevam wrote:
Hi Adam,
On Mon, Oct 22, 2018 at 9:37 AM Adam Ford wrote:
Thank you! This tutorial web
On 10/23/18 10:54 AM, Adam Ford wrote:
On Tue, Oct 23, 2018 at 12:39 PM Steve Longerbeam
wrote:
On 10/23/18 10:34 AM, Adam Ford wrote:
On Tue, Oct 23, 2018 at 11:36 AM Steve Longerbeam
wrote:
Hi Adam,
On 10/23/18 8:19 AM, Adam Ford wrote:
On Mon, Oct 22, 2018 at 7:40 AM Fabio Estevam
Hi Niklas,
On 11/29/18 10:47 AM, Niklas Söderlund wrote:
Hi Steve, Sakari and Hans,
I have been made aware of a possible regression by a few users of
rcar-vin and I'm a bit puzzled how to best handle it. Maybe you can help
me out?
The issue is visible when running with LOCKDEP enabled and it p
On 11/29/18 11:26 AM, Steve Longerbeam wrote:
Hi Niklas,
On 11/29/18 10:47 AM, Niklas Söderlund wrote:
Hi Steve, Sakari and Hans,
I have been made aware of a possible regression by a few users of
rcar-vin and I'm a bit puzzled how to best handle it. Maybe you can help
me out?
The iss
Hi Niklas,
On 11/29/18 6:25 PM, Niklas Söderlund wrote:
Hi Sakari, Steve,
Thanks for your quick response.
On 2018-11-29 22:37:53 +0200, Sakari Ailus wrote:
Hi Steve, Niklas,
On Thu, Nov 29, 2018 at 11:41:32AM -0800, Steve Longerbeam wrote:
On 11/29/18 11:26 AM, Steve Longerbeam wrote:
Hi
Hi Philipp, can you review this patch and give it your ack?
Thanks,
Steve
On 10/16/18 5:00 PM, Steve Longerbeam wrote:
The function ipu_csi_init_interface() was inverting the F-bit for
NTSC case, in the CCIR_CODE_1/2 registers. The result being that
for NTSC bottom-top field order, the CSI
From: Steve Longerbeam
Forward events from a sub-device to its list of reachable video
devices.
Note this will queue the event to a video device even if there is
no actual _enabled_ media path from the sub-device to the video device.
So a future improvement is to skip the video device if there
On 12/13/18 4:59 AM, Philipp Zabel wrote:
Hi Steve,
On Tue, 2018-10-16 at 17:00 -0700, Steve Longerbeam wrote:
The function ipu_csi_init_interface() was inverting the F-bit for
NTSC case, in the CCIR_CODE_1/2 registers. The result being that
for NTSC bottom-top field order, the CSI would
lines for one field.
Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
---
Changes since v5:
- Convert to const the infmt, outfmt, and mbus_cfg pointer args to
ipu_csi_init_interface(), suggested by Philipp Zabel.
- Bring back if_fmt local var and don't copy outfmt to local sta
: rcar-vin: add link notify for Gen3")
Signed-off-by: Steve Longerbeam
---
drivers/media/platform/rcar-vin/rcar-core.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-core.c
b/drivers/media/platform/rcar-vin/rcar-core.c
index f0719ce24b97..b2c9a
Hi Niklas,
On 12/26/18 4:51 PM, Niklas Söderlund wrote:
Hi Steve,
Thanks for your patch.
On 2018-12-25 15:27:25 -0800, Steve Longerbeam wrote:
There is a block of code in rvin_group_link_notify() that prevents
enabling a link to a VIN node if any entity in the media graph is
in use. This
if (entity->stream_count)
return -EBUSY;
mutex_lock(&group->lock);
And that might be overkilll, maybe only the stream_count's of the VIN
entities need to be checked.
Steve
On 12/29/18 3:37 PM, Steve Longerbeam wrote:
Hi Niklas,
On 12/26/18 4:51 PM, Niklas Söderlund
can now be enabled even if there are other independent
in-use entities that are not streaming.
Fixes: c0cc5aef31 ("media: rcar-vin: add link notify for Gen3")
Signed-off-by: Steve Longerbeam
---
Changes in v2:
- bring back the media_device_for_each_entity() loop but check the
stream_cou
Hi Hans,
On 1/8/19 5:26 AM, Hans Verkuil wrote:
On 12/09/18 20:57, Steve Longerbeam wrote:
From: Steve Longerbeam
Forward events from a sub-device to its list of reachable video
devices.
Note this will queue the event to a video device even if there is
no actual _enabled_ media path from
Please disregard. This patch can't be submitted stand-alone, I will
re-submit as part of a v6 of "imx-media: Fixes for interlaced capture"
patchset.
Steve
On 12/14/18 3:46 PM, Steve Longerbeam wrote:
The function ipu_csi_init_interface() was inverting the F-bit for
NT
top lines.
The capture interface device allows selecting IDMAC interweave by
choosing INTERLACED_TB if the CSI/PRPENCVF source pad is seq-tb and
INTERLACED_BT if the source pad is seq-bt (for future support of seq-bt).
Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
---
drivers/staging/medi
Also add an example pipeline for unconverted capture with interweave
on SabreAuto.
Cleanup some language in various places in the process.
Signed-off-by: Steve Longerbeam
---
Changes since v4:
- Make clear that it is IDMAC channel that does pixel reordering and
interweave, not the CSI. Caught
().
Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-csi.c | 27 ---
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-csi.c
b/drivers/staging/media/imx/imx-media-csi.c
index
-> seq-bt
alternate -> seq-bt
Suggested-by: Philipp Zabel
Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
---
Changes since v4:
- Removed interweave_offset and replace with boolean interweave_swap,
suggested by Philipp Zabel.
---
drivers/staging/media/imx/imx-ic-
From: Steve Longerbeam
A set of patches that fixes some bugs with capturing from an
interlaced source, and incompatibilites between IDMAC interlace
interweaving and 4:2:0 data write reduction.
History:
v6:
- Changes to patch "gpu: ipu-csi: Swap fields according to input/output
field
Skip writing U/V components to odd rows for YVU420 in addition to
YUV420 and NV12.
Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-csi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/imx/imx-media-csi.c
b/drivers
o fix prepare_vdi_in_buffers() to give the VDIC the fields in whatever
order they were received by the video source, and rely on the VDIC to
sort out which is top and which is bottom.
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-vdic.c | 12 ++--
1 file changed, 2 inser
If IDMAC interweaving is enabled in a write channel, the channel must
write the odd chroma rows for 4:2:0 formats. Skipping writing the odd
chroma rows produces corrupted captured 4:2:0 images when interweave
is enabled.
Reported-by: Krzysztof Hałasa
Signed-off-by: Steve Longerbeam
Reviewed-by
lines for one field.
Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
---
Changes since v5:
- Convert to const the infmt, outfmt, and mbus_cfg pointer args to
ipu_csi_init_interface(), suggested by Philipp Zabel.
- Bring back if_fmt local var and don't copy outfmt to local sta
an unconnected endpoint as an error.
Fixes: c893500a16baf ("media: imx: csi: Register a subdev notifier")
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-csi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx-medi
If the incoming sink field type is alternate, the reset crop height
and crop height bounds must be set to twice the incoming height,
because in alternate field mode, upstream will report only the
lines for a single field, and the CSI captures the whole frame.
Signed-off-by: Steve Longerbeam
iven field type is
'interlaced', that is a full frame is transmitted, or exists in
memory, as top field lines interlaced with bottom field lines.
Signed-off-by: Steve Longerbeam
---
Changes since v3:
- none
Changes since v2:
- none
Changes since v1:
- add the complement macro V4L2_FIELD_IS
doubled, since a single chroma line
is shared by two luma lines.
Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
Acked-by: Philipp Zabel
---
drivers/gpu/ipu-v3/ipu-cpmem.c | 26 +++--
drivers/staging/media/imx/imx-ic-prpencvf.c | 3 ++-
drivers/staging/media
On 1/9/19 3:13 AM, Philipp Zabel wrote:
On Tue, 2019-01-08 at 16:15 -0800, Steve Longerbeam wrote:
Some imx platforms do not have fwnode connections to all CSI input
ports, and should not be treated as an error. This includes the
imx6q SabreAuto, which has no connections to ipu1_csi1 and
1 - 100 of 1192 matches
Mail list logo
