Re: [PATCH 04/12] v4l: vb2-dma-contig: add setup of sglist for MMAP buffers

2012-06-06 Thread Tomasz Stanislawski
Hi Laurent, Thank your for your comments. On 06/06/2012 10:06 AM, Laurent Pinchart wrote: Hi Tomasz, Thanks for the patch. On Wednesday 23 May 2012 15:07:27 Tomasz Stanislawski wrote: This patch adds the setup of sglist list for MMAP buffers. It is needed for buffer exporting via DMABUF

Re: [PATCH v3] scatterlist: add sg_alloc_table_from_pages function

2012-06-06 Thread Tomasz Stanislawski
On 05/22/2012 10:10 PM, Andrew Morton wrote: On Mon, 21 May 2012 16:01:50 +0200 Tomasz Stanislawski t.stanisl...@samsung.com wrote: +int sg_alloc_table_from_pages(struct sg_table *sgt, + struct page **pages, unsigned int n_pages, + unsigned long offset, unsigned long size, + gfp_t

Re: [PATCH 04/12] v4l: vb2-dma-contig: add setup of sglist for MMAP buffers

2012-06-08 Thread Tomasz Stanislawski
memory by calling *((volatile int *)kaddr) = 0; before calling follow_pfn This way a fault is generated and the PT is updated by copying entries from init_mm. What do you think about presented solutions? Regards, Tomasz Stanislawski On 06/07/2012 04:28 PM, Subash Patel wrote

[PATCH v4] scatterlist: add sg_alloc_table_from_pages function

2012-06-14 Thread Tomasz Stanislawski
in userptr mode' and hints from Laurent Pinchart. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Daniel Vetter daniel.vet...@ffwll.ch Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Marek Szyprowski

[PATCHv7 00/15] Integration of videobuf2 with dmabuf

2012-06-14 Thread Tomasz Stanislawski
: add support for shared buffer (dma_buf) v4l: vb: remove warnings about MEMORY_DMABUF v4l: vb2-dma-contig: add support for dma_buf importing Tomasz Stanislawski (7): Documentation: media: description of DMABUF importing in V4L2 v4l: vb2-dma-contig: remove reference of alloc_ctx from

[PATCHv7 04/15] v4l: vb: remove warnings about MEMORY_DMABUF

2012-06-14 Thread Tomasz Stanislawski
From: Sumit Semwal sumit.sem...@ti.com Adding DMABUF memory type causes videobuf to complain about not using it in some switch cases. This patch removes these warnings. Signed-off-by: Sumit Semwal sumit.sem...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

[PATCHv7 09/15] v4l: vb2: add prepare/finish callbacks to allocators

2012-06-14 Thread Tomasz Stanislawski
From: Marek Szyprowski m.szyprow...@samsung.com This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

[PATCHv7 11/15] v4l: vb2-dma-contig: add support for dma_buf importing

2012-06-14 Thread Tomasz Stanislawski
sumit.sem...@linaro.org [author of the original patch] Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [integration with refactored dma-contig allocator] Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2-dma-contig.c | 120

[PATCHv7 10/15] v4l: vb2-dma-contig: add prepare/finish to dma-contig allocator

2012-06-14 Thread Tomasz Stanislawski
From: Marek Szyprowski m.szyprow...@samsung.com Add prepare/finish callbacks to vb2-dma-contig allocator. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/media/video/videobuf2-dma-contig.c | 24 1 file changed, 24 insertions(+) diff --git

[PATCHv7 13/15] v4l: vivi: support for dmabuf importing

2012-06-14 Thread Tomasz Stanislawski
This patch enhances VIVI driver with a support for importing a buffer from DMABUF file descriptors. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/Kconfig |1 + drivers/media/video/vivi.c |2

[PATCHv7 07/15] v4l: vb2-dma-contig: Reorder functions

2012-06-14 Thread Tomasz Stanislawski
From: Laurent Pinchart laurent.pinch...@ideasonboard.com Group functions by buffer type. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2-dma-contig.c | 92 1 file changed, 54 insertions(+), 38 deletions(-) diff

[PATCHv7 12/15] v4l: vb2-vmalloc: add support for dmabuf importing

2012-06-14 Thread Tomasz Stanislawski
This patch adds support for importing DMABUF files for vmalloc allocator in Videobuf2. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/videobuf2-vmalloc.c | 56 +++ 1 file

[PATCHv7 14/15] v4l: s5p-tv: mixer: support for dmabuf importing

2012-06-14 Thread Tomasz Stanislawski
This patch enhances s5p-tv with support for DMABUF importing via V4L2_MEMORY_DMABUF memory type. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-tv/Kconfig |1 + drivers/media/video/s5p-tv

[PATCHv7 15/15] v4l: s5p-fimc: support for dmabuf importing

2012-06-14 Thread Tomasz Stanislawski
This patch enhances s5p-fimc with support for DMABUF importing via V4L2_MEMORY_DMABUF memory type. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/video/s5p

[PATCHv7 05/15] v4l: vb2-dma-contig: Shorten vb2_dma_contig prefix to vb2_dc

2012-06-14 Thread Tomasz Stanislawski
From: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2-dma-contig.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git

[PATCHv7 08/15] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-06-14 Thread Tomasz Stanislawski
...@samsung.com. Kind thanks for bug reports from Laurent Pinchart laurent.pinch...@ideasonboard.com and Seung-Woo Kim sw0312@samsung.com. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Laurent Pinchart laurent.pinch

[PATCHv7 03/15] v4l: vb2: add support for shared buffer (dma_buf)

2012-06-14 Thread Tomasz Stanislawski
outside of V4L2. [A sample allocator of dma-buf shared buffer is given at [1]] [1]: Rob Clark's DRM: https://github.com/robclark/kernel-omap4/commits/drmplane-dmabuf Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [original work in the PoC for buffer sharing] Signed-off-by: Sumit

[PATCHv7 01/15] v4l: Add DMABUF as a memory type

2012-06-14 Thread Tomasz Stanislawski
From: Sumit Semwal sumit.sem...@ti.com Adds DMABUF memory type to v4l framework. Also adds the related file descriptor in v4l2_plane and v4l2_buffer. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [original work in the PoC for buffer sharing] Signed-off-by: Sumit Semwal sumit.sem

[PATCHv7 06/15] v4l: vb2-dma-contig: remove reference of alloc_ctx from a buffer

2012-06-14 Thread Tomasz Stanislawski
This patch removes a reference to alloc_ctx from an instance of a DMA contiguous buffer. It helps to avoid a risk of a dangling pointer if the context is released while the buffer is still valid. Moreover it removes one dereference step while accessing a device structure. Signed-off-by: Tomasz

[PATCHv7 02/15] Documentation: media: description of DMABUF importing in V4L2

2012-06-14 Thread Tomasz Stanislawski
This patch adds description and usage examples for importing DMABUF file descriptor in V4L2. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: linux-...@vger.kernel.org --- Documentation/DocBook/media/v4l/compat.xml

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-06-14 Thread Tomasz Stanislawski
This patch adds extension to V4L2 api. It allow to export a mmap buffer as file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer offset used by mmap and return a file descriptor on success. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park

[PATCHv2 6/9] v4l: s5p-fimc: support for dmabuf exporting

2012-06-14 Thread Tomasz Stanislawski
This patch enhances s5p-fimc with support for DMABUF exporting via VIDIOC_EXPBUF ioctl. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-fimc/fimc-capture.c |9 + 1 file changed, 9

[PATCHv2 1/9] v4l: vb2-dma-contig: let mmap method to use dma_mmap_coherent call

2012-06-14 Thread Tomasz Stanislawski
vb2_mmap_pfn_range from videobuf2 helpers. The function is no longer used in vb2 code. Suggested-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Laurent Pinchart laurent.pinch

[PATCHv2 0/9] Support for dmabuf exporting for videobuf2

2012-06-14 Thread Tomasz Stanislawski
/69302 [4] This patchset is rebased on 3.4-rc1 plus the following patchsets: [5] http://www.spinics.net/lists/linux-arch/msg18282.html Marek Szyprowski (1): v4l: vb2-dma-contig: let mmap method to use dma_mmap_coherent call Tomasz Stanislawski (8): Documentation: media: description of DMABUF

[PATCHv2 9/9] v4l: vb2-dma-contig: use dma_get_sgtable

2012-06-14 Thread Tomasz Stanislawski
This patch removes a workaround for extraction of struct pages from DMA buffer. The method of using follow_pfn for artificial VMA is dropped in favour of dma_get_sgtable function. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCHv2 4/9] v4l: vb2: add buffer exporting via dmabuf

2012-06-14 Thread Tomasz Stanislawski
This patch adds extension to videobuf2-core. It allow to export a mmap buffer as a file descriptor. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media

[PATCHv2 8/9] v4l: s5p-mfc: support for dmabuf exporting

2012-06-14 Thread Tomasz Stanislawski
This patch enhances s5p-mfc with support for DMABUF exporting via VIDIOC_EXPBUF ioctl. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Kamil Debski k.deb...@samsung.com --- drivers/media/video/s5p-mfc/s5p_mfc_dec.c | 18

[PATCHv2 2/9] Documentation: media: description of DMABUF exporting in V4L2

2012-06-14 Thread Tomasz Stanislawski
This patch adds description and usage examples for exporting DMABUF file descriptor in V4L2. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: linux-...@vger.kernel.org --- Documentation/DocBook/media/v4l/compat.xml

[PATCHv2 5/9] v4l: vb2-dma-contig: add support for DMABUF exporting

2012-06-14 Thread Tomasz Stanislawski
This patch adds support for exporting a dma-contig buffer using DMABUF interface. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/videobuf2-dma-contig.c | 248 1 file changed

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-23 Thread Tomasz Stanislawski
Hello, May I ask what is the rationale for this patch? To reduce a few lines of code? Or to give up possibility of changing message format in just one place? I could see migrating from mxr_* to pr_* could seen as the fix, but not this. Waiting for reply, Tomasz Stanislawski On 09/21/2013 05:00

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-24 Thread Tomasz Stanislawski
Hi, On 09/23/2013 05:48 PM, Bartlomiej Zolnierkiewicz wrote: Hi Tomasz, On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote: Hello, May I ask what is the rationale for this patch? To reduce a few lines of code? This patch makes source code more generic-like and easier

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-24 Thread Tomasz Stanislawski
On 09/23/2013 07:44 PM, Joe Perches wrote: On Mon, 2013-09-23 at 17:48 +0200, Bartlomiej Zolnierkiewicz wrote: On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote: May I ask what is the rationale for this patch? To reduce a few lines of code? This patch makes source code more

Re: [PATCH v5 2/4] media: s5p-tv: Restore vpll clock rate

2013-09-25 Thread Tomasz Stanislawski
Hi, As you can see sdo, hdmi and mixer are saparate drivers that are parts of s5p-tv drivers set. Could you rename commit name to 'media: s5p-tv: sdo: Restore vpll clock rate after streamoff' On 09/21/2013 05:00 PM, Mateusz Krawczuk wrote: Restore vpll clock rate if start stream fail or stream

Re: [PATCH v5 3/4] media: s5p-tv: Fix sdo driver to work with CCF

2013-09-25 Thread Tomasz Stanislawski
Rename to 'media: s5p-tv: sdo: integrate with CCF' On 09/21/2013 05:00 PM, Mateusz Krawczuk wrote: Replace clk_enable by clock_enable_prepare and clk_disable with clk_disable_unprepare. Clock prepare is required by Clock Common Framework, and old clock driver didn`t support it. Without it

Re: [PATCH v5 4/4] media: s5p-tv: Fix mixer driver to work with CCF

2013-09-25 Thread Tomasz Stanislawski
it Common Clock Framework prints a warning. Signed-off-by: Mateusz Krawczuk m.krawc...@partner.samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Tomasz Stanislawski t.stanisl...@samsung.com --- drivers/media/platform/s5p-tv/mixer_drv.c | 34

Re: [PATCH v5 4/4] media: s5p-tv: Fix mixer driver to work with CCF

2013-09-25 Thread Tomasz Stanislawski
On 09/23/2013 02:44 PM, Sylwester Nawrocki wrote: On 21/09/13 17:00, Mateusz Krawczuk wrote: Replace clk_enable by clock_enable_prepare and clk_disable with clk_disable_unprepare. Clock prepare is required by Clock Common Framework, and old clock driver didn`t support it. Without it Common

Re: Fwd: [PATCH 3/6] [media] s5p-mfc: add support for VIDIOC_{G,S}_CROP to encoder

2013-10-17 Thread Tomasz Stanislawski
= V4L2_SEL_TGT_CROP }) ioctl(capture, VIDIOC_S_SELECTION, struct v4l2_selection { .type = V4L2_BUF_TYPE_VIDEO_OUTPUT, .target = V4L2_SEL_TGT_COMPOSE }) is still undefined and application should not use them. I hope you find this information useful. Regards, Tomasz Stanislawski

Re: [RFC v3] [RFC] v4l2: Support for multiple selections

2013-10-24 Thread Tomasz Stanislawski
or v4l2_ext_rect. This way one can avoid introducting v4l2_selection::rectangles field. I hope you find this comments useful. Regards, Tomasz Stanislawski -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 5/7] phy: Add driver for Exynos DP PHY

2013-10-24 Thread Tomasz Stanislawski
may help to avoid code duplication. Regards, Tomasz Stanislawski On 10/16/2013 06:28 PM, Kishon Vijay Abraham I wrote: From: Jingoo Han jg1@samsung.com Add a PHY provider driver for the Samsung Exynos SoC Display Port PHY. Signed-off-by: Jingoo Han jg1@samsung.com Reviewed

Re: [RFC v3] [RFC] v4l2: Support for multiple selections

2013-11-12 Thread Tomasz Stanislawski
, 2013 at 12:31 PM, Tomasz Stanislawski t.stanisl...@samsung.com wrote: Hi Ricardo, I am the designer of selection API. I hope I can help you a little. I think that there are two issues mixed in 'Mulitple selections' topic. Firstly, you described that you program a piece of hardware

Re: [RFC v3] [RFC] v4l2: Support for multiple selections

2013-11-14 Thread Tomasz Stanislawski
Hi Hans, On 11/14/2013 11:18 AM, Hans Verkuil wrote: Hi Tomasz, On 11/12/13 15:54, Tomasz Stanislawski wrote: Hi Ricardo, Sorry for a late reply. I've been 'offline' for the last two weeks. Please refer to the comments below. [snip] As I said. Changes of rectangle n may trigger

Re: [PATCH 27/26] v4l: vb2: Set data_offset to 0 for single-plane buffers

2012-11-08 Thread Tomasz Stanislawski
it is pretty intuitive. For DMABUF capture devices data_offset maybe used to inform a driver to capture the image at some offset inside the DMABUF buffer. BTW. Should {} be added after if (V4L2_TYPE_IS_OUTPUT(b-type)) to avoid 'interesting' behavior? :) Regards, Tomasz Stanislawski -- To unsubscribe

Re: [PATCH 1/1] [media] s5p-tv: Use devm_gpio_request in sii9234_drv.c

2012-11-15 Thread Tomasz Stanislawski
On 11/16/2012 05:55 AM, Sachin Kamat wrote: devm_gpio_request is a device managed function and will make error handling and cleanup a bit simpler. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Tomasz Stanislawski t.stanisl...@samsung.com --- drivers/media/platform/s5p-tv

Re: [PATCH 0/9] [media] s5p-tv: Checkpatch Fixes and cleanup

2012-12-03 Thread Tomasz Stanislawski
integrated with clk_prepare/unprepare stuff. Regards, Tomasz Stanislawski Hi Tomasz, Any comments on this series? Regards, Sachin Sachin Kamat (9): [media] s5p-tv: Add missing braces around sizeof in sdo_drv.c [media] s5p-tv: Add missing braces around sizeof

Re: Query the meaning of variable in v4l2_pix_format and v4l2_plane

2011-11-04 Thread Tomasz Stanislawski
devices. This rectangle should not be used in any computations of the buffer parameters. Best regards, Tomasz Stanislawski I assumed the following buffer. | | |- bytesperline

[PATCH 4/5] v4l: emulate old crop API using extended crop/compose API

2011-11-10 Thread Tomasz Stanislawski
This patch allows new video drivers to work correctly with applications that use the old-style crop API. The old crop ioctl is emulated by using selection callbacks. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers

[PATCHv6 0/5] v4l: introduce selection API

2011-11-10 Thread Tomasz Stanislawski
and COMPOSE ioctls into VIDIOC_{S/G}_SELECTION - introduced crop and compose targets - introduced try flag that prevents passing configuration to a hardware - added usage examples Tomasz Stanislawski (5): v4l: add support for selection api doc: v4l: add binary images for selection API doc: v4l: add

[PATCH 1/5] v4l: add support for selection api

2011-11-10 Thread Tomasz Stanislawski
This patch introduces new api for a precise control of cropping and composing features for video devices. The new ioctls are VIDIOC_S_SELECTION and VIDIOC_G_SELECTION. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers

[PATCH 2/5] doc: v4l: add binary images for selection API

2011-11-10 Thread Tomasz Stanislawski
This patch adds images in binary format for the V4L2 selection API. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/DocBook/media/constraints.png.b64 | 59 +++ Documentation/DocBook/media/selection.png.b64

[PATCH 5/5] v4l: s5p-tv: mixer: add support for selection API

2011-11-10 Thread Tomasz Stanislawski
This patch add support for V4L2 selection API to s5p-tv driver. Moreover it removes old API for cropping. Old applications would still work because the crop ioctls are emulated using the selection API. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park

Re: [RFC] SUBDEV_S/G_SELECTION IOCTLs

2011-11-10 Thread Tomasz Stanislawski
data stream produced on scaler:1. Therefore the format on scaler:1 should not be changed. The area outside 640x480 would left undefined or filled by some pattern configured using controls. This situation was the reason of introducing PADDED target. Best regards, Tomasz Stanislawski The result

[GIT PATCHES FOR 3.3] v4l: introduce selection API

2011-11-14 Thread Tomasz Stanislawski
Stanislawski The following changes since commit e9eb0dadba932940f721f9d27544a7818b2fa1c5: [media] V4L menu: add submenu for platform devices (2011-11-08 12:09:52 -0200) are available in the git repository at: git://git.infradead.org/users/kmpark/linux-samsung v4l-selection Tomasz Stanislawski

Re: [RFC PATCH 00/18] Remove DV_PRESET API

2013-03-01 Thread Tomasz Stanislawski
-by: Tomasz Stanislawski t.stanisl...@samsung.com to all s5p-tv related patches. I tested following features: a) v4l2-ctl --list-dv-timings Result: got 10 timings entries as expected b) v4l2-ctl --get-dv-timings-cap Result: got timings caps. The was minor issue. Minimal with is 720 not 640. c

Re: [RFC PATCH 09/18] s5p-tv: add dv_timings support for hdmi.

2013-03-01 Thread Tomasz Stanislawski
Hi Hans, Please refer to the comments below. On 02/16/2013 10:28 AM, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com This just adds dv_timings support without modifying existing dv_preset support. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Tomasz Stanislawski

Re: [RFC PATCH 10/18] s5p-tv: add dv_timings support for hdmiphy.

2013-03-01 Thread Tomasz Stanislawski
() between the preset and timings code. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Tomasz Stanislawski t.stanisl...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-tv/hdmiphy_drv.c | 48 ++- 1 file changed, 39

Re: [RFC PATCH 11/18] s5p-tv: remove dv_preset support from mixer_video.

2013-03-01 Thread Tomasz Stanislawski
to remove the dv_preset API altogether (s5p-tv being the last user of this code). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Tomasz Stanislawski t.stanisl...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-tv/mixer_video.c | 68

Re: [REVIEW PATCH 0/6] s5p-tv: replace dv_preset by dv_timings

2013-03-20 Thread Tomasz Stanislawski
Hi everyone, After successful testing (after applying use cap instead of 0 fix), please add: Tested-by: Tomasz Stanislawski t.stanisl...@samsung.com Acked-by: Tomasz Stanislawski t.stanisl...@samsung.com to the commit log. Regards, Tomasz Stanislawski On 03/18/2013 03:24 PM, Hans Verkuil wrote

Re: [PATCH] [media] s5p-tv: Fix potential NULL pointer dereference error

2012-09-24 Thread Tomasz Stanislawski
platform_device *pdev) mdev = kzalloc(sizeof *mdev, GFP_KERNEL); if (!mdev) { - mxr_err(mdev, not enough memory.\n); + dev_err(dev, not enough memory.\n); ret = -ENOMEM; goto fail; } Acked-by: Tomasz Stanislawski t.stanisl

Re: [PATCH v2] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-24 Thread Tomasz Stanislawski
Acked-by: Tomasz Stanislawski t.stanisl...@samsung.com --- drivers/media/platform/s5p-tv/sdo_drv.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/s5p-tv/sdo_drv.c b/drivers/media/platform/s5p-tv/sdo_drv.c index ad68bbe..58cf56d 100644 --- a/drivers/media

Re: [PATCHv8 02/26] Documentation: media: description of DMABUF importing in V4L2

2012-09-24 Thread Tomasz Stanislawski
Hi Hans, Thank you for review. On 08/22/2012 12:47 PM, Hans Verkuil wrote: On Tue August 14 2012 17:34:32 Tomasz Stanislawski wrote: This patch adds description and usage examples for importing DMABUF file descriptor in V4L2. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com

Re: [PATCHv8 13/26] v4l: vivi: support for dmabuf importing

2012-09-25 Thread Tomasz Stanislawski
On 08/22/2012 01:47 PM, Hans Verkuil wrote: On Wed August 22 2012 12:56:30 Hans Verkuil wrote: On Tue August 14 2012 17:34:43 Tomasz Stanislawski wrote: This patch enhances VIVI driver with a support for importing a buffer from DMABUF file descriptors. Thanks for adding DMABUF support

Re: [PATCHv8 18/26] v4l: add buffer exporting via dmabuf

2012-09-25 Thread Tomasz Stanislawski
Hi Hans, Thank you for review. Please refer to the comments below. On 08/22/2012 01:41 PM, Hans Verkuil wrote: On Tue August 14 2012 17:34:48 Tomasz Stanislawski wrote: This patch adds extension to V4L2 api. It allow to export a mmap buffer as file descriptor. New ioctl VIDIOC_EXPBUF

Re: [PATCHv8 18/26] v4l: add buffer exporting via dmabuf

2012-09-26 Thread Tomasz Stanislawski
Hi Hans, Thank your for your comments. On 09/26/2012 08:39 AM, Hans Verkuil wrote: On Tue September 25 2012 18:30:43 Tomasz Stanislawski wrote: Hi Hans, Thank you for review. Please refer to the comments below. On 08/22/2012 01:41 PM, Hans Verkuil wrote: On Tue August 14 2012 17:34:48

Re: [PATCHv8 21/26] v4l: vb2-dma-contig: add reference counting for a device from allocator context

2012-09-27 Thread Tomasz Stanislawski
Hi Laurent, On 08/15/2012 10:04 PM, Laurent Pinchart wrote: Hi Tomasz, Thanks for the patch. On Tuesday 14 August 2012 17:34:51 Tomasz Stanislawski wrote: This patch adds taking reference to the device for MMAP buffers. Such buffers, may be exported using DMABUF mechanism. If the driver

[PATCHv9 00/25] Integration of videobuf2 with DMABUF

2012-10-02 Thread Tomasz Stanislawski
-dma-contig: fail if user ptr buffer is not correctly aligned Sumit Semwal (4): v4l: Add DMABUF as a memory type v4l: vb2: add support for shared buffer (dma_buf) v4l: vb: remove warnings about MEMORY_DMABUF v4l: vb2-dma-contig: add support for dma_buf importing Tomasz Stanislawski (15

[PATCHv9 01/25] v4l: Add DMABUF as a memory type

2012-10-02 Thread Tomasz Stanislawski
From: Sumit Semwal sumit.sem...@ti.com Adds DMABUF memory type to v4l framework. Also adds the related file descriptor in v4l2_plane and v4l2_buffer. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [original work in the PoC for buffer sharing] Signed-off-by: Sumit Semwal sumit.sem

[PATCHv9 02/25] Documentation: media: description of DMABUF importing in V4L2

2012-10-02 Thread Tomasz Stanislawski
This patch adds description and usage examples for importing DMABUF file descriptor in V4L2. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: linux-...@vger.kernel.org --- Documentation/DocBook/media/v4l/compat.xml

[PATCHv9 03/25] v4l: vb2: add support for shared buffer (dma_buf)

2012-10-02 Thread Tomasz Stanislawski
outside of V4L2. [A sample allocator of dma-buf shared buffer is given at [1]] [1]: Rob Clark's DRM: https://github.com/robclark/kernel-omap4/commits/drmplane-dmabuf Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [original work in the PoC for buffer sharing] Signed-off-by: Sumit

[PATCHv9 04/25] v4l: vb: remove warnings about MEMORY_DMABUF

2012-10-02 Thread Tomasz Stanislawski
From: Sumit Semwal sumit.sem...@ti.com Adding DMABUF memory type causes videobuf to complain about not using it in some switch cases. This patch removes these warnings. Signed-off-by: Sumit Semwal sumit.sem...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

[PATCHv9 05/25] v4l: vb2-dma-contig: shorten vb2_dma_contig prefix to vb2_dc

2012-10-02 Thread Tomasz Stanislawski
From: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2-dma-contig.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git

[PATCHv9 06/25] v4l: vb2-dma-contig: remove reference of alloc_ctx from a buffer

2012-10-02 Thread Tomasz Stanislawski
This patch removes a reference to alloc_ctx from an instance of a DMA contiguous buffer. It helps to avoid a risk of a dangling pointer if the context is released while the buffer is still valid. Moreover it removes one dereference step while accessing a device structure. Signed-off-by: Tomasz

[PATCHv9 07/25] v4l: vb2-dma-contig: reorder functions

2012-10-02 Thread Tomasz Stanislawski
From: Laurent Pinchart laurent.pinch...@ideasonboard.com Group functions by buffer type. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2-dma-contig.c | 92 1 file changed, 54 insertions(+), 38 deletions(-) diff

[PATCHv9 08/25] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-10-02 Thread Tomasz Stanislawski
...@samsung.com. Kind thanks for bug reports from Laurent Pinchart laurent.pinch...@ideasonboard.com and Seung-Woo Kim sw0312@samsung.com. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Laurent Pinchart laurent.pinch

[PATCHv9 09/25] v4l: vb2: add prepare/finish callbacks to allocators

2012-10-02 Thread Tomasz Stanislawski
From: Marek Szyprowski m.szyprow...@samsung.com This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

[PATCHv9 10/25] v4l: vb2-dma-contig: add prepare/finish to dma-contig allocator

2012-10-02 Thread Tomasz Stanislawski
From: Marek Szyprowski m.szyprow...@samsung.com Add prepare/finish callbacks to vb2-dma-contig allocator. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2-dma-contig.c | 24

[PATCHv9 11/25] v4l: vb2-dma-contig: add support for dma_buf importing

2012-10-02 Thread Tomasz Stanislawski
sumit.sem...@linaro.org [author of the original patch] Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [integration with refactored dma-contig allocator] Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/Kconfig|1

[PATCHv9 12/25] v4l: vb2-vmalloc: add support for dmabuf importing

2012-10-02 Thread Tomasz Stanislawski
This patch adds support for importing DMABUF files for vmalloc allocator in Videobuf2. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2

[PATCHv9 13/25] v4l: vivi: support for dmabuf importing

2012-10-02 Thread Tomasz Stanislawski
This patch enhances VIVI driver with a support for importing a buffer from DMABUF file descriptors. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/vivi.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCHv9 14/25] v4l: s5p-tv: mixer: support for dmabuf importing

2012-10-02 Thread Tomasz Stanislawski
This patch enhances s5p-tv with support for DMABUF importing via V4L2_MEMORY_DMABUF memory type. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-tv/mixer_video.c |2 +- 1 file changed, 1 insertion

[PATCHv9 15/25] v4l: s5p-fimc: support for dmabuf importing

2012-10-02 Thread Tomasz Stanislawski
This patch enhances s5p-fimc with support for DMABUF importing via V4L2_MEMORY_DMABUF memory type. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/video/s5p

[PATCHv9 16/25] v4l: vb2-dma-contig: let mmap method to use dma_mmap_coherent call

2012-10-02 Thread Tomasz Stanislawski
...@samsung.com Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2-dma-contig.c | 28 +-- drivers/media/video/videobuf2-memops.c | 40 include

[PATCHv9 17/25] Documentation: media: description of DMABUF exporting in V4L2

2012-10-02 Thread Tomasz Stanislawski
This patch adds description and usage examples for exporting DMABUF file descriptor in V4L2. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: linux-...@vger.kernel.org --- Documentation/DocBook/media/v4l/compat.xml

[PATCHv9 18/25] v4l: add buffer exporting via dmabuf

2012-10-02 Thread Tomasz Stanislawski
This patch adds extension to V4L2 api. It allow to export a mmap buffer as file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer offset used by mmap and return a file descriptor on success. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park

[PATCHv9 19/25] v4l: vb2: add buffer exporting via dmabuf

2012-10-02 Thread Tomasz Stanislawski
This patch adds extension to videobuf2-core. It allow to export a mmap buffer as a file descriptor. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media

[PATCHv9 20/25] v4l: vb2-dma-contig: add support for DMABUF exporting

2012-10-02 Thread Tomasz Stanislawski
This patch adds support for exporting a dma-contig buffer using DMABUF interface. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/videobuf2-dma-contig.c | 200 1 file changed

[PATCHv9 21/25] v4l: vb2-dma-contig: add reference counting for a device from allocator context

2012-10-02 Thread Tomasz Stanislawski
descriptor(s). The device pointer kept in a buffer must be valid for the whole buffer's lifetime. Therefore MMAP buffers should take a reference to the device to avoid risk of dangling pointers. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com --- drivers/media/video/videobuf2-dma

[PATCHv9 22/25] v4l: vb2-dma-contig: fail if user ptr buffer is not correctly aligned

2012-10-02 Thread Tomasz Stanislawski
From: Marek Szyprowski m.szyprow...@samsung.com The DMA transfer must be aligned to a specific value. If userptr is not aligned to DMA requirements then unexpected corruptions of the memory may occur before or after a buffer. To prevent such situations, all unligned userptr buffers are rejected

[PATCHv9 23/25] v4l: s5p-fimc: support for dmabuf exporting

2012-10-02 Thread Tomasz Stanislawski
This patch enhances s5p-fimc with support for DMABUF exporting via VIDIOC_EXPBUF ioctl. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/video/s5p-fimc/fimc-capture.c

[PATCHv9 24/25] v4l: s5p-tv: mixer: support for dmabuf exporting

2012-10-02 Thread Tomasz Stanislawski
This patch enhances s5p-tv with support for DMABUF exporting via VIDIOC_EXPBUF ioctl. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-tv/mixer_video.c | 10 ++ 1 file changed, 10 insertions

[PATCHv9 25/25] v4l: s5p-mfc: support for dmabuf exporting

2012-10-02 Thread Tomasz Stanislawski
This patch enhances s5p-mfc with support for DMABUF exporting via VIDIOC_EXPBUF ioctl. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Kamil Debski k.deb...@samsung.com --- drivers/media/video/s5p-mfc/s5p_mfc_dec.c | 14

[GIT PULL FOR v3.7] media: s5p-hdmi: add HPD GPIO to platform data

2012-10-05 Thread Tomasz Stanislawski
-for3.7 for you to fetch changes up to b26bab928dd6f6e1d5613b68fa6fea1d29c9005e: media: s5p-hdmi: add HPD GPIO to platform data (2012-10-05 14:53:05 +0200) Tomasz Stanislawski (1): media: s5p-hdmi: add HPD GPIO to platform data

Re: [PATCHv9 18/25] v4l: add buffer exporting via dmabuf

2012-10-08 Thread Tomasz Stanislawski
Hi Hans, On 10/07/2012 04:17 PM, Hans Verkuil wrote: On Sun October 7 2012 15:38:30 Laurent Pinchart wrote: Hi Hans, On Friday 05 October 2012 10:55:40 Hans Verkuil wrote: On Tue October 2 2012 16:27:29 Tomasz Stanislawski wrote: This patch adds extension to V4L2 api. It allow to export

Re: [PATCHv9 18/25] v4l: add buffer exporting via dmabuf

2012-10-08 Thread Tomasz Stanislawski
Hi Hans, On 10/08/2012 11:54 AM, Hans Verkuil wrote: On Mon October 8 2012 11:40:37 Tomasz Stanislawski wrote: Hi Hans, On 10/07/2012 04:17 PM, Hans Verkuil wrote: On Sun October 7 2012 15:38:30 Laurent Pinchart wrote: Hi Hans, On Friday 05 October 2012 10:55:40 Hans Verkuil wrote

Re: [PATCHv9 19/25] v4l: vb2: add buffer exporting via dmabuf

2012-10-10 Thread Tomasz Stanislawski
On 10/06/2012 02:22 PM, Hans Verkuil wrote: On Tue October 2 2012 16:27:30 Tomasz Stanislawski wrote: This patch adds extension to videobuf2-core. It allow to export a mmap buffer as a file descriptor. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park

[PATCHv10 00/26] Integration of videobuf2 with DMABUF

2012-10-10 Thread Tomasz Stanislawski
MEMORY_DMABUF v4l: vb2-dma-contig: add support for dma_buf importing Tomasz Stanislawski (16): Documentation: media: description of DMABUF importing in V4L2 v4l: vb2-dma-contig: remove reference of alloc_ctx from a buffer v4l: vb2-dma-contig: add support for scatterlist in userptr mode v4l

[PATCHv10 01/26] v4l: Add DMABUF as a memory type

2012-10-10 Thread Tomasz Stanislawski
From: Sumit Semwal sumit.sem...@ti.com Adds DMABUF memory type to v4l framework. Also adds the related file descriptor in v4l2_plane and v4l2_buffer. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [original work in the PoC for buffer sharing] Signed-off-by: Sumit Semwal sumit.sem

[PATCHv10 02/26] Documentation: media: description of DMABUF importing in V4L2

2012-10-10 Thread Tomasz Stanislawski
This patch adds description and usage examples for importing DMABUF file descriptor in V4L2. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: linux-...@vger.kernel.org --- Documentation/DocBook/media/v4l/compat.xml

[PATCHv10 03/26] v4l: vb2: add support for shared buffer (dma_buf)

2012-10-10 Thread Tomasz Stanislawski
outside of V4L2. [A sample allocator of dma-buf shared buffer is given at [1]] [1]: Rob Clark's DRM: https://github.com/robclark/kernel-omap4/commits/drmplane-dmabuf Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [original work in the PoC for buffer sharing] Signed-off-by: Sumit

[PATCHv10 04/26] v4l: vb: remove warnings about MEMORY_DMABUF

2012-10-10 Thread Tomasz Stanislawski
From: Sumit Semwal sumit.sem...@ti.com Adding DMABUF memory type causes videobuf to complain about not using it in some switch cases. This patch removes these warnings. Signed-off-by: Sumit Semwal sumit.sem...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans

[PATCHv10 05/26] v4l: vb2-dma-contig: shorten vb2_dma_contig prefix to vb2_dc

2012-10-10 Thread Tomasz Stanislawski
From: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 36 1 file changed, 18 insertions(+), 18

<    1   2   3   4   5   >