Re: [PATCH v3.16 2/2] v4l: event: Add subscription to list before calling "add" operation

On Thu, Nov 08, 2018 at 02:03:50PM +0200, Sakari Ailus wrote: > [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ] > > Patch ad608fbcf166 changed how events were subscribed to address an issue > elsewhere. As a side effect of that change, the "add" callback was called > before the event

Re: [PATCH v3.16 1/2] v4l: event: Prevent freeing event subscriptions while accessed

On Thu, Nov 08, 2018 at 02:03:49PM +0200, Sakari Ailus wrote: > [ upstream commit ad608fbcf166fec809e402d548761768f602702c ] This is already in 3.18.124. thanks, greg k-h

Re: [Outreachy kernel] [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

On Mon, Oct 08, 2018 at 03:29:03PM +0200, Hans Verkuil wrote: > On 10/08/2018 03:07 PM, Greg KH wrote: > > On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote: > >> Replace calls to `printk` with the appropriate `pr_*` > >> macro. > >>

Re: [Outreachy kernel] [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote: > Replace calls to `printk` with the appropriate `pr_*` > macro. > > Signed-off-by: Dafna Hirschfeld > --- > drivers/media/usb/pvrusb2/pvrusb2-debug.h| 2 +- > drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8 +++--- >

Re: [PATCH] media: uvcvideo: Support UVC 1.5 video probe & commit controls

On Sun, Sep 30, 2018 at 01:38:16PM +0300, Laurent Pinchart wrote: > From: ming_qian > > commit f620d1d7afc7db57ab59f35000752840c91f67e7 upstream. > > The length of UVC 1.5 video control is 48, and it is 34 for UVC 1.1. > Change it to 48 for UVC 1.5 device, and the UVC 1.5 device can be >

Re: [PATCH] media: cleanup fall-through comments

On Tue, Aug 07, 2018 at 09:33:03AM -0700, Nick Desaulniers wrote: > On Tue, Aug 7, 2018 at 5:07 AM Mauro Carvalho Chehab > wrote: > > > > As Ian pointed out, adding a '-' to the fallthrough seems to meet > > the regex requirements at level 3 of the warning, at least when > > the comment fits into

Re: [PATCH] usbtv: Fix refcounting mixup

On Tue, May 15, 2018 at 01:51:37PM +0200, Oliver Neukum wrote: > The premature free in the error path is blocked by V4L > refcounting, not USB refcounting. Thanks to > Ben Hutchings for review. > > Signed-off-by: Oliver Neukum > Fixes: 50e704453553 ("media: usbtv: prevent

Re: [PATCH stable v4.15 1/3] media: staging: lirc_zilog: broken reference counting

On Mon, Apr 16, 2018 at 10:15:28AM +0100, Sean Young wrote: > On Mon, Apr 16, 2018 at 10:50:15AM +0200, Greg KH wrote: > > On Mon, Apr 16, 2018 at 09:43:45AM +0100, Sean Young wrote: > > > On Mon, Apr 16, 2018 at 09:52:28AM +0200, Greg KH wrote: > > > > What is t

Re: [PATCH stable v4.15 1/3] media: staging: lirc_zilog: broken reference counting

On Mon, Apr 16, 2018 at 09:43:45AM +0100, Sean Young wrote: > On Mon, Apr 16, 2018 at 09:52:28AM +0200, Greg KH wrote: > > On Sun, Apr 15, 2018 at 10:54:20AM +0100, Sean Young wrote: > > > commit 615cd3fe6ccc ("[media] media: lirc_dev: make better use of > > &

Re: [PATCH stable v4.15 1/3] media: staging: lirc_zilog: broken reference counting

On Sun, Apr 15, 2018 at 10:54:20AM +0100, Sean Young wrote: > commit 615cd3fe6ccc ("[media] media: lirc_dev: make better use of > file->private_data") removed the reference get from open, so on the first > close the reference count hits zero and the lirc device is freed. > > BUG: unable to handle

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

On Wed, Mar 28, 2018 at 03:12:19PM -0300, Mauro Carvalho Chehab wrote: > Hi Greg, > > Those are the backports meant to solve CVE-2017-13166 on Kernel 3.18. > > It contains two v4l2-ctrls fixes that are required to avoid crashes > at the test application. > > I wrote two patches myself for

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

On Thu, Mar 29, 2018 at 03:39:54PM +0900, Inki Dae wrote: > 2018년 03월 29일 13:25에 Greg KH 이(가) 쓴 글: > > On Thu, Mar 29, 2018 at 08:22:08AM +0900, Inki Dae wrote: > >> Really thanks for doing this. :) There would be many users who use > >> Linux-3.18 for their products yet

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

On Thu, Mar 29, 2018 at 08:22:08AM +0900, Inki Dae wrote: > Really thanks for doing this. :) There would be many users who use > Linux-3.18 for their products yet. For new products? They really should not be. The kernel is officially end-of-life, but I'm keeping it alive for a short while

Re: [PATCH v3 1/2] staging: media: davinci_vpfe: add error handling on kmalloc failure

On Tue, Mar 27, 2018 at 08:20:59AM +0300, Dan Carpenter wrote: > On Tue, Mar 27, 2018 at 02:00:45PM +0900, Ji-Hun Kim wrote: > > > > Are there any opinions? I'd like to know how this patch is going. > > > > > Looks good. Thanks! > > Greg just hasn't gotten to it yet. Greg does not take

Re: [PATCH 0/5] SPDX license identifiers in all DD drivers

On Wed, Mar 21, 2018 at 06:29:48PM +0100, Daniel Scheller wrote: > Hi Greg, > > Am Wed, 21 Mar 2018 10:49:32 +0100 > schrieb Greg KH <gre...@linuxfoundation.org>: > > > On Tue, Mar 20, 2018 at 10:01:27PM +0100, Daniel Scheller wrote: > > > From:

Re: [PATCH 0/5] SPDX license identifiers in all DD drivers

On Tue, Mar 20, 2018 at 10:01:27PM +0100, Daniel Scheller wrote: > From: Daniel Scheller > > This series adds SPDX license identifiers to all source files which are > copyright by either Digital Devices GmbH or Metzlerbros GbR, who are > the original authors of the ddbridge,

Re: [PATCH 1/5] [media] stv0910/stv6111: add SPDX license headers

On Tue, Mar 20, 2018 at 10:01:28PM +0100, Daniel Scheller wrote: > From: Daniel Scheller > > Add SPDX license headers to the stv0910 and stv6111 DVB frontend > drivers. Both drivers are licensed as GPL-2.0-only, so fix this in the > MODULE_LICENSE while at it. Also, the

Re: [PATCH v2] Add udmabuf misc device

On Fri, Mar 16, 2018 at 08:46:49AM +0100, Gerd Hoffmann wrote: > --- /dev/null > +++ b/tools/testing/selftests/drivers/dma-buf/udmabuf.c > @@ -0,0 +1,69 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include No license text at all? Come on, I already made

Re: [PATCH v2] Add udmabuf misc device

On Fri, Mar 16, 2018 at 08:46:49AM +0100, Gerd Hoffmann wrote: > --- /dev/null > +++ b/drivers/dma-buf/udmabuf.c > @@ -0,0 +1,261 @@ > +/* > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + *

Re: [PATCH] [media] cpia2_usb: drop bogus interface-release call

On Wed, Mar 07, 2018 at 10:49:36AM +0100, Johan Hovold wrote: > Drop bogus call to usb_driver_release_interface() from the disconnect() > callback. As the interface is already being unbound at this point, > usb_driver_release_interface() simply returns early. > > Signed-off-by: Johan Hovold

Re: [PATCH v2] Staging: bcm2048: Fix function argument alignment in radio-bcm2048.c.

On Tue, Feb 27, 2018 at 08:32:30AM +0100, Hans Verkuil wrote: > On 02/27/2018 02:53 AM, Quytelda Kahja wrote: > > Hans, > > > > Thank you very much for your input on the patch; however this patch > > has already been applied to the staging tree. Additionally: > > I have no record of this being

Re: [PATCH v2 1/3] staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler

On Wed, Feb 21, 2018 at 02:43:14PM -0800, Rohit Athavale wrote: > This commit adds driver support for the pre-release Xilinx M2M Video > Scaler IP. There are three parts to this driver : > > - The Hardware/IP layer that reads and writes register of the IP >contained in the scaler_hw_xm2m.c >

Re: [PATCH for v4.4 00/14] v4l2-compat-ioctl32.c: remove set_fs(KERNEL_DS)

On Wed, Feb 14, 2018 at 12:52:26PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > This patch series fixes a number of bugs and culminates in the removal > of the set_fs(KERNEL_DS) call in v4l2-compat-ioctl32.c. > > This was tested with a VM running 4.4, the vivid

Re: [PATCH for v4.9 00/13] v4l2-compat-ioctl32.c: remove set_fs(KERNEL_DS)

On Wed, Feb 14, 2018 at 12:48:17PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > This patch series fixes a number of bugs and culminates in the removal > of the set_fs(KERNEL_DS) call in v4l2-compat-ioctl32.c. > > This was tested with a VM running 4.9, the vivid

Re: [PATCH for v4.14 00/13] v4l2-compat-ioctl32.c: remove set_fs(KERNEL_DS)

On Wed, Feb 14, 2018 at 12:44:21PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > This patch series fixes a number of bugs and culminates in the removal > of the set_fs(KERNEL_DS) call in v4l2-compat-ioctl32.c. > > This was tested with a VM running 4.14, the vivid

Re: [PATCH 07/18] [media] uvcvideo: prevent bounds-check bypass via speculative execution

On Tue, Jan 09, 2018 at 04:26:28PM +0200, Laurent Pinchart wrote: > Hi Greg, > > On Tuesday, 9 January 2018 12:04:10 EET Greg KH wrote: > > On Tue, Jan 09, 2018 at 10:40:21AM +0200, Laurent Pinchart wrote: > > > On Saturday, 6 January 2018 11:40:26 EET Greg KH wrote: >

Re: [PATCH 07/18] [media] uvcvideo: prevent bounds-check bypass via speculative execution

On Tue, Jan 09, 2018 at 10:40:21AM +0200, Laurent Pinchart wrote: > On Saturday, 6 January 2018 11:40:26 EET Greg KH wrote: > > On Sat, Jan 06, 2018 at 10:09:07AM +0100, Greg KH wrote: > > > > While I'm all for fixing this type of thing, I feel like we need to d

Re: [PATCH 07/18] [media] uvcvideo: prevent bounds-check bypass via speculative execution

On Sat, Jan 06, 2018 at 09:41:17AM -0800, Dan Williams wrote: > On Sat, Jan 6, 2018 at 1:40 AM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Sat, Jan 06, 2018 at 10:09:07AM +0100, Greg KH wrote: > >> On Fri, Jan 05, 2018 at 05:10:32PM -0800, Dan Williams wrote: > &

Re: [PATCH 07/18] [media] uvcvideo: prevent bounds-check bypass via speculative execution

On Sat, Jan 06, 2018 at 10:09:07AM +0100, Greg KH wrote: > On Fri, Jan 05, 2018 at 05:10:32PM -0800, Dan Williams wrote: > > Static analysis reports that 'index' may be a user controlled value that > > is used as a data dependency to read 'pin' from the > > 'selector->baS

Re: [PATCH 07/18] [media] uvcvideo: prevent bounds-check bypass via speculative execution

On Fri, Jan 05, 2018 at 05:10:32PM -0800, Dan Williams wrote: > Static analysis reports that 'index' may be a user controlled value that > is used as a data dependency to read 'pin' from the > 'selector->baSourceID' array. In order to avoid potential leaks of > kernel memory values, block

Re: [PATCH v3 00/27] kill devm_ioremap_nocache

On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: > Hi all, > > When I tried to use devm_ioremap function and review related code, I found > devm_ioremap and devm_ioremap_nocache is almost the same with each other, > except one use ioremap while the other use ioremap_nocache. For all

Re: [PATCH v3 27/27] devres: kill devm_ioremap_nocache

On Sat, Dec 23, 2017 at 07:02:59PM +0800, Yisheng Xie wrote: > --- a/lib/devres.c > +++ b/lib/devres.c > @@ -44,35 +44,6 @@ void __iomem *devm_ioremap(struct device *dev, > resource_size_t offset, > EXPORT_SYMBOL(devm_ioremap); > > /** > - * devm_ioremap_nocache - Managed ioremap_nocache() >

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

On Thu, Dec 14, 2017 at 10:44:16PM +0200, Laurent Pinchart wrote: > Hi Greg, > > On Thursday, 14 December 2017 22:08:51 EET Greg KH wrote: > > On Thu, Dec 14, 2017 at 09:05:27PM +0200, Laurent Pinchart wrote: > > > On Thursday, 14 December 2017 20:54:39 EET Joe Perches wr

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

On Thu, Dec 14, 2017 at 09:05:27PM +0200, Laurent Pinchart wrote: > Hi Joe, > > (CC'ing Greg and adding context for easier understanding) > > On Thursday, 14 December 2017 20:54:39 EET Joe Perches wrote: > > On Thu, 2017-12-14 at 20:37 +0200, Laurent Pinchart wrote: > > > On Thursday, 14

Re: [PATCH 0/4] Backported amdgpu ttm deadlock fixes for 4.14

On Thu, Nov 30, 2017 at 07:23:02PM -0500, Lyude Paul wrote: > I haven't gone to see where it started, but as of late a good number of > pretty nasty deadlock issues have appeared with the kernel. Easy > reproduction recipe on a laptop with i915/amdgpu prime with lockdep enabled: > > DRI_PRIME=1

Re: [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.

On Wed, Nov 29, 2017 at 11:08:17AM +0200, Sakari Ailus wrote: > Hi Greg, > > On Mon, Nov 27, 2017 at 01:21:25PM +0100, Greg KH wrote: > > On Mon, Nov 27, 2017 at 11:30:53AM +, Jeremy Sowden wrote: > > > Signed-off-by: Jeremy Sowden <jer...@azazel.net> > >

Re: [PATCH] staging/media: lirc: style fix - replace hard-coded function names

On Sun, Nov 26, 2017 at 08:49:42PM +0100, Martin Homuth wrote: > This patch fixes the remaining coding style warnings in the lirc module. > > It fixes the following checkpatch.pl warning: > > WARNING: Prefer using '"%s...", __func__' to using 'read', this > function's name, in a string > >From

Re: [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.

On Mon, Nov 27, 2017 at 11:30:53AM +, Jeremy Sowden wrote: > Signed-off-by: Jeremy Sowden > --- > .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 24 > +++--- > 1 file changed, 12 insertions(+), 12 deletions(-) I can never take patches without any

Re: [PATCH 00/18] use ARRAY_SIZE macro

On Sun, Oct 01, 2017 at 08:52:20PM -0400, Jérémy Lefaure wrote: > On Mon, 2 Oct 2017 09:01:31 +1100 > "Tobin C. Harding" wrote: > > > > In order to reduce the size of the To: and Cc: lines, each patch of the > > > series is sent only to the maintainers and lists concerned by the

Re: [PATCH] [media] staging/atomisp: fix minor coding style warnings

On Thu, Jul 13, 2017 at 08:06:21AM -0700, smklearn wrote: > Below were the minor issues flagged by checkpatch.pl: > - WARNING: Block comments use * on subsequent lines > - ERROR: space prohibited after that open parenthesis '(' Don't do multiple things in the same patch please, this should be

Re: [PATCH] staging drivers fixed coding style error

On Thu, Jul 13, 2017 at 07:17:56AM -0700, smklearn wrote: > Fixed coding style error flagged checkpatch.pl: > - ERROR: space prohibited after that open parenthesis '(' > - WARNING: Block comments use * on subsequent lines > > Signed-off-by: Shy More > > Output

Re: [PATCH] Staging: media: fix missing blank line coding style issue in atomisp_tpg.c

On Thu, May 18, 2017 at 05:31:20PM +0100, Alan Cox wrote: > On Wed, 2017-05-17 at 21:48 -0400, Manny Vindiola wrote: > > This is a patch to the atomisp_tpg.c file that fixes up a missing > > blank line warning found by the checkpatch.pl tool > > > > Signed-off-by: Manny Vindiola

Re: [PATCH] ATOMISP: Tidies up code warnings and errors in file

On Mon, May 08, 2017 at 11:25:55PM +0100, Mark Railton wrote: > Cleared up some errors and warnings in > drivers/staging/media/atomisp/i2c/ap1302.c > > Signed-off-by: Mark Railton > --- > drivers/staging/media/atomisp/i2c/ap1302.c | 83 > ++ >

Re: uvcvideo logging kernel warnings on device disconnect

On Sun, Apr 30, 2017 at 06:19:59PM +0200, Greg KH wrote: > On Sun, Apr 16, 2017 at 02:11:31PM +0300, Laurent Pinchart wrote: > > Hi Greg, > > > > On Wednesday 21 Dec 2016 10:59:54 Greg KH wrote: > > > On Tue, Dec 20, 2016 at 11:19:23AM +, Dave Stevenson wrote: &

Re: uvcvideo logging kernel warnings on device disconnect

On Sun, Apr 16, 2017 at 02:11:31PM +0300, Laurent Pinchart wrote: > Hi Greg, > > On Wednesday 21 Dec 2016 10:59:54 Greg KH wrote: > > On Tue, Dec 20, 2016 at 11:19:23AM +, Dave Stevenson wrote: > > > On 09/12/16 09:43, Greg KH wrote: > > >> On Fri, Dec 0

Re: [PATCH v2] [media] uvcvideo: Refactor teardown of uvc on USB disconnect

isconnect(). To this, move the unregistration > into the disconnect path: > > - split uvc_status_cleanup() into two parts, one on disconnect that >unregisters and one on delete that frees. > > - move v4l2_device_unregister() and media_device_unregister() into >the disconnect path. >

Re: [PATCH 1/2] [media] uvcvideo: Refactor teardown of uvc on USB disconnect

vice is deleted and still has children, instead of accepting that silently > and later complaining due to sysfs issues ? When a physical device, or any other device, is removed, the children should all also be removed. You can't leave them around to be cleaned up later, this has always been the

Re: [PATCH v3] [media] staging: css2400: fix checkpatch error

On Wed, Mar 29, 2017 at 10:50:08AM +0300, Haim Daniel wrote: > isp_capture_defs.h: clean up ERROR: Macros with complex values should be > enclosed in parentheses > > Signed-off-by: Haim Daniel > --- > .../pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h

Re: [PATCH 14/14] atomisp: remove UDS kernel code

On Fri, Apr 14, 2017 at 03:27:08AM +0800, kbuild test robot wrote: > Hi Alan, > > [auto build test ERROR on next-20170412] > [cannot apply to linuxtv-media/master v4.9-rc8 v4.9-rc7 v4.9-rc6 v4.11-rc6] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the

Re: [PATCH 12/14] atomisp: remove fixedbds kernel code

On Thu, Apr 13, 2017 at 07:53:58PM +0800, kbuild test robot wrote: > Hi Alan, > > [auto build test ERROR on next-20170412] > [cannot apply to linuxtv-media/master v4.9-rc8 v4.9-rc7 v4.9-rc6 v4.11-rc6] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the

Re: [PATCH 28/38] Annotate hardware config module parameters in drivers/staging/media/

On Wed, Apr 05, 2017 at 06:01:01PM +0100, David Howells wrote: > When the kernel is running in secure boot mode, we lock down the kernel to > prevent userspace from modifying the running kernel image. Whilst this > includes prohibiting access to things like /dev/mem, it must also prevent > access

Re: [PATCH]: staging: media: css2400: fix checkpatch error

On Wed, Mar 29, 2017 at 08:36:27AM +0300, Haim Daniel wrote: > >From 41d35b455f8eb139912909639e914469ef5e06fb Mon Sep 17 00:00:00 2001 > From: Haim Daniel > Date: Tue, 28 Mar 2017 19:27:57 +0300 > Subject: [PATCH] [media] staging: css2400: fix checkpatch error > >

Re: [PATCH v2] [media] staging: css2400: fix checkpatch error

On Wed, Mar 29, 2017 at 10:12:28AM +0300, Haim Daniel wrote: > isp_capture_defs.h: What is this line for? > fix checkpatch ERROR: Trailing whitespace? > Macros with complex values should be enclosed in parentheses > > Signed-off-by: Haim Daniel > --- >

Re: [PATCH] Remove atomisp/i2c style errors.

On Tue, Mar 28, 2017 at 08:31:37PM -0700, Daniel Cashman wrote: > From: Dan Cashman Please list what the issue you fixed in the subject line. Also change the subject to match others for this driver, a 'git log' will show you what to do there. > > Remove two ' , '

Re: [PATCH] staging: media: atomisp: i2c: removed unnecessary white space before comma in memset()

On Tue, Mar 28, 2017 at 11:02:45AM +0530, vaibhavd...@gmail.com wrote: > From: Vaibhav Kothari > > Removed extra space before comma in memset() as a part of > checkpatch.pl fix-up. > > Signed-off-by: Vaibhav Kothari > --- >

Re: [PATCH] staging: media: atomisp: i2c: removed unnecessary white space before comma in memset()

On Tue, Mar 28, 2017 at 10:44:44AM +0530, vaibhavd...@gmail.com wrote: > gc2235.c Why is this file name here? > > Removed extra space before comma in memset() as a part of > checkpatch.pl fix-up. Why the extra space at the beginning of the line? > Signed-off-by: Vaibhav Kothari

Re: [PATCH 06/24] atomisp: kill another define

On Mon, Mar 20, 2017 at 02:39:38PM +, Alan Cox wrote: > We don't need an ifdef for the sake of 8-12 bytes. This undoes the ifdef > added by > fde469701c7efabebf885e785edf367bfb1a8f3f. Instead turn it into a single const > string > array at a fixed location thereby saving even more memory. >

Re: [PATCH v1 1/7] staging: gc2235: Remove unnecessary typecast of c90 int constant

On Fri, Mar 10, 2017 at 04:20:23AM +0530, simran singhal wrote: > This patch removes unnecessary typecast of c90 int constant. > > WARNING: Unnecessary typecast of c90 int constant > > Signed-off-by: simran singhal > --- > drivers/staging/media/atomisp/i2c/gc2235.c |

Re: [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()

On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote: > The function atomisp_set_stop_timeout on being called, simply returns > back. The function hasn't been mentioned in the TODO and doesn't have > FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been > removed. >

Re: [PATCH] staging: media: Remove parentheses from return arguments

On Fri, Mar 03, 2017 at 10:31:39PM +0530, simran singhal wrote: > The sematic patch used for this is: > @@ > identifier i; > constant c; > @@ > return > - ( > \(i\|-i\|i(...)\|c\) > - ) > ; > > Signed-off-by: simran singhal > Acked-by: Julia Lawall

Re: [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

On Fri, Mar 03, 2017 at 01:21:56AM +0530, simran singhal wrote: > This patch removes unnecessary typecast of c90 int constant. > > WARNING: Unnecessary typecast of c90 int constant > > Signed-off-by: simran singhal > --- > drivers/staging/media/atomisp/i2c/gc2235.c |

Re: [PATCH] atomisp2: unify some ifdef cases caused by format changes

On Wed, Mar 08, 2017 at 01:49:23PM +0100, Hans Verkuil wrote: > OK, so I discovered that these patches are for a driver added to linux-next > without it ever been cross-posted to linux-media. > > To be polite, I think that's rather impolite. They were, but got rejected due to the size :( Mauro

Re: [PATCH] atomisp2: unify some ifdef cases caused by format changes

On Wed, Mar 08, 2017 at 02:55:44PM +0100, Hans Verkuil wrote: > On 08/03/17 14:45, Hans Verkuil wrote: > > On 08/03/17 14:39, Greg KH wrote: > > > On Wed, Mar 08, 2017 at 01:49:23PM +0100, Hans Verkuil wrote: > > > > OK, so I discovered that these patches are for a

Re: [PATCH] Staging: media: platform: bcm2835 - Style fix

On Sun, Mar 05, 2017 at 10:43:19AM +1300, Derek Robson wrote: > On Sat, Mar 04, 2017 at 02:57:22PM +0300, Dan Carpenter wrote: > > Copy a patch prefix that everyone else has been using: > > > > git log --oneline drivers/staging/media/platform/bcm2835/ > > > > The subject is too vague as well. >

Re: [PATCH] staging/atomisp:fix build issue verus 4.11-rc1

On Mon, Mar 06, 2017 at 11:21:28AM +, Alan Cox wrote: > From: xingzhen > > commit:2a1f062a4acf move sigpending method fatal_signal_pending from > into cause the build issue,fix it. > > Signed-off-by: xingzhen > Signed-off-by: Alan Cox

Re: [PATCH] media: staging: bcm2048: use unsigned int instead of unsigned

On Mon, Feb 20, 2017 at 05:08:56PM -0700, David Cako wrote: > Signed-off-by: David Cako > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 44 > +-- > 1 file changed, 22 insertions(+), 22 deletions(-) We can't take patches without any changelog text,

Re: [PATCH] siano: make it work again with CONFIG_VMAP_STACK

On Tue, Feb 14, 2017 at 05:32:11PM -0200, Mauro Carvalho Chehab wrote: > Reported as a Kaffeine bug: > https://bugs.kde.org/show_bug.cgi?id=375811 > > The USB control messages require DMA to work. We cannot pass > a stack-allocated buffer, as it is not warranted that the > stack would be

Re: [PATCH] Staging: media: bcm2048: Fixed an error

On Sat, Feb 11, 2017 at 12:41:29AM +0200, Ran Algawi wrote: > Fixed an error where the system was given a code in the form of decimal > instead of octal. It's not really an "error", right? Please be more descriptive of exactly what is going on here (hint, it's a coding style warning...) thanks,

Re: [PATCH 1/2] Staging: media: bcm2048: fixed 20+ warings/errors

On Fri, Feb 10, 2017 at 11:37:04AM +0200, Ran Algawi wrote: > Fixed a coding style issues, and two major erros about complex macros > and an error where the driver used a decimal number insted of an octal > number when using a warning. Only do one thing-per-patch please. thanks, gre gk-h -- To

Re: [Patch] Staging: media: bcm2048: fixed errors and warnings

On Fri, Feb 10, 2017 at 11:41:41AM +0200, Ran Algawi wrote: > Never attach patches, and always test-build them yourself to ensure they do not break the build :( greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to

Re: [PATCH v3 1/2] staging: omap4iss: fix multiline comment style

On Tue, Feb 07, 2017 at 05:40:57PM +0200, Avraham Shukron wrote: > Signed-off-by: Avraham Shukron > --- > drivers/staging/media/omap4iss/iss_video.c | 38 > -- > 1 file changed, 25 insertions(+), 13 deletions(-) Again, I don't take patches

Re: [PATCH v2] Staging: omap4iss: Fix coding style issues

On Mon, Feb 06, 2017 at 07:58:35PM +0200, Avraham Shukron wrote: > Fixes line-over-80-characters issues as well as multiline comments style. When you say things like "as well as", that's a hint that this needs to be broken up into different patches. Please do so here. thanks, greg k-h -- To

Re: [PATCH] Staging: omap4iss: fix coding style issues. This is a patch that fixes checkpatch.pl issues in omap4iss/iss_video.c Specifically, it fixes "line over 80 characters" issues.

On Sat, Jan 28, 2017 at 05:59:43PM +0200, Avraham Shukron wrote: > --- > drivers/staging/media/omap4iss/iss_video.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) That's a crazy subject line :( Please fix... -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH V2] Staging: media: bcm2048: style fix - bare use of unsigned

On Mon, Jan 16, 2017 at 08:09:51PM +1300, Derek Robson wrote: > Changed macro to not pass signedness and size as seprate fields. > This is to improve code readablity. Not really, it reads just fine as is. In fact, it forces you to think about the signed vs. unsigned of the variable and doesn't

Re: [PATCH] Staging: media: bcm2048: style fix - bare use of unsigned

On Mon, Jan 16, 2017 at 06:06:25PM +1300, Derek Robson wrote: > On Sun, Jan 15, 2017 at 10:40:02PM -0600, Scott Matheina wrote: > > > > > > > On Jan 15, 2017, at 10:30 PM, Derek Robson wrote: > > > > > > Changed bare use of 'unsigned' to the prefered us of 'unsigned int' >

Re: uvcvideo logging kernel warnings on device disconnect

On Tue, Dec 20, 2016 at 11:19:23AM +, Dave Stevenson wrote: > Hi Greg. > > On 09/12/16 09:43, Greg KH wrote: > > On Fri, Dec 09, 2016 at 11:14:41AM +0200, Laurent Pinchart wrote: > > > Hi Greg, > > > > > > On Friday 09 Dec 2016 10:11:13 Greg KH wr

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

On Thu, Dec 15, 2016 at 10:57:16AM -0200, Mauro Carvalho Chehab wrote: > Em Thu, 15 Dec 2016 09:42:35 -0300 > Javier Martinez Canillas escreveu: > > > Hello Mauro, > > > > On 12/15/2016 09:37 AM, Mauro Carvalho Chehab wrote: > > > > [snip] > > > > > > > > What happens

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

On Thu, Dec 15, 2016 at 02:13:42PM +0200, Laurent Pinchart wrote: > Hi Mauro, > > (CC'ing Greg) > > On Wednesday 14 Dec 2016 13:14:06 Mauro Carvalho Chehab wrote: > > Avoid calling streamoff without having the media structs allocated. > > > > Signed-off-by: Mauro Carvalho Chehab

Re: uvcvideo logging kernel warnings on device disconnect

On Fri, Dec 09, 2016 at 11:14:41AM +0200, Laurent Pinchart wrote: > Hi Greg, > > On Friday 09 Dec 2016 10:11:13 Greg KH wrote: > > On Fri, Dec 09, 2016 at 10:59:24AM +0200, Laurent Pinchart wrote: > > > On Friday 09 Dec 2016 08:25:52 Greg KH wrote: > > >> On F

Re: uvcvideo logging kernel warnings on device disconnect

On Fri, Dec 09, 2016 at 10:59:24AM +0200, Laurent Pinchart wrote: > Hi Greg, > > On Friday 09 Dec 2016 08:25:52 Greg KH wrote: > > On Fri, Dec 09, 2016 at 01:09:21AM +0200, Laurent Pinchart wrote: > > > On Thursday 08 Dec 2016 12:31:55 Dave Stevenson wrote: > >

Re: uvcvideo logging kernel warnings on device disconnect

On Fri, Dec 09, 2016 at 01:09:21AM +0200, Laurent Pinchart wrote: > Hi Dave, > > (CC'ing LKML and Greg KH) > > On Thursday 08 Dec 2016 12:31:55 Dave Stevenson wrote: > > Hi All. > > > > I'm working with a USB webcam which has been seen to spontaneously &

Re: [PATCH] usb: core: urb make use of usb_endpoint_maxp_mult

On Sun, Nov 13, 2016 at 01:31:16PM +0300, Mike Krinkin wrote: > Since usb_endpoint_maxp now returns only lower 11 bits mult > calculation here isn't correct anymore and that breaks webcam > for me. Patch make use of usb_endpoint_maxp_mult instead of > direct calculation. > > Fixes: abb621844f6a

Re: [PATCH v2 00/11] getting back -Wmaybe-uninitialized

On Sun, Nov 13, 2016 at 09:47:41AM +0100, Greg KH wrote: > On Sat, Nov 12, 2016 at 01:27:12PM +, Jonathan Cameron wrote: > > On 11/11/16 19:49, Arnd Bergmann wrote: > > > On Friday, November 11, 2016 9:13:00 AM CET Linus Torvalds wrote: > > >> On Thu, Nov 10,

Re: [PATCH v2 00/11] getting back -Wmaybe-uninitialized

On Sat, Nov 12, 2016 at 01:27:12PM +, Jonathan Cameron wrote: > On 11/11/16 19:49, Arnd Bergmann wrote: > > On Friday, November 11, 2016 9:13:00 AM CET Linus Torvalds wrote: > >> On Thu, Nov 10, 2016 at 8:44 AM, Arnd Bergmann wrote: > >>> > >>> Please merge these directly if

Re: [PATCH] [media] v4l: rcar-fcp: Don't force users to check for disabled FCP support

On Tue, Oct 18, 2016 at 04:24:20PM +0300, Laurent Pinchart wrote: > commit fd44aa9a254b18176ec3792a18e7de6977030ca8 upstream. > > The rcar_fcp_enable() function immediately returns successfully when the > FCP device pointer is NULL to avoid forcing the users to check the FCP > device manually

Re: [PATCH] Staging: media: omap4iss: fixed coding style issues

On Sun, Oct 16, 2016 at 05:18:56PM +0200, Hector Roussille wrote: > Fixed coding style issues You need to be a lot more specific please. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 00/28] media: don't print error when allocating urb fails

On Thu, Aug 11, 2016 at 11:03:36PM +0200, Wolfram Sang wrote: > This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses > kmalloc which already prints enough information on failure. So, let's simply > remove those "allocation failed" messages from drivers like we did already

Re: Backport a Security Fix for CVE-2015-7833 to v4.1

On Mon, Apr 18, 2016 at 06:01:19PM +0900, Yuki Machida wrote: > Hi Greg and Sasha, > > Please do not accept patch of 588afcc to stable tree, > because above patch has some problem. > It reported by Vladis and Hans. > https://patchwork.linuxtv.org/patch/32798/ >

Re: USB xHCI regression after upgrading from kernel 3.19.0-51 to 4.2.0-34.

On Fri, Apr 08, 2016 at 10:51:26AM +0200, Hans de Goede wrote: > Hi, > > It is probably best to resend this mail to > linux-usb > since this is more of a usb problem then a v4l2 problem, > and all the usb experts are subscribed to that list. Heh, I told him to send it

Re: On Lindent shortcomings and massive style fixing

On Mon, Dec 28, 2015 at 04:33:27PM +0200, Andrey Utkin wrote: > After some iterations of checkpatch.pl, on a new developed driver > (tw5864), now I have the following: > > $ grep 'WARNING\|ERROR' /src/checkpatch.tw5864 | sort | uniq -c > 31 ERROR: do not use C99 // comments > 147

Re: [PATCH RFC] [media] Postpone the addition of MEDIA_IOC_G_TOPOLOGY

On Mon, Dec 28, 2015 at 08:37:19AM -0700, Shuah Khan wrote: > On 12/28/2015 07:03 AM, Mauro Carvalho Chehab wrote: > > There are a few discussions left with regards to this ioctl: > > > > 1) the name of the new structs will contain _v2_ on it? > > 2) what's the best alternative to avoid compat32

Re: [PATCH 15/15] dma: remove external references to dma_supported

On Sat, Oct 03, 2015 at 05:19:39PM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > Documentation/DMA-API.txt | 13 - > drivers/usb/host/ehci-hcd.c | 2 +- > drivers/usb/host/fotg210-hcd.c | 2 +- > drivers/usb/host/fusbh200-hcd.c |

Re: [PATCH] staging: media:lirc: Added a newline character after declaration

On Wed, Aug 12, 2015 at 08:41:42PM +0530, Aparna Karuthodi wrote: Added a newline character to remove a coding style warning detected by checkpatch. The warning is given below: drivers/staging/media/lirc/lirc_serial.c:1169: WARNING: quoted string split across lines Signed-off-by: Aparna

Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.

On Sat, Aug 08, 2015 at 03:42:18PM +0530, Sudip Mukherjee wrote: On Sat, Aug 08, 2015 at 01:55:02AM -0500, Junsu Shin wrote: On 08/06/2015 11:45 PM, Sudip Mukherjee wrote: On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote: snip Thanks for pointing it out. Again, this

Re: [Y2038] [PATCH] Staging: media: lirc: Replace timeval with ktime_t

On Mon, Jun 08, 2015 at 09:37:24PM +0200, Ksenija Stanojević wrote: Hi Greg, It's been over two weeks that I've sent this patch. Have you missed it? Not at all, please look at the output of $ ./scripts/get_maintainer.pl --file drivers/staging/media/lirc/lirc_sir.c To see why I

Re: [PATCH] radio-bcm2048: Fix region selection

On Sat, May 16, 2015 at 01:22:27PM +0200, Jan Roemisch wrote: Oh sorry, the real name is Jan Roemisch. Ok, thanks, can someone please fix up the patches and resend them? greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to

Re: [PATCH v3] dma-buf: add ref counting for module as exporter

On Fri, May 08, 2015 at 07:12:43PM +0530, Sumit Semwal wrote: Add reference counting on a kernel module that exports dma-buf and implements its operations. This prevents the module from being unloaded while DMABUF file is in use. The original patch [1] was submitted by Tomasz Stanislawski,

Re: [PATCH] dma-buf: add ref counting for module as exporter

On Thu, May 07, 2015 at 01:00:52PM +0530, Sumit Semwal wrote: Add reference counting on a kernel module that exports dma-buf and implements its operations. This prevents the module from being unloaded while DMABUF file is in use. The original patch [1] was submitted by Tomasz, but he's since

Re: [PATCH v2] dma-buf: add ref counting for module as exporter

On Thu, May 07, 2015 at 06:58:44PM +0530, Sumit Semwal wrote: Add reference counting on a kernel module that exports dma-buf and implements its operations. This prevents the module from being unloaded while DMABUF file is in use. The original patch [1] was submitted by Tomasz Stanislawski,

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

On Fri, Feb 20, 2015 at 05:15:10PM +0100, Jacek Anaszewski wrote: On 02/20/2015 04:36 PM, Greg KH wrote: On Fri, Feb 20, 2015 at 08:56:11AM +0100, Jacek Anaszewski wrote: On 02/19/2015 10:40 PM, Greg KH wrote: On Thu, Feb 19, 2015 at 11:02:04AM +0200, Sakari Ailus wrote: On Wed, Feb 18, 2015

  1   2   3   4   >