Re: [PATCH] MMC: remove regulator refcount fiddling in mmc core

2010-06-28 Thread Adrian Hunter
Linus Walleij wrote: Currently the mmc_regulator_set_ocr() fiddles with the regulator refcount by selectively calling regulator_[enable|disable] depending on the state of the regulator. This will confuse the reference count if case the regulator is for example shared with other MMC slots or user

Re: [PATCH v5 2/2] OMAP4 HSMMC: Adding card detect support for MMC1 Controller

2010-06-28 Thread kishore kadiyala
Adrian , Sorry for the late response snip As per my email 5/5/10, I would suggest the only change to omap_hsmmc is: Agreed and followed the changes mostly but made some more changes on top of it. snip And that the late init function is used to do the rest e.g. find a home for these 3

Re: [PATCH 2/3] SDHCI: Don't assign mmc-caps at SDHCI directly

2010-06-28 Thread Andrew Morton
On Sat, 12 Jun 2010 14:44:50 +0900 Kyungmin Park kyungmin.p...@samsung.com wrote: From: Kyungmin Park kyungmin.p...@samsung.com Some host controller can set mmc-caps before sdhci_add_host. Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/mmc/host/sdhci.c |2 +- 1

Re: [PATCH 3/3] SDHCI: 8-bit data transfer width support

2010-06-28 Thread Andrew Morton
On Sat, 12 Jun 2010 14:45:02 +0900 Kyungmin Park kyungmin.p...@samsung.com wrote: From: Kyungmin Park kyungmin.p...@samsung.com Some host constroller such as s5pc110 has WIDE8 support feature. Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/mmc/host/sdhci.c |5

Re: [PATCH 3/3] SDHCI: 8-bit data transfer width support

2010-06-28 Thread Colin Cross
These patches are not coming from the tegra/for-next branch, they are coming from Grant's devicetree-next branch. Grant, why are these patches in your tree, and why is tegra/for-next in your tree? It's going to cause conflicts when we rebase our for-next branch. Please remove tegra and this

Re: [PATCH 2/3] SDHCI: Don't assign mmc-caps at SDHCI directly

2010-06-28 Thread Grant Likely
On Mon, Jun 28, 2010 at 11:34 AM, Andrew Morton a...@linux-foundation.org wrote: On Sat, 12 Jun 2010 14:44:50 +0900 Kyungmin Park kyungmin.p...@samsung.com wrote: From: Kyungmin Park kyungmin.p...@samsung.com Some host controller can set mmc-caps before sdhci_add_host. Signed-off-by:

Re: [PATCH 3/3] SDHCI: 8-bit data transfer width support

2010-06-28 Thread Olof Johansson
On Mon, Jun 28, 2010 at 11:56:26AM -0700, Colin Cross wrote: These patches are not coming from the tegra/for-next branch, they are coming from Grant's devicetree-next branch. Grant, why are these patches in your tree, and why is tegra/for-next in your tree? It's going to cause conflicts when