Re: [RFC Patch] SDHCI: add quirk for data timeout value when card busy.

2010-12-02 Thread Wolfram Sang
The timeout value in the host controller should not change once it is set. It s not supposed to change value on reset (for example). Curious -- if you read the value when you are in the busy state before you set it -- what value is there. I checked the timeout value to 0xa (i

[PATVH v3 0/3]mmc: set a suitable max_discard_sectors value for HC

2010-12-02 Thread Chuanxiao Dong
Hi, This is the version 3 patch which set a suitable max_discard_sectors value for SDHCI host controller. In this patch, a new quirk is added for such controller. max_discard_sectors is a parameter of MMC driver request queue. This value can limit how many

[PATCH v3 1/3]add a new quirk for SDHCI host

2010-12-02 Thread Chuanxiao Dong
From 08e9f6c1fb908172c2ebb278e7b8da359db51bac Mon Sep 17 00:00:00 2001 From: Chuanxiao Dong chuanxiao.d...@intel.com Date: Thu, 2 Dec 2010 15:19:54 +0800 Subject: [PATCH 1/3] add a quirk for sdhci host which cannot erase too many sectors each time The original max_discard_sectors value which

[PATCH v3 2/3]set timeout control reg for such SDHCI host

2010-12-02 Thread Chuanxiao Dong
From b1cc696f0fbb0c48f024359977624a862ece93f4 Mon Sep 17 00:00:00 2001 From: Chuanxiao Dong chuanxiao.d...@intel.com Date: Thu, 2 Dec 2010 15:53:37 +0800 Subject: [PATCH 2/3] set timeout control reg for SDHCI host when sending erase cmd Since if erasing needs longer time than the timeout host

[PATCH v3 3/3]add this quirk to MFLD SDHCI host

2010-12-02 Thread Chuanxiao Dong
From 8572052d6130daaddbae7c529b02a61692ff765f Mon Sep 17 00:00:00 2001 From: Chuanxiao Dong chuanxiao.d...@intel.com Date: Thu, 2 Dec 2010 18:53:39 +0800 Subject: [PATCH 3/3] Add quirk to MFLD sdhci host controller MFLD platform host controller cannot erase too many sectors at one time, this

Re: [PATCH v4] mmc: Make ID freq configurable

2010-12-02 Thread Sahitya Tummala
Hi Hein Tibosch, On Fri, 2010-09-03 at 05:34 +0800, Hein_Tibosch wrote: In the latest releases of the mmc driver, the freq during initialization is set to a fixed 400 Khz. This was reportedly too fast for several users. As there doesn't seem to be an ideal frequency which-works-for-all,

[PATCH] mmci: supply per-instance regulator name

2010-12-02 Thread Linus Walleij
On the Ux500 we have different regulators to different card slots and eMMCs, and some have no regulator. Move the hardcoded vmmc regulator name to platform data and supply it that way for the platforms that use it. Remove the ugly and unneeded #ifdef around the regulator fetch code at the same

Re: [PATCH v3 2/3]set timeout control reg for such SDHCI host

2010-12-02 Thread Wolfram Sang
On Thu, Dec 02, 2010 at 07:26:13PM +0800, Chuanxiao Dong wrote: + if (host-quirks SDHCI_QUIRK_FORCE_ERASE_SINGLE) { + /* Set the timeout to be the maximum value */ + if (cmd-erase_timeout) + sdhci_writeb(host, 0xE, SDHCI_TIMEOUT_CONTROL); +

Re: [PATCH] mmci: supply per-instance regulator name

2010-12-02 Thread Russell King - ARM Linux
On Thu, Dec 02, 2010 at 12:35:07PM +0100, Linus Walleij wrote: On the Ux500 we have different regulators to different card slots and eMMCs, and some have no regulator. Move the hardcoded vmmc regulator name to platform data and supply it that way for the platforms that use it. Remove the ugly

Re: [PATCH] mmci: supply per-instance regulator name

2010-12-02 Thread Mark Brown
On Thu, Dec 02, 2010 at 12:35:07PM +0100, Linus Walleij wrote: On the Ux500 we have different regulators to different card slots and eMMCs, and some have no regulator. Move the hardcoded vmmc regulator name to platform data and supply it that way for the You should never be passing regulator

Re: [PATCH] mmci: supply per-instance regulator name

2010-12-02 Thread Mark Brown
On Thu, Dec 02, 2010 at 11:57:00AM +, Russell King - ARM Linux wrote: It seems that the regulator code is making all the same mistakes that historically were made with the clk API code. It's not... Rather than using the struct device, it's trying to use the regulator ...it does exactly

Re: [PATCH] mmci: supply per-instance regulator name

2010-12-02 Thread Russell King - ARM Linux
On Thu, Dec 02, 2010 at 12:03:18PM +, Mark Brown wrote: On Thu, Dec 02, 2010 at 12:35:07PM +0100, Linus Walleij wrote: On the Ux500 we have different regulators to different card slots and eMMCs, and some have no regulator. Move the hardcoded vmmc regulator name to platform data and

Re: [PATCH] mmci: supply per-instance regulator name

2010-12-02 Thread Mark Brown
On Thu, Dec 02, 2010 at 12:28:27PM +, Russell King - ARM Linux wrote: The way the MMCI code is, it only requests one regulator per AMBA device, and therefore only one regulator per struct device. So I don't think the current code needs changing in any way provided the struct device is

Re: [PATCH] mmci: supply per-instance regulator name

2010-12-02 Thread Linus Walleij
2010/12/2 Mark Brown broo...@opensource.wolfsonmicro.com: On Thu, Dec 02, 2010 at 12:28:27PM +, Russell King - ARM Linux wrote: The way the MMCI code is, it only requests one regulator per AMBA device, and therefore only one regulator per struct device.  So I don't think the current code

Re: [PATCH] mmci: drop superfluous regulator #ifdef

2010-12-02 Thread Mark Brown
On Thu, Dec 02, 2010 at 02:36:58PM +0100, Linus Walleij wrote: The regulator and MMC frameworks provide the proper stub functions for the regulator functions anyway, get rid of this. It's more that the regulator API stubs have been changed to match what MMC is doing (there always were stubs)

Re: [RFC Patch] SDHCI: add quirk for data timeout value when card busy.

2010-12-02 Thread Philip Rakity
On Dec 1, 2010, at 11:40 PM, Jaehoon Chung wrote: Philip Rakity wrote: On Dec 1, 2010, at 4:29 AM, Jaehoon Chung wrote: Philip Rakity wrote: On Nov 30, 2010, at 9:44 PM, Jaehoon Chung wrote: Philip Rakity wrote: Can we just remove the quirk for broken timeout and just set the timeout

[PATCH] mmci: corrected calculation of clock div for ux500

2010-12-02 Thread Linus Walleij
From: Ulf Hansson ulf.hans...@stericsson.com The Ux500 variant of this block has a different divider. The value used right now is too big and which means a loss in performance. This fix corrects it. Signed-off-by: Ulf Hansson ulf.hans...@stericsson.com Signed-off-by: Linus Walleij

Re: [PATCH] mmci: corrected calculation of clock div for ux500

2010-12-02 Thread Russell King - ARM Linux
On Thu, Dec 02, 2010 at 05:51:18PM +0100, Linus Walleij wrote: From: Ulf Hansson ulf.hans...@stericsson.com The Ux500 variant of this block has a different divider. The value used right now is too big and which means a loss in performance. This fix corrects it. Err. + } else

Re: [PATCH] mmci: corrected calculation of clock div for ux500

2010-12-02 Thread Linus Walleij
2010/12/2 Russell King - ARM Linux li...@arm.linux.org.uk: On Thu, Dec 02, 2010 at 05:51:18PM +0100, Linus Walleij wrote: From: Ulf Hansson ulf.hans...@stericsson.com The Ux500 variant of this block has a different divider. The value used right now is too big and which means a loss in

RE: [PATCH v3 2/3]set timeout control reg for such SDHCI host

2010-12-02 Thread Dong, Chuanxiao
On Thu, Dec 02, 2010 at 07:26:13PM +0800, Chuanxiao Dong wrote: + if (host-quirks SDHCI_QUIRK_FORCE_ERASE_SINGLE) { + /* Set the timeout to be the maximum value */ + if (cmd-erase_timeout) + sdhci_writeb(host, 0xE, SDHCI_TIMEOUT_CONTROL); +

Re: [PATCH v4] mmc: Make ID freq configurable

2010-12-02 Thread stummala
Hi Michal, On Fri, Dec 03, 2010 at 05:21:10AM +0800, Hein_Tibosch wrote: Hi Sahitya, On 2-12-2010 19:16, Sahitya Tummala wrote: Hi Hein Tibosch, On Fri, 2010-09-03 at 05:34 +0800, Hein_Tibosch wrote: In the latest releases of the mmc driver, the freq during initialization is set to

[PATCH 0/2] share sdhci-pxa among mmp2, pxa910, pxa168 and pxa955

2010-12-02 Thread zhangfei gao
These two patches introduce several call backs, in order to share sdhci-pxa. patch 1: move sdhci_priv and sdhci_ops definition to include/linux/mmc/sdhci.h from drivers/mmc/host/sdhci.h 1. platfrom could directly overwrite sdhci_ops with soc specific ops, this case occurs at different controller

[PATCH 1/2] mmc move sdhci_ops and sdhci_priv to header

2010-12-02 Thread zhangfei gao
From 9ae40c28754f1034abad9d07c0c86725a0a3f4b8 Mon Sep 17 00:00:00 2001 From: Zhangfei Gao zhangfei@marvell.com Date: Tue, 30 Nov 2010 05:37:27 -0500 Subject: [PATCH 1/2] mmc: move sdhci_ops and sdhci_priv to header Soc specific function under /arch would access private via sdhci_priv.

[PATCH 2/2] sdhci-pxa add call back interface to share sdhci-pxa

2010-12-02 Thread zhangfei gao
From fb5927afac7cbb44805093816bea51dde33da1e5 Mon Sep 17 00:00:00 2001 From: Zhangfei Gao zhangfei@marvell.com Date: Tue, 30 Nov 2010 05:43:29 -0500 Subject: [PATCH 2/2] sdhci-pxa: add call back interface to share sdhci-pxa Call back functions is added to support mmp2, pxa910, pxa168