[PATCH V4 1/4] ARM: imx53_loco: add esdhc device support

2011-03-01 Thread Richard Zhu
Signed-off-by: Richard Zhao richard.z...@freescale.com Acked-by: Wolfram Sang w.s...@pengutronix.de --- arch/arm/mach-mx5/Kconfig |1 + arch/arm/mach-mx5/board-mx53_loco.c |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mx5/Kconfig

[PATCH V4 3/4] mmc: sdhci-esdhc: remove SDHCI_QUIRK_NO_CARD_NO_RESET from ESDHC_DEFAULT_QUIRKS

2011-03-01 Thread Richard Zhu
sdhci-esdhc-imx does not need SDHCI_QUIRK_NO_CARD_NO_RESET. Make it OF-specific. Signed-off-by: Richard Zhu hong-xing@freescale.com Tested-by: Wolfram Sang w.s...@pengutronix.de --- drivers/mmc/host/sdhci-esdhc.h|3 +-- drivers/mmc/host/sdhci-of-esdhc.c |2 +- 2 files changed, 2

[PATCH V4 4/4] mmc: sdhci-esdhc: enable esdhc on imx53

2011-03-01 Thread Richard Zhu
Fix the NO INT in the Multi-BLK IO in SD/MMC, and Multi-BLK read in SDIO The CMDTYPE of the CMD register(offset 0xE) should be set to 11 when the STOP CMD12 is issued on imx53 to abort one open ended multi-blk IO. Otherwise one the TC INT wouldn't be generated. In exact block transfer, the

[PATCH V4 2/4] ARM: imx51/53: add sdhc3/4 clock

2011-03-01 Thread Richard Zhu
Signed-off-by: Richard Zhao richard.z...@freescale.com --- arch/arm/mach-mx5/clock-mx51-mx53.c | 140 ++- arch/arm/mach-mx5/crm_regs.h|7 ++ 2 files changed, 146 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c

Re: [PATCH] mmc: dw_mmc: Remove set-but-unused variable.

2011-03-01 Thread Will Newton
On Mon, Feb 28, 2011 at 9:55 PM, Chris Ball c...@laptop.org wrote: count is only ever used by assigning to old_len if count == 0, and then old_len isn't ever used at all.  So, both are redundant.  Fixes: drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_read_data_pio’:

Re: [PATCH V3 4/4] mmc: sdhci-esdhc: enable esdhc on imx53

2011-03-01 Thread Wolfram Sang
Hi Richard, Thanks a lot for your review-comments firstly. :) You are welcome :) +/* Abort type definition in the command register */ +#define SDHCI_CMD_ABORTCMD0xC0 Won't that belong into sd.h (unless I misunderstood your last mail)? This is the bit definitions of the

Re: [RFC] MMC: error handling improvements

2011-03-01 Thread Sahitya Tummala
Hi Russell King, On Sat, 2011-02-19 at 15:00 +, Russell King - ARM Linux wrote: On Tue, Feb 15, 2011 at 03:49:04PM -0800, David Brown wrote: On Tue, Feb 15 2011, Russell King - ARM Linux wrote: This patch is for RFC only; it needs splitting up somewhat. However, I wanted to get

[PATCH] mmc/sdio: remember new card RCA when redetecting card

2011-03-01 Thread Linus Walleij
From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com During redetection of a SDIO card, a request for a new card RCA was submitted to the card, but was then overwritten by the old RCA. This caused the card to be deselected instead of selected when using the incorrect RCA. Signed-off-by:

RE: [PATCH 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-01 Thread subhashj
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Arindam Nath Sent: Tuesday, February 15, 2011 3:05 PM To: c...@laptop.org Cc: linux-mmc@vger.kernel.org; henry...@amd.com; aaron...@amd.com; anath@gmail.com; Arindam

[RFC,PATCHv3 0/3] sdhci runtime_pm implementation

2011-03-01 Thread Pierre Tardy
Please find sdhci runtime_pm implementation. It uses clock gating fw as a tip to know when our chip is idle. It implements wake up from card insertion/removal. This is RFC, please dont merge yet. I really would like to have deep review from PCI linux-pm guys. Opens are: 1/ Not sure if the pci

[RFC,PATCHv3 1/3] mmc: sdhci-pci: Enable runtime PM support

2011-03-01 Thread Pierre Tardy
From: Yunpeng Gao yunpeng@intel.com Follow the kernel runtime PM framework, enable runtime PM support of the sdhci host controller with pci interface. Note that this patch implements runtime_pm but now actually detects activity. It relies on higher level (childrens) to do actual waking up

[RFC,PATCHv3 3/3] mmc: sdhci: handle wake-up from runtime_pm

2011-03-01 Thread Pierre Tardy
When sdhci is runtime_suspended, it can still receive a wake-up because of card insertion. The wake-up will then be signaled by an interrupt which cannot be serviced immediatly, as the device is powered off, and register are not accessibles. We cannot call pm_runtime_get_sync() in irq context as

[RFC,PATCHv3 2/3] mmc: sdhci: use ios-clock to know when sdhci is idle

2011-03-01 Thread Pierre Tardy
This allows sdhci to detect its own activity and to autosuspend when not used inspired from mmci: handle clock frequency 0 properly From Linus Walleij linus.wall...@stericsson.com author of mmc aggressive clock gating fw. The idea of using mmc clock gating fw in order to power gate the sdhci is

Re: Fwd: [RFC] MMC: error handling improvements

2011-03-01 Thread Murali Krishna Palnati
-- Forwarded message -- From: Linus Walleij linus.wall...@linaro.org Date: Tue, Feb 22, 2011 at 2:19 AM Subject: Re: [RFC] MMC: error handling improvements To: Brian Swetland swetl...@google.com, David Brown dav...@codeaurora.org Cc: Russell King - ARM Linux

Re: MMC quirks relating to performance/lifetime.

2011-03-01 Thread Arnd Bergmann
On Tuesday 01 March 2011 19:48:17 Jens Axboe wrote: On 2011-02-25 07:21, Arnd Bergmann wrote: On Friday 25 February 2011, Andrei Warkentin wrote: Yup. I understand :-). That's the strategy I'm going to follow. For page_size-alignment/splitting I'm looking at the block layer now. Is

Re: MMC quirks relating to performance/lifetime.

2011-03-01 Thread Jens Axboe
On 2011-03-01 14:11, Arnd Bergmann wrote: On Tuesday 01 March 2011 19:48:17 Jens Axboe wrote: On 2011-02-25 07:21, Arnd Bergmann wrote: On Friday 25 February 2011, Andrei Warkentin wrote: Yup. I understand :-). That's the strategy I'm going to follow. For page_size-alignment/splitting I'm

Re: [linux-pm] [RFC,PATCHv3 0/3] sdhci runtime_pm implementation

2011-03-01 Thread Alan Stern
On Tue, 1 Mar 2011, Pierre Tardy wrote: Please find sdhci runtime_pm implementation. It uses clock gating fw as a tip to know when our chip is idle. It implements wake up from card insertion/removal. This is RFC, please dont merge yet. I really would like to have deep review from PCI

Re: [linux-pm] [RFC,PATCHv3 0/3] sdhci runtime_pm implementation

2011-03-01 Thread Pierre Tardy
On Tue, Mar 1, 2011 at 8:33 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 1 Mar 2011, Pierre Tardy wrote: Please find sdhci runtime_pm implementation. It uses clock gating fw as a tip to know when our chip is idle. It implements wake up from card insertion/removal. This is RFC,

Re: [linux-pm] [RFC, PATCHv3 1/3] mmc: sdhci-pci: Enable runtime PM support

2011-03-01 Thread Alan Stern
On Tue, 1 Mar 2011, Pierre Tardy wrote: From: Yunpeng Gao yunpeng@intel.com Follow the kernel runtime PM framework, enable runtime PM support of the sdhci host controller with pci interface. Note that this patch implements runtime_pm but now actually detects activity. It relies on

Re: MMC quirks relating to performance/lifetime.

2011-03-01 Thread Arnd Bergmann
On Tuesday 01 March 2011 20:15:30 Jens Axboe wrote: Thanks for the recap. One way to handle this would be to have a dm target that ensures that requests are never built up to violate any of the above items. Doing splitting is a little silly, when you can prevent it from happening in the first

Re: [linux-pm] [RFC, PATCHv3 3/3] mmc: sdhci: handle wake-up from runtime_pm

2011-03-01 Thread Alan Stern
On Tue, 1 Mar 2011, Pierre Tardy wrote: When sdhci is runtime_suspended, it can still receive a wake-up because of card insertion. The wake-up will then be signaled by an interrupt which cannot be serviced immediatly, as the device is powered off, and register are not accessibles. We

Re: [linux-pm] [RFC,PATCHv3 0/3] sdhci runtime_pm implementation

2011-03-01 Thread Alan Stern
On Tue, 1 Mar 2011, Pierre Tardy wrote: On Tue, Mar 1, 2011 at 8:33 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 1 Mar 2011, Pierre Tardy wrote: Please find sdhci runtime_pm implementation. It uses clock gating fw as a tip to know when our chip is idle. It implements wake

Re: [linux-pm] [RFC, PATCHv3 3/3] mmc: sdhci: handle wake-up from runtime_pm

2011-03-01 Thread Pierre Tardy
+     if (pm_runtime_suspended()) { +             host-waking_up = 1; +             /* Note that we disable temporarly the interrupt until we do the +              * resume. If we don't then we'll get constantly interrupted +              * until we actually resume. +              * +    

Re: [linux-pm] [RFC,PATCHv3 0/3] sdhci runtime_pm implementation

2011-03-01 Thread Pierre Tardy
On Tue, Mar 1, 2011 at 8:57 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 1 Mar 2011, Pierre Tardy wrote: On Tue, Mar 1, 2011 at 8:33 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 1 Mar 2011, Pierre Tardy wrote: Please find sdhci runtime_pm implementation. It uses

Re: Fwd: [RFC] MMC: error handling improvements

2011-03-01 Thread Russell King - ARM Linux
On Tue, Mar 01, 2011 at 10:39:59AM -0800, Murali Krishna Palnati wrote: Our main concern in moving to mmci is support for DMA that needs to be added to this driver. I believe PL180 controller does have the ability to talk to DMA engines, but i dont see any relevant support for that in mmci

Re: [linux-pm] [RFC, PATCHv3 3/3] mmc: sdhci: handle wake-up from runtime_pm

2011-03-01 Thread Alan Stern
On Tue, 1 Mar 2011, Pierre Tardy wrote: +     if (pm_runtime_suspended()) { +             host-waking_up = 1; +             /* Note that we disable temporarly the interrupt until we do the +              * resume. If we don't then we'll get constantly interrupted +              *

[PATCH] tmio: silence warnings introduced by mfd changes

2011-03-01 Thread Andres Salomon
On Tue, 1 Mar 2011 10:53:22 -0800 Andres Salomon dilin...@queued.net wrote: On Tue, 1 Mar 2011 15:42:30 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: Hi Samuel, After merging the mfd tree, today's linux-next build (x86_64 allmodconfig) produced these warnings:

Re: [linux-pm] [RFC, PATCHv3 3/3] mmc: sdhci: handle wake-up from runtime_pm

2011-03-01 Thread Pierre Tardy
On Tue, Mar 1, 2011 at 9:27 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 1 Mar 2011, Pierre Tardy wrote: +     if (pm_runtime_suspended()) { +             host-waking_up = 1; +             /* Note that we disable temporarly the interrupt until we do the +              *

Re: [linux-pm] [RFC,PATCHv3 0/3] sdhci runtime_pm implementation

2011-03-01 Thread Rafael J. Wysocki
On Tuesday, March 01, 2011, Pierre Tardy wrote: On Tue, Mar 1, 2011 at 8:33 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 1 Mar 2011, Pierre Tardy wrote: Please find sdhci runtime_pm implementation. It uses clock gating fw as a tip to know when our chip is idle. It

[RFC 1/3] MMC: Adjust unaligned write accesses.

2011-03-01 Thread Andrei Warkentin
Adjust unaligned write accesses spanning preferred align size into two accesses - an unaligned and an aligned access. This is meant to be used for card quirks, and is off by default. Change-Id: Ic4ce561a4a72a13f34d1a88ad669f98e3c7b9d90 Signed-off-by: Andrei Warkentin andr...@motorola.com ---

Re: MMC quirks relating to performance/lifetime.

2011-03-01 Thread Andrei Warkentin
On Tue, Mar 1, 2011 at 1:51 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 01 March 2011 20:15:30 Jens Axboe wrote: Thanks for the recap. One way to handle this would be to have a dm target that ensures that requests are never built up to violate any of the above items. Doing splitting is a

[RFC 2/3] MMC: Add block quirks support.

2011-03-01 Thread Andrei Warkentin
Quirks are card-specific workarounds. Usually they involve tuning mmcblk parameters at mmc_blk_probe time, but can involve affecting the way mmcblk I/O requests are handled. The later is necessary to handle Sandisk out-of-spec discard support, and the small-writes reliability workaround for

MMC block quirk support + Toshiba performance quirk

2011-03-01 Thread Andrei Warkentin
This patch set is meant for as a review for comments, and is the result of the discussion on MMC quirks. Sorry ahead of time if I didn't format this correctly. It's my first tiem with git mail-send :-). For 1/3: Arnd suggested setting the default write alignment to adjust on to be 32K. Since I

Re: [linux-pm] [RFC,PATCHv3 0/3] sdhci runtime_pm implementation

2011-03-01 Thread Rafael J. Wysocki
On Wednesday, March 02, 2011, Pierre Tardy wrote: On Tue, Mar 1, 2011 at 10:07 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Tuesday, March 01, 2011, Pierre Tardy wrote: On Tue, Mar 1, 2011 at 8:33 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 1 Mar 2011, Pierre Tardy wrote:

Re: [PATCH V4 1/4] ARM: imx53_loco: add esdhc device support

2011-03-01 Thread Fabio Estevam
On Tue, Mar 1, 2011 at 6:58 AM, Richard Zhu hong-xing@freescale.com wrote: Signed-off-by: Richard Zhao richard.z...@freescale.com Acked-by: Wolfram Sang w.s...@pengutronix.de ---  arch/arm/mach-mx5/Kconfig           |    1 +  arch/arm/mach-mx5/board-mx53_loco.c |    2 ++  2 files

Re: [RFC] dw_mmc: didn't support multiple blocks of weird length?

2011-03-01 Thread Jaehoon Chung
Will Newton wrote: On Mon, Feb 28, 2011 at 10:55 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Will Newton wrote: On Mon, Feb 28, 2011 at 2:44 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Right...maybe not problem merging those two functions. But think not use

Re: [PATCH] mmc: dw_mmc: Remove set-but-unused variable.

2011-03-01 Thread Jaehoon Chung
Acked-by: Jaehoon Chung jh80.ch...@samsung.com Will Newton wrote: On Mon, Feb 28, 2011 at 9:55 PM, Chris Ball c...@laptop.org wrote: count is only ever used by assigning to old_len if count == 0, and then old_len isn't ever used at all. So, both are redundant. Fixes:

RE: [PATCH V3 4/4] mmc: sdhci-esdhc: enable esdhc on imx53

2011-03-01 Thread Zhu Richard-R65037
Hi Wolfram: Best Regards Richard Zhu -Original Message- From: Wolfram Sang [mailto:w.s...@pengutronix.de] Sent: Tuesday, March 01, 2011 7:31 PM To: Zhu Richard-R65037 Cc: linux-arm-ker...@lists.infradead.org; ker...@pengutronix.de; linux- m...@vger.kernel.org; c...@laptop.org;