Re: [PATCH 2/5] mmc: tmio: add a flag to prohibit access to registers above 0xff

2011-03-08 Thread Paul Mundt
On Mon, Mar 07, 2011 at 07:47:51PM +0100, Guennadi Liakhovetski wrote: On some implementations there are no registers above 0xff and any access to them mirrors to registers at addresses with bit 8 masked out, which leads to malfunction. Add a flag to prevent such accesses. I'm not sure I

Re: [PATCH 0/5] tmio PM: aggressive clock gating, register layout limitation

2011-03-08 Thread Paul Mundt
On Mon, Mar 07, 2011 at 07:47:45PM +0100, Guennadi Liakhovetski wrote: 5 more patches, that fix high register access on sh-mobile in a correct way and implement aggressive clock gating. Marked as RFC because testing on non-SDHI platforms is required! The next step would be to add runtime-pm

Re: [PATCH 0/5] tmio PM: aggressive clock gating, register layout limitation

2011-03-08 Thread Guennadi Liakhovetski
On Tue, 8 Mar 2011, Paul Mundt wrote: On Mon, Mar 07, 2011 at 07:47:45PM +0100, Guennadi Liakhovetski wrote: 5 more patches, that fix high register access on sh-mobile in a correct way and implement aggressive clock gating. Marked as RFC because testing on non-SDHI platforms is required!

RE: [[RFC] 2/5] MMC: Add block quirks support.

2011-03-08 Thread Tardy, Pierre
I took a look at quirks.c in linux-next. It's a bit sdio-specific... I would extend mmc_fixup to contain card type (to know if cis vendor/device should be checked) as well as name/manfid/oemid and rev id (which is just a combination of hwrev, fwrev and date). Feel free to change mmc_fixup.

Re: MMC quirks relating to performance/lifetime.

2011-03-08 Thread Arnd Bergmann
On Tuesday 08 March 2011, Pavel Machek wrote: How big is performance difference? Several orders of magnitude. It is very easy to get a card that can write 12 MB/s into a case where it writes no more than 30 KB/s, doing only things that happen frequently with ext3. Ungood. I

Re: [[RFC] 2/5] MMC: Add block quirks support.

2011-03-08 Thread Arnd Bergmann
On Monday 07 March 2011, Andrei Warkentin wrote: I took a look at quirks.c in linux-next. It's a bit sdio-specific... I would extend mmc_fixup to contain card type (to know if cis vendor/device should be checked) as well as name/manfid/oemid and rev id (which is just a combination of hwrev,

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-08 Thread Ohad Ben-Cohen
On Mon, Mar 7, 2011 at 9:01 PM, Dmitry Shmidt dimitr...@google.com wrote: On Sat, Mar 5, 2011 at 7:03 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Fri, Mar 4, 2011 at 4:22 AM, Maxim Levitsky maximlevit...@gmail.com wrote: This patch breaks the CONFIG_MMC_UNSAFE_RESUME Does the below work

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-08 Thread Maxim Levitsky
On Tue, 2011-03-08 at 18:44 +0200, Ohad Ben-Cohen wrote: On Mon, Mar 7, 2011 at 9:01 PM, Dmitry Shmidt dimitr...@google.com wrote: On Sat, Mar 5, 2011 at 7:03 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Fri, Mar 4, 2011 at 4:22 AM, Maxim Levitsky maximlevit...@gmail.com wrote: This

Re: [PATCH] mmc: export function mmc_do_release_host

2011-03-08 Thread Linus Walleij
2011/3/5 Linus Walleij linus.wall...@stericsson.com: From: Ulf Hansson ulf.hans...@stericsson.com When using mmc_try_claim_host the corresponding release function is mmc_do_release_host, which then also must be exported. Is this one OK Chris? Not much said about it but looks harmless to

Re: [PATCH] mmc: reset card voltage after power off

2011-03-08 Thread Linus Walleij
2011/3/5 Linus Walleij linus.wall...@stericsson.com: From: Ulf Hansson ulf.hans...@stericsson.com At power off, reset OCR mask to be the highest possible voltage supported for the current mmc host. Any comments on this? Can we merge it? Yours, Linus Walleij -- To unsubscribe from this list:

Re: [PATCH] mmc: export function mmc_do_release_host

2011-03-08 Thread Chris Ball
Hi Linus, On Tue, Mar 08 2011, Linus Walleij wrote: 2011/3/5 Linus Walleij linus.wall...@stericsson.com: From: Ulf Hansson ulf.hans...@stericsson.com When using mmc_try_claim_host the corresponding release function is mmc_do_release_host, which then also must be exported. Is this one OK

Re: [PATCH] mmc: export function mmc_do_release_host

2011-03-08 Thread Chris Ball
Hi, On Sat, Mar 05 2011, Linus Walleij wrote: From: Ulf Hansson ulf.hans...@stericsson.com When using mmc_try_claim_host the corresponding release function is mmc_do_release_host, which then also must be exported. Reviewed-by: Jonas Aberg jonas.ab...@stericsson.com Reviewed-by: Sebastian

Re: [PATCH resend] sdhci: work around broken dma boundary behaviour

2011-03-08 Thread Chris Ball
Hi Mikko, On Mon, Mar 07 2011, Mikko Vinni wrote: Some SD host controllers (noticed on an integrated JMicron SD reader on an HP Pavilion dv5-1250eo laptop) don't update the dma address register before signaling a dma interrupt due to a dma boundary. Detect this and update the register to the

Re: [[RFC] 2/5] MMC: Add block quirks support.

2011-03-08 Thread Andrei Warkentin
On Tue, Mar 8, 2011 at 8:42 AM, Arnd Bergmann a...@arndb.de wrote: I'm still not comfortable with having the blk_adjust method. I think it would be much better to encode that behavior in an abstract way in the block driver and set a flag to enable it in the quirks file. Ok, will encode the

Re: [[RFC] 2/5] MMC: Add block quirks support.

2011-03-08 Thread Linus Walleij
2011/3/7 Andrei Warkentin andr...@motorola.com: The other real issue I see is that it's kind of nasty to put block-related workarounds into core/quirks.c. The later seems more of generic card interface workarounds, rather than workarounds for specific functionality. It would be like putting

Re: [[RFC] 2/5] MMC: Add block quirks support.

2011-03-08 Thread Andrei Warkentin
On Tue, Mar 8, 2011 at 2:28 PM, Linus Walleij linus.wall...@linaro.org wrote: 2011/3/7 Andrei Warkentin andr...@motorola.com: The other real issue I see is that it's kind of nasty to put block-related workarounds into core/quirks.c. The later seems more of generic card interface workarounds,

Re: [[RFC] 2/5] MMC: Add block quirks support.

2011-03-08 Thread Andrei Warkentin
On Tue, Mar 8, 2011 at 2:34 PM, Andrei Warkentin andr...@motorola.com wrote: On Tue, Mar 8, 2011 at 2:28 PM, Linus Walleij linus.wall...@linaro.org wrote: 2011/3/7 Andrei Warkentin andr...@motorola.com: The other real issue I see is that it's kind of nasty to put block-related workarounds

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-08 Thread Ohad Ben-Cohen
On Tue, Mar 8, 2011 at 7:02 PM, Maxim Levitsky maximlevit...@gmail.com wrote: Maxim, does this work for you too ? Yep, just tested. Thanks -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] mmc: fix CONFIG_MMC_UNSAFE_RESUME regression

2011-03-08 Thread Ohad Ben-Cohen
30201e7 allowed skipping detection of nonremovable cards on mmc_rescan(). The intention was to only skip detection of hardwired cards that cannot be removed, so make sure this is indeed the case by directly checking for (lack of) MMC_CAP_NONREMOVABLE, instead of using mmc_card_is_removable(),

[PATCH] SDHCI: Suspend/Resume needs to save/restore INT_ENABLE on ARM/Tegra2

2011-03-08 Thread Grant Grundler
Save and restore SDHCI interrupt mask during suspend/resume. Enables ARM Tegra2 board to suspend/resume. Signed-off-by: Venkat Rao v...@broadcom.com Reviewed-by: Olof Johansson ol...@chromium.org Reviewed-by: Grant Grundler grund...@chromium.org --- drivers/mmc/host/sdhci.c |5 +

Re: [PATCH] mmc: fix CONFIG_MMC_UNSAFE_RESUME regression

2011-03-08 Thread Chris Ball
Hi Ohad, On Tue, Mar 08 2011, Ohad Ben-Cohen wrote: 30201e7 allowed skipping detection of nonremovable cards on mmc_rescan(). The intention was to only skip detection of hardwired cards that cannot be removed, so make sure this is indeed the case by directly checking for (lack of)

Re: [PATCH resend] sdhci: work around broken dma boundary behaviour

2011-03-08 Thread Wolfram Sang
Thanks, I agree, pushed to -next for testing. I'd still appreciate a Reviewed-by: from someone on linux-mmc@, and would like to hear if anyone thinks this needs to be a quirk rather than a generic fix. Not surprisingly, I prefer the generic fix over a quirk ;) It seems to not cost much

Re: [PATCH] mmc: fix CONFIG_MMC_UNSAFE_RESUME regression

2011-03-08 Thread Ohad Ben-Cohen
On Tue, Mar 8, 2011 at 11:56 PM, Chris Ball c...@laptop.org wrote: I have removed the stable@ tag, because the patch causing this regression was introduced in .38-rc1 -- it has not been part of any released kernel.  So, as long as we fix it before .38 releases in a week, there's no need to

Re: [PATCH v2 04/12] mmc: sd: add support for driver type selection

2011-03-08 Thread Philip Rakity
On Mar 4, 2011, at 3:32 AM, Arindam Nath wrote: This patch adds support for setting driver strength during UHS-I initialization prcedure. Since UHS-I cards set S18A (bit 24) in response to ACMD41, we use this as a base for UHS-I initialization. We modify the parameter list of