RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread Nath, Arindam
Hi Zhangfei, > -Original Message- > From: zhangfei gao [mailto:zhangfei@gmail.com] > Sent: Wednesday, March 16, 2011 8:33 AM > To: Subhash Jadavani; Nath, Arindam > Cc: c...@laptop.org; prak...@marvell.com; linux-mmc@vger.kernel.org; Su, > Henry; Lu, Aaron; anath@gmail.com > Subje

RE: [PATCH v2 09/12] mmc: sd: add support for tuning during uhs initialization

2011-03-15 Thread Nath, Arindam
Hi Zhangfei, > -Original Message- > From: zhangfei gao [mailto:zhangfei@gmail.com] > Sent: Wednesday, March 16, 2011 8:21 AM > To: Nath, Arindam > Cc: c...@laptop.org; prak...@marvell.com; subha...@codeaurora.org; > linux-mmc@vger.kernel.org; Su, Henry; Lu, Aaron; anath@gmail.com

RE: [PATCH v2 01/12] mmc: sdhci: add support for auto CMD23

2011-03-15 Thread Nath, Arindam
Hi Subhash, > -Original Message- > From: Subhash Jadavani [mailto:subha...@codeaurora.org] > Sent: Tuesday, March 15, 2011 5:23 PM > To: Nath, Arindam; c...@laptop.org > Cc: zhangfei@gmail.com; prak...@marvell.com; linux- > m...@vger.kernel.org; Su, Henry; Lu, Aaron; anath@gmail.c

Re: [PATCH 4/4 v4] mmc, ARM: Add zboot from eSD support for SuperH Mobile ARM

2011-03-15 Thread Simon Horman
On Wed, Mar 16, 2011 at 02:26:05PM +0900, Magnus Damm wrote: > On Wed, Mar 16, 2011 at 2:16 PM, Simon Horman wrote: > > On Wed, Mar 16, 2011 at 11:20:46AM +0900, Magnus Damm wrote: > >> On Wed, Mar 16, 2011 at 10:14 AM, Simon Horman wrote: > >> > How do you envisage that the hardware block would

Re: [PATCH 4/4 v4] mmc, ARM: Add zboot from eSD support for SuperH Mobile ARM

2011-03-15 Thread Magnus Damm
On Wed, Mar 16, 2011 at 2:16 PM, Simon Horman wrote: > On Wed, Mar 16, 2011 at 11:20:46AM +0900, Magnus Damm wrote: >> On Wed, Mar 16, 2011 at 10:14 AM, Simon Horman wrote: >> > How do you envisage that the hardware block would be selected? >> > At compile time through Kconfig? If so the current

Re: [PATCH 4/4 v4] mmc, ARM: Add zboot from eSD support for SuperH Mobile ARM

2011-03-15 Thread Simon Horman
On Wed, Mar 16, 2011 at 11:20:46AM +0900, Magnus Damm wrote: > On Wed, Mar 16, 2011 at 10:14 AM, Simon Horman wrote: > > On Wed, Mar 16, 2011 at 09:37:50AM +0900, Magnus Damm wrote: [snip] > >> Not sure if it makes sense at this point, but perhaps it's a good idea > >> to move the mmc_loader() f

Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread zhangfei gao
On Tue, Mar 15, 2011 at 7:58 AM, Subhash Jadavani wrote: > > >> -Original Message- >> From: Nath, Arindam [mailto:arindam.n...@amd.com] >> Sent: Tuesday, March 15, 2011 4:59 PM >> To: Subhash Jadavani; c...@laptop.org >> Cc: zhangfei@gmail.com; prak...@marvell.com; linux- >> m...@vger.

Re: [PATCH v2 09/12] mmc: sd: add support for tuning during uhs initialization

2011-03-15 Thread zhangfei gao
On Tue, Mar 15, 2011 at 6:43 AM, Nath, Arindam wrote: > Hi Zhangfei, > > >> -Original Message- >> From: zhangfei gao [mailto:zhangfei@gmail.com] >> Sent: Tuesday, March 15, 2011 4:02 PM >> To: Nath, Arindam >> Cc: c...@laptop.org; prak...@marvell.com; subha...@codeaurora.org; >> linux-

Re: [PATCH 4/4 v4] mmc, ARM: Add zboot from eSD support for SuperH Mobile ARM

2011-03-15 Thread Magnus Damm
On Wed, Mar 16, 2011 at 10:14 AM, Simon Horman wrote: > On Wed, Mar 16, 2011 at 09:37:50AM +0900, Magnus Damm wrote: >> On Wed, Mar 16, 2011 at 7:27 AM, Simon Horman wrote: >> > This allows a ROM-able zImage to be written to eSD and for SuperH Mobile >> > ARM to boot directly from the SDHI hardwa

Re: [PATCH 4/4 v4] mmc, ARM: Add zboot from eSD support for SuperH Mobile ARM

2011-03-15 Thread Simon Horman
Hi Magnus, On Wed, Mar 16, 2011 at 09:37:50AM +0900, Magnus Damm wrote: > Hi Simon, > > Thanks for your work on this! [ snip ] > > On Wed, Mar 16, 2011 at 7:27 AM, Simon Horman wrote: > > This allows a ROM-able zImage to be written to eSD and for SuperH Mobile > > ARM to boot directly from th

Re: [PATCH 4/4 v4] mmc, ARM: Add zboot from eSD support for SuperH Mobile ARM

2011-03-15 Thread Magnus Damm
Hi Simon, Thanks for your work on this! On Wed, Mar 16, 2011 at 7:27 AM, Simon Horman wrote: > This allows a ROM-able zImage to be written to eSD and for SuperH Mobile > ARM to boot directly from the SDHI hardware block. > > This is achieved by the MaskROM loading the first portion of the image

Re: [PATCH 4/4 v4] mmc, ARM: Add zboot from eSD support for SuperH Mobile ARM

2011-03-15 Thread Simon Horman
This allows a ROM-able zImage to be written to eSD and for SuperH Mobile ARM to boot directly from the SDHI hardware block. This is achieved by the MaskROM loading the first portion of the image into MERAM and then jumping to it. This portion contains loader code which copies the entire image to

Re: [PATCH 0/6] mmc: split the tmio driver into several modules

2011-03-15 Thread Ian Molton
Sounds like a good idea... Its possible that I could implement DMA on the toshiba stuff too, can your code handle this? (I havent had time to read this yet) -- Ian Molton Linux, Automotive, and other hacking: http://www.mnementh.co.uk/ On 11 March 2011 07:51, Guennadi Liakhovetski wrote: > H

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-03-15 Thread Tony Olech
see embedded answers:- On Tue, 2011-03-15 at 17:23 +0100, Arnd Bergmann wrote: > On Thursday 10 March 2011, Tony Olech wrote: > > Add a driver for Elan Digital System's VUB300 chip > > which is a USB connected SDIO/SDmem/MMC host controller. > > A VUB300 chip enables a USB 2.0 or USB 1.1 connect

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-03-15 Thread Arnd Bergmann
On Thursday 10 March 2011, Tony Olech wrote: > Add a driver for Elan Digital System's VUB300 chip > which is a USB connected SDIO/SDmem/MMC host controller. > A VUB300 chip enables a USB 2.0 or USB 1.1 connected host > computer to use SDIO/SD/MMC cards without the need for > a directly connected,

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-03-15 Thread Arnd Bergmann
On Tuesday 15 March 2011, Chris Ball wrote: > I thought about it, but I think staging drivers generally have a much > larger TODO list than this one would. > > Perhaps a good plan is: I'll push it to mmc-next after the 2.6.39 merge, > then I'll try to work on style changes a bit (I'll send each p

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-03-15 Thread Chris Ball
Hi Wolfram, On Tue, Mar 15 2011, Wolfram Sang wrote: >> I'm leaning towards merging it as-is and then >> working on incremental fixes; please yell if that sounds like a bad idea. > > What about staging? From my all overall impression, the driver would fit > there. > Also, there are more people lu

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread Subhash Jadavani
> -Original Message- > From: Nath, Arindam [mailto:arindam.n...@amd.com] > Sent: Tuesday, March 15, 2011 4:59 PM > To: Subhash Jadavani; c...@laptop.org > Cc: zhangfei@gmail.com; prak...@marvell.com; linux- > m...@vger.kernel.org; Su, Henry; Lu, Aaron; anath@gmail.com > Subject: R

RE: [PATCH v2 01/12] mmc: sdhci: add support for auto CMD23

2011-03-15 Thread Subhash Jadavani
> -Original Message- > From: Nath, Arindam [mailto:arindam.n...@amd.com] > Sent: Tuesday, March 15, 2011 5:05 PM > To: Subhash Jadavani; c...@laptop.org > Cc: zhangfei@gmail.com; prak...@marvell.com; linux- > m...@vger.kernel.org; Su, Henry; Lu, Aaron; anath@gmail.com > Subject: R

RE: [PATCH v2 01/12] mmc: sdhci: add support for auto CMD23

2011-03-15 Thread Nath, Arindam
Hi Subhash, > -Original Message- > From: Subhash Jadavani [mailto:subha...@codeaurora.org] > Sent: Tuesday, March 15, 2011 4:54 PM > To: Nath, Arindam; c...@laptop.org > Cc: zhangfei@gmail.com; prak...@marvell.com; linux- > m...@vger.kernel.org; Su, Henry; Lu, Aaron; anath@gmail.c

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread Nath, Arindam
Hi Subhash, > -Original Message- > From: Subhash Jadavani [mailto:subha...@codeaurora.org] > Sent: Tuesday, March 15, 2011 4:49 PM > To: Nath, Arindam; c...@laptop.org > Cc: zhangfei@gmail.com; prak...@marvell.com; linux- > m...@vger.kernel.org; Su, Henry; Lu, Aaron; anath@gmail.c

RE: [PATCH v2 01/12] mmc: sdhci: add support for auto CMD23

2011-03-15 Thread Subhash Jadavani
Arindam, Capability to send CMD23 automatically is something specific to your controller. CMD23 (SET_BLOCK_COUNT) is a new command added in SD3.0 spec and mandatory for SDR104 mode. Why are you not adding this command in core/block layer before sending multi byte read command to host controller dr

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread Subhash Jadavani
> -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Nath, Arindam > Sent: Tuesday, March 15, 2011 4:03 PM > To: Subhash Jadavani; c...@laptop.org > Cc: zhangfei@gmail.com; prak...@marvell.com; linux- > m...@vger.kernel.

RE: [PATCH v2 09/12] mmc: sd: add support for tuning during uhs initialization

2011-03-15 Thread Nath, Arindam
Hi Zhangfei, > -Original Message- > From: zhangfei gao [mailto:zhangfei@gmail.com] > Sent: Tuesday, March 15, 2011 4:02 PM > To: Nath, Arindam > Cc: c...@laptop.org; prak...@marvell.com; subha...@codeaurora.org; > linux-mmc@vger.kernel.org; Su, Henry; Lu, Aaron; anath@gmail.com >

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread Nath, Arindam
Hi Subhash, > -Original Message- > From: Subhash Jadavani [mailto:subha...@codeaurora.org] > Sent: Tuesday, March 15, 2011 3:48 PM > To: Nath, Arindam; c...@laptop.org > Cc: zhangfei@gmail.com; prak...@marvell.com; linux- > m...@vger.kernel.org; Su, Henry; Lu, Aaron; anath@gmail.c

Re: [PATCH v2 09/12] mmc: sd: add support for tuning during uhs initialization

2011-03-15 Thread zhangfei gao
On Fri, Mar 4, 2011 at 6:32 AM, Arindam Nath wrote: > Host Controller needs tuning during initialization to operate SDR50 > and SDR104 UHS-I cards. Whether SDR50 mode actually needs tuning is > indicated by bit 45 of the Host Controller Capabilities register. > A new command CMD19 has been defined

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread Subhash Jadavani
Arindam, During voltage switch, voltage level for CLK, DATA and CMD pads/pins should be changed from 3.3v to 1.8v. for this SD controller has to modify few bits in their controller registers and also have to set the voltage level of a regulator which is powering those pad/pins. Now with you curre

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-03-15 Thread Wolfram Sang
Hi, > linux-mmc@ folks, any strong opinions on this driver? My impression is > that it looks reasonable, but has some areas of being pretty far from > standard CodingStyle. I totally agree (sadly it is hard to review because of its size) and I am still not convinced of the sysfs-entry. Then agai

Re: [PATCH 3/6] mmc: tmio: convert the SDHI MMC driver from MFD to a standard platform driver

2011-03-15 Thread Magnus Damm
On Mon, Mar 14, 2011 at 5:01 PM, Guennadi Liakhovetski wrote: > On Sun, 13 Mar 2011, Magnus Damm wrote: >> On Fri, Mar 11, 2011 at 4:52 PM, Guennadi Liakhovetski >> wrote: >> > On sh-mobile platforms the SDHI driver was using the tmio_mmc SD/SDIO >> > MFD cell driver. Now that the tmio_mmc driver

Re: [PATCH 1/6] mmc: tmio: split core functionality, DMA and MFD glue

2011-03-15 Thread Magnus Damm
On Mon, Mar 14, 2011 at 7:51 AM, Guennadi Liakhovetski wrote: > On Sun, 13 Mar 2011, Magnus Damm wrote: >> On Sun, Mar 13, 2011 at 7:48 AM, Guennadi Liakhovetski >> wrote: >> > On Sun, 13 Mar 2011, Magnus Damm wrote: >> >> On Fri, Mar 11, 2011 at 4:51 PM, Guennadi Liakhovetski >> >> wrote: >> >>

Re: Memory replacement

2011-03-15 Thread Arnd Bergmann
On Tuesday 15 March 2011 01:29:19 John Watlington wrote: > On Mar 14, 2011, at 3:18 PM, Arnd Bergmann wrote: > > > Another effect is that the page size has increased by a factor of 8, > > from 2 or 4 KB to 16 or 32 KB. Writing data that as smaller than > > a page is more likely to get you into the

Re: [PATCH V1] mx51 enchance the sd/mmc HW timing compatibility on mx51 boards.

2011-03-15 Thread Sascha Hauer
On Tue, Mar 15, 2011 at 11:30:04AM +0800, Richard Zhu wrote: > Some cards have the CRC errors in read on mx51 BBG board. > Configure the eSDHC pad configurations to level up the > compatibility to fix this issue. This one is already applied. Sascha -- Pengutronix e.K.

Re: [PATCH] [rfc] mmc, ARM: Add zboot from eSD support for SuperH Mobile ARM

2011-03-15 Thread Magnus Damm
Hi Simon, On Mon, Mar 14, 2011 at 10:28 AM, Simon Horman wrote: > Hi Magnus, > > are the following also sh7372 specific? > > #define SDHI1_BASE              (void __iomem *)0xe686 > #define SDHI_BASE                SDHI1_BASE Yes, you want to specify the base address of the SDHI hardware blo