Re: [PATCH 1/5] mmc: tmio: Cache interrupt masks

2011-08-16 Thread Guennadi Liakhovetski
On Tue, 16 Aug 2011, Simon Horman wrote: This avoids the need to look up the masks each time an interrupt is handled. Yes, almost... But I think, we can use the mask-caches even more extensively. In your patch you actually hardly gain anything, you continue reading the mask register instead

Re: [PATCH 2/5] mmc: tmio: Provide separate interrupt handlers

2011-08-16 Thread Guennadi Liakhovetski
On Tue, 16 Aug 2011, Simon Horman wrote: Provide separate interrupt handlers which may be used by platforms where SDHI has three interrupt sources. Yes, this looks much simpler and cleaner to me now, than 3 original patches. It might change a bit after you change your PATCH 1/5, This

Re: [PATCH 3/5] mmc: sdhi: Add defines for platform irq indexes

2011-08-16 Thread Guennadi Liakhovetski
On Tue, 16 Aug 2011, Simon Horman wrote: This is intended to make it easier to correctly order platform defines in platform data and the logic that uses them. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm magnus.d...@gmail.com Cc: Paul Mundt let...@linux-sh.org

Re: [PATCH 2/5] mmc: tmio: Provide separate interrupt handlers

2011-08-16 Thread Simon Horman
On Tue, Aug 16, 2011 at 09:41:52AM +0200, Guennadi Liakhovetski wrote: On Tue, 16 Aug 2011, Simon Horman wrote: Provide separate interrupt handlers which may be used by platforms where SDHI has three interrupt sources. Yes, this looks much simpler and cleaner to me now, than 3 original

Re: [PATCH 3/5] mmc: sdhi: Add defines for platform irq indexes

2011-08-16 Thread Simon Horman
On Tue, Aug 16, 2011 at 09:51:00AM +0200, Guennadi Liakhovetski wrote: On Tue, 16 Aug 2011, Simon Horman wrote: This is intended to make it easier to correctly order platform defines in platform data and the logic that uses them. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc:

Re: [PATCH 1/5] mmc: tmio: Cache interrupt masks

2011-08-16 Thread Simon Horman
On Tue, Aug 16, 2011 at 09:19:12AM +0200, Guennadi Liakhovetski wrote: On Tue, 16 Aug 2011, Simon Horman wrote: This avoids the need to look up the masks each time an interrupt is handled. Yes, almost... But I think, we can use the mask-caches even more extensively. In your patch you

Re: [PATCH 4/5] mmc: sdhi: Make use of per-source irq handlers

2011-08-16 Thread Guennadi Liakhovetski
On Tue, 16 Aug 2011, Simon Horman wrote: Make use of per-source irq handles if the platform (data) has multiple irq sources. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm magnus.d...@gmail.com Signed-off-by: Simon Horman ho...@verge.net.au ---

Re: [PATCH 3/5] mmc: sdhi: Add defines for platform irq indexes

2011-08-16 Thread Guennadi Liakhovetski
On Tue, 16 Aug 2011, Simon Horman wrote: On Tue, Aug 16, 2011 at 09:51:00AM +0200, Guennadi Liakhovetski wrote: On Tue, 16 Aug 2011, Simon Horman wrote: This is intended to make it easier to correctly order platform defines in platform data and the logic that uses them. Cc:

Re: Testing Infrastructure for SD/MMC Commands

2011-08-16 Thread Shashidhar Hiremath
adding mmc mailing list On Tue, Aug 16, 2011 at 11:12 AM, Shashidhar Hiremath shashidh...@vayavyalabs.com wrote: Hi All,  i am planning to come up with a module that would help for testing the SD/MMC controller to see if supports the particular command. For example ,Through this module , we

[PATCH 0/4 v3] mmc: tmio, sdhi: provide multiple irq handlers

2011-08-16 Thread Simon Horman
The SDHI driver already supports making use of up to three interrupt sources. This series breaks up the existing interrupt handler into three handlers, one for card access, one for card detect interrupts, and one for SDIO interrupts. A cover-all handler, which makes use of these new broken-out

[PATCH 1/4] mmc: tmio: Cache interrupt masks

2011-08-16 Thread Simon Horman
This avoids the need to look up the masks each time an interrupt is handled. As suggested by Guennadi. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm magnus.d...@gmail.com Signed-off-by: Simon Horman ho...@verge.net.au --- * SDCARD portion tested on AP4/Mackerel * SDIO portion

[PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-16 Thread Simon Horman
This is intended to make it easier to correctly order IRQs. As suggested by Guennadi Liakhovetski. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm magnus.d...@gmail.com Signed-off-by: Simon Horman ho...@verge.net.au --- Depends on mmc: sdhi: Make use of per-source irq handlers

[PATCH 2/4] mmc: tmio: Provide separate interrupt handlers

2011-08-16 Thread Simon Horman
Provide separate interrupt handlers which may be used by platforms where SDHI has three interrupt sources. This patch also removes the commented-out handling of CRC and other errors. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm magnus.d...@gmail.com Signed-off-by: Simon Horman

[PATCH 3/4] mmc: sdhi: Make use of per-source irq handlers

2011-08-16 Thread Simon Horman
Make use of per-source irq handles if the platform (data) has multiple irq sources. Also, as suggested by Guennadi Liakhovetski, add and use defines the index or irqs in platform data. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm magnus.d...@gmail.com Signed-off-by: Simon

Re: [PATCH 3/5] mmc: sdhi: Add defines for platform irq indexes

2011-08-16 Thread Simon Horman
On Tue, Aug 16, 2011 at 10:34:22AM +0200, Guennadi Liakhovetski wrote: On Tue, 16 Aug 2011, Simon Horman wrote: On Tue, Aug 16, 2011 at 09:51:00AM +0200, Guennadi Liakhovetski wrote: On Tue, 16 Aug 2011, Simon Horman wrote: This is intended to make it easier to correctly order

Re: [PATCH 3/4] mmc: sdhi: Make use of per-source irq handlers

2011-08-16 Thread Guennadi Liakhovetski
On Tue, 16 Aug 2011, Simon Horman wrote: Make use of per-source irq handles if the platform (data) has multiple irq sources. Also, as suggested by Guennadi Liakhovetski, add and use defines the index or irqs in platform data. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus

Re: [PATCH 2/5] mmc: tmio: Provide separate interrupt handlers

2011-08-16 Thread Guennadi Liakhovetski
On Tue, 16 Aug 2011, Simon Horman wrote: On Tue, Aug 16, 2011 at 09:41:52AM +0200, Guennadi Liakhovetski wrote: On Tue, 16 Aug 2011, Simon Horman wrote: [snip] +irqreturn_t tmio_mmc_irq(int irq, void *devid) +{ + struct tmio_mmc_host *host = devid; + unsigned int ireg, status;

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-16 Thread Ben Dooks
On Tue, Aug 16, 2011 at 07:11:26PM +0900, Simon Horman wrote: This is intended to make it easier to correctly order IRQs. As suggested by Guennadi Liakhovetski. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm magnus.d...@gmail.com Signed-off-by: Simon Horman

Re: [PATCH 2/4] mmc: tmio: Provide separate interrupt handlers

2011-08-16 Thread Simon Horman
On Tue, Aug 16, 2011 at 01:14:01PM +0200, Guennadi Liakhovetski wrote: On Tue, 16 Aug 2011, Simon Horman wrote: Provide separate interrupt handlers which may be used by platforms where SDHI has three interrupt sources. This patch also removes the commented-out handling of CRC and other

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-16 Thread Simon Horman
On Tue, Aug 16, 2011 at 12:13:50PM +0100, Ben Dooks wrote: On Tue, Aug 16, 2011 at 07:11:26PM +0900, Simon Horman wrote: This is intended to make it easier to correctly order IRQs. As suggested by Guennadi Liakhovetski. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm

Re: [PATCH 2/5] mmc: tmio: Provide separate interrupt handlers

2011-08-16 Thread Simon Horman
On Tue, Aug 16, 2011 at 01:13:06PM +0200, Guennadi Liakhovetski wrote: On Tue, 16 Aug 2011, Simon Horman wrote: On Tue, Aug 16, 2011 at 09:41:52AM +0200, Guennadi Liakhovetski wrote: On Tue, 16 Aug 2011, Simon Horman wrote: [snip] +irqreturn_t tmio_mmc_irq(int irq, void *devid)

Re: [PATCH 3/4] mmc: sdhi: Make use of per-source irq handlers

2011-08-16 Thread Simon Horman
On Tue, Aug 16, 2011 at 01:11:42PM +0200, Guennadi Liakhovetski wrote: On Tue, 16 Aug 2011, Simon Horman wrote: Make use of per-source irq handles if the platform (data) has multiple irq sources. Also, as suggested by Guennadi Liakhovetski, add and use defines the index or irqs in

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-16 Thread Simon Horman
On Tue, Aug 16, 2011 at 08:36:20PM +0900, Simon Horman wrote: On Tue, Aug 16, 2011 at 12:13:50PM +0100, Ben Dooks wrote: On Tue, Aug 16, 2011 at 07:11:26PM +0900, Simon Horman wrote: This is intended to make it easier to correctly order IRQs. As suggested by Guennadi Liakhovetski.

Re: [PATCH 3/4] mmc: sdhi: Make use of per-source irq handlers

2011-08-16 Thread Simon Horman
On Tue, Aug 16, 2011 at 02:40:25PM +0200, Guennadi Liakhovetski wrote: On Tue, 16 Aug 2011, Simon Horman wrote: On Tue, Aug 16, 2011 at 01:11:42PM +0200, Guennadi Liakhovetski wrote: On Tue, 16 Aug 2011, Simon Horman wrote: [snip] Sorry, I still don't understand why you check

[GIT PULL] mmc: atmel rework for next

2011-08-16 Thread Nicolas Ferre
Hi Chris, Please pull from: git://github.com/at91linux/linux-2.6-at91.git nfe/mmc_atmel This is a series that reworks the atmel-mci driver for a future merge of both at91_mci and atmel-mci drivers. Those patches have been discussed on the mailing-list. I added a tiny at91_mci patch also sent

Re: Testing Infrastructure for SD/MMC Commands

2011-08-16 Thread J Freyensee
On 08/16/2011 02:26 AM, Shashidhar Hiremath wrote: adding mmc mailing list On Tue, Aug 16, 2011 at 11:12 AM, Shashidhar Hiremath shashidh...@vayavyalabs.com wrote: Hi All, i am planning to come up with a module that would help for testing the SD/MMC controller to see if supports the

Re: Testing Infrastructure for SD/MMC Commands

2011-08-16 Thread Chris Ball
Hi Shashidhar, On Tue, Aug 16 2011, Shashidhar Hiremath wrote: i am planning to come up with a module that would help for testing the SD/MMC controller to see if supports the particular command. For example ,Through this module , we will be able to see if a particular command has been

Re: [RFC PATCH] mmc: support background operation

2011-08-16 Thread J Freyensee
On 08/12/2011 04:14 AM, Jaehoon Chung wrote: Hi mailing. This RFC patch is supported background operation(BKOPS). And if you want to test this patch, must apply [PATCH v3] mmc: support HPI send command This patch is based on Hanumath Prasad's patch mmc: enable background operations for

Re: [RFC PATCH] mmc: support background operation

2011-08-16 Thread Chris Ball
Hi, On Tue, Aug 16 2011, J Freyensee wrote: On 08/12/2011 04:14 AM, Jaehoon Chung wrote: Hi mailing. This RFC patch is supported background operation(BKOPS). And if you want to test this patch, must apply [PATCH v3] mmc: support HPI send command This patch is based on Hanumath Prasad's

[PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-16 Thread Simon Horman
This is intended to make it easier to correctly order IRQs. As suggested by Guennadi Liakhovetski. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm magnus.d...@gmail.com Cc: Paul Mundt let...@linux-sh.org Signed-off-by: Simon Horman ho...@verge.net.au --- Depends on mmc: sdhi:

[PATCH 2/4] mmc: tmio: Provide separate interrupt handlers

2011-08-16 Thread Simon Horman
Provide separate interrupt handlers which may be used by platforms where SDHI has three interrupt sources. This patch also removes the commented-out handling of CRC and other errors. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm magnus.d...@gmail.com Signed-off-by: Simon Horman

[PATCH 1/4] mmc: tmio: Cache interrupt masks

2011-08-16 Thread Simon Horman
This avoids the need to look up the masks each time an interrupt is handled. As suggested by Guennadi. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm magnus.d...@gmail.com Signed-off-by: Simon Horman ho...@verge.net.au --- * SDCARD portion tested on AP4/Mackerel * SDIO portion

[PATCH 3/4] mmc: sdhi: Make use of per-source irq handlers

2011-08-16 Thread Simon Horman
Make use of per-source irq handles if the platform (data) has multiple irq sources. Also, as suggested by Guennadi Liakhovetski, add and use defines the index or irqs in platform data. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm magnus.d...@gmail.com Signed-off-by: Simon

Re: [RFC PATCH] mmc: support background operation

2011-08-16 Thread Jaehoon Chung
Hi, J Freyensee wrote: On 08/12/2011 04:14 AM, Jaehoon Chung wrote: Hi mailing. This RFC patch is supported background operation(BKOPS). And if you want to test this patch, must apply [PATCH v3] mmc: support HPI send command This patch is based on Hanumath Prasad's patch mmc: enable

Re: [PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating

2011-08-16 Thread Mika Westerberg
On Mon, Aug 15, 2011 at 01:03:37PM +0300, Mika Westerberg wrote: There are few places where we want to make sure that no clock gating takes place. For example when we are updating several related fields in ios structure and we don't want to accidentally pass the partially filled ios to the