Re: [Fwd: Re: [PATCH] arm, da8xx, mmc: set second MMC controllers default queue]

2011-12-07 Thread Heiko Schocher
Hello Rajashekhara, Rajashekhara, Sudhakar wrote: > On Wed, Dec 07, 2011 at 11:52:23, Heiko Schocher wrote: >> Hello Sekhar, >> >> here the forwarded comment from Ido Yariv to my patch. I tried >> with current kernel MMC Controller 2 on my am1808 based board >> without my fix, and it works fine, s

[PATCH v2] arm, da8xx, mmc: set second MMC controllers default queue

2011-12-07 Thread Heiko Schocher
The MMC driver allocates channels with EVENTQ_DEFAULT, they get put into EVENTQ_1, which the second EDMA controller does not have and hence transfers stall. This is fixed in commit f23fe857bbea393b4b94fe2218c98d934bd3d4cf "ARM: davinci: Explicitly set channel controllers' default queues" from Ido Y

Re: [PATCH v3] mmc: boot partition ro lock support

2011-12-07 Thread Chris Ball
Hi Johan, On Fri, Dec 02 2011, Johan Rudholm wrote: > Enable boot partitions to be read-only locked until next power on via > a sysfs entry. There will be one sysfs entry for each boot partition: > > /sys/block/mmcblkXbootY/ro_lock_until_next_power_on > > Both boot partitions are locked by writing

Re: [PATCH-next] mmc: core: Fixup delayed work clock gating patch

2011-12-07 Thread Chris Ball
Hi Stephen, On Mon, Dec 05 2011, Stephen Boyd wrote: > c31b50e (mmc: core: Use delayed work in clock gating framework, > 2011-11-14) missed a few things during review: > > o A useless pr_info() > > o milliseconds was written as two words > > o The sysfs file had units in its output > > Fix all

Re: [PATCH] mmc: sdhci-pci: simplify error handling

2011-12-07 Thread Chris Ball
Hi, On Mon, Dec 05 2011, Adrian Hunter wrote: > On 03/12/11 09:28, Axel Lin wrote: >> Signed-off-by: Axel Lin > > Acked-by: Adrian Hunter > >> --- >> drivers/mmc/host/sdhci-pci.c | 38 ++ >> 1 files changed, 18 insertions(+), 20 deletions(-) >> >> diff --g

Re: [linux-next] sdhci-s3c build error

2011-12-07 Thread Chris Ball
Hi, On Sat, Dec 03 2011, Chris Ball wrote: >> CC drivers/mmc/host/sdhci-s3c.o >> drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe': >> drivers/mmc/host/sdhci-s3c.c:524: error: 'struct s3c_sdhci_platdata' >> has no member named 'pm_caps' >> drivers/mmc/host/sdhci-s3c.c:525: error:

RE: [Fwd: Re: [PATCH] arm, da8xx, mmc: set second MMC controllers default queue]

2011-12-07 Thread Rajashekhara, Sudhakar
Hi Heiko, On Wed, Dec 07, 2011 at 11:52:23, Heiko Schocher wrote: > Hello Sekhar, > > here the forwarded comment from Ido Yariv to my patch. I tried > with current kernel MMC Controller 2 on my am1808 based board > without my fix, and it works fine, so no need for applying my > patch. > > Thanks

Re: [PATCH V3] mmc: Kill block requests if card is removed

2011-12-07 Thread Adrian Hunter
On 06/12/11 11:00, Sujit Reddy Thumma wrote: > Hi Adrian/Per, > > Any comments on this patch? What about adding the following to the top of mmc_blk_cmd_recovery() if (mmc_card_removed(card)) return ERR_NOMEDIUM; > > Thanks, > Sujit > > On 12/1/2011 4:00 PM, Sujit Red

Re: [MXS MMC 2/5] Some cleanups for the MMC driver

2011-12-07 Thread Uwe Kleine-König
On Wed, Dec 07, 2011 at 12:57:44PM +0100, Lothar Waßmann wrote: > Hi, > > Shawn Guo writes: > > I'm fine with this cosmetic patch with the comments below addressed. > > > > On Tue, Dec 06, 2011 at 02:41:27PM +0100, Lothar Waßmann wrote: > > > - Remove bogus parens around numerical arguments in #

Re: mmc: sdio: runtime PM and 8686 problems

2011-12-07 Thread Joe Woodward
Right, a bit more information. First I tried just adding delays as suggested: # Delays in core.c:mmc_power_up() increased to 1000. # Delay in core.c:mmc_power_off() increased to 1000. # sdio.c:mmc_sdio_power_restore() modified to add delays. ... msleep(500); sdio_reset(host);

Re: [MXS MMC 5/5] Add an appropriate MODULE_ALIAS

2011-12-07 Thread Shawn Guo
On Tue, Dec 06, 2011 at 02:41:30PM +0100, Lothar Waßmann wrote: > > Signed-off-by: Lothar Waßmann > --- > drivers/mmc/host/mxs-mmc.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c > index 0003d03..1ba08ae 100

Re: [MXS MMC 4/5] Check the return codes of clk_enable() and mxs_reset_block()

2011-12-07 Thread Shawn Guo
On Tue, Dec 06, 2011 at 02:41:29PM +0100, Lothar Waßmann wrote: > Add an int return value to mxs_mmc_reset(), so that the return code of > mxs_reset_block() can be promoted to the caller. > Also check the return code of clk_enable() in the probe function. > > Signed-off-by: Lothar Waßmann Acked-

Re: [MXS MMC 3/5] Add support for SSP/MMC ports 2 & 3

2011-12-07 Thread Shawn Guo
On Tue, Dec 06, 2011 at 02:41:28PM +0100, Lothar Waßmann wrote: > i.MX28 has four SSP/MMC units, only two of which are currently > usable. > > Signed-off-by: Lothar Waßmann Applied, thanks. Please add prefix 'ARM: mxs:' or 'arm/mxs' to make the patch look like the below in the future submission

Re: [PATCH 00/14] mmc: mmci: Improved PM support, cleanup and bugfixes

2011-12-07 Thread Linus Walleij
Hi Ulf, On Mon, Dec 5, 2011 at 6:35 PM, Ulf Hansson wrote: > Patch 1 -> 4: > Minor changes for bugs and some performance optimizations. > Previously sent to the mailing list. > Patch 5 -> 7: > Minor changes affecting how to handle a levelshifter. > Previously sent to the mailing list. > Patch 8:

Re: [MXS MMC 2/5] Some cleanups for the MMC driver

2011-12-07 Thread Shawn Guo
On Wed, Dec 07, 2011 at 12:57:44PM +0100, Lothar Waßmann wrote: > Hi, > > Shawn Guo writes: > > I'm fine with this cosmetic patch with the comments below addressed. > > > > On Tue, Dec 06, 2011 at 02:41:27PM +0100, Lothar Waßmann wrote: > > > - Remove bogus parens around numerical arguments in #

Re: [MXS MMC 2/5] Some cleanups for the MMC driver

2011-12-07 Thread Lothar Waßmann
Hi, Shawn Guo writes: > I'm fine with this cosmetic patch with the comments below addressed. > > On Tue, Dec 06, 2011 at 02:41:27PM +0100, Lothar Waßmann wrote: > > - Remove bogus parens around numerical arguments in #define's > > - When defining bit masks, use the #def for the shift count > >

Re: [MXS MMC 2/5] Some cleanups for the MMC driver

2011-12-07 Thread Shawn Guo
I'm fine with this cosmetic patch with the comments below addressed. On Tue, Dec 06, 2011 at 02:41:27PM +0100, Lothar Waßmann wrote: > - Remove bogus parens around numerical arguments in #define's > - When defining bit masks, use the #def for the shift count >instead of repeating the numbers

Re: [MXS MMC 1/5] Fix grammatical error in comment

2011-12-07 Thread Shawn Guo
On Tue, Dec 06, 2011 at 02:41:26PM +0100, Lothar Waßmann wrote: > > Signed-off-by: Lothar Waßmann > --- > arch/arm/mach-mxs/clock-mx28.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c > index da6e4aa

Re: [PATCH 3/4] MMC/core: Make sure the power is up, when detect the card

2011-12-07 Thread Linus Walleij
On Mon, Dec 5, 2011 at 10:23 AM, wrote: > From: Jerry Huang > > Before running get_cd() recall function to detect whether the card is > present, must make sure the power is up. (...) > +       mmc_power_up(host); >        if (host->ops->get_cd && host->ops->get_cd(host) == 0) >                go