Re: [PATCH v8 1/2] mmc: add packed command feature of eMMC4.5

2012-07-10 Thread merez
On Mon, July 9, 2012 10:54 pm, Chris Ball wrote: Hi, On Fri, Jun 29 2012, Seungwon Jeon wrote: This patch adds packed command feature of eMMC4.5. The maximum number for packing read(or write) is offered and exception event relevant to packed command which is used for error handling is

Re: [PATCH v8 1/2] mmc: add packed command feature of eMMC4.5

2012-07-10 Thread S, Venkatraman
On Tue, Jul 10, 2012 at 11:24 AM, Chris Ball c...@laptop.org wrote: Hi, On Fri, Jun 29 2012, Seungwon Jeon wrote: This patch adds packed command feature of eMMC4.5. The maximum number for packing read(or write) is offered and exception event relevant to packed command which is used for

Re: [PATCH v8 1/2] mmc: add packed command feature of eMMC4.5

2012-07-10 Thread Chris Ball
Hi, On Tue, Jul 10 2012, me...@codeaurora.org wrote: Sorry, I don't have a copy of the eMMC 4.5 spec -- is PACKED_EVENT_EN a one-time programmable fuse on the eMMC, like BKOPS_ENABLE was? No, it's not. Excellent, thanks. I've pushed both v8 patches to mmc-next. Before pushing it up to

[PATCH] mmc: core: reset sigal voltage on power up

2012-07-10 Thread Aaron Lu
Add a call to mmc_set_signal_voltage to set signal voltage to 3.3v in mmc_power_up so that we do not need to touch signal voltage setting in mmc/sd/sdio init functions and rescan function. For mmc/sd cards, when doing a suspend/resume cycle, consider the unsafe resume case, the card will lose its

Re: [PATCH v8 1/2] mmc: add packed command feature of eMMC4.5

2012-07-10 Thread merez
On Tue, July 10, 2012 12:33 am, Chris Ball wrote: Hi, On Tue, Jul 10 2012, me...@codeaurora.org wrote: Sorry, I don't have a copy of the eMMC 4.5 spec -- is PACKED_EVENT_EN a one-time programmable fuse on the eMMC, like BKOPS_ENABLE was? No, it's not. Excellent, thanks. I've pushed

Re: [PATCH v1 5/5] mmc: card: Add RPMB support in IOCTL interface

2012-07-10 Thread Loic pallardy
Repost in text format 2012/7/10 Namjae Jeon linkinj...@gmail.com + err = mmc_blk_part_switch(card, md); + if (err) + goto cmd_rel_host; + Should it wrapped by if (is_rpbm) condition ? It can be called in other ioctl. It was my first implementation, but in that

mmc: mxs: DEADLOCK

2012-07-10 Thread Lauri Hintsala
Hi, I was able to get deadlock with CONFIG_DEBUG_SPINLOCK enabled. I added also CONFIG_PROVE_LOCKING to get more verbose output. I got following error message after SDIO device has been powered. I'm able to replicate issue with Linux next-20120710. Platform is imx28. [ 79.66

Re: [PATCH] mmc: omap_hsmmc: fix runtime suspend crash: add host checks in callbacks

2012-07-10 Thread Kevin Hilman
S, Venkatraman svenk...@ti.com writes: On Sat, Jul 7, 2012 at 5:56 AM, Kevin Hilman khil...@ti.com wrote: Due to the way the driver core takes runtime PM references during probe, a driver's runtime PM callbacks may not be called until probe returns. During probe, drvdata is set to the 'host'

Re: [PATCH] mmc: omap_hsmmc: fix runtime suspend crash: add host checks in callbacks

2012-07-10 Thread S, Venkatraman
On Tue, Jul 10, 2012 at 7:47 PM, Kevin Hilman khil...@ti.com wrote: S, Venkatraman svenk...@ti.com writes: On Sat, Jul 7, 2012 at 5:56 AM, Kevin Hilman khil...@ti.com wrote: Due to the way the driver core takes runtime PM references during probe, a driver's runtime PM callbacks may not be

Re: mmc: mxs: DEADLOCK

2012-07-10 Thread Marek Vasut
Dear Lauri Hintsala, [...] --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -278,11 +278,11 @@ static irqreturn_t mxs_mmc_irq_handler(int irq, void *dev_id) writel(stat MXS_MMC_IRQ_BITS, host-base + HW_SSP_CTRL1(host) + STMP_OFFSET_REG_CLR); +

Re: [PATCH] mmc: core: Prevent eMMC VCC supply to be cut from late init

2012-07-10 Thread Girish K S
On 9 May 2012 19:45, Ulf Hansson ulf.hans...@stericsson.com wrote: From: Ulf Hansson ulf.hans...@linaro.org For eMMC cards that has been initialized from a bootloader, the VCC voltage supply must not be cut in an uncontrolled manner, without first sending SLEEP or POWEROFF_NOTIFY. The

Re: [PATCH] mmc: core: Prevent eMMC VCC supply to be cut from late init

2012-07-10 Thread Chris Ball
Hi, On Tue, Jul 10 2012, Girish K S wrote: @@ -2063,7 +2074,8 @@ void mmc_rescan(struct work_struct *work) void mmc_start_host(struct mmc_host *host) { - mmc_power_off(host); + host-f_init = max(freqs[0], host-f_min); + mmc_power_up(host);

Re: [CFT 03/11] mmc: omap_hsmmc: remove private DMA API implementation

2012-07-10 Thread Kevin Hilman
Hi Russell, Russell King rmk+ker...@arm.linux.org.uk writes: Remove the private DMA API implementation from omap_hsmmc, making it use entirely the DMA engine API. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk While testing this, I noticed a minor problem in the case of probe

Re: [PATCH] mmc: omap_hsmmc: fix runtime suspend crash: add host checks in callbacks

2012-07-10 Thread Kevin Hilman
S, Venkatraman svenk...@ti.com writes: On Tue, Jul 10, 2012 at 7:47 PM, Kevin Hilman khil...@ti.com wrote: S, Venkatraman svenk...@ti.com writes: On Sat, Jul 7, 2012 at 5:56 AM, Kevin Hilman khil...@ti.com wrote: Due to the way the driver core takes runtime PM references during probe, a

[PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

2012-07-10 Thread Kevin Hilman
If platform_get_resource_by_name() fails, driver probe is aborted an should return an error so the driver is not bound to the device. However, in the current error path of platform_get_resource_by_name(), probe returns zero since the return value (ret) is not properly set. With a zero return

Re: [PATCH v1 5/5] mmc: card: Add RPMB support in IOCTL interface

2012-07-10 Thread Namjae Jeon
2012/7/10, Loic pallardy loic.palla...@gmail.com: Repost in text format 2012/7/10 Namjae Jeon linkinj...@gmail.com + err = mmc_blk_part_switch(card, md); + if (err) + goto cmd_rel_host; + Should it wrapped by if (is_rpbm) condition ? It can be called in other

Re: [PATCH v1 2/5] mmc: card: Do not scan RPMB partitions

2012-07-10 Thread Namjae Jeon
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index 276d21c..1b202fe 100644 --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c @@ -1521,6 +1521,9 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card, md-disk-queue = md-queue.queue;