Re: question about IO-sched

2012-07-17 Thread Corrado Zoccolo
On Sun, Jul 15, 2012 at 9:08 AM, gaoqiang wrote: > > many thanks. but why the sys_read operation hangs on sync_page ? there are > still > many free memory.I mean ,the actually free memory,excluding the various > kinds of > caches or buffers. http://kerneltrap.org/node/4941 explains sync_page: > >

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread Jaehoon Chung
On 07/18/2012 04:34 AM, me...@codeaurora.org wrote: > See my comments below. > >> +/** >> + * mmc_start_bkops - start BKOPS for supported cards >> + * @card: MMC card to start BKOPS >> + * >> + * Start background operations whenever requested. >> + * when the urgent BKOPS bit is set in a R1 co

Re: [PATCH v2 1/1] mmc: block: Add write packing control

2012-07-17 Thread merez
Hi Chris, Is there anything else that holds this patch from being pushed to mmc-next? Thanks, Maya On Tue, July 17, 2012 3:50 pm, Chris Ball wrote: > Hi Muthu, > > On Mon, Jul 16 2012, Muthu Kumar wrote: >> On Sun, Jul 15, 2012 at 7:46 PM, Chris Ball wrote: >>> Hi, >>> >>> On Sun, Jul 15 2012, M

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread merez
On Tue, July 17, 2012 11:16 pm, Adrian Hunter wrote: > On 17/07/12 15:58, Jaehoon Chung wrote: >> On 07/17/2012 09:30 PM, Adrian Hunter wrote: >>> On 17/07/12 05:44, Jaehoon Chung wrote: >>> >>> >>> +/** + *mmc_start_bkops - start BKOPS for supported cards + *@card:

Devicetree: Initialization order of mmc block devices?

2012-07-17 Thread Dirk Behme
Similar to [1] we have a device which has two mmc block devices connected: One external removable and a second internal hard wired one. Depending on the availability of the external removable mmc card at boot time, the internal hard wired device becomes mmcblk1 (external mmc card available ==

Re: [PATCH 2/2] mmc: sd: Fix sd current limit setting

2012-07-17 Thread Aaron Lu
Hi Chris, On Wed, Jul 18, 2012 at 01:28:40AM -0400, Chris Ball wrote: > Hi Aaron, > > On Wed, Jul 18 2012, Aaron Lu wrote: > > Is the following patch OK? This is based on top of current mmc-next with > > the previous one in tree. Not sure if this is what you want though. > > Yes, that's perfect;

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread Adrian Hunter
On 17/07/12 15:58, Jaehoon Chung wrote: > On 07/17/2012 09:30 PM, Adrian Hunter wrote: >> On 17/07/12 05:44, Jaehoon Chung wrote: >> >> >> >>> +/** >>> + * mmc_start_bkops - start BKOPS for supported cards >>> + * @card: MMC card to start BKOPS >>> + * >>> + * Start background operations whenever

Re: [PATCH 2/2] mmc: sd: Fix sd current limit setting

2012-07-17 Thread Chris Ball
Hi Aaron, On Wed, Jul 18 2012, Aaron Lu wrote: > Is the following patch OK? This is based on top of current mmc-next with > the previous one in tree. Not sure if this is what you want though. Yes, that's perfect; squashed into the original patch and pushed out to mmc-next. Thanks! Having there

Re: [PATCH 2/2] mmc: sd: Fix sd current limit setting

2012-07-17 Thread Aaron Lu
Hi, On Tue, Jul 17, 2012 at 11:43:26AM -0400, Chris Ball wrote: > > > > Chris, please let me know how you want to deal with this and I'll be > > glad to do whatever I can to fix this. Sorry for the trouble. > > No worries, I can rebase it in. Mind sending a patch on top of current > mmc-next for

Re: [PATCH v2 1/1] mmc: block: Add write packing control

2012-07-17 Thread Chris Ball
Hi Muthu, On Mon, Jul 16 2012, Muthu Kumar wrote: > On Sun, Jul 15, 2012 at 7:46 PM, Chris Ball wrote: >> Hi, >> >> On Sun, Jul 15 2012, Muthu Kumar wrote: I've already replied to a later version of the patch, but just to get this comment in at the appropriate point of the discussion as

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread merez
See my comments below. > +/** > + * mmc_start_bkops - start BKOPS for supported cards > + * @card: MMC card to start BKOPS > + * > + * Start background operations whenever requested. > + * when the urgent BKOPS bit is set in a R1 command response > + * then background operations should b

Re: [PATCH RESEND] gpio: of_get_named_gpio_flags() return -EPROBE_DEFER if GPIO not yet available

2012-07-17 Thread Alexandre Pereira da Silva
On Tue, Jul 17, 2012 at 3:24 PM, Linus Walleij wrote: > On Thu, Jun 28, 2012 at 12:32 AM, Roland Stigge wrote: > >> of_get_named_gpio_flags() and of_get_named_gpio() return -EPROBE_DEFER if the >> respective GPIO is not (yet) available. This is useful if driver's probe() >> functions try to get a

Re: [PATCH RESEND] gpio: of_get_named_gpio_flags() return -EPROBE_DEFER if GPIO not yet available

2012-07-17 Thread Linus Walleij
On Thu, Jun 28, 2012 at 12:32 AM, Roland Stigge wrote: > of_get_named_gpio_flags() and of_get_named_gpio() return -EPROBE_DEFER if the > respective GPIO is not (yet) available. This is useful if driver's probe() > functions try to get a GPIO whose controller isn't probed yet. Thus, the > driver

Re: [PATCH RESEND] gpio: of_get_named_gpio_flags() return -EPROBE_DEFER if GPIO not yet available

2012-07-17 Thread Linus Walleij
On Tue, Jul 17, 2012 at 9:43 AM, Mark Brown wrote: > On Tue, Jul 17, 2012 at 12:16:48AM +0200, Linus Walleij wrote: >> On Sun, Jul 15, 2012 at 11:11 PM, Mark Brown > >> > I had thought a version of this >> > had been submitted already and was in a similar place to the one for >> > gpio_request().

Re: [PATCH v2 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

2012-07-17 Thread Javier Martinez Canillas
On Tue, Jul 17, 2012 at 9:09 AM, Shilimkar, Santosh wrote: > On Tue, Jul 17, 2012 at 12:33 PM, Javier Martinez Canillas > wrote: >> The OMAP MMC and OMAP High Speed MMC hosts now use entirely the DMA >> engine API instead of the previous private DMA API implementation. >> >> So, if the kernel is

Re: [PATCH] esdhc: fix DMA_MASK to not break mx25 DMA access

2012-07-17 Thread Wilson & Cassie
Patch to not set reserved bits in i.MX25 PROCTL register. DMA stops working if those bits get set. Signed-off-by: Wilson Callan Acked-by: Sascha Hauer --- linux-3.4.4/drivers/mmc/host/sdhci-esdhc-imx.c.orig 2012-07-04 13:58:16.239979741 -0400 +++ linux-3.4.4/drivers/mmc/host/sdhci-esdhc-imx.

Re: [PATCH 2/2] mmc: sd: Fix sd current limit setting

2012-07-17 Thread Chris Ball
Hi, On Tue, Jul 17 2012, Aaron Lu wrote: >> sorry for seeing this late. >> The macro name should be **_CAP2_***. > > Chris, please let me know how you want to deal with this and I'll be > glad to do whatever I can to fix this. Sorry for the trouble. No worries, I can rebase it in. Mind sending a

[PATCH 0/2] mmc: mxs-mmc: fix deadlocks

2012-07-17 Thread Lauri Hintsala
Two different deadlock fixes in cases with SDIO IRQs generated by SDIO device. Lauri Hintsala (2): mmc: mxs-mmc: fix deadlock in SDIO IRQ case mmc: mxs-mmc: fix deadlock caused by recursion loop drivers/mmc/host/mxs-mmc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

[PATCH 2/2] mmc: mxs-mmc: fix deadlock caused by recursion loop

2012-07-17 Thread Lauri Hintsala
Release the lock before mmc_signal_sdio_irq is called by mxs_mmc_enable_sdio_irq. Backtrace: [ 65.47] = [ 65.47] [ INFO: possible recursive locking detected ] [ 65.47] 3.5.0-rc5 #2 Not tainted [ 65.47]

[PATCH 1/2] mmc: mxs-mmc: fix deadlock in SDIO IRQ case

2012-07-17 Thread Lauri Hintsala
Release the lock before mmc_signal_sdio_irq is called by mxs_mmc_irq_handler. Backtrace: [ 79.66] = [ 79.66] [ INFO: possible recursive locking detected ] [ 79.66] 3.4.0-9-g3e96082-dirty #11 Not tainted [ 79.66] --

Re: [PATCH 2/2] mmc: sd: Fix sd current limit setting

2012-07-17 Thread Aaron Lu
On Tue, Jul 17, 2012 at 03:04:05PM +0530, Girish K S wrote: > > @@ -261,6 +261,14 @@ struct mmc_host { > > #define MMC_CAP2_HC_ERASE_SZ (1 << 9)/* High-capacity erase size > > */ > > #define MMC_CAP2_CD_ACTIVE_HIGH(1 << 10) /* Card-detect > > signal active high */ > > #

Re: mmc: mxs: DEADLOCK

2012-07-17 Thread Lauri Hintsala
On 07/17/2012 03:40 PM, Shawn Guo wrote: On Tue, Jul 17, 2012 at 07:54:39AM +0300, Lauri Hintsala wrote: Shawn, Could you review this patch? Attila reported it fixes his SDIO initialization issue. Thanks for fixing it. Acked-by: Shawn Guo Thanks. I'll send both this and previous patches t

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread Jaehoon Chung
On 07/17/2012 09:30 PM, Adrian Hunter wrote: > On 17/07/12 05:44, Jaehoon Chung wrote: > > > >> +/** >> + * mmc_start_bkops - start BKOPS for supported cards >> + * @card: MMC card to start BKOPS >> + * >> + * Start background operations whenever requested. >> + * when the urgent BKOPS bit i

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread Adrian Hunter
On 17/07/12 05:44, Jaehoon Chung wrote: > +/** > + * mmc_start_bkops - start BKOPS for supported cards > + * @card: MMC card to start BKOPS > + * > + * Start background operations whenever requested. > + * when the urgent BKOPS bit is set in a R1 command response > + * then background

Re: mmc: mxs: DEADLOCK

2012-07-17 Thread Shawn Guo
On Tue, Jul 17, 2012 at 07:54:39AM +0300, Lauri Hintsala wrote: > Shawn, > > Could you review this patch? Attila reported it fixes his SDIO > initialization issue. > Thanks for fixing it. Acked-by: Shawn Guo > Lauri > > > On 07/16/2012 08:57 AM, Lauri Hintsala wrote: > >>Any hints how to wor

Re: [PATCH] mmc: core: reset sigal voltage on power up

2012-07-17 Thread S, Venkatraman
On Tue, Jul 10, 2012 at 2:25 PM, Aaron Lu wrote: > Add a call to mmc_set_signal_voltage to set signal voltage to 3.3v in > mmc_power_up so that we do not need to touch signal voltage setting in > mmc/sd/sdio init functions and rescan function. > > For mmc/sd cards, when doing a suspend/resume cycl

Re: [PATCH] mmc: core: skip mmc_power_up call from start host

2012-07-17 Thread Girish K S
On 17 July 2012 16:22, S, Venkatraman wrote: > On Fri, Jul 13, 2012 at 6:27 PM, Girish K S > wrote: >> The call to the mmc_power_up during the mmc_start_host breaks the card >> detection in design-ware host controller. This patch removes the call to >> mmc_power_up function during host start. >>

Re: [PATCH] mmc: core: skip mmc_power_up call from start host

2012-07-17 Thread S, Venkatraman
On Fri, Jul 13, 2012 at 6:27 PM, Girish K S wrote: > The call to the mmc_power_up during the mmc_start_host breaks the card > detection in design-ware host controller. This patch removes the call to > mmc_power_up function during host start. > Please explain why. Which commit introduced it ? > Th

Re: [PATCH RESEND v7 2/2] mmc: card: Adding support for sanitize in eMMC 4.5

2012-07-17 Thread Yaniv Gardi
Hi Chris, Can you push this patch to mmc-next? Thanks, Yaniv > Looks good to me. > Reviewed-by: Maya Erez > > On Thu, June 28, 2012 1:32 am, Yaniv Gardi wrote: >> This feature delete the unmap memory region of the eMMC card, >> by writing to a specific register in the EXT_CSD >> unmap region is

Re: [PATCH RESEND v7 1/2] block: ioctl support for sanitize in eMMC 4.5

2012-07-17 Thread Yaniv Gardi
Hi Jens, Can you approve this patch? Thanks, Yaniv > Looks good to me. > Reviewed-by: Maya Erez > > On Thu, June 28, 2012 1:32 am, Yaniv Gardi wrote: >> Adding a new ioctl to support sanitize operation in eMMC >> cards version 4.5. >> The sanitize ioctl support helps performing this operation >>

Re: [PATCH] mmc: dwmmc: Add quirk for broken Hardware Config

2012-07-17 Thread Girish K S
On 17 July 2012 15:43, Jaehoon Chung wrote: > Hi Girish.. > > i tested with your patch and applied the device tree patch. > But i found the didn't compare with the MMC_CAP2_CONFIG_BROKEN. > > I think that host->drv_data->caps2 just denote address. > So if running the your code, > Maybe it's compar

[PATCH 3/9] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-07-17 Thread Thomas Abraham
Some platforms allow for clock gating and control of bus interface unit clock and card interface unit clock. Add support for clock lookup of optional biu and ciu clocks for clock gating and clock speed determination. Signed-off-by: Abhilash Kesavan Signed-off-by: Thomas Abraham --- drivers/mmc/

[PATCH 5/9] mmc: dw_mmc: add device tree support

2012-07-17 Thread Thomas Abraham
Add device tree based discovery support. Signed-off-by: Thomas Abraham --- .../devicetree/bindings/mmc/synposis-dw-mshc.txt | 99 ++ drivers/mmc/host/dw_mmc-pltfm.c| 23 +++ drivers/mmc/host/dw_mmc.c | 201 +++- drivers/

Re: [PATCH v3 5/6] mmc: dw_mmc: add device tree support

2012-07-17 Thread Thomas Abraham
On 16 July 2012 09:53, Chris Ball wrote: > Hi, > > On Thu, Jul 12 2012, Thomas Abraham wrote: >> diff --git a/Documentation/devicetree/bindings/mmc/synposis-dw-mshc.txt >> b/Documentation/devicetree/bindings/mmc/synposis-dw-mshc.txt >> new file mode 100644 >> index 000..3acd6c9 >> --- /dev/nu

Re: [PATCH v3 5/6] mmc: dw_mmc: add device tree support

2012-07-17 Thread Thomas Abraham
On 16 July 2012 09:45, Girish K S wrote: > On 12 July 2012 18:24, Thomas Abraham wrote: [...] >> >> +#ifdef CONFIG_OF >> +static struct dw_mci_drv_data synopsis_drv_data = { >> + .ctrl_type = DW_MCI_TYPE_SYNOPSIS, >> +}; >> + >> +static const struct of_device_id dw_mci_pltfm_match[]

Re: [PATCH] mmc-util: add the method to enable the bkops

2012-07-17 Thread Jaehoon Chung
Hi, Also i will fix, then resend the patch. Best Regards, Jaehoon Chung On 07/17/2012 06:36 PM, S, Venkatraman wrote: > Minor printk nits.. > > On Tue, Jul 17, 2012 at 8:14 AM, Jaehoon Chung wrote: >> This patch added the method to enable the bkops. >> In ext_csd register, BKOPS_EN bit is one-

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread Jaehoon Chung
Hi I will fix your comment and resend the patch. Thank you. Best Regards, Jaehoon Chung On 07/17/2012 06:25 PM, S, Venkatraman wrote: > Some minor nits.. > > On Tue, Jul 17, 2012 at 8:14 AM, Jaehoon Chung wrote: >> Enable eMMC background operations (BKOPS) feature. >> >> If URGENT_BKOPS is set

Re: [PATCH] mmc: dwmmc: Add quirk for broken Hardware Config

2012-07-17 Thread Jaehoon Chung
Hi Girish.. i tested with your patch and applied the device tree patch. But i found the didn't compare with the MMC_CAP2_CONFIG_BROKEN. I think that host->drv_data->caps2 just denote address. So if running the your code, Maybe it's compared like "0xc02a6e54 & 0x1000". Is it wrong? Best Regar

Re: [PATCH] mmc: dwmmc: Add quirk for broken Hardware Config

2012-07-17 Thread Girish K S
On 17 July 2012 13:16, Jaehoon Chung wrote: > Hi Girish, > > On 07/16/2012 05:45 PM, Girish K S wrote: >> In some Soc'S that integrate Designware mmc host controllers, the >> HCON register is broken. The hardware configuration is not >> updated. One specific usecase is the IDMAC. In Exysons5 SoC >

Re: [PATCH] mmc: dwmmc: Add quirk for broken Hardware Config

2012-07-17 Thread Girish K S
On 17 July 2012 15:18, Jaehoon Chung wrote: > On 07/17/2012 06:17 PM, Girish K S wrote: >> On 17 July 2012 13:16, Jaehoon Chung wrote: >>> Hi Girish, >>> >>> On 07/16/2012 05:45 PM, Girish K S wrote: In some Soc'S that integrate Designware mmc host controllers, the HCON register is brok

Re: [PATCH] mmc: dwmmc: Add quirk for broken Hardware Config

2012-07-17 Thread Jaehoon Chung
On 07/17/2012 06:17 PM, Girish K S wrote: > On 17 July 2012 13:16, Jaehoon Chung wrote: >> Hi Girish, >> >> On 07/16/2012 05:45 PM, Girish K S wrote: >>> In some Soc'S that integrate Designware mmc host controllers, the >>> HCON register is broken. The hardware configuration is not >>> updated. On

Re: [PATCH] mmc-util: add the method to enable the bkops

2012-07-17 Thread S, Venkatraman
Minor printk nits.. On Tue, Jul 17, 2012 at 8:14 AM, Jaehoon Chung wrote: > This patch added the method to enable the bkops. > In ext_csd register, BKOPS_EN bit is one-time programable. > So if you want to use the bkops, use the this command. > > > #mmc bkops enable /dev/mmcblk0 > > Signed-off-b

Re: [PATCH 2/2] mmc: sd: Fix sd current limit setting

2012-07-17 Thread Girish K S
On 3 July 2012 11:46, Aaron Lu wrote: > Host has different current capabilities at different voltages, we need > to record these settings seperately. Before set current limit for the sd > card, find out the current voltage first and then find out the current > capabilities of the host to set the l

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread S, Venkatraman
Some minor nits.. On Tue, Jul 17, 2012 at 8:14 AM, Jaehoon Chung wrote: > Enable eMMC background operations (BKOPS) feature. > > If URGENT_BKOPS is set after a response, note that BKOPS > are required. After all I/O requests are finished, run > BKOPS if required. Should read/write operations be r

Re: [PATCH] mmc: dwmmc: Add quirk for broken Hardware Config

2012-07-17 Thread Girish K S
On 17 July 2012 13:16, Jaehoon Chung wrote: > Hi Girish, > > On 07/16/2012 05:45 PM, Girish K S wrote: >> In some Soc'S that integrate Designware mmc host controllers, the >> HCON register is broken. The hardware configuration is not >> updated. One specific usecase is the IDMAC. In Exysons5 SoC >

Re: [PATCH] mmc: dwmmc: Add quirk for broken Hardware Config

2012-07-17 Thread Girish K S
On 17 July 2012 13:16, Jaehoon Chung wrote: > Hi Girish, > > On 07/16/2012 05:45 PM, Girish K S wrote: >> In some Soc'S that integrate Designware mmc host controllers, the >> HCON register is broken. The hardware configuration is not >> updated. One specific usecase is the IDMAC. In Exysons5 SoC >

Re: [PATCH] mmc: dwmmc: Add quirk for broken Hardware Config

2012-07-17 Thread Jaehoon Chung
Hi Girish, On 07/16/2012 05:45 PM, Girish K S wrote: > In some Soc'S that integrate Designware mmc host controllers, the > HCON register is broken. The hardware configuration is not > updated. One specific usecase is the IDMAC. In Exysons5 SoC > there exist a internal DMA, but the HCON register's

Re: [PATCH RESEND] gpio: of_get_named_gpio_flags() return -EPROBE_DEFER if GPIO not yet available

2012-07-17 Thread Mark Brown
On Tue, Jul 17, 2012 at 12:16:48AM +0200, Linus Walleij wrote: > On Sun, Jul 15, 2012 at 11:11 PM, Mark Brown > > I had thought a version of this > > had been submitted already and was in a similar place to the one for > > gpio_request(). > Me to... Greg just merged the driver core patch for pus

Re: [PATCH v2 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

2012-07-17 Thread Shilimkar, Santosh
On Tue, Jul 17, 2012 at 12:33 PM, Javier Martinez Canillas wrote: > The OMAP MMC and OMAP High Speed MMC hosts now use entirely the DMA > engine API instead of the previous private DMA API implementation. > > So, if the kernel is built with support for any of these hosts but it > doesn't support D

[PATCH v2 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

2012-07-17 Thread Javier Martinez Canillas
The OMAP MMC and OMAP High Speed MMC hosts now use entirely the DMA engine API instead of the previous private DMA API implementation. So, if the kernel is built with support for any of these hosts but it doesn't support DMA devices nor OMAP DMA support, it fails when trying to obtain a DMA channe