Re: [PATCH v3 0/3] DaVinci DMA engine conversion

2012-08-22 Thread Tom Rini
On Wed, Aug 22, 2012 at 09:09:33PM -0400, Matt Porter wrote: [snip] > Matt Porter (3): > dmaengine: add TI EDMA DMA engine driver > mmc: davinci_mmc: convert to DMA engine API > spi: spi-davinci: convert to DMA engine API > > drivers/dma/Kconfig| 10 + > drivers/dma/Makefile

Re: v3.6-rc1: modprobe hangs with sdhci failure on dell e6410

2012-08-22 Thread Aaron Lu
On 08/22/2012 10:11 PM, Arend van Spriel wrote: > A quick search using google did not provide clues. Regardless if there > is anything inserted the hang occurs. your dmesg shows: [ 241.908294] INFO: task modprobe:134 blocked for more than 120 seconds. [ 241.908298] "echo 0 > /proc/sys/kernel/h

Re: [PATCH v2 3/3] spi: spi-davinci: convert to DMA engine API

2012-08-22 Thread Vinod Koul
On Wed, 2012-08-22 at 12:04 -0400, Matt Porter wrote: > for querying of these types of limitations. Right now, the > mmc driver implicitly knows that EDMA needs this restriction > but it's something that should be queried before calling > prep_slave(). that's something we need to add; exporting cha

[drivers/mmc]Issue on DMA out of SW-IOMMU space

2012-08-22 Thread wwang
Hi all: Several days ago I sent out a series of patches to support Realtek SD/MMC reader. Boris helped to give it a test using his Thinkpad x121e, with a built-in Realtek card reader named rts5209. (Hi, Thank you, Boris .. ) And he reported that some error messages, as below shows, would arise whe

[PATCH v3 1/3] dmaengine: add TI EDMA DMA engine driver

2012-08-22 Thread Matt Porter
Add a DMA engine driver for the TI EDMA controller. This driver is implemented as a wrapper around the existing DaVinci private DMA implementation. This approach allows for incremental conversion of each peripheral driver to the DMA engine API. The EDMA driver supports slave transfers but does not

[PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API

2012-08-22 Thread Matt Porter
Removes use of the DaVinci EDMA private DMA API and replaces it with use of the DMA engine API. Signed-off-by: Matt Porter --- drivers/spi/spi-davinci.c | 292 - 1 file changed, 130 insertions(+), 162 deletions(-) diff --git a/drivers/spi/spi-davinci

[PATCH v3 2/3] mmc: davinci_mmc: convert to DMA engine API

2012-08-22 Thread Matt Porter
Removes use of the DaVinci EDMA private DMA API and replaces it with use of the DMA engine API. Signed-off-by: Matt Porter --- drivers/mmc/host/davinci_mmc.c | 271 1 file changed, 82 insertions(+), 189 deletions(-) diff --git a/drivers/mmc/host/davinci

[PATCH v3 0/3] DaVinci DMA engine conversion

2012-08-22 Thread Matt Porter
Changes since v1: - Add virt-dma support. Better error checks and simplified descriptor handling. - Fix support for multiple EDMA controllers Tested on AM18x EVM with WL12xx on MMC1 Changes since v2: - Set default Kconfig state to off - Fix white

Re: [PATCH 1/2] mmc: core: Add a capability for disabling mmc cards

2012-08-22 Thread Nicolas Pitre
On Wed, 22 Aug 2012, Olof Johansson wrote: > On Wed, Aug 22, 2012 at 9:00 AM, Philip Rakity wrote: > > > > On Aug 22, 2012, at 8:44 AM, Doug Anderson wrote: > > > >> Thanks for your feedback. In this case I have a card that is an MMC > >> card so mmc_attach_sdio() and mmc_attach_sd() will fail.

Re: [PATCH v2 2/3] mmc: davinci_mmc: convert to DMA engine API

2012-08-22 Thread Koen Kooi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Op 21-08-12 20:43, Matt Porter schreef: > Removes use of the DaVinci EDMA private DMA API and replaces it with use > of the DMA engine API. > > Signed-off-by: Matt Porter Runtime tested on hawkboard with 3.6.0-rc2 with rootfs on SD and running bonni

Re: [PATCH 1/2] mmc: core: Add a capability for disabling mmc cards

2012-08-22 Thread Olof Johansson
On Wed, Aug 22, 2012 at 11:25 AM, Nicolas Pitre wrote: > On Wed, 22 Aug 2012, Olof Johansson wrote: > >> On Wed, Aug 22, 2012 at 9:00 AM, Philip Rakity wrote: >> > >> > On Aug 22, 2012, at 8:44 AM, Doug Anderson wrote: >> > >> >> Thanks for your feedback. In this case I have a card that is an M

[PATCH] mmc: dt: Add card-detection properties to core binding.

2012-08-22 Thread Chris Ball
Signed-off-by: Chris Ball --- Documentation/devicetree/bindings/mmc/mmc.txt | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt index 8a6811f..8e2e0ba 100644 --- a/Documentation

Re: [PATCH v2 1/3] dmaengine: add TI EDMA DMA engine driver

2012-08-22 Thread Matt Porter
On Wed, Aug 22, 2012 at 12:37:18PM +, Hebbar, Gururaja wrote: > On Wed, Aug 22, 2012 at 00:13:07, Porter, Matt wrote: > > Add a DMA engine driver for the TI EDMA controller. This driver > > is implemented as a wrapper around the existing DaVinci private > > DMA implementation. This approach all

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Mitch Bradley
Hi Thomas, On 8/22/2012 2:04 AM, Thomas Abraham wrote: > On 22 August 2012 16:38, Chris Ball wrote: >> Hi Thomas, >> >> On Wed, Aug 22 2012, Thomas Abraham wrote: This matches Mitch's last suggestion exactly -- I think we're all agreed on these properties now. The only remaining questi

Re: [PATCH 1/2] mmc: core: Add a capability for disabling mmc cards

2012-08-22 Thread Olof Johansson
Hi, On Wed, Aug 22, 2012 at 9:00 AM, Philip Rakity wrote: > > On Aug 22, 2012, at 8:44 AM, Doug Anderson wrote: > >> Jaehoon, >> >> On Tue, Aug 21, 2012 at 9:35 PM, Jaehoon Chung >> wrote: >>> >>> Hi Doug, >>> >>> I didn't know what purpose is. >>> Why need to add the MMC_CAP2_NO_MMC? >>> If c

Re: [PATCH v2 1/3] dmaengine: add TI EDMA DMA engine driver

2012-08-22 Thread Matt Porter
On Wed, Aug 22, 2012 at 09:09:26AM +0530, Vinod Koul wrote: > On Tue, 2012-08-21 at 14:43 -0400, Matt Porter wrote: > > Add a DMA engine driver for the TI EDMA controller. This driver > > is implemented as a wrapper around the existing DaVinci private > > DMA implementation. This approach allows fo

Re: [PATCH v2 3/3] spi: spi-davinci: convert to DMA engine API

2012-08-22 Thread Matt Porter
On Wed, Aug 22, 2012 at 09:15:22AM +0530, Vinod Koul wrote: > On Tue, 2012-08-21 at 14:43 -0400, Matt Porter wrote: > > Removes use of the DaVinci EDMA private DMA API and replaces > > it with use of the DMA engine API. > > > > Signed-off-by: Matt Porter > > --- > > > + struct dma_slav

Re: [PATCH 1/2] mmc: core: Add a capability for disabling mmc cards

2012-08-22 Thread Philip Rakity
On Aug 22, 2012, at 8:44 AM, Doug Anderson wrote: > Jaehoon, > > On Tue, Aug 21, 2012 at 9:35 PM, Jaehoon Chung wrote: >> >> Hi Doug, >> >> I didn't know what purpose is. >> Why need to add the MMC_CAP2_NO_MMC? >> If card is SD or SDIO, mmc_attach_mmc(host) should not be entered. >> Could yo

Re: [PATCH 1/2] mmc: core: Add a capability for disabling mmc cards

2012-08-22 Thread Doug Anderson
Jaehoon, On Tue, Aug 21, 2012 at 9:35 PM, Jaehoon Chung wrote: > > Hi Doug, > > I didn't know what purpose is. > Why need to add the MMC_CAP2_NO_MMC? > If card is SD or SDIO, mmc_attach_mmc(host) should not be entered. > Could you explain to me in more detail? Thanks for your feedback. In this

Re: [PATCH] ARM: dts: imx51-babbage: fix esdhc cd/wp properties

2012-08-22 Thread Shawn Guo
On Wed, Aug 22, 2012 at 10:02:48AM -0400, Chris Ball wrote: > Want to take this through your own tree, to avoid .dts conflicts later? > If so: Yes, I have another a few IMX fixing queued for 3.6-rc, and would send this one together shortly. > > Acked-by: Chris Ball > Thanks. -- Regards, Shaw

[PATCH] mmc: sdhci-esdhc: break out early if clock is 0

2012-08-22 Thread Shawn Guo
Since commit 30832ab (mmc: sdhci: Always pass clock request value zero to set_clock host op) gets in, esdhc_set_clock starts hitting "if (clock == 0)" where ESDHC_SYSTEM_CONTROL has been operated. This causes SDHCI card-detection function being broken. Fix the regression by moving "if (clock == 0

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Thomas Abraham
On 22 August 2012 20:24, Chris Ball wrote: > Hi Thomas, > > On Wed, Aug 22 2012, Thomas Abraham wrote: >>> none -> currently "samsung,sdhci-cd-internal" >>> broken-cd -> currently "samsung,sdhci-cd-none" >>> cd-gpios -> currently "samsung,sdhci-cd-gpios" >>> non-removable -> curr

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Chris Ball
Hi Stephen, On Wed, Aug 22 2012, Stephen Warren wrote: > On 08/22/2012 04:17 AM, Chris Ball wrote: >> Hi, >> >> On Wed, Aug 22 2012, Shawn Guo wrote: >>> The following is what I have on my mind. >>> >>> broken-cd cd-gpiosimplication >>> --- >>> no

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Stephen Warren
On 08/22/2012 04:17 AM, Chris Ball wrote: > Hi, > > On Wed, Aug 22 2012, Shawn Guo wrote: >> The following is what I have on my mind. >> >> broken-cdcd-gpiosimplication >> --- >> no no SDHCI CD >> no yes

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Chris Ball
Hi Thomas, On Wed, Aug 22 2012, Thomas Abraham wrote: >> none -> currently "samsung,sdhci-cd-internal" >> broken-cd -> currently "samsung,sdhci-cd-none" >> cd-gpios -> currently "samsung,sdhci-cd-gpios" >> non-removable -> currently "samsung,sdhci-cd-permanent" >> cd-gpios + sams

Re: [PATCH] ARM: dts: imx51-babbage: fix esdhc cd/wp properties

2012-08-22 Thread Chris Ball
Hi, (removing stable@ from e-mail) On Wed, Aug 22 2012, Shawn Guo wrote: > The binding doc and dts use properties "fsl,{cd,wp}-internal" while > esdhc driver uses "fsl,{cd,wp}-controller". Fix binding doc and dts > to get them match driver code. > > Reported-by: Chris Ball > Signed-off-by: Shaw

[PATCH] ARM: dts: imx51-babbage: fix esdhc cd/wp properties

2012-08-22 Thread Shawn Guo
The binding doc and dts use properties "fsl,{cd,wp}-internal" while esdhc driver uses "fsl,{cd,wp}-controller". Fix binding doc and dts to get them match driver code. Reported-by: Chris Ball Signed-off-by: Shawn Guo Cc: --- .../devicetree/bindings/mmc/fsl-imx-esdhc.txt |8 a

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Chris Ball
Hi Shawn, On Wed, Aug 22 2012, Shawn Guo wrote: > mmc: sdhci: Always pass clock request value zero to set_clock host op > > To allow the set_clock host op to disable the SDCLK source when not > needed, always call the host op when the requested clock speed is > zero. Do this even

RE: [PATCH v2 1/3] dmaengine: add TI EDMA DMA engine driver

2012-08-22 Thread Hebbar, Gururaja
On Wed, Aug 22, 2012 at 00:13:07, Porter, Matt wrote: > Add a DMA engine driver for the TI EDMA controller. This driver > is implemented as a wrapper around the existing DaVinci private > DMA implementation. This approach allows for incremental conversion > of each peripheral driver to the DMA engi

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Shawn Guo
Hi Chris, On Tue, Aug 21, 2012 at 10:48:43AM -0400, Chris Ball wrote: > Aside: the bindings do not match the code. The bindings document says > to use "fsl,cd-internal", and imx51-babbage.dts does so -- but the code > doesn't check for "fsl,cd-internal", it checks for "fsl,cd-controller": > >

Re: [PATCH] mmc: sh-mmcif: avoid Oops on spurious interrupts

2012-08-22 Thread Tetsuyuki Kobayashi
Hello Guennadi, Thank you for your patch. I will test this next week. > One more question - is this only needed for 3.7 or also for 3.6 / stable? I hope this also for 3.6 / stable because it is more robust. The other hand, we need investigate why this strange interrupt happens. (2012/08/22 15:

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Thomas Abraham
On 22 August 2012 16:38, Chris Ball wrote: > Hi Thomas, > > On Wed, Aug 22 2012, Thomas Abraham wrote: >>> This matches Mitch's last suggestion exactly -- I think we're all agreed >>> on these properties now. The only remaining question is how to handle >>> the pinctrl for CD in Thomas's case. >>

Re: [PATCH 09/10] mmc: omap_hsmmc: convert from IP timer to hrtimer

2012-08-22 Thread Felipe Balbi
Hi, On Wed, Aug 22, 2012 at 04:08:17PM +0530, S, Venkatraman wrote: > >> @@ -992,7 +996,7 @@ static void omap_hsmmc_do_irq(struct omap_hsmmc_host > >> *host, int status) > >> hsmmc_command_incomplete(host, -EILSEQ); > >> > >> end_cmd = 1; > >> - if

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Chris Ball
Hi Thomas, On Wed, Aug 22 2012, Thomas Abraham wrote: >> This matches Mitch's last suggestion exactly -- I think we're all agreed >> on these properties now. The only remaining question is how to handle >> the pinctrl for CD in Thomas's case. > > Hi Chris, > > For sdhci-s3c driver, the 'broken-cd

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Thomas Abraham
On 22 August 2012 15:47, Chris Ball wrote: > Hi, > > On Wed, Aug 22 2012, Shawn Guo wrote: >> The following is what I have on my mind. >> >> broken-cd cd-gpiosimplication >> --- >> nono SDHCI CD >> noyes

Re: [PATCH 09/10] mmc: omap_hsmmc: convert from IP timer to hrtimer

2012-08-22 Thread S, Venkatraman
On Tue, Aug 21, 2012 at 4:12 PM, Felipe Balbi wrote: > On Sat, Aug 18, 2012 at 12:22:29AM +0530, Venkatraman S wrote: >> omap hsmmc controller IP has an inbuilt timer that can be programmed to > ^^^ > built-in >> guard against

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Chris Ball
Hi, On Wed, Aug 22 2012, Shawn Guo wrote: > The following is what I have on my mind. > > broken-cd cd-gpiosimplication > --- > nono SDHCI CD > noyes GPIO CD > yes no NO CD /

Re: [PATCH v3 5/5] mmc: card: Add RPMB support in IOCTL interface

2012-08-22 Thread Loic pallardy
> > > Hi, > Any specific reason why the RPMB support is implemented using the > IOCTL interface. Can this be done by the Kernel itself instead of > being initiated by a user space application ? > > -- > regards, > Shashidhar Hiremath > -- Hi, There are several reasons for that: - RPMB partition