Re: [PATCH v5 1/3] block: Add test-iosched scheduler

2012-08-28 Thread merez
Hi Jens, Can you refer to my reply? Currently the test-iosched is our only option for testing the eMMC4.5 features on a HS200 eMMC card. Thanks, Maya On Thu, August 2, 2012 6:16 am, me...@codeaurora.org wrote: On Tue, July 31, 2012 8:46 am, Jens Axboe wrote: On 07/31/2012 04:36 PM,

[PATCH] mmc: tegra: remove useless include of mach/*.h

2012-08-28 Thread Stephen Warren
From: Stephen Warren swar...@nvidia.com Nothing from this file is needed, so remove the include. This helps single zImage work by reducing use of the mach-tegra/include/mach/ directory. Signed-off-by: Stephen Warren swar...@nvidia.com --- drivers/mmc/host/sdhci-tegra.c |1 - 1 file changed,

RE: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-08-28 Thread Seungwon Jeon
Hi Thomas, Thank you for your effort. Some reviews seems like to be omitted. Please check more. On Sunday, August 26, 2012 Thomas Abraham thomas.abra...@linaro.org wrote: Samsung Exynos SoC's extend the dw-mshc controller for additional clock and bus control. Add support for these extensions

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-08-28 Thread Thomas Abraham
Hi Seungwon, On 28 August 2012 12:36, Seungwon Jeon tgih@samsung.com wrote: Hi Thomas, Thank you for your effort. Some reviews seems like to be omitted. Please check more. On Sunday, August 26, 2012 Thomas Abraham thomas.abra...@linaro.org wrote: Samsung Exynos SoC's extend the dw-mshc

[PATCH v2 0/5] Add the dw-mmc patches

2012-08-28 Thread Jaehoon Chung
These patches added some feature for dw-mmc. Maybe specific portion of these patches should conflicted with the Thomas's patches. (If Thomas's patch is applied, i will fix the latest kernel.) Changelog v2: - add the fix the present flags for card detect. - applied with Will and

[PATCH v2 1/5] mmc: dw-mmc: ensure that the card is not busy when changing clock

2012-08-28 Thread Jaehoon Chung
synopsys spec is mentioned. (7.1 Software/Hardware Restrictions) Before disabling clock, ensure that card is not busy due to any previous data command. At specific board, i found the problem that didn't inform ciu. (It didn't produce always.) At that time, i checked the status register whether

[PATCH v2 2/5] mmc: dw-mmc: add the platdata related with clock

2012-08-28 Thread Jaehoon Chung
Some SoC need to set the clock-phase shift. So Add the callback function into platdata for using phase-shift Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/mmc/host/dw_mmc.c |3 +++ include/linux/mmc/dw_mmc.h |8

[PATCH v2 3/5] mmc: dw-mmc: add the header file for exynos specific code.

2012-08-28 Thread Jaehoon Chung
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/linux/mmc/exynos-dw_mmc.h | 61 + 1 files changed, 61 insertions(+), 0 deletions(-) create mode 100644 include/linux/mmc/exynos-dw_mmc.h

[PATCH v2 4/5] mmc: dw-mmc: add the use_hold_reg in CMD register

2012-08-28 Thread Jaehoon Chung
This patch is added the use_hold_reg bit in CMD register. In upper version than 2.40a, bit[29] of CMD register is used the use_hold_reg. Some SoC is affected by this bit. (This bit means whether use hold register when send data and cmd. And related with cclk_in_drv phase) Now i known that

[PATCH v2 5/5] mmc: dw-mmc: fix the present flags for card detect

2012-08-28 Thread Jaehoon Chung
dw_mci_get_cd() is registered to call-back function. If call host-ops-get_cd(), host didn't set any card present flag. Then host didn't know whether card is present or not. This patch fixed them. Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Singed-off-by: Kyungmin Park

Re: [PATCH 0/2] mmc: mxs-mmc: fix deadlocks

2012-08-28 Thread Lauri Hintsala
On 07/17/2012 05:16 PM, Lauri Hintsala wrote: Two different deadlock fixes in cases with SDIO IRQs generated by SDIO device. Any comments? Could they be applied? BR, Lauri Lauri Hintsala (2): mmc: mxs-mmc: fix deadlock in SDIO IRQ case mmc: mxs-mmc: fix deadlock caused by recursion

RE: [PATCH v4 4/9] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-08-28 Thread Seungwon Jeon
On Sunday, August 26, 2012 Thomas Abraham thomas.abra...@linaro.org wrote: Some platforms allow for clock gating and control of bus interface unit clock and card interface unit clock. Add support for clock lookup of optional biu and ciu clocks for clock gating and clock speed determination.

Re: [PATCH v4 4/9] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-08-28 Thread Thomas Abraham
On 28 August 2012 16:13, Seungwon Jeon tgih@samsung.com wrote: On Sunday, August 26, 2012 Thomas Abraham thomas.abra...@linaro.org wrote: Some platforms allow for clock gating and control of bus interface unit clock and card interface unit clock. Add support for clock lookup of optional biu

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-08-28 Thread Thomas Abraham
On 28 August 2012 16:13, Seungwon Jeon tgih@samsung.com wrote: On Tuesday, August 28, 2012 Thomas Abraham thomas.abra...@linaro.org wrote: Hi Seungwon, On 28 August 2012 12:36, Seungwon Jeon tgih@samsung.com wrote: [...] + /* + * Exynos4412 and Exynos5250 extends the use

[PATCHv2 1/2] mmc: omap_hsmmc: convert from IP timer to hrtimer

2012-08-28 Thread Venkatraman S
omap hsmmc controller IP has a built in timer that can be programmed to guard against unresponsive operations. But its range is very narrow, and the maximum countable time is a few seconds. Card maintenance operations like BKOPS and MMC_ERASE and long stream writes like packed command require

[PATCH 2/2] mmc: omap_hsmmc: cleanup the bitmap definitions of Interrupt Register

2012-08-28 Thread Venkatraman S
Define the most frequently used bitmasks of the Interrupt Enable / Interrupt Status register with consistent naming ( with _EN suffix). Use meaningful concatenation of bitfields for INT_EN_MASK, which shows which interrupts are enabled by default. No functional changes. Signed-off-by:

Re: [PATCHv2 1/2] mmc: omap_hsmmc: convert from IP timer to hrtimer

2012-08-28 Thread Felipe Balbi
On Tue, Aug 28, 2012 at 06:49:06PM +0530, Venkatraman S wrote: omap hsmmc controller IP has a built in timer that can be programmed to guard against unresponsive operations. But its range is very narrow, and the maximum countable time is a few seconds. Card maintenance operations like BKOPS

Re: [PATCH 2/2] mmc: omap_hsmmc: cleanup the bitmap definitions of Interrupt Register

2012-08-28 Thread Felipe Balbi
Hi, On Tue, Aug 28, 2012 at 06:49:07PM +0530, Venkatraman S wrote: Define the most frequently used bitmasks of the Interrupt Enable / Interrupt Status register with consistent naming ( with _EN suffix). Use meaningful concatenation of bitfields for INT_EN_MASK, which shows which interrupts

Re: [PATCH v2 2/5] mmc: dw-mmc: add the platdata related with clock

2012-08-28 Thread Thomas Abraham
On 28 August 2012 13:25, Jaehoon Chung jh80.ch...@samsung.com wrote: Some SoC need to set the clock-phase shift. So Add the callback function into platdata for using phase-shift Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH v2 3/5] mmc: dw-mmc: add the header file for exynos specific code.

2012-08-28 Thread Thomas Abraham
On 28 August 2012 13:25, Jaehoon Chung jh80.ch...@samsung.com wrote: Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/linux/mmc/exynos-dw_mmc.h | 61 + 1 files changed, 61

Re: [PATCH v2 4/5] mmc: dw-mmc: add the use_hold_reg in CMD register

2012-08-28 Thread Thomas Abraham
On 28 August 2012 13:25, Jaehoon Chung jh80.ch...@samsung.com wrote: This patch is added the use_hold_reg bit in CMD register. In upper version than 2.40a, bit[29] of CMD register is used the use_hold_reg. Some SoC is affected by this bit. (This bit means whether use hold register when send

Re: [PATCH v2 5/5] mmc: dw-mmc: fix the present flags for card detect

2012-08-28 Thread Thomas Abraham
On 28 August 2012 13:25, Jaehoon Chung jh80.ch...@samsung.com wrote: dw_mci_get_cd() is registered to call-back function. If call host-ops-get_cd(), host didn't set any card present flag. Then host didn't know whether card is present or not. This patch fixed them. Signed-off-by: Jaehoon

Re: [PATCH] mmc: tegra: remove useless include of mach/*.h

2012-08-28 Thread Stephen Warren
On 08/28/2012 12:00 AM, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com Nothing from this file is needed, so remove the include. This helps single zImage work by reducing use of the mach-tegra/include/mach/ directory. BTW, it'd be easiest for me to take this through the Tegra

Re: [PATCH] mmc: tegra: remove useless include of mach/*.h

2012-08-28 Thread Chris Ball
Hi Stephen, On Tue, Aug 28 2012, Stephen Warren wrote: On 08/28/2012 12:00 AM, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com Nothing from this file is needed, so remove the include. This helps single zImage work by reducing use of the mach-tegra/include/mach/ directory.

Re: [PATCH v2 1/1] mmc: block: Add write packing control

2012-08-28 Thread S, Venkatraman
On Mon, Aug 27, 2012 at 11:58 PM, me...@codeaurora.org wrote: On Fri, July 27, 2012 2:07 am, S, Venkatraman wrote: On Fri, Jul 27, 2012 at 12:24 AM, me...@codeaurora.org wrote: On Thu, July 26, 2012 8:28 am, S, Venkatraman wrote: On Tue, Jul 24, 2012 at 2:14 PM, me...@codeaurora.org

Re: [PATCH 9/9] ARM: OMAP: remove plat/board.h file

2012-08-28 Thread Chris Ball
Hi, On Tue, Aug 28 2012, Igor Grinberg wrote: drivers/mmc/host/omap.c |1 - drivers/mmc/host/omap_hsmmc.c|1 - Acked-by: Chris Ball c...@laptop.org -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from

RE: [PATCH v2 1/5] mmc: dw-mmc: ensure that the card is not busy when changing clock

2012-08-28 Thread Seungwon Jeon
On Tuesday, August 28, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: synopsys spec is mentioned. (7.1 Software/Hardware Restrictions) Before disabling clock, ensure that card is not busy due to any previous data command. At specific board, i found the problem that didn't inform ciu.

RE: [PATCH v2 4/5] mmc: dw-mmc: add the use_hold_reg in CMD register

2012-08-28 Thread Seungwon Jeon
On Tuesday, August 28, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: This patch is added the use_hold_reg bit in CMD register. In upper version than 2.40a, bit[29] of CMD register is used the use_hold_reg. Some SoC is affected by this bit. (This bit means whether use hold register when

RE: [PATCH v2 3/5] mmc: dw-mmc: add the header file for exynos specific code.

2012-08-28 Thread Seungwon Jeon
On Tuesday, August 28, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: Commit message is no need? Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/linux/mmc/exynos-dw_mmc.h | 61 +

Re: [PATCH v2 5/5] mmc: dw-mmc: fix the present flags for card detect

2012-08-28 Thread Jaehoon Chung
On 08/28/2012 11:04 PM, Thomas Abraham wrote: On 28 August 2012 13:25, Jaehoon Chung jh80.ch...@samsung.com wrote: dw_mci_get_cd() is registered to call-back function. If call host-ops-get_cd(), host didn't set any card present flag. Then host didn't know whether card is present or not. This

Re: [PATCH v2 1/5] mmc: dw-mmc: ensure that the card is not busy when changing clock

2012-08-28 Thread Jaehoon Chung
On 08/29/2012 10:21 AM, Seungwon Jeon wrote: On Tuesday, August 28, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: synopsys spec is mentioned. (7.1 Software/Hardware Restrictions) Before disabling clock, ensure that card is not busy due to any previous data command. At specific board, i

Re: [PATCH v2 4/5] mmc: dw-mmc: add the use_hold_reg in CMD register

2012-08-28 Thread Jaehoon Chung
On 08/29/2012 10:21 AM, Seungwon Jeon wrote: On Tuesday, August 28, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: This patch is added the use_hold_reg bit in CMD register. In upper version than 2.40a, bit[29] of CMD register is used the use_hold_reg. Some SoC is affected by this bit.

Re: [PATCH v2 3/5] mmc: dw-mmc: add the header file for exynos specific code.

2012-08-28 Thread Jaehoon Chung
On 08/29/2012 10:22 AM, Seungwon Jeon wrote: On Tuesday, August 28, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: Commit message is no need? Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/linux/mmc/exynos-dw_mmc.h

Re: [PATCH v2 3/5] mmc: dw-mmc: add the header file for exynos specific code.

2012-08-28 Thread Jaehoon Chung
On 08/28/2012 10:37 PM, Thomas Abraham wrote: On 28 August 2012 13:25, Jaehoon Chung jh80.ch...@samsung.com wrote: Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/linux/mmc/exynos-dw_mmc.h | 61

[PATCH v6] mmc: card: Skip secure option for MoviNAND.

2012-08-28 Thread IAN CHEN
For several MoviNAND, there are some known issue with secure option. For these specific MoviNAND device, we skip secure option. You could refer this discussion in XDA developers. http://forum.xda-developers.com/showthread.php?t=1644364

[PATCH] mmc: sdhci-s3c: fix checkpatch error and warnings

2012-08-28 Thread Jingoo Han
This patch fixes the checkpatch error and warnings listed below: ERROR: return is not a function, parentheses are not required WARNING: Prefer pr_err(... to printk(KERN_ERR, ... WARNING: quoted string split across lines WARNING: line over 80 characters WARNING: braces {} are not necessary for

Re: [PATCH v6] mmc: card: Skip secure option for MoviNAND.

2012-08-28 Thread Jaehoon Chung
Need to check your mail setting. On 08/29/2012 02:04 PM, IAN CHEN wrote: For several MoviNAND, there are some known issue with secure option. For these specific MoviNAND device, we skip secure option. You could refer this discussion in XDA developers.